From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 12/14] avcodec/huffyuv: Inline ff_huffyuv_common_init() in its callers
Date: Sun, 2 Oct 2022 02:06:15 +0200
Message-ID: <GV1P250MB073710846B7F7B07AA664B5C8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB073731CA0D62A48F301E43DA8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
This is in preparation for splitting HYuvContext.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/huffyuv.c | 9 ---------
libavcodec/huffyuv.h | 1 -
libavcodec/huffyuvdec.c | 5 +++--
libavcodec/huffyuvenc.c | 4 +++-
4 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/libavcodec/huffyuv.c b/libavcodec/huffyuv.c
index 4a5bd53998..23a2bb2537 100644
--- a/libavcodec/huffyuv.c
+++ b/libavcodec/huffyuv.c
@@ -68,15 +68,6 @@ av_cold int ff_huffyuv_alloc_temp(HYuvContext *s, int width)
return 0;
}
-av_cold void ff_huffyuv_common_init(AVCodecContext *avctx)
-{
- HYuvContext *s = avctx->priv_data;
-
- s->flags = avctx->flags;
-
- ff_bswapdsp_init(&s->bdsp);
-}
-
av_cold void ff_huffyuv_common_end(HYuvContext *s)
{
int i;
diff --git a/libavcodec/huffyuv.h b/libavcodec/huffyuv.h
index 92e390ad78..823a091809 100644
--- a/libavcodec/huffyuv.h
+++ b/libavcodec/huffyuv.h
@@ -93,7 +93,6 @@ typedef struct HYuvContext {
int non_determ; // non-deterministic, multi-threaded encoder allowed
} HYuvContext;
-void ff_huffyuv_common_init(AVCodecContext *s);
void ff_huffyuv_common_end(HYuvContext *s);
int ff_huffyuv_alloc_temp(HYuvContext *s, int width);
int ff_huffyuv_generate_bits_table(uint32_t *dst, const uint8_t *len_table, int n);
diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c
index 89db3db65a..093070e348 100644
--- a/libavcodec/huffyuvdec.c
+++ b/libavcodec/huffyuvdec.c
@@ -300,6 +300,9 @@ static av_cold int decode_init(AVCodecContext *avctx)
if (ret < 0)
return ret;
+ s->flags = avctx->flags;
+
+ ff_bswapdsp_init(&s->bdsp);
ff_huffyuvdsp_init(&s->hdsp, avctx->pix_fmt);
ff_llviddsp_init(&s->llviddsp);
memset(s->vlc, 0, 4 * sizeof(VLC));
@@ -545,8 +548,6 @@ static av_cold int decode_init(AVCodecContext *avctx)
}
}
- ff_huffyuv_common_init(avctx);
-
if ((avctx->pix_fmt == AV_PIX_FMT_YUV422P || avctx->pix_fmt == AV_PIX_FMT_YUV420P) && avctx->width & 1) {
av_log(avctx, AV_LOG_ERROR, "width must be even for this colorspace\n");
return AVERROR_INVALIDDATA;
diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c
index 0e9b24c8db..5293d32d2b 100644
--- a/libavcodec/huffyuvenc.c
+++ b/libavcodec/huffyuvenc.c
@@ -210,7 +210,9 @@ static av_cold int encode_init(AVCodecContext *avctx)
const AVPixFmtDescriptor *desc;
s->avctx = avctx;
- ff_huffyuv_common_init(avctx);
+ s->flags = avctx->flags;
+
+ ff_bswapdsp_init(&s->bdsp);
ff_huffyuvencdsp_init(&s->hencdsp, avctx->pix_fmt);
ff_llvidencdsp_init(&s->llvidencdsp);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-02 0:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 0:04 [FFmpeg-devel] [PATCH 01/14] avcodec/ylc: Remove inclusion of huffyuvdsp.h Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 02/14] avcodec/huffyuvenc: Remove redundant casts Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 03/14] avcodec/huffyuvenc: Avoid pointless indirections Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 04/14] avcodec/huffyuvenc: Remove always-false check Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 05/14] avcodec/huffyuvenc: Remove redundant call Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 06/14] avcodec/huffyuvenc: Don't second-guess error code Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 07/14] avcodec/huffyuvencdsp: Pass pix_fmt directly when initing dsp Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 08/14] avocdec/huffyuvdec: Don't use HYuvContext.avctx Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 09/14] avcodec/huffyuvenc: Improve code locality Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 10/14] avcodec/huffyuvenc: Avoid unnecessary function call Andreas Rheinhardt
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 11/14] avcodec/huffyuv: Use AVCodecContext.(width|height) directly Andreas Rheinhardt
2022-10-02 0:06 ` Andreas Rheinhardt [this message]
2022-10-02 0:06 ` [FFmpeg-devel] [PATCH 13/14] avcodec/huffyuv: Split HYuvContext into decoder and encoder context Andreas Rheinhardt
2022-10-02 0:10 ` [FFmpeg-devel] [PATCH 14/14] avcodec/huffyuv: Speed up generating Huffman codes Andreas Rheinhardt
2022-10-02 14:46 ` [FFmpeg-devel] [PATCH 15/15] avcodec/huffyuv: Update outdated link Andreas Rheinhardt
2022-10-07 11:58 ` [FFmpeg-devel] [PATCH 01/14] avcodec/ylc: Remove inclusion of huffyuvdsp.h Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB073710846B7F7B07AA664B5C8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git