From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4343C48D21 for ; Sat, 24 Feb 2024 02:50:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 198E068C66E; Sat, 24 Feb 2024 04:50:01 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2048.outbound.protection.outlook.com [40.92.75.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C457068BDBC for ; Sat, 24 Feb 2024 04:49:54 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYGlj5R6Wb9JuDAJD4Lr/7G7lWTTm2JshDvWEpOI+kOHw16RJhogaUVHmj0bRf7RO6yuzQ4OasBe9oGt0mXlwSZQ62oM/LIbrsfl0+TzGX2dkykrO4z2py6AjSYczssxDT3zHodmr3rdd2j/hmJyvb+olp5H/o+qVT6R1Ax54PM7hFc6Y2VIyNgt3W0sHPr5Ls6HJxXAjDDre53Og6DD5Qp55pwWPFexQeZ/4tCJaNBvNnEUt6MV2yL174zkXqbf8TSeP248mmy3AhBr0RFm/or1nDHybKZWS+9w76HMgP8lUUqmz5UFBRfl4hMboKYorP3sZOLqNegLXYeHLL3C1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XEIOg3cmgngwtuLLVqvBpz1FIo3Enq3t9/u+s0YFWMk=; b=BsViAgyVi/KBV5vwtcMSa6R341R9WEHcQ6DL3oJr18E90C0ZT7juDPbl7Omq9ofvgY2e5RdPlS1jLrjYlfFxE8eXykWdQz8gRSoQJSliX7zdIFOMmcOBJhPdoHQe4MvZ9a6R2XWrO8fRNJiY7jl8XYZem7Bel44ahDvB4GO4A47aCdf9ZJtbX5IrABHLMC4xYpITLROG9+8U2H/+H0hlKzhHd2n4YF1EYQ8U4AVDnF6UnaUshOUaBggoNRCJHHskHpaSo2lfAAjDPoT1jRVRaa15sF9jgx19eysPZjys8VK/t/G9T2j+7igxbuaHqGfijmT4eB1Inkv2amOC0bcajA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XEIOg3cmgngwtuLLVqvBpz1FIo3Enq3t9/u+s0YFWMk=; b=Eiv06BTkV0gT//iyLTLJbdwgNxeufLtKva59UA0jzKuVeMQDNHxAvNZWsg1gsrC3dNleH+TClmD1GHjMgPy2bB7D5mFUOinHN9YZkX0wAWcMxIKKvGDS7XsAAMeatLMtCp5oIjAO9ylu9E7alrVaEB9cp498wey0py/R4c57vj9/HARnaG8yrfQOLge2aHOZNX/5E5iiTM1cCY9B+cQz8WtKq5LC2Mo1tMIDEqME3CQKlC5PRbmzXQ54YU5SRus6nRiphFjq9Cnfo4BG9pb36+/RbcU9rSO2uEu0tA//VGHfqVb7VqvtmqgKWGVDAffXmlHeuawDm5M0WjkRy2gKag== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0051.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Sat, 24 Feb 2024 02:49:52 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5%7]) with mapi id 15.20.7316.023; Sat, 24 Feb 2024 02:49:52 +0000 Message-ID: Date: Sat, 24 Feb 2024 03:51:50 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [BfFyuL+rBb0uIW8nKqHyvJmuSk8Pc7YuDd3Uvpk3UEE=] X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0051:EE_ X-MS-Office365-Filtering-Correlation-Id: 9005ecbd-af92-476c-9f4a-08dc34e34663 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B0HLNPzMKkM6ZJL1GquKaIqnuPIHybE3ARa3W6ILgtcm/DbgMNpfGQh2iMlRZTSrzDD2+4ojjeE4BG/0vn21k2LW+/x8B63hU7YTH/SpO70p8lTdpCgLBp6QUOHRXKjd+jha3K6h3t/nw9GgenmlfGcU6TFi2TxQvpQL7X2vkCAZl+QvXK5zPzUhmRviV/0zHPqmYMz0Ouvgo4aU6UK9bnSw1rvqb1OlvEyxNOTfd11VEorgQewIW4myUUID/nyR5yXNWlcUR3e5xtRUSWxW55UqMvo/sQ9fGl4EZNXhQipzmgthC+1AGc8IYWtNaCJHpcfYs4SbZ2hDUDznQAATPlBfeTf8estkInhPogMqSbara74sRwc5iYgaBOzOBSEDFcdBqc42c61zNLcY1Zqcg/Mhe6EGtvsSdLNoK+zLlS3n8IQ0uKMqG+AmIPH6J8fq816W/jx6FR9oF2mjwECQ0uPHzmzBEWD+ol2KGSA4Mqa6PpFFvbCx2cqLezepvio9EAwF3rSXMQx1tVmRq7tXnFwDJRTEsadQ1rHBxvDhB/Ymcp5OSrSrajqU3DLPN8LI X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTNQUE9hM0pURjZCUkVOR3M4cHVSSHlmMTltSDB4bllLT1pCcTc3bWxPTmVG?= =?utf-8?B?c0NnWjRYeGlNeWEyM0ZtTisweW5sVkhLUU1IelNsVXhaTUN0RlRhdG1YSk4y?= =?utf-8?B?M1lpa1UvNEQ5cHprT2NlV2pjSzNHRTlIK3hhM1gwWGZyZmRUbVZ1NFFGREtI?= =?utf-8?B?bkJiKzNJaHNFVUdvRWhCQmpBWEpWOTBqUEprOTZ6aFlpSEc1anUrQmU3RmtJ?= =?utf-8?B?a0JJYUE5b1ZXRWpNSTJJbEQxZ0poYmxGMHhrTVJibENaODFsSXMreEdNVWJK?= =?utf-8?B?empUNGtNTWJhNjJRVjErUW1lUzhLNmVsMy9UejZzTXBjVlcvUnhIQm1HY0Vs?= =?utf-8?B?SmNWdzU4ZHpCK0t4UmNXcVA4cG9KTlZXYXZkWnlYV3ZFeVJ1MGp6T3ZhZVFm?= =?utf-8?B?TENMREZTUWtuUjJGYldVY1gxSnU0Zk5CZW1nOUFpK0tKc3JYaC80L0U0TG5x?= =?utf-8?B?NWVDL3RUUU15STVYT3BSckgvbzNVUU1DRERacTdydlBPTmxHRzdFV0xrL2dp?= =?utf-8?B?K0wwc2I4NFN1U29RSmJKdGh4a1RJQlpmVGRxbHErRTNWLytBYUR4YzByYm1O?= =?utf-8?B?dU1Pb0lzSHY0S3BDK295VWRGcldNRW5EZmJuOGh3N0V0SnRnbmFwUXhxNlhD?= =?utf-8?B?V2hCTWhyaHN2d1FZYU1IQXkzVXQxckwzdEtqUGtZWmtNWVpURW1MdkZsNndT?= =?utf-8?B?bGxCaURyajJ3K3ROZ0hqdWYrMVBqTm1HR2J2SEI3RFczNnJ5VG5lRFpNeXN2?= =?utf-8?B?RU1KcWhGRm1KMzdJSXBYNzdJeW5kOVBnMVNGbXZqa2p3V0szdFpRcUhyTUIr?= =?utf-8?B?V0xHZ2laS0YwZEZrQ09rbkhYUjNBS0xtYXozcUV4Y1ZudWUvQW13R2Nsa0tU?= =?utf-8?B?N3JqYnZQdG1ucXJQY0JUUDU0RG1rK2gxT2xGNktRdGF2VUdzK1JSZjNpTjZS?= =?utf-8?B?UVZQZXRmblY5WlNScVhrY0xqQWVVV2RFTXM1R3V4R2ZMT1ptQkF3YXZRRXdm?= =?utf-8?B?aU0xVzJBVEdRVUhQVkpvbCtTK3VYaG9jQTZsckNBSndsZUEvb0s0NUtMMEhX?= =?utf-8?B?MjFVeVl5Nk1YcVovRGozV1AwNCtoZ2FCVXVMV3VLajFCVTVTWXVqTlRxeGtv?= =?utf-8?B?SlYyWEtUajdXZTJIQnVTRGFYZ2RxYm5USktnVjZFN2tMc0hSZ0tLK3o4K1Ju?= =?utf-8?B?UVdMc2I1b1dJcXRDSXhSMnBkd3FqYXBtQzNMU1lqK3JpdFlFZDVqd0d0UTJM?= =?utf-8?B?UE01eWkwM1hKOU15VUVtcW9kQ3ZHb3JpVFNpUkJYQlhsZXIvYThPT0FTNjdW?= =?utf-8?B?WE9FaWN6Vk5hUGx0R3JNcktITlZvU3AyVjMxYnord3RpdGs3SG9qaWt4WkZR?= =?utf-8?B?SmltdGN4S29MalRhVGpCTWo4R0JPWjhOVEZtYm9XUkVuQ0JNeENEZHpMeVZZ?= =?utf-8?B?d3MyS2NiUG1TcVNldS9IeHdHODdMVmV3MUJxRG1KMFZ5SzJzMkpoRlBVUXVT?= =?utf-8?B?ZUl2Z283VnhiRFhJU01mSnZPcUNwZUR0MzRpQWNodWMvRmhkY0hyNEl2Zzg2?= =?utf-8?B?V0lGUWRLZzMxaGxiZVF4aUR3ZDd4NU8xWHFQN2lYQThQbjdOdkdrQ3VPVHpx?= =?utf-8?B?UjBnZkp5THNWMEFCb1dlb1pzYnJDOGQ3N0xCaHlVcm5CczdDRXg3VmZRUFc2?= =?utf-8?B?ZElNbWovNGsxbFNoT29SR011Y0pZa05YN05ZK1IxTGY3RDZidmxmTld3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9005ecbd-af92-476c-9f4a-08dc34e34663 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 02:49:52.5586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0051 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h266_syntax_template: Don't omit unused function parameter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The calls to the sei_decoded_picture_hash read and write functions > are performed with four pointer arguments; just because one > of them is unused by the callees does not mean that they > can be omitted: This is undefined behaviour. > (This was not recognized because the SEI_MESSAGE_RW macro > contains casts.) > > Signed-off-by: Andreas Rheinhardt > --- > I found this via UBSan test failures with Clang 17, > but actually there are compiler warnings for this: > -Wcast-function-type for GCC and old Clang > and -Wcast-function-type in conjunction with > -Wno-cast-function-type-strict (without the latter, > Clang warns about conversions with different pointer > types, like int (*)(void*)->int (*)(struct Foo*); > the latter typically lead to UB (when used in a call), > but are actually common). > > libavcodec/cbs_h266_syntax_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c > index 26ee7a420b..e75f2f6971 100644 > --- a/libavcodec/cbs_h266_syntax_template.c > +++ b/libavcodec/cbs_h266_syntax_template.c > @@ -3430,7 +3430,7 @@ static int FUNC(slice_header) (CodedBitstreamContext *ctx, RWContext *rw, > static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx, > RWContext *rw, > H266RawSEIDecodedPictureHash * > - current) > + current, SEIMessageState *unused) > { > int err, c_idx, i; > Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".