From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2DEAB4BAF0 for ; Sun, 1 Jun 2025 10:39:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6662F68D245; Sun, 1 Jun 2025 13:39:55 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2062.outbound.protection.outlook.com [40.92.59.62]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9269D68CEE1 for ; Sun, 1 Jun 2025 13:39:49 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OEWQkFH75t+dXnKbFvG1Iby9XMPhcDVgQxxXiZOT+g2T2LrA1uas+wheB2dsLw5LNBF/e5pzVxtYYcjJmNyAulFr6T4Q+qn6NoIgIeG/rp+9ap3DIXPbC9SZh24FhHWu6iCDvGyC/VZu0lGYyDP4Fl2N5rQ6XnQberkLvMIzVVen2q/kplpi14oigVYwn8H7x5qw92cX25n+xiy+K0B50/giGXj1ZuRak80pufrVg/wHFZzOx998K7sKa1CmKWMcT/NzSbZq6UsZQ/WOfSHcZ3c4J8Q8o5yYiwoMEIQOkkaPHwPQ9ri1xQlg8eRE6nkMzSCGvkLr9UyVLDN6Fgup3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogrjhFnXD5K7UelHmUh3esjlgbDkd/K05+LCPSriqME=; b=Sbozblj0PO8HsNVRCzKtDWZjhTqniimpb/h6nmLZLUjm/Cq96lUm9l0z6QbV1PXj1S6a7zjQxuhfS4vAVHVLXH1t03+5dCUGYiSZd0Hk35olaOStC74INEk5UKllRZjMMq777IhY1vPAv7fuqu+9rLNugsTgdHkccYok2zYw1vfcKfQpoxXsSG2GQOiFhoEhRxNLNGkzSyuvUPV4JMjPdrlf6ONQWxhFOeaKnJCaWYP4bWd9B88a7PsH39/X4DPxA4DmO6GKFpi4w6uv1dH9725FNw+CxuDhJeuFTRSyLiJe5wsZdtSw9kixvuiKXTYC7XuLkYc0TUFSngPx5Nbptg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogrjhFnXD5K7UelHmUh3esjlgbDkd/K05+LCPSriqME=; b=InGV+rDSGC3ljQx4s0QTgPaXCqHRJ1tRlDUGtxbuiCi9d20L/caJNvGnaWRuY4fBcwQa/4As4kphnb5WF3traV7y9pLXVWor5gyDOSYElnL/mFwA3sm5C3PYKybj9zfd8gglZB/D94EFZ4AV0lylHliTI4+3QFuaFyyw3wGxFeTU4CXKBppVeao4MJ+Pfp7vtPrY/UP6q1fkjFspD01d6992fvI0mIRdi0ZQACqwXoyMsZ86ORtI8QjSdAiK7IsABpdn0qtBj4K7myZDD/Jau+zNWppTeu+VybGkbuFbNX4QTj6sIdzVapFlC3UiYZ31jO4ocLhzfIWZkNeKbggeHg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0182.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:325::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.26; Sun, 1 Jun 2025 10:39:48 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8769.035; Sun, 1 Jun 2025 10:39:48 +0000 Message-ID: Date: Sun, 1 Jun 2025 12:39:46 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: FR4P281CA0438.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0182:EE_ X-MS-Office365-Filtering-Correlation-Id: 556728d6-b45b-451d-cd58-08dda0f8a14d X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799006|15080799009|7092599006|5072599009|8060799009|6090799003|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkZDczJXQ3hNQWg1Ynl3SCtKN1JvdWpRS0U1bTZZMDBNenVQZm82QnlVOUdo?= =?utf-8?B?VnhQUUhYY0Z4KzBaQjFxa1RLZmNLRXhqd2M5bmprVEpFeUtBSkIyYSszcGFk?= =?utf-8?B?dXpLblk0eXQxc0JTcjRnbmU2bXN3QjBsaUtMU2VSVkRnOGZHdFJWZ0xwWFZu?= =?utf-8?B?KzFDRGJjQkpQbTVqMzNXM3ZkajhmY0JkZmpkVytwY1pocHNiaGVaa3FWUDJj?= =?utf-8?B?U25XMUFNZjVyQ3lOWUxVUVFLVDBBR3pBR3ppZWdSelE3LzUrTEI4Tk90ZmxV?= =?utf-8?B?S3dFK3FWNWg4SkFicjVDcmxCajBQSEp4bTVVVzVNL214RDllSmo2cTVjRXhq?= =?utf-8?B?dFZ4c2VFTzVoS25GODBaNU5ZMVFsVlhucUxhZHpZcEhNTWtPMHVxRXdjaVV4?= =?utf-8?B?eitkOFJDekRZT01SeUU0MUo0VTUrT1Y3VzhFZGlYbjMwMUl5K2dXek1rSzNj?= =?utf-8?B?ZnlPZVZYOE54cEd5UHNSM3JQNjd1VTM1bnF3TTVack5nbmNQTFEyUTV2dytp?= =?utf-8?B?OTlkRnJheFoyM1FVL29kdEE5R0JDMlFla0wxa2xoQzQ3ZHVCU3dhdjNBREY3?= =?utf-8?B?eDArRlJzbGhZNmhJcENoRFlCVm1oR3hXQmIwczBURWsvaitPSXB5aXBwWGZZ?= =?utf-8?B?QXFlZ0lJblZQSmJEdExXZUFpdHFMWTEvY1hYZ0hSUjJVMUZFZVhOK2QrNk13?= =?utf-8?B?c0UvMGd2K1l1bjFmQmNZc0tXc0o3UldvT1REL201UVFRR1I5VDhNWTJvVEww?= =?utf-8?B?NFdlUkFMMjRRMWF6Zjd1OHQ0WTZrR2ZTeVNqcFBPRlFPMUdVaUJEWlA1bTIr?= =?utf-8?B?V0pMYVhoZkFCSFZtZUVKV2FwUHQwYWp5OG52L29PU2YxQlg2Sy8yblhxancx?= =?utf-8?B?bVZSQ09WUE1HazdZM0srM0lqQWh2RTV2eXdPNXF1Ykx3MCtmbHpBSGFqa2VL?= =?utf-8?B?OUY1ZEJPR3pqd1kxUzRRWjFkUmpnelU2amExL3pRQmplZGtKUFl1bHVZWGMv?= =?utf-8?B?bTA2WitHRVhoVEwvdFdWSENJeU5HZXo2aWpZUnZBUCs1KzJuOEw5VWphcTVi?= =?utf-8?B?aXJsNzBTNkJYWmt2RzdDc3UvV1dGVVYzbnc1Ym9EbStzdVZteXQzSUt5YW9J?= =?utf-8?B?SXZMUGtsaUMxWmU3R0VUSWNKeGpwd0EzditTdHhmVXVLSWtMSWNyWVdUTWp6?= =?utf-8?B?SXVJeDRqczI2dElYbGNOMStncUk3RXljY0Y4bStZNCtXVjZuZ3dIWnNidWtW?= =?utf-8?B?RkxKRmlTYkliUlcwRVdoeU5ZZkdIeHhuRjZBQ2hzeXFZelp5VC8wQjhxRmJS?= =?utf-8?B?ZTlJM01XNTAraUxUTXc3cXhoWW42aUVPdEVFN2hzTFpUdnZCYUFuUGIrd1M5?= =?utf-8?B?SzdZSVpnUjVlVXZsQzRvQytWeDNEYVNlWFVJeXc0eEJLT2hQYUZXZ0NLOXIr?= =?utf-8?B?SWtZSW5UMU5nRzh3UUJHaGlwd0V5VXIvOWo4SXFsbHI2N1AxTHdVSjF5blZ6?= =?utf-8?B?TUo0V3RzbDRNb1c1YS9GazdNUmxjUWVwZGdSRTBpL0Q0V2hFNU03Wkx3cHNT?= =?utf-8?B?OW5PZz09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2FDQWthZ0g2SHhSaG9IYytEZUhhWCtuT3NQdDMzczBLNGNFamM1WEVXeFVD?= =?utf-8?B?bkM5RVhnbWY0QXVJbTg2M2lrZE92ZmtSeXlFajArUHYyTjQ1OHA4WmsxdGRU?= =?utf-8?B?cXF0d0d2clhvT2NVSHNSSjJXSFZUNFJqSGNyOWI1cVArNVFVVldUOTV5YnRS?= =?utf-8?B?TjdGSzZmZDBnVDZVTDcwcnVaR0Rrd0lLdUJPUlBoWXV5NnU0ZWVsUGhXWG5P?= =?utf-8?B?YS9lKzJBQkFDbmk2VGVKUnpKL0pNMjVuN2oyU1NBaDM5YUxyeFZuVFFHMkZl?= =?utf-8?B?a2xsbGlrWDVJMDZXQnlaWWdMRThhcXQxbmFuNXpYSEoyZEhERTAvOS8wRnFO?= =?utf-8?B?TE9Vdy9OV1UzVEFOTktKUWtNOUNqdTVlVHUyVXk2ZGN1M1BxWStKOEwvL1BV?= =?utf-8?B?VlR3OFFyUHkwT3VHQytQK2NUZGhZQVlpVzdUdjlrL29BZ0lLOWxZTnEvU1dL?= =?utf-8?B?TjFrVmZraUY2eTR2SUs3dTdESEVGc042azJnbGJ2YlhWaStmb1RvTFpMaEFy?= =?utf-8?B?RWxWZFFtUDlrcFdnZTdEU2tMcVg1Y3VPNTNsSStRNTRtNW9BU2ZlRUNLVS9l?= =?utf-8?B?M213YVJXVk1XYnN6NU15TGhVdWExWjhibFlWV3J5cTBqNktkbk9jSkw4Qlhh?= =?utf-8?B?bWVQZ0FJdHRZN1VtdEN3YlJPS3dnYVZnVmh2V2lqY2tZbllEbzFWOWpqWHpk?= =?utf-8?B?QWNUR3hmWWVSSWptRE1YSXltRHpQYmZtYXhwTWtReStDS0NQb0Y5bmMyK1o1?= =?utf-8?B?RlBQNkJsQ2M3WVdDWC92WjNtN3JKcWYyQWN3MldIMzdHVUtSUWsrTE80QTYw?= =?utf-8?B?Vkg1eElyUlpaQ2F1aGNsNS8vSk5mdzJTa21Tcy9FbHZ0K3NnZ2cwaVJCWnhH?= =?utf-8?B?c3VFR0JUMWk5NE5nQjNsZlNaWmpoZms0c29kbWY4M1ZKeEhYQUIxZTdjaUFV?= =?utf-8?B?YjRWTmZTY3dVdWUwTTYwRWdQd2czRzVlbnNjRVZTYU9QRzM1RWs0ZUNHZlBN?= =?utf-8?B?UTE0N3RtTVVFdDhzWkM3VEZoU3ZXZUZldW4yWTI0UVd6STFkR1Y2RE0ya3l3?= =?utf-8?B?ZHdTVDAxdWFCVGVpNitaVVd5dGZyYS9kOUNFWmZ1OWVDL1FWTjZkVkFWMmcv?= =?utf-8?B?NVJCcDBxQ3FzMUlsSmdpcmZOK1NqemZKb1ZWOFgwNUhWTzlQTng0OHdKOG9y?= =?utf-8?B?dklFSTIxam9ZV1Y0YjNzRXpueW9jSUlGaDhLK21HS2J3MHNLYkNSMU9WRE5J?= =?utf-8?B?WmZxblYwUnV0R2lTMnZqWTd6NXZCeFJWQXNCcWJQcTMrQkdIQTdDWnFnM2Ns?= =?utf-8?B?dGp0SWxPUTlVOUZrTzJzZ3ZyTlZnSEV6RmF0TDFqS3FjU0o3dFhhazRESmlN?= =?utf-8?B?c0VyWUdtMkl0a3BSNytRdGJFZzhtRURLbi9WVjcrVUZVS2hwVGthVlFZU29F?= =?utf-8?B?b1cwaGtHUEhBK0xZNXRzMHVWeFpGaUpQYlFiTURDVjM3TFpRQXdsSnNkS1pJ?= =?utf-8?B?bXlnUHF1bTFaaFBES0wzNXBFNXc2d3BZTkdhdUJQcnRPU0hCSzcxK2tQcjdp?= =?utf-8?B?Q1JPTll2SUNIekZVRGtGNVZzR08vVTlsWUtKQXQ4Sm1zZXRoUVp2d0VZYTNV?= =?utf-8?B?ZktoeFN0MlFlSTFnckRVRENyeU11VzBNM1JmRXpGQTZBeTl2RDQ2N3VGVXVx?= =?utf-8?B?L2RlRUVNcTZ2QWxmY2FObEU2MlhXdkhqeE1MMG1TclZFUUk1V2YxSFR0b3lj?= =?utf-8?B?RG0vZUM2eVozWDgrWTNqYm10YTBJUDExd0txeCtKYkQ1N1pBdXUvcXEzaHRH?= =?utf-8?B?T1pzS250TE9VRHQ2SEF5dz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 556728d6-b45b-451d-cd58-08dda0f8a14d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2025 10:39:47.9112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0182 Subject: Re: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: softworkz .: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Sonntag, 1. Juni 2025 05:27 >> To: FFmpeg development discussions and patches >> Subject: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when >> initializing graphprint >> >> Patches attached. >> >> - Andreas > > > Hi Andreas,, > > thanks for the patches - most looking good from a glance. > > I have a few questions: > > - Why do you want to remove the ResourceManager AVClass? Because I think callers should provide their own logcontext, instead of adding yet another AVClass that is likely never used. > It wasn't unused. Now the prefix is gone for log entries in > decompress_gzip() True, this patch is just wrong (in case of decompression errors, av_log() will treat ResourceManagerContext as a logging context, although it is no more; this would lead to segfaults if AVDictionary is already set, i.e. when initializing the second resource). > Actually, all av_log() calls should include the resman_ctx > Seems this has been forgotten (well..by me) > > - For the registered_formatters initialization: > I used to have initialization order issues when I had tried > with static initialization. That's the reason for those functions > Probably you've done it differently as it seems to work so far What issues? > > - In resman.c:64 - should the resman_ctx be static? Yes, of course. Will change it in the patch. Also notice that patch #1 needs to be fixed, too (it failed when actual options were passed). Will send an updated version soon. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".