Re: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

softworkz .:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Andreas
>> Rheinhardt
>> Sent: Sonntag, 1. Juni 2025 05:27
>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>> Subject: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when
>> initializing graphprint
>>
>> Patches attached.
>>
>> - Andreas
> 
> 
> Hi Andreas,,
> 
> thanks for the patches - most looking good from a glance.
> 
> I have a few questions:
> 
> - Why do you want to remove the ResourceManager AVClass?

Because I think callers should provide their own logcontext, instead of
adding yet another AVClass that is likely never used.

>   It wasn't unused. Now the prefix is gone for log entries in 
>   decompress_gzip()

True, this patch is just wrong (in case of decompression errors,
av_log() will treat ResourceManagerContext as a logging context,
although it is no more; this would lead to segfaults if AVDictionary is
already set, i.e. when initializing the second resource).

>   Actually, all av_log() calls should include the resman_ctx
>   Seems this has been forgotten (well..by me)
>   
> - For the registered_formatters initialization:
>   I used to have initialization order issues when I had tried
>   with static initialization. That's the reason for those functions
>   Probably you've done it differently as it seems to work so far 

What issues?

> 
> - In resman.c:64 - should the resman_ctx be static?

Yes, of course. Will change it in the patch.

Also notice that patch #1 needs to be fixed, too (it failed when actual
options were passed). Will send an updated version soon.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".