From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC48F43E9B for ; Thu, 15 Sep 2022 18:19:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DAF9568BBD4; Thu, 15 Sep 2022 21:19:55 +0300 (EEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067061.outbound.protection.outlook.com [40.92.67.61]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB1FD68BBC7 for ; Thu, 15 Sep 2022 21:19:49 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8zr4TWtNE4espqcH0c8bJsj+u4tNq9gq3MNqaV2rkEE8ZIoZFU0tri4pSqtIVQhOl/Dlf5xEVXQUbupiD0enWb+Erfmt0sJZfirlhEDMnQ2DBpwTUxHMbrNUXqfZy4zkN8Pc0IBzEd1DwE3+0dnkS8SSXoWlkER0/74rYXeDMNhE8jReEi8/xvAGAP4phTqv6CzSo3KaZKjOFmXanNHwt6DRSar8nW7d8PWBCStEgUQ8v+CwOuicD9351WCDZ7J5SIJgqMRY1kuHpdcZP8pXF3T58NS+n97v3dHZ20TbAhr9qGCs3MVmKyY9a2jd6mnLKFNm2YQbBh32ozDJoSStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sG2tJiPh/YtH0D43fyyfaEjANKjAMXPnzPpqM3W+lQk=; b=bhgxbLhkLmvatPLejRjgDpwxEk6V+TYxCXdy3z5/KGsnitDqSUNemnl4slfE29hVnaHoGYsEQL+Xpa3BC7/W0vivHcD2pZqopxKHkVKw+p1Wp6uhlFl/a0n4bz4E1WXoichj81dBPxhxMoTnk4Riom4OeW90qevtLqrfOoT1xd1ykGIeazDB6TTPCSyrsqO+yoD0jrY94KPMrNa30qYFquDU5okSOwkDqeC4Fl4mzf6yF5oI/oD58ksnXRlPQmhCcLAkKPQ0voXT33u8iJu27YvWwx80Xk65am4ND+JYbtRIP8Kv+IE5rgaslgSRb5QBQrW5pwsB75R7V87dX4xVJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sG2tJiPh/YtH0D43fyyfaEjANKjAMXPnzPpqM3W+lQk=; b=CAKexIQgonI/Im//YM69AQcECnqNU3CK4miQBWe1Cv/Pw0tnH+pzwQZU4/s1eYrcP/xzp7I+um8I8wAChYzJtzpAlZehWi0ITx4SM0B9kdcmEw/+s4AWLAEcK4nnW0cBAq5lI7cdgzaAAllmo3Su5PR0il4HoKOTSkkOhzcfB9rUqIIh3pRfyhGJMjIasAYHVmG4NUGWtMu4keqA7ukVpcib0DKqWQJVeetlwLdiJecDPD4WvbtI4jSuLD8X91GXoDcP7/HcNkjqDhvB3jW4NsDfovpsmP5lHk1ePQgZdUlR+VucnX6g5uNHut7LcIcnLhWZTzkozrb6+Sr828YXgg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB9P250MB0428.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:33f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 18:19:48 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::51a4:ed23:ea45:dfeb]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::51a4:ed23:ea45:dfeb%8]) with mapi id 15.20.5612.022; Thu, 15 Sep 2022 18:19:48 +0000 Message-ID: Date: Thu, 15 Sep 2022 20:19:50 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220915162145.2284957-1-mvanb1@gmail.com> <20220915162145.2284957-4-mvanb1@gmail.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [XZlA2MttjdHvgdsQYMMzLCXeDrcGEDWqFUUi1VpG2Zk=] X-ClientProxiedBy: ZR2P278CA0040.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::11) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB9P250MB0428:EE_ X-MS-Office365-Filtering-Correlation-Id: 3761f275-e1f8-48c5-8144-08da9746df6b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lgFz6MXa4GmHKvuxf6P+cgGS4deQ9YmVHOTXkkkBpGkp/5uoXoMbR9/xZsUqpgGL0fL459fOc2kHio5lzRN5QJFdXPAgp6a/+MZeTCT5C7NsBLbUoH2o5rGcWlEPVhtkLF8r7qxPownLAPW23SXcm5DtAaiIwqJyA3Gt0qL6OEP3pvHDzpe0Jkw3F8QQE2DIrBIK4OoNN4f4m6KsCpEqvxsJFsYn59oXo4RV+2xTklNKAgjxy0SIwQ/MizBMsO6WhI81Vhbm4ZFmAssFWgr4ThGfm5RHZUTZ5wKAA3lJTbmmtPb8pCxlhR7womkSSFvMnxM1w7UCVA2j66evdfPf60Dj9jQSkrQJzTzvjF9zRcP7PNV29G8QSidoRcAdN8IsGCiV3aBmIxCG7ASvPMf/7qo0M6fZ0nUw1uWy28BM1yqVMw3sriFNBsQja7HKMwgeBz1p4lZtHY4jWExd4SXUutcyJ65ljffmi82Swl8FCkKF8X/NCIrbtvnJc9vk4QnGaJmOUcpjVd4dDNdraIPnXCM6LvVmbLtLo9uCVtdqBul4ngoJqcL2rexaJupD/zLnNqxHNbiQHg82TdUVYhVKKnmwvaKfYF2z3ByKNRbPJUzlL1pKzEu0C0U0gAAVOl81ftgHknyk9iv3gnV5cQYm4NQluIug3mPclmifPBFF+wricL5HvuZqedAUGVIEZE7G X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3pFS2tGQkNKYXo3RUZhZ0JuQTdIUjhnY2ltOElPUWhmdVZ5L2FYbmVLbWg0?= =?utf-8?B?S09jWnc0OWEycEEvM2NBU3JJMVJDbXRDM0Q0aFF0bWFmcklBLzNrblNVbDZ2?= =?utf-8?B?dU1rUXBQM2RZeHAyOHBWc09BSE5DMXRzTjY1MjZhRFJXejQzSDBEVzRHMy9C?= =?utf-8?B?VnNGVHRjVW9nQldHTmhwSlRPemlNUkp1M08xUDNDN0lELzBtdFV5WmhUdys1?= =?utf-8?B?MzhQV3NhUmp2SmVKMmdlMHBGY0FtZVQ3TDl5bm9nblpybldBZVl5ZmVlcWJp?= =?utf-8?B?QXgyNXhwSEQ5RWE5U21BTTZFaEhXNFFyazVpeVhVenM3N2R1cWlObkpybDVt?= =?utf-8?B?cE5scXd2by9BMS9MRzhhcHZtbWZjdnZvWDlaTGRMRmNYcEdXMlN0TU40d3Jr?= =?utf-8?B?TkM1aXJGSUVIdEJwdlVKLzBXUFlUYmxiOUNydEdhUjRYcm1zcnVJcDYrZlg4?= =?utf-8?B?eHhUeWNGc0lESzU0dVZUWkNsTHFabmkwZEZ1ak45TmlUU3BCZjNVYjR2K0hO?= =?utf-8?B?MGVwSGRHRnJiR1ZsclZoYVBXc0tha2o1dTAvOU5PdFAxWEpReTl5TTYvVDNK?= =?utf-8?B?bzF0MTJhL25XZlRnNzJRVUxlNnFtalRnMnVvVHpaazliV01sL2krVDZVNkdI?= =?utf-8?B?T1U4L0ZMYjBqRXE0TnlEUGRGemwxQnlZTm1GbnZjMVVsMy9nUnJXRXQycUhr?= =?utf-8?B?VDVVVHkzeWs1UzFvN3F0Uk02cmdwOWRPSEhxQ2gwVEJBcWxXNjJrT1U1Njd6?= =?utf-8?B?VWpaeFozQTNXUXlLckwyaDBINHN0SEpadHpxSG9rVXZlbVFibERxRGJ2ejFa?= =?utf-8?B?cDQ3SEJFWjI1bnlOMndNd1EyaWhYWDR5a0lMTnhtakUwRTJ0bVFMVTJ3MkFX?= =?utf-8?B?c1M1MlJMN05BY2VPVmpScllzTW9DL2g5MG52dUJFQmVTV3JhTkp4R05yMTNy?= =?utf-8?B?NFd3UjJKbUI2Ni9xaGNSR0RDK1kyWkVhWFZWMUY4d3dpY3FXbjdSZVJZbGx4?= =?utf-8?B?MDdrUFB6L3FIYUdqRnJnbldKa09mOVZNZ1VwdFpibGdseFNLWkdKaDN1QWxB?= =?utf-8?B?My9JM3VZRjRzTHp1NzcycG40bzFQRzZ2cU92bVlydzVSUUdsOEc1ckhDUVF3?= =?utf-8?B?eno5Z3JITGdnK2NFaEJBY09mSE8xQ1E5clhhdjB1WC9ielhxZUJXcHR3b0pS?= =?utf-8?B?czhtb2N6MUpVOTNaRmdkOGdLNXFmQmthYmEydUl2ZjFUcUJpQUNCUkxoVlh5?= =?utf-8?B?K0hRVFZDelAvbVI0SkRsWnMzb0NKdE1BbEQ1VFV5b2NudG9ocUZuOXBwcDk0?= =?utf-8?B?VWx6RkVMUnpHZ3pMK05zS2hxNEMycStIRkpUNkpaS2VEWEtOaTJaa2FncXhO?= =?utf-8?B?UExIZXgyUWxOMnpsWCtGaDJEOC9kUzRPYU1LU3I5aFZaSithZXRDSU5pQXNK?= =?utf-8?B?aG1uVUgwWjhFazg3azlVbitwUnRsYzgrL3Q2ckFOUS9HWk5pUHBENzBFckFS?= =?utf-8?B?RXV6aWxOT05VQVZybDhqZzlFUjJwTm5KZ0ZqOU9lVGltR1V3bTRLQnM4cUZU?= =?utf-8?B?cjRsNnpFQVZmWVExRDRqc2Q2K2J1ZkFaWTVuTTBxelcwT255dXVVcW03dG9H?= =?utf-8?B?NlgyZ3ZUc1JrdWdMc3MwK1NYSE8vT2F5c3BXOTVSbFJKdWUvNTI1MW9qVllI?= =?utf-8?B?QkhFSUxUSTRyU2QrMiszb3FvU3hxV3YwWEhDNFpsRWdiTXdFcnJxVUdVUTQy?= =?utf-8?Q?e/UOoJDpZPt1qUf575MIB9X5fIuHfbH9RTyYmRl?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3761f275-e1f8-48c5-8144-08da9746df6b X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 18:19:48.0090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0428 Subject: Re: [FFmpeg-devel] [PATCH v5 3/3] fate/flac: Add test of 32 bps encoding/decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Martijn van Beurden: > Op do 15 sep. 2022 om 18:58 schreef Andreas Rheinhardt < > andreas.rheinhardt@outlook.com>: > >> Martijn van Beurden: >>> --- >>> tests/fate/flac.mak | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak >>> index 115cc965e1..4db28b1e1d 100644 >>> --- a/tests/fate/flac.mak >>> +++ b/tests/fate/flac.mak >>> @@ -6,6 +6,8 @@ FATE_FLAC += fate-flac-16-chmode-indep >> \ >>> fate-flac-16-lpc-cholesky >> \ >>> fate-flac-16-lpc-levinson >> \ >>> fate-flac-24-comp-8 >> \ >>> + fate-flac-32 >> \ >>> + fate-flac-32-wasted-bits >> \ >>> fate-flac-rice-params >> \ >>> >>> fate-flac-16-chmode-%: OPTS = -ch_mode $(@:fate-flac-16-chmode-%=%) >>> @@ -20,6 +22,13 @@ fate-flac-24-comp-%: OPTS = -compression_level >> $(@:fate-flac-24-comp-%=%) >>> fate-flac-24-%: REF = >> $(SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav >>> fate-flac-24-%: CMD = enc_dec_pcm flac wav s24le $(subst >> $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac $(OPTS) >>> >>> + >>> +fate-flac-32: REF = $(SAMPLES)/audio-reference/drums_2ch_44kHz_s32.wav >>> +fate-flac-32: CMD = enc_dec_pcm flac wav s32le $(subst >> $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac -strict -2 >> >> We already have 32bit samples in the fate-suite, namely >> wavpack/lossless/32bit_int_partial.wv. Why don't you use these? >> (Anyway, don't hardcode the numerical value of 'experimental'.) >> > > I wasn't sure that was possible. If for example the build is configured to > leave wavpack out that wouldn't work. Or is it assumed that fate is only > run with a ffmpeg build configured with default and some additions but > nothing default left out? > The wavpack decoder would have to be a requirement of this test. (The wav demuxer is btw needed as a requirement for the current tests, but has been left out; the pcm_s16le decoder is also needed for the tests with s16 input samples and the pcm_s24le decoder for the with s24 input samples, but checking for this has been forgotten.) Notice that the test functions would have to be tweaked (the flac tests use CMP = oneoff, i.e. they do not check checksums of the encoded file, but instead test that the decoded audio data coincides with what has been sent to the decoder). (In any case, I don't get why there are two samples: The flac decoder is intra-only, so if you made the samples so that one of the frames had a wasted bit, you could test all the codepaths that two samples test. And it would even have the advantage that it tests what happens when it swiches from >0 wasted bits to 0 wasted bits to >0 wasted bits and back.) > Considering the strict value, I guess I should also change the help text > then? Now it reads: encoding as 24 bits-per-sample, more is considered > experimental. Add -strict -2 if you want to encode more than 24 > bits-per-sample Yes, that should also be changed. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".