* [FFmpeg-devel] [PATCH] fix av_log format specifier
@ 2024-04-25 23:02 Marcus B Spencer
2024-04-26 17:01 ` marcus
0 siblings, 1 reply; 3+ messages in thread
From: Marcus B Spencer @ 2024-04-25 23:02 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marcus B Spencer
Signed-off-by: Marcus B Spencer <marcus@marcusspencer.xyz>
---
libavcodec/bsf/noise.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
index a622855717..d36be5fab4 100644
--- a/libavcodec/bsf/noise.c
+++ b/libavcodec/bsf/noise.c
@@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
drop = !(s->state % s->dropamount);
}
- av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
+ av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
if (drop) {
--
2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fix av_log format specifier
2024-04-25 23:02 [FFmpeg-devel] [PATCH] fix av_log format specifier Marcus B Spencer
@ 2024-04-26 17:01 ` marcus
2024-04-26 17:30 ` [FFmpeg-devel] [PATCH] avcodec/bsf/noise: " Marcus B Spencer
0 siblings, 1 reply; 3+ messages in thread
From: marcus @ 2024-04-26 17:01 UTC (permalink / raw)
To: ffmpeg-devel
This patch does not meet the guidelines of commit messages.
On Thursday, April 25th, 2024 at 6:02 PM, Marcus B Spencer <marcus@marcusspencer.xyz> wrote:
>
>
> Signed-off-by: Marcus B Spencer marcus@marcusspencer.xyz
>
> ---
> libavcodec/bsf/noise.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
> index a622855717..d36be5fab4 100644
> --- a/libavcodec/bsf/noise.c
> +++ b/libavcodec/bsf/noise.c
> @@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
> drop = !(s->state % s->dropamount);
>
> }
>
> - av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
> + av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
> pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
>
>
> if (drop) {
> --
> 2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] [PATCH] avcodec/bsf/noise: fix av_log format specifier
2024-04-26 17:01 ` marcus
@ 2024-04-26 17:30 ` Marcus B Spencer
0 siblings, 0 replies; 3+ messages in thread
From: Marcus B Spencer @ 2024-04-26 17:30 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marcus B Spencer
Replace the "%d" specifier corresponding to the 2nd argument of av_log starting on line 176 with "%u", due to the fact that the 2nd argument is an unsigned int. Without this patch, if the second argument exceeded the maximum value of an int, the behavior would be undefined.
Signed-off-by: Marcus B Spencer <marcus@marcusspencer.xyz>
---
libavcodec/bsf/noise.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
index a622855717..d36be5fab4 100644
--- a/libavcodec/bsf/noise.c
+++ b/libavcodec/bsf/noise.c
@@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
drop = !(s->state % s->dropamount);
}
- av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
+ av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
if (drop) {
--
2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 23:02 [FFmpeg-devel] [PATCH] fix av_log format specifier Marcus B Spencer
2024-04-26 17:01 ` marcus
2024-04-26 17:30 ` [FFmpeg-devel] [PATCH] avcodec/bsf/noise: " Marcus B Spencer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git