[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: fix color primaries check

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: fix color primaries check

[Jun Zhao]

From: Jun Zhao <mypopydev@gmail.com>

Fix incorrect enum value used in color primaries check by replacing
AVCOL_SPC_UNSPECIFIED with AVCOL_PRI_UNSPECIFIED.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavutil/hwcontext_videotoolbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index 1d7dff4a7d..172683121f 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -590,7 +590,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
             colorpri, kCVAttachmentMode_ShouldPropagate);
     else {
         CVBufferRemoveAttachment(pixbuf, kCVImageBufferColorPrimariesKey);
-        if (src->color_primaries != AVCOL_SPC_UNSPECIFIED)
+        if (src->color_primaries != AVCOL_PRI_UNSPECIFIED)
             av_log(log_ctx, AV_LOG_WARNING,
                 "Color primaries %s is not supported.\n",
                 av_color_primaries_name(src->color_primaries));
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: fix color primaries check

[Marvin Scholz]

On 9 Jun 2025, at 11:38, Jun Zhao wrote:

> From: Jun Zhao <mypopydev@gmail.com>
>
> Fix incorrect enum value used in color primaries check by replacing
> AVCOL_SPC_UNSPECIFIED with AVCOL_PRI_UNSPECIFIED.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavutil/hwcontext_videotoolbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 1d7dff4a7d..172683121f 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -590,7 +590,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>              colorpri, kCVAttachmentMode_ShouldPropagate);
>      else {
>          CVBufferRemoveAttachment(pixbuf, kCVImageBufferColorPrimariesKey);
> -        if (src->color_primaries != AVCOL_SPC_UNSPECIFIED)
> +        if (src->color_primaries != AVCOL_PRI_UNSPECIFIED)
>              av_log(log_ctx, AV_LOG_WARNING,
>                  "Color primaries %s is not supported.\n",
>                  av_color_primaries_name(src->color_primaries));
> -- 
> 2.25.1
>

LGTM

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".