From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: fix color primaries check
Date: Mon, 09 Jun 2025 14:30:23 +0200
Message-ID: <FF54DC90-C547-4955-899A-6FA33C2FE404@gmail.com> (raw)
In-Reply-To: <20250609093812.1232896-1-mypopy@gmail.com>
On 9 Jun 2025, at 11:38, Jun Zhao wrote:
> From: Jun Zhao <mypopydev@gmail.com>
>
> Fix incorrect enum value used in color primaries check by replacing
> AVCOL_SPC_UNSPECIFIED with AVCOL_PRI_UNSPECIFIED.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavutil/hwcontext_videotoolbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 1d7dff4a7d..172683121f 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -590,7 +590,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> colorpri, kCVAttachmentMode_ShouldPropagate);
> else {
> CVBufferRemoveAttachment(pixbuf, kCVImageBufferColorPrimariesKey);
> - if (src->color_primaries != AVCOL_SPC_UNSPECIFIED)
> + if (src->color_primaries != AVCOL_PRI_UNSPECIFIED)
> av_log(log_ctx, AV_LOG_WARNING,
> "Color primaries %s is not supported.\n",
> av_color_primaries_name(src->color_primaries));
> --
> 2.25.1
>
LGTM
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-06-09 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 9:38 Jun Zhao
2025-06-09 12:30 ` Marvin Scholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF54DC90-C547-4955-899A-6FA33C2FE404@gmail.com \
--to=epirat07-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git