From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 09B524E27F for ; Mon, 9 Jun 2025 00:27:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6B39368C2C8; Mon, 9 Jun 2025 03:27:53 +0300 (EEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5803C68A351 for ; Mon, 9 Jun 2025 03:27:46 +0300 (EEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-23508d30142so50112515ad.0 for ; Sun, 08 Jun 2025 17:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749428864; x=1750033664; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=8bFpBQRFGieStwS5Gk3NoFftQ5Z/WpDc2N5yyVpsrbk=; b=DxCoXUNd/sdCE/Ssf/MKaeuRZlVpJs9IGWaW4NGrK+p7dY6xCI59Bn0y3YO2Q6Wnqs YSLZlI7ujhEs1o7qsSN2+fp0lbRW2MB4ZawhbHcgKnP5YopmDuyOlcLAdBif9dNph2gO BtsayDQgx/7M6bb8jQsUuCZuYdfNzsng9KVJX+Q7ypuH22xPiMuvk0xbHVWLbr76fbcS eKzS6yyvb5vaAiFMvcXK5hsz1+tr9YaFqxl53Q8SmET8JE0UYTEOUWDJVbYdYkqXGcML 7+lBGfBGy6GDEMsilAwyjtU+boqafH7fq/dqHlW+N5/k9NGYf2dj86YvZrJ6JhSmp/tt gSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749428864; x=1750033664; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8bFpBQRFGieStwS5Gk3NoFftQ5Z/WpDc2N5yyVpsrbk=; b=htVzOl3Dkeq0lbRNZYcv/HfAS/bfcmjQZKdU6lmtJBGgWKrse0U+dXV+MvCDpWicGk nbp/qSUWhY/2Wc7ZUebYl3IcKX8dgA4WiNmTxfNr1fUoFOko/Z+WvnOJOn2AY88y8GbA tI/VDavxm9LUaKjpzKdnebSMbYJ6ldHL53sGmz2DAL63vSS7p/uWY/v6lksNewmKoF3G p1mhU2BIn5okjda1knn18oNXoz1PPBDMRfkqEj95Ap1zN6wtuFcyxn/f+NeDsJcejnRP FHzHS+Dxb2EVxqbXLQ9ScDbhwCATut/McsZSr1Hgse1ypwy94BRgVdBFr0jEEp2oygVt nc7w== X-Gm-Message-State: AOJu0YxAet70FJDGw+p17QzfSI2SA0GZNo16m21z3oAXszArxGEiqRLz +ynM48m4qcBvkp8miktqqMLjCXauQhVJjyDnPJezgLIrPKMFKiUI73G2mXFch4vO49A= X-Gm-Gg: ASbGncv1AsdZJGMhJ/PVf8x9++DuQWpACNQtd2HIhSmh6Ar1/xC8wGhzX0DD+dygjSn RzbLspe3HKLT46WWizeytDoOFZQsGWPmhehzMCLWrdncyNMbz7gJkbu3+nCzEWt0+a+kOaLu9wA eaySFnx+8NZT44nGqcnFlEktKDbYUhR8kFLZzBm9irJb/UUBiIZKc4gYMiXDrjUyVxAzpy8N5vz KwUIZZkoVGiU/62+UgyVNftyldmdJeATMjlV4DuTGmN53L9/S91yK3qMuLCMm8vXaI9oX7/4IG5 VwLGrA0xvsm9kueBM2XZSbCxYrQZyicCGM6ICTOoyyheU+bqUh17SuaCBkai8w== X-Google-Smtp-Source: AGHT+IFUQdoCtrsuBE+u0t6URsnJ/kd4FJeJGn6paDQvuIUBlGI3qJSoxXzDFExpPowYVwfFU9qvKQ== X-Received: by 2002:a17:902:ce85:b0:234:f6ba:e689 with SMTP id d9443c01a7336-23601d7128emr157306765ad.39.1749428864032; Sun, 08 Jun 2025 17:27:44 -0700 (PDT) Received: from smtpclient.apple ([38.99.248.174]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603507281sm43981405ad.240.2025.06.08.17.27.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jun 2025 17:27:43 -0700 (PDT) From: Jack Lau Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Date: Mon, 9 Jun 2025 08:26:58 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 8, 2025, at 04:04, Andreas Rheinhardt wrote: > > Jack Lau via ffmpeg-devel: >> In higher versions (like openssl 1.1.1 and higher), >> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), >> so passing a const string doesn't cause an warnings. >> However, in lower versions of OpenSSL, >> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), >> which leads to warnings. >> >> OpenSSL guarantees that it will not modify the string, >> so it's safe to cast the pem_str to (void *) to avoid this warning. >> >> Signed-off-by: Jack Lau >> --- >> libavformat/tls_openssl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c >> index 86e8935fee..5387e21df1 100644 >> --- a/libavformat/tls_openssl.c >> +++ b/libavformat/tls_openssl.c >> @@ -415,7 +415,7 @@ error: >> */ >> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) >> { >> - BIO *mem = BIO_new_mem_buf(pem_str, -1); >> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); >> if (!mem) { >> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); >> return NULL; >> @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) >> */ >> static X509 *cert_from_pem_string(const char *pem_str) >> { >> - BIO *mem = BIO_new_mem_buf(pem_str, -1); >> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); >> if (!mem) { >> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); >> return NULL; > > Shouldn't this use #if checks to only cast const away when building for > old versions so that we do not forget to remove these casts when we drop > support for these old versions (and to avoid warnings when using > -Wcast-qual)? Thanks for the review! The Patch v2 already is here https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344816.html Thanks Jack > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".