* [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version
@ 2025-06-07 1:35 Jack Lau via ffmpeg-devel
2025-06-07 8:37 ` Steven Liu
2025-06-07 20:04 ` Andreas Rheinhardt
0 siblings, 2 replies; 4+ messages in thread
From: Jack Lau via ffmpeg-devel @ 2025-06-07 1:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jack Lau
In higher versions (like openssl 1.1.1 and higher),
the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
so passing a const string doesn't cause an warnings.
However, in lower versions of OpenSSL,
the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
which leads to warnings.
OpenSSL guarantees that it will not modify the string,
so it's safe to cast the pem_str to (void *) to avoid this warning.
Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
libavformat/tls_openssl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 86e8935fee..5387e21df1 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -415,7 +415,7 @@ error:
*/
static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
{
- BIO *mem = BIO_new_mem_buf(pem_str, -1);
+ BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
@@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
*/
static X509 *cert_from_pem_string(const char *pem_str)
{
- BIO *mem = BIO_new_mem_buf(pem_str, -1);
+ BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
--
2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-07 1:35 [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
@ 2025-06-07 8:37 ` Steven Liu
2025-06-07 20:04 ` Andreas Rheinhardt
1 sibling, 0 replies; 4+ messages in thread
From: Steven Liu @ 2025-06-07 8:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Jack Lau
Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> 于2025年6月7日周六 09:35写道：
>
> In higher versions (like openssl 1.1.1 and higher),
> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> so passing a const string doesn't cause an warnings.
> However, in lower versions of OpenSSL,
> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> which leads to warnings.
>
> OpenSSL guarantees that it will not modify the string,
> so it's safe to cast the pem_str to (void *) to avoid this warning.
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/tls_openssl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..5387e21df1 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,7 @@ error:
> */
> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> */
> static X509 *cert_from_pem_string(const char *pem_str)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
LGTM
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-07 1:35 [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
2025-06-07 8:37 ` Steven Liu
@ 2025-06-07 20:04 ` Andreas Rheinhardt
2025-06-09 0:26 ` Jack Lau
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Rheinhardt @ 2025-06-07 20:04 UTC (permalink / raw)
To: ffmpeg-devel
Jack Lau via ffmpeg-devel:
> In higher versions (like openssl 1.1.1 and higher),
> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> so passing a const string doesn't cause an warnings.
> However, in lower versions of OpenSSL,
> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> which leads to warnings.
>
> OpenSSL guarantees that it will not modify the string,
> so it's safe to cast the pem_str to (void *) to avoid this warning.
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/tls_openssl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..5387e21df1 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,7 @@ error:
> */
> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> */
> static X509 *cert_from_pem_string(const char *pem_str)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
Shouldn't this use #if checks to only cast const away when building for
old versions so that we do not forget to remove these casts when we drop
support for these old versions (and to avoid warnings when using
-Wcast-qual)?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-07 20:04 ` Andreas Rheinhardt
@ 2025-06-09 0:26 ` Jack Lau
0 siblings, 0 replies; 4+ messages in thread
From: Jack Lau @ 2025-06-09 0:26 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 8, 2025, at 04:04, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Jack Lau via ffmpeg-devel:
>> In higher versions (like openssl 1.1.1 and higher),
>> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
>> so passing a const string doesn't cause an warnings.
>> However, in lower versions of OpenSSL,
>> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
>> which leads to warnings.
>>
>> OpenSSL guarantees that it will not modify the string,
>> so it's safe to cast the pem_str to (void *) to avoid this warning.
>>
>> Signed-off-by: Jack Lau <jacklau1222@qq.com>
>> ---
>> libavformat/tls_openssl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>> index 86e8935fee..5387e21df1 100644
>> --- a/libavformat/tls_openssl.c
>> +++ b/libavformat/tls_openssl.c
>> @@ -415,7 +415,7 @@ error:
>> */
>> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> {
>> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>> @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> */
>> static X509 *cert_from_pem_string(const char *pem_str)
>> {
>> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>
> Shouldn't this use #if checks to only cast const away when building for
> old versions so that we do not forget to remove these casts when we drop
> support for these old versions (and to avoid warnings when using
> -Wcast-qual)?
Thanks for the review! The Patch v2 already is here https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344816.html
Thanks
Jack
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-09 0:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-07 1:35 [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
2025-06-07 8:37 ` Steven Liu
2025-06-07 20:04 ` Andreas Rheinhardt
2025-06-09 0:26 ` Jack Lau
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git