Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

[Jack Lau <jacklau1222gm@gmail.com>]

> On Jul 30, 2025, at 04:02, Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> Hello,
> 
> It seem there is strong evidence that AI wrote TLS code as part of the
> WHIP patch. It goes without saying why this is bad. Further discussion
> here:
> https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053
Hello,

I would like to clarify a few things.

Before GSoC, the initial WHIP patches were written by Winlin and many other RTC developers. My first task during GSoC was to refactor the DTLS code and integrate it into the existing tls.

Additionally, I did use AI to speed up parts of the WHIP development. Specifically, the functions for converting cert/key between PEM and string formats were generated with the help of AI. I tested them locally before including them in the codebase.

At the time, I believed these functions were relatively straightforward and didn’t require refer to RFCs, so I used the AI-generated output.

However, the rest of the WHIP and DTLS implementation — especially the parts that require RFC compliance — was written manually. That said, there's still room for improvement. For example, this pull request <https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20030> not only adds new features, but also refactors the ICE/DTLS logic in WHIP.

I sincerely apologize for introducing the AI-generated code snippet, and I will avoid this in the future.

Before GSoC ends, I plan to continue improving the WHIP codebase, including adding support for multiple SSL libraries and additional codecs.

I would like to thank my mentors, Steven and Zhao, as well as many RTC developers for their support. 

Thanks to Timo and Marvin for their help during this time. I'm also grateful to Timo for his patient guidance, and to Kieran for many suggestions that have helped FFmpeg improve. Due to language and cultural differences, it would be even better if we could communicate more directly through patches.


> 
> This patch was pushed without ML review.
> 
> I think this code should be removed before the FFmpeg release. I
> include TC in this email for that reason.
> 
> Regards,
> Kieran Kunhya
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Regards,
Jack

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".