From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3CC084FBFC for ; Sat, 28 Jun 2025 14:16:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6059C68E1CF; Sat, 28 Jun 2025 17:16:09 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1254E68E185 for ; Sat, 28 Jun 2025 17:16:02 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-60c51860bf5so4998998a12.1 for ; Sat, 28 Jun 2025 07:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751120161; x=1751724961; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1FA72Ktsjg/0yzC+PhS5Lr3umiThQzHNM4itdaFOoGc=; b=BMoC1Raj621ewrIAOANpIsx4zjT/w+5Kev/VDuKj0N0f1C+7nuowuPg4DEGniviOwO SvybzIpbAR5pssmJJngwJEN2cVk6nUNTc/RIospSEo0PiNVTyDRmXV7QRCcEH7gBiz4+ q2857yCP3AqPQgtGnrejp5tl2gSDkXqEx+JWbGEfxyq51LjC6uly/cEAi2xQ2z0nlsr/ hbJTb8Ljlrdd24BDPW6AYNd13A9j4G90DmivcemBGmyb3kJwCFWraN2DmwxPwRJDuTfZ y07q3FrT6oQ1nSoz+UAr71OEw+tazDIUhJ82NFzRG6wpYKvFjFTkKu3i42wmHA+ag10N QWkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751120161; x=1751724961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1FA72Ktsjg/0yzC+PhS5Lr3umiThQzHNM4itdaFOoGc=; b=gW6IPS91MkoBmZa52ScFI0sBnGFXEIG9G0FojSxN6fXntmeXfH/0bhKQREvaog6ADa bgQdPbaI2K+NptDWQZTAulbtb/MOk7yNgit31ZJWpsaXtS5tAqRxVoW8nupZxY9S2EmB fTFMS5pb8SZGRjQHiVE97CNxxj+eFSdJb2ixHWqsoOXSNXOREIGeleCE/Kwwpb08M5P1 KW4DVvcX6slKu9IqKcfhuu/unvoAGSEZUwmplJAEVbaCuc327ToWW2eBldfDgYiDyMG9 +X0wbiSBmB2+kSXd+j0tf7Oy4NP39Fq2F1mWOPBtxNjKB2+S4EDlnkMMrxcGq7RM7lpI hiOQ== X-Gm-Message-State: AOJu0YwYAgFq4EeQssKjn/KV/dcseWzb+vJo+CnfRvU7f5OSDsOLMjLq ibM3/V00h6KGzD1GXI62ZewiOE6ESDKWnu3MBJVBMKzMSyuUcM4JDvdfykr2lA== X-Gm-Gg: ASbGnctr5UH/xgv6OVXgGWFvco1BcXgv7rQK+gAsnaUHR9cWf/daON51mVuPqI93wmS Bemg2UoL1qCKQSzmnUCYpqsxAg3XavvHMqZO2yRvP8HOnXMT7A5FppcmshCj9z0SN+N2qIyov1I 3E5wJIYxx3J7iu34uo2IlMqiYYMSuKtmxhN5+R8GOA7KPQ0eyzLcvx6H5g/z4x0SD12lHSu9GaT qO0+nPg9fVb7e/ocWXNdzU5Q+++Gc6SMRa7Q/PICwfo3lQx42MOV0J07A8JsgORkQjNMmAlgNzC NuBH+LYRf0mw/XC1D3/sG5okF6wqCw/1CGfG+hqEn+Q6CvFFOfMEC0PhkMAE16auyGFjIvjZHi0 LbcOwO/ErnEbePmQCppZbQ0rMyFxYLtRPuedB9yo5YpiJ5CkkTI9OIttFbdPTkBY8KVRJ3BovV4 w= X-Google-Smtp-Source: AGHT+IGtMDtXLtN5XwgXR+wLgdfZ53RxaHxpQn4j9eOH+U8eqB+p2FZY2zZs8hEA/BWCRp25JzQOHw== X-Received: by 2002:a05:6402:2747:b0:609:7ed1:c792 with SMTP id 4fb4d7f45d1cf-60c88e7aeb5mr5309922a12.29.1751120160964; Sat, 28 Jun 2025 07:16:00 -0700 (PDT) Received: from [192.168.178.57] (p2003010237004500d82e3c7de7372df5.dip0.t-ipconnect.de. [2003:102:3700:4500:d82e:3c7d:e737:2df5]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c828e492bsm2974707a12.20.2025.06.28.07.16.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jun 2025 07:16:00 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Sat, 28 Jun 2025 16:15:59 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/whip: fix typos X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28 Jun 2025, at 4:17, Jack Lau via ffmpeg-devel wrote: > AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC }, > - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), > + { "authorization", "(Optional) Bearer token for WHIP Authorization", OFFSET(authorization), > AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, > - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), > + { "cert_file", "(Optional) Certificate file path for DTLS", OFFSET(cert_file), > AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, > - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), > + { "key_file", "(Optional) Private key file path for DTLS", OFFSET(key_file), > AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC }, I dont think we mark any options as option like this so maybe just change those to: Optional bearer token for WHIP Authorization Optional certificate file path for DTLS Optional private key file path for DTLS > - { "whip_flags", "Set flags affecting WHIP connection behavior", OFFSET(flags), > + { "whip_flags", "(Optional) Set flags affecting WHIP connection behavior", OFFSET(flags), I dont think it makes sense here to mention this is optional, thats a given. > AV_OPT_TYPE_FLAGS, { .i64 = 0 }, 0, UINT_MAX, ENC, .unit = "flags" }, > { "ignore_ipv6", "(Optional) Ignore any IPv6 ICE candidate", 0, > AV_OPT_TYPE_CONST, { .i64 = WHIP_FLAG_IGNORE_IPV6 }, 0, UINT_MAX, ENC, .unit = "flags" }, Same. Otherwise the set looks good to me. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".