From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/whip: fix typos
Date: Sat, 28 Jun 2025 16:15:59 +0200
Message-ID: <ED49BF1F-C871-4E57-8C1B-907B0A1E324F@gmail.com> (raw)
In-Reply-To: <mailman.4666.1751077037.1384.ffmpeg-devel@ffmpeg.org>
On 28 Jun 2025, at 4:17, Jack Lau via ffmpeg-devel wrote:
> AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC },
> - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization),
> + { "authorization", "(Optional) Bearer token for WHIP Authorization", OFFSET(authorization),
> AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
> - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file),
> + { "cert_file", "(Optional) Certificate file path for DTLS", OFFSET(cert_file),
> AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
> - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file),
> + { "key_file", "(Optional) Private key file path for DTLS", OFFSET(key_file),
> AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
I dont think we mark any options as option like this so maybe just change those to:
Optional bearer token for WHIP Authorization
Optional certificate file path for DTLS
Optional private key file path for DTLS
> - { "whip_flags", "Set flags affecting WHIP connection behavior", OFFSET(flags),
> + { "whip_flags", "(Optional) Set flags affecting WHIP connection behavior", OFFSET(flags),
I dont think it makes sense here to mention this is optional, thats a given.
> AV_OPT_TYPE_FLAGS, { .i64 = 0 }, 0, UINT_MAX, ENC, .unit = "flags" },
> { "ignore_ipv6", "(Optional) Ignore any IPv6 ICE candidate", 0,
> AV_OPT_TYPE_CONST, { .i64 = WHIP_FLAG_IGNORE_IPV6 }, 0, UINT_MAX, ENC, .unit = "flags" },
Same.
Otherwise the set looks good to me.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-28 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 2:17 Jack Lau via ffmpeg-devel
2025-06-28 14:15 ` Marvin Scholz [this message]
2025-06-28 15:04 ` Jack Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED49BF1F-C871-4E57-8C1B-907B0A1E324F@gmail.com \
--to=epirat07-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git