Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
       [not found] <CGME20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20@eucas1p1.samsung.com>
@ 2025-03-25  7:56 ` Dawid Kozinski
  2025-03-25  8:18   ` Andreas Rheinhardt
  0 siblings, 1 reply; 8+ messages in thread
From: Dawid Kozinski @ 2025-03-25  7:56 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Dawid Kozinski

Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
---
 libavcodec/libxevd.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
index 520fdab7d8..483700c81e 100644
--- a/libavcodec/libxevd.c
+++ b/libavcodec/libxevd.c
@@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
     }
     switch(color_space) {
     case XEVD_CS_YCBCR400_10LE:
-        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
+    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
+        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
         break;
     case XEVD_CS_YCBCR420_10LE:
-        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
+    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
+        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
         break;
     case XEVD_CS_YCBCR422_10LE:
-        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
+    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
+        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
         break;
     case XEVD_CS_YCBCR444_10LE:
-        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
+    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
+        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
         break;
     default:
         av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
  2025-03-25  7:56 ` [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function Dawid Kozinski
@ 2025-03-25  8:18   ` Andreas Rheinhardt
  0 siblings, 0 replies; 8+ messages in thread
From: Andreas Rheinhardt @ 2025-03-25  8:18 UTC (permalink / raw)
  To: ffmpeg-devel

Dawid Kozinski:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
>  libavcodec/libxevd.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> index 520fdab7d8..483700c81e 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
>      }
>      switch(color_space) {
>      case XEVD_CS_YCBCR400_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
>          break;
>      case XEVD_CS_YCBCR420_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
>          break;
>      case XEVD_CS_YCBCR422_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
>          break;
>      case XEVD_CS_YCBCR444_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
>          break;
>      default:
>          av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");

This patch maps both BE and LE formats to FFmpeg's corresponding native
endian formats. This is wrong.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
  2025-03-25  6:45   ` Andreas Rheinhardt
  2025-03-25  8:01     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
@ 2025-03-25 15:57     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
  1 sibling, 0 replies; 8+ messages in thread
From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2025-03-25 15:57 UTC (permalink / raw)
  To: 'FFmpeg development discussions and patches'





> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: wtorek, 25 marca 2025 07:46
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel
format
> handling in export_stream_params function
> 
> Dawid Kozinski:
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> >
> >
> > ---
> >
> >
> >  libavcodec/libxevd.c | 12 ++++++++----
> >
> >
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> >
> >
> >
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> >
> >
> > index 520fdab7d8..483700c81e 100644
> >
> >
> > --- a/libavcodec/libxevd.c
> >
> >
> > +++ b/libavcodec/libxevd.c
> >
> >
> > @@ -152,16 +152,20 @@ static int export_stream_params(const
> > XevdContext *xectx, AVCodecContext *avctx)
> >
> >
> >      }
> >
> >
> >      switch(color_space) {
> >
> >
> >      case XEVD_CS_YCBCR400_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): //
> > + XEVD_CS_YCBCR400_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR420_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): //
> > + XEVD_CS_YCBCR420_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR422_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): //
> > + XEVD_CS_YCBCR422_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR444_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): //
> > + XEVD_CS_YCBCR444_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> >
> >
> >          break;
> >
> >
> >      default:
> >
> >
> >          av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");
> >
> >
> 
> Patch is still broken. Apart from that: Does the BE in
XEVD_CS_YCBCR444_10BE
> etc. mean big endian?
> 
> - Andreas

Fixed

Dawid
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=a97927d0-c804cd53-a978ac9f-
> 74fe48600158-e92750f94350d790&q=1&e=b1134fec-7a63-44be-a722-
> 98aa431c9a91&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
  2025-03-25  6:45   ` Andreas Rheinhardt
@ 2025-03-25  8:01     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
  2025-03-25 15:57     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
  1 sibling, 0 replies; 8+ messages in thread
From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2025-03-25  8:01 UTC (permalink / raw)
  To: 'FFmpeg development discussions and patches'




> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: wtorek, 25 marca 2025 07:46
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel
format
> handling in export_stream_params function
> 
> Dawid Kozinski:
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> >
> >
> > ---
> >
> >
> >  libavcodec/libxevd.c | 12 ++++++++----
> >
> >
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> >
> >
> >
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> >
> >
> > index 520fdab7d8..483700c81e 100644
> >
> >
> > --- a/libavcodec/libxevd.c
> >
> >
> > +++ b/libavcodec/libxevd.c
> >
> >
> > @@ -152,16 +152,20 @@ static int export_stream_params(const
> > XevdContext *xectx, AVCodecContext *avctx)
> >
> >
> >      }
> >
> >
> >      switch(color_space) {
> >
> >
> >      case XEVD_CS_YCBCR400_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): //
> > + XEVD_CS_YCBCR400_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR420_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): //
> > + XEVD_CS_YCBCR420_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR422_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): //
> > + XEVD_CS_YCBCR422_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> >
> >
> >          break;
> >
> >
> >      case XEVD_CS_YCBCR444_10LE:
> >
> >
> > -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> >
> >
> > +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): //
> > + XEVD_CS_YCBCR444_10BE
> >
> >
> > +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> >
> >
> >          break;
> >
> >
> >      default:
> >
> >
> >          av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");
> >
> >
> 
> Patch is still broken. Apart from that: Does the BE in
XEVD_CS_YCBCR444_10BE
> etc. mean big endian?

Yes BE in XEVD_CS_YCBCR444_10BE means Big Endian.  
> 
> - Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=a97927d0-c804cd53-a978ac9f-
> 74fe48600158-e92750f94350d790&q=1&e=b1134fec-7a63-44be-a722-
> 98aa431c9a91&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
  2025-03-25  6:35 ` Dawid Kozinski
@ 2025-03-25  6:45   ` Andreas Rheinhardt
  2025-03-25  8:01     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
  2025-03-25 15:57     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
  0 siblings, 2 replies; 8+ messages in thread
From: Andreas Rheinhardt @ 2025-03-25  6:45 UTC (permalink / raw)
  To: ffmpeg-devel

Dawid Kozinski:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> 
> 
> ---
> 
> 
>  libavcodec/libxevd.c | 12 ++++++++----
> 
> 
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> 
> 
> 
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> 
> 
> index 520fdab7d8..483700c81e 100644
> 
> 
> --- a/libavcodec/libxevd.c
> 
> 
> +++ b/libavcodec/libxevd.c
> 
> 
> @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
> 
> 
>      }
> 
> 
>      switch(color_space) {
> 
> 
>      case XEVD_CS_YCBCR400_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> 
> 
>          break;
> 
> 
>      case XEVD_CS_YCBCR420_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> 
> 
>          break;
> 
> 
>      case XEVD_CS_YCBCR422_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> 
> 
>          break;
> 
> 
>      case XEVD_CS_YCBCR444_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> 
> 
>          break;
> 
> 
>      default:
> 
> 
>          av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");
> 
> 

Patch is still broken. Apart from that: Does the BE in
XEVD_CS_YCBCR444_10BE etc. mean big endian?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
       [not found] <CGME20250325063514eucas1p15a0d6c2b7047c2e61b1500e85fd09e33@eucas1p1.samsung.com>
@ 2025-03-25  6:35 ` Dawid Kozinski
  2025-03-25  6:45   ` Andreas Rheinhardt
  0 siblings, 1 reply; 8+ messages in thread
From: Dawid Kozinski @ 2025-03-25  6:35 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Dawid Kozinski

Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>


---


 libavcodec/libxevd.c | 12 ++++++++----


 1 file changed, 8 insertions(+), 4 deletions(-)





diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c


index 520fdab7d8..483700c81e 100644


--- a/libavcodec/libxevd.c


+++ b/libavcodec/libxevd.c


@@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)


     }


     switch(color_space) {


     case XEVD_CS_YCBCR400_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE


+        avctx->pix_fmt = AV_PIX_FMT_GRAY10;


         break;


     case XEVD_CS_YCBCR420_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;


         break;


     case XEVD_CS_YCBCR422_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;


         break;


     case XEVD_CS_YCBCR444_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;


         break;


     default:


         av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");


-- 


2.34.1





_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
  2025-03-24 17:22 ` Dawid Kozinski
@ 2025-03-24 20:27   ` James Almer
  0 siblings, 0 replies; 8+ messages in thread
From: James Almer @ 2025-03-24 20:27 UTC (permalink / raw)
  To: ffmpeg-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 1930 bytes --]

On 3/24/2025 2:22 PM, Dawid Kozinski wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> 
> 
> ---
> 
> 
>   libavcodec/libxevd.c | 12 ++++++++----
> 
> 
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> 
> 
> 
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> 
> 
> index 520fdab7d8..483700c81e 100644
> 
> 
> --- a/libavcodec/libxevd.c
> 
> 
> +++ b/libavcodec/libxevd.c
> 
> 
> @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
> 
> 
>       }
> 
> 
>       switch(color_space) {
> 
> 
>       case XEVD_CS_YCBCR400_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR420_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR422_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> 
> 
>           break;
> 
> 
>       case XEVD_CS_YCBCR444_10LE:
> 
> 
> -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> 
> 
> +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
> 
> 
> +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> 
> 
>           break;
> 
> 
>       default:
> 
> 
>           av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");

You mailer mangled the patch. You could attach the output of git 
format-patch instead if you can't fix the above.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function
       [not found] <CGME20250324172251eucas1p28dac6b240d775b289485ceb483444ecb@eucas1p2.samsung.com>
@ 2025-03-24 17:22 ` Dawid Kozinski
  2025-03-24 20:27   ` James Almer
  0 siblings, 1 reply; 8+ messages in thread
From: Dawid Kozinski @ 2025-03-24 17:22 UTC (permalink / raw)
  To: d.frankiewic, ffmpeg-devel; +Cc: Dawid Kozinski

Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>


---


 libavcodec/libxevd.c | 12 ++++++++----


 1 file changed, 8 insertions(+), 4 deletions(-)





diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c


index 520fdab7d8..483700c81e 100644


--- a/libavcodec/libxevd.c


+++ b/libavcodec/libxevd.c


@@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)


     }


     switch(color_space) {


     case XEVD_CS_YCBCR400_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE


+        avctx->pix_fmt = AV_PIX_FMT_GRAY10;


         break;


     case XEVD_CS_YCBCR420_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;


         break;


     case XEVD_CS_YCBCR422_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;


         break;


     case XEVD_CS_YCBCR444_10LE:


-        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;


+    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE


+        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;


         break;


     default:


         av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");


-- 


2.34.1





_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-03-25 15:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20@eucas1p1.samsung.com>
2025-03-25  7:56 ` [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function Dawid Kozinski
2025-03-25  8:18   ` Andreas Rheinhardt
     [not found] <CGME20250325063514eucas1p15a0d6c2b7047c2e61b1500e85fd09e33@eucas1p1.samsung.com>
2025-03-25  6:35 ` Dawid Kozinski
2025-03-25  6:45   ` Andreas Rheinhardt
2025-03-25  8:01     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2025-03-25 15:57     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
     [not found] <CGME20250324172251eucas1p28dac6b240d775b289485ceb483444ecb@eucas1p2.samsung.com>
2025-03-24 17:22 ` Dawid Kozinski
2025-03-24 20:27   ` James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git