Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format handling in export_stream_params function

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Dawid Kozinski:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
>  libavcodec/libxevd.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> index 520fdab7d8..483700c81e 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext *xectx, AVCodecContext *avctx)
>      }
>      switch(color_space) {
>      case XEVD_CS_YCBCR400_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): // XEVD_CS_YCBCR400_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_GRAY10;
>          break;
>      case XEVD_CS_YCBCR420_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): // XEVD_CS_YCBCR420_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
>          break;
>      case XEVD_CS_YCBCR422_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): // XEVD_CS_YCBCR422_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
>          break;
>      case XEVD_CS_YCBCR444_10LE:
> -        avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> +    case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): // XEVD_CS_YCBCR444_10BE
> +        avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
>          break;
>      default:
>          av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");

This patch maps both BE and LE formats to FFmpeg's corresponding native
endian formats. This is wrong.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".