From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 022E94AF75 for <ffmpegdev@gitmailbox.com>; Tue, 25 Mar 2025 10:21:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21307687B95; Tue, 25 Mar 2025 12:21:11 +0200 (EET) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2079.outbound.protection.outlook.com [40.92.48.79]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 88800687AEC for <ffmpeg-devel@ffmpeg.org>; Tue, 25 Mar 2025 12:21:04 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dLolgaGJC3f1j1FFEgQHPMBjd45Mxkdri1UytmbREOFKpPLXDm83a5v0nwqF9T1TWOgDBankcY1TFHkP//QWs6rp5cJ+KjOdps8AuU8z4aQhWsp7Hh+Ym3Tj+waNQQCyvLtqDPhBaZKA1tDuJFIMghanigTBkxNjIFxhNAMbJyiMNcOsterbsZDl3b9Yo9FJuFL7cCOhNkQLYI620Dcm0eQ88FnDcSChyvmZwOW1uP/HjwaAx9cXlHsMCHWeDV+WcajcY/vmQj1JHV2xnr2KsFbDMF07pxThuAmv8bVghn5MDGCNwpyYknJVBij3tqp3fmT1/3MIYpMGvRARCg7Usw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lz8PZXXREJhiWG3mBNGJHYuq5G+e8oYu4fzhOpJtMos=; b=Di6OCFZXz/V9wP+682RYdz31uGIA/W/yzWnhyaKlqkRJaXegrpU9va8/rNI59il+M4WqH0Z7j9v4zlLzV6gmN0G53iQg0HpySblGT8iFDBIUUyYQJ0eqsbUtqSqjKOSkc9HCwG4Pp5Yq7xxsOseHOv6vzbNnbf5P35QqASdK+qYjxuPm9V6KlXwEW1gAiRIkFwH+dbTxVDathBpke33nxFXUv/nj0fmkhEToy5dQ1Yc3g7qTpleo+qiwWBtpvIjY5q+AZuw7KT0v7BUwo4/FFqr5A6W0I8quPIg3izlduy6SfdQe6GuC6kURzayfRH0wFK+FEUq3YtImmmae03lg6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lz8PZXXREJhiWG3mBNGJHYuq5G+e8oYu4fzhOpJtMos=; b=PLq1pYoq7TrBubE8NnuLyxG8VQMaxc5+ShU6TNyFoCviuKP6MdXyTHOA9cj34x5aGjTLH4cC0aX8B+jS+qNAJOLLcLDppyyf6hzt4K19RQyrJiMlSHfP2QQTkBU5Rx2ZOnXFwYkwizoIIoRk2xJi8aW6TUJW7UQqWLDjSqwVB2TeONs8TGuyChAiQz24EhsNN2/Xln+bwJ8ponNmPH4oH42Wu+nUxndtlhpWTthVPa+v/n5Xl7J3jYV6H6OYl0f06X/gTUkoAUkeuhwHVrQ/OkGLDZbHnB+6jIPHLh/A+5ECM9WF2gXHxbqTtH6oZ1K64Dc7MmccyGXUziySkL15MA== Received: from DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:4e3::18) by PRAP250MB0418.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:27b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.24; Tue, 25 Mar 2025 10:21:03 +0000 Received: from DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM ([fe80::1623:380f:e44:bf3a]) by DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM ([fe80::1623:380f:e44:bf3a%6]) with mapi id 15.20.8583.023; Tue, 25 Mar 2025 10:21:03 +0000 Message-ID: <DUZSPRMB00050FE701ACB383534A8E6A8FA72@DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM> Date: Tue, 25 Mar 2025 11:20:57 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <GV1SPRMB003688D4B4AF15EE9D532F998FA52@GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM> <20250325101021.GY4991@pb2> Content-Language: en-US From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> In-Reply-To: <20250325101021.GY4991@pb2> X-ClientProxiedBy: ZR0P278CA0110.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::7) To DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:4e3::18) X-Microsoft-Original-Message-ID: <641b5524-808b-4b4b-b62b-158fd9818a47@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DUZSPRMB0005:EE_|PRAP250MB0418:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e5568d0-2b0c-4bc1-b560-08dd6b86beea X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|7092599003|8060799006|19110799003|5072599009|6090799003|461199028|3412199025|440099028|19061999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NTNQZzhrM3FLTjM4Zjg2b2pxaVRlb2h0MGVuZVMwTURVWEErNzJURFdDdjFt?= =?utf-8?B?M2FsUEdIc3NiZVdDYm9QS3ZEZGtMT0hWMzMrcC9paHMwdnpyd1lZNjN0bWNF?= =?utf-8?B?UzF5MHFYOTdpWVBHclVRa3NVbWNUTlM1eGxmNlAxVHpYMWtVYmMxZFNvYkVw?= =?utf-8?B?cS9rSUp1RGUzczlkd3dWR1ZlZTZ2WlBOK2hBa0p6V1lGNTExN3FvVDBPNHAv?= =?utf-8?B?RTI5Z2Mydjk2enhIajNldWZiUWorT2oydTB1U0g2bkwrY3dVcXl0U2N5Z2Q0?= =?utf-8?B?VWRqWDV4UmxxQlRvdU5lSTh1dmNkTGhoakZsbDBUTG84T3dQT095RDJBRGxB?= =?utf-8?B?WEtSOW12TkUyMU1zcmxiY0dkdHQ2WWlsNkVCcWN6alNQVERFN3VzWjhpS0kv?= =?utf-8?B?VUl6RkJzM2hvbWxIK2Q5MHNEd3VKUzhuWE4yS3pWSGRHZUV5a1p5OWFQNVBN?= =?utf-8?B?MFVpaGN3SVZsaHBWaFVhOTVZWDhqaVk2ODFrYUd6aGZFOXBrZ0x6RmMrbklI?= =?utf-8?B?VGhhUm5BMmVsVUkyUDVueU9pYnhBVytzSGphdDRxa2hFWk4yUnVnUGd4Nk5i?= =?utf-8?B?aUV5WGZKUnFWMHJWNWR3cThRYmhjSk5BVUdITTFid2MreDFtVTg4LzZIQk5o?= =?utf-8?B?SWVPdjZ1WXRCNnNmYURid2tyOHo4cDUrR3Y4QlZ4QkxlY2dhYitoemZHSUc0?= =?utf-8?B?dms4RmM3SnBvUVlQak00Q1h2SFVhUjZ1a3Jqc0VGSzQvNHJZRmtTWVJFUHZJ?= =?utf-8?B?TzdwRXFMNVdRdW9YTjZubkQ1bk1UUXJVbE1uQjhRWEdUdXNrclFPaS83eE5E?= =?utf-8?B?UWlCOVltQjZEOW9KQklTM2UxZVU0Sjh4NVZtenVDZklrUkRJcDAxZS9tOHdk?= =?utf-8?B?QkU1cU5vTTM2SXBFSU5ZNThRaG95WmRNcktwV0NHZFVFeWNuS1hjQzhYeFZr?= =?utf-8?B?NWJWS1hDazAzd2lVSmUrT08zcnJNRFRqUXorVVNZUkRtSW8xNnp0NXg4QnMw?= =?utf-8?B?cjNMby9mZ2xqbnJzRFd2MjJONDV2T2VvTlJOREpvbFVyRDlhWUdUOUpsOVRO?= =?utf-8?B?UU1UM0JLbHhTWmpyTnQyNzZrcFZMOS9Sdmgxb1pBRXNhdEwvekUvK0F4MkUz?= =?utf-8?B?WTROQXcxUUoxOGh1NWpyUXVKcEVzdmF1NHQ2eWJuTGlDSjhDbk5YOHRXL1pM?= =?utf-8?B?OEY4RG5KOHpXSWxBNUtxUTBFRlV2NkpJdzkxci9TU0MvcnBlMlByOStwd0ZY?= =?utf-8?B?YWZDVnFyVlpPbzNDcDBZd0ZWU1pkREYrNU1MU0xxc1FGbi94ZkExV1FDalpl?= =?utf-8?B?clFzTXJiWnN3SUFwa2VZbUhKaXNidGdKMytrYk0yNVB4b29tdlZUcUQ2MGxH?= =?utf-8?B?bHdrV2RZQTU3YWUybFhvU094RVpKMHNaQkp0Y1FKc0g5bktjUW4rRyswM2VD?= =?utf-8?B?QllIdjJuWkhSdTZuRWpQOUFPVmRPVUpneFRWZmtaM1lyMnRoNU9yQWtyRXNR?= =?utf-8?B?MVNBVUJyV1ZvRy9NS0dNU1ZMS242MWM0QmoycHVtWE9pb2F5T1Y4UGQzZ1Mx?= =?utf-8?Q?cgHmtSfGQcDUZCMaKYMfZ6sJ8=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlV2bDZQVUgxUnJQMG9pa2dRUFd6T1RZN2ViTlMraitSRldNczQ0NlNOQUYx?= =?utf-8?B?QnlSdmtsL1JZN2FiaWJzUzkxUVlOc2ZZV0M3R2t6RkE1Qnh1SmJ6bi81Z2g3?= =?utf-8?B?bmRnekEvSWZCVDJMUTBzS0ZmQmUzZWpQenArMDVDSldBenUvendxa29CUWNB?= =?utf-8?B?dGZsUk1qUlYzblZFSnI0L1JGdGRHMnNyZEM1MFllOGdkeWVhU3AyaFB3WUdP?= =?utf-8?B?TFA2dytndlVucGhJS2FlTG8vaHhqSHRMMVZMWHVIVW5xZUxyeVFaODREMFJw?= =?utf-8?B?eDFvTENtTWJydE95KzZieXZjOHA3UjZ4UHlVYWZSREtzWEY4S3p2K3BxYmY0?= =?utf-8?B?UkV4UmVOc0U1VVJZemVnZ1RjOU1PNWxyd3hvM21QMWdndTA0SUMrZkNGQXox?= =?utf-8?B?c0JHVmpOT2xySVJtcFYzUnQvbTBpZXNiSDBGbTlLU0I5Smw0TUhpd1YxUEZk?= =?utf-8?B?eWtuRi9sak9yUGJYMU5KQUpza1BVakE0bWcrVExYQ2g0OSt6NkpPZUlOd3I2?= =?utf-8?B?bmUyMmJrOGhCa2lIZ3UybzliQzBhdUNBeFB1TitqT1NEc1BKVzlBczhFSC8v?= =?utf-8?B?bnE0K0ZaUUxiRlE1ZkxPa0FjL3FqZm5tOG5SMmxyYU0rL0hjYzFWTnRuVzV5?= =?utf-8?B?UFlqVFhQeENQTE12SkFrNW9ia1RSYnFySW84U0FWSTFveFNXaVAvUW5sRXdT?= =?utf-8?B?dm83MGFaRVY5U3ptc3pZR2hFY0dDc0RSa1VHT1FkY2lUWlUwdDNpVnNXUnQ0?= =?utf-8?B?ajNSZjdOMVU0RndRQloxN1BjRGxTQXB0c1RLTWZtb3RaWi9ZSUxJUXA2UjdG?= =?utf-8?B?Ri9RZWREZlk5a2RLSDRIZGh6YXdDYVJMZ0hQRHI0ZGNIdFdUQ292K2g2NUt6?= =?utf-8?B?TzdjMjB2K1RIdFk3ZE1zMGwxaGZwQzhpNVZ4bkJSb2VzaE81L1dUMmtpbDBZ?= =?utf-8?B?K1Y5cm5uVEFsY0xsa05pakVtajZsMVQ1dUhoV1ZGNm1ON0xsaG5xcWxTT3pp?= =?utf-8?B?V1Ztc2hJc0RxS3l1UDlEamlxUHdjblJYeVVJcU81UG5UK3BUK3RRT0hScTF5?= =?utf-8?B?d2dlYlNBTEtmR3Rxd0t0VFAvWlFnbmxxcjM2aXZtc3pkS1VSQ1p4SXlYZ1VO?= =?utf-8?B?S1ZONys1QW82MERVTDJVZEIyK2hISVdUUkF3UnMzcDBLV0d0RnhWcldGQmNh?= =?utf-8?B?UXdLcWZVU3U3Mm9wdU81Ujc2R0hLQ2daV21Fdkhwa2tVQ2J6bGRlRllUQUJv?= =?utf-8?B?eGhwOVg3Z1RqUzdJbjN3NDJEYVgzcFg1YmJmQVhwdDQ1Z3J1Q3JiNjI3eHN6?= =?utf-8?B?WkNCQnl1Ynl1WDhPc2ZlU3AwRWs5ZSs4SHZIN2pSUTdHSUpYTmY0U0NYREtu?= =?utf-8?B?dTVwWWJuYUhBc3poSEdEaXpFWGwvcHdFNHVIR1hNUHU1NGVzakNIRDZQQm1p?= =?utf-8?B?b3ZLUUt5akt1eFZFcHM5Y0dpWkMrdkZkbExXQmJjSlJYVitzM3Y4NDFLTzdr?= =?utf-8?B?azIwTDNhQ1U1Z2krNGxMWlM1cnhvYzYxUmpxODJFWnpDb3Jjb25ENnRxWHpz?= =?utf-8?B?OHkxNjdKWFh5WG1mSVFDd2FNWVVBK3AyeDhlRVBidjI0TUZiVlU1SXdDK3Iz?= =?utf-8?B?UldyeHZkWW8yL2k2c1doTWh0ZElXbDVGbGd0cU4zUXBuQ1RhdThhc2VVWGNX?= =?utf-8?B?TUFEN1hzMWlKSG5sNWRIUWtjaFpidk55M0FjMU5RQmQ3NmtGRTdQT3htbXBH?= =?utf-8?Q?uZVd/h04DYGoYnl1xRTWuAIZHyeeoJ8FzccaTkv?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e5568d0-2b0c-4bc1-b560-08dd6b86beea X-MS-Exchange-CrossTenant-AuthSource: DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2025 10:21:03.1226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0418 Subject: Re: [FFmpeg-devel] [PATCH] all: Replace assert by av_assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DUZSPRMB00050FE701ACB383534A8E6A8FA72@DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Michael Niedermayer: > On Sun, Mar 23, 2025 at 06:01:01PM +0100, Andreas Rheinhardt wrote: >> Patch attached. >> >> - Andreas > >> libavcodec/aacpsy.c | 7 ++++--- >> libavcodec/encode.c | 2 ++ >> libavcodec/h264_direct.c | 14 +++++++------- >> libavcodec/h264_refs.c | 20 +++++++++----------- >> libavcodec/h264_slice.c | 6 +++--- >> libavcodec/mips/mpegvideo_mmi.c | 3 ++- >> libavcodec/mpegvideo_enc.c | 7 ++++--- >> libavcodec/mpegvideoencdsp.c | 1 - >> libavcodec/sinewin_tablegen.h | 9 +++++++++ >> libavcodec/vdpau_mpeg12.c | 4 +++- >> libavcodec/vdpau_mpeg4.c | 6 ++++-- >> libavcodec/vdpau_vc1.c | 6 ++++-- >> libavcodec/vorbisenc.c | 14 ++++++-------- >> libavfilter/vf_tonemap_opencl.c | 4 ++++ >> libavformat/asfdec_f.c | 15 ++++++--------- >> libavutil/internal.h | 5 ----- >> 16 files changed, 67 insertions(+), 56 deletions(-) >> 4b05bc0165c919f3f4cfc4cee50ccd15a74cc4fe 0001-all-Replace-assert-by-av_assert.patch >> From a6481493a5a9acf0968798dd5afd72239acca11c Mon Sep 17 00:00:00 2001 >> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> >> Date: Sun, 23 Mar 2025 17:50:54 +0100 >> Subject: [PATCH] all: Replace assert by av_assert >> >> Also remove the assert.h inclusion from lavu/internal.h. > > breaks: > > ./ffmpeg -i ~/tickets/2254/ttvHD_vlc_sample.ts -an -vframes 5 -bitexact -f framecrc - > > Assertion h->cur_pic_ptr->reference != (1 << 2) failed at libavcodec/h264_slice.c:1451 > > I have more files hitting the same above > > > i also see a Assertion b8_stride == 2 failed at libavcodec/h264_direct.c:441 > in freh5.264.SIGABRT.9f5.65 Interesting. It shows that nobody (not even the fuzzers) actually defines DEBUG in order to stop disabling C asserts. I thought that these asserts were tested which would make converting them to av_assert easy. Honestly, I don't have time atm to dig into why exactly these asserts exist and (if they are actually still necessary or not just superseded) how to fix them. So this patch is put on hold. Anyway, thanks for testing. > i did not verify with bisect that this is from this patchset too The underlying issue is definitely not from this issue. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".