Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: sfan5 <sfan5@live.de>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 1/6] lavf/tls_mbedtls: handle more error codes for
Date: Tue, 4 Jun 2024 12:23:25 +0200
Message-ID: <DU0PR03MB95673E8D25ADC8B2EE385B28ECF82@DU0PR03MB9567.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <CAEu79SY=wy6g1FyJVARESxneHqvFJU5-pYqBtEZac9A=XOJ7nw@mail.gmail.com>

Am 03.06.24 um 22:08 schrieb Jan Ekström:
> On Wed, May 29, 2024 at 2:05 PM sfan5<sfan5@live.de>  wrote:
> Did an initial tired look at the set, and in general it looks alright
> and the wrapper still builds with Fedora's mbedtls 2.28.8.
>
> (Of course then it fails to link due to unchecked usage of
> `mbedtls_x509_crt_{init,free,parse_file}` in tls_mbedtls, as well as
> `mbedtls_mpi_copy` in rtmpdh. But this breakage is unrelated to this
> patch, as current master does exactly the same)
>
> I'd just probably move the MBEDTLS_ERR_X509_CERT_VERIFY_FAILED logging
> diff into the first commit that adds error codes (also probably
> "messages" in the commit message there?), as adding that error's
> logging really doesn't have anything to do with the verify=0 + TLS 1.3
> workaround.
>
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org  with subject "unsubscribe".

I will move that change to the first commit for v3 as discussed on IRC.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-06-04 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 11:01 sfan5
2024-06-03 20:08 ` Jan Ekström
2024-06-04 10:23   ` sfan5 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DU0PR03MB95673E8D25ADC8B2EE385B28ECF82@DU0PR03MB9567.eurprd03.prod.outlook.com \
    --to=sfan5@live.de \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git