From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 085114A119 for ; Thu, 21 Mar 2024 13:13:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2598D68D553; Thu, 21 Mar 2024 15:13:03 +0200 (EET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2074.outbound.protection.outlook.com [40.92.65.74]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DEFF68D4E8 for ; Thu, 21 Mar 2024 15:12:57 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IvCKKHRIKsl2Vg6Qb5xghghBNX+NFsoYcAxWRQvrBgORjv6c8lFAm3/2R+XFhOHoE1gntT3xacKS2UyGS24BxsB8V9vjjEGYGPcRWqAPPhQsWOfW6Wi0TEOxRgya9lKDRErFlUDI1S5//QLDtBj+pBQ9kz4JHTn1+ikZUTtlbWqXzAn/RFUuzFL/GcSXa7FQA3BRCU4JqlewEgbyZ3kZ781s1Pa+T8MrwKSzKWi3nSwUASZwQ9m21RE3NokBof9aX3giaQfbG7zQYttHl0jSKQ3lDoLUjw8U/mZSciEBGn82rSvL4xw07vexFM5Qjfb3FTYWqySkbzq7XWDsqMitnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SyJMV5oimrwXuBc1oaNdGSJHttL1qEYb2S5NN0U1/1I=; b=SL+L1wH6ToRtg08NHwnQXlCV20HUXhmLLJHRcqKf1q36+8Uf/TYm5NfFd0pHY2mWlj9gOIKFfmF52SCql7u/MKh0vlJO8XoVITe8O4l3QivJjsPVFXxh0Vw1RWMWMADGx1tck8gAyJcA/BG5Df3EKIGdizJRKPjlpVwb1OQWrAQ58q6KgQgbfEKb6c25Xh5mqDn24o8eSRwsodHsw3w3KVpJBMTWw2xrug9GNpL3JSpPqJAbUxp4zTPJIgUBA9rf/f5og8tlwB2CYHPZDKIq2XGYV1T/HjlGwRUTulh1KTa2WxfDONJy3gSYs4EGvHDlirxfHbUEkSVRTf0hFKSxHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SyJMV5oimrwXuBc1oaNdGSJHttL1qEYb2S5NN0U1/1I=; b=UL9eIRLIP/lT5+W/RmYJEv/TFVn5NbVgMpBqZZGm8bCFiB1N3Tcrw5nwvrGnm49XlhqivqmZvBH3wi/IQzekrhHoFqlI3y9ycNrtiJCfZPZQebWC3TnDD5s24esHB3VrCyIELGExRguGsovdNAFVYYrOaD1aEBbRbUzdBQ+8MHMqORxCvxEE6iV9gzzA/4kcC6AnsnsPW5UFJ/zyyj1T/l4IseE2SR4Z4LM2E5Cxx6836bmivNKmC9WWIGPYFFwiK6Sct/tL8CRmXJUv+JUVbwiwfdlS9SYnpCMrHoptzD2E1aGFHANZrfpdhhydIY5UQ0yXP9sA01LhzNre2TsCXw== Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) by PR3P250MB0227.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.30; Thu, 21 Mar 2024 13:12:50 +0000 Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::8230:ffad:27e5:20bf]) by DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::8230:ffad:27e5:20bf%3]) with mapi id 15.20.7362.035; Thu, 21 Mar 2024 13:12:50 +0000 Message-ID: Date: Thu, 21 Mar 2024 14:12:48 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [1NZxBELuEOrBU7PZIB9Z+SfMlQ9rUmU7t8N2Hpo5S3Q=] X-ClientProxiedBy: ZR2P278CA0015.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::19) To DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) X-Microsoft-Original-Message-ID: <866d8f8b-36cc-4133-a0bf-483e400adcba@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0P250MB0747:EE_|PR3P250MB0227:EE_ X-MS-Office365-Filtering-Correlation-Id: 93632085-2c20-40c8-c557-08dc49a89bec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yDUgPiSYpZnORFsBj1xEwm8zDB9MDcLs4DLcAvH/NsvuJ6MLozJztFT1HGEGHPGhOPgtoJYij0F6DH+KEmQHV0d72n+2zAt62xxGIo5XEAdHW0zxK7/zy5fZ1GfMI7P4yDyyOmBTUeYIvzOrqRof1gThSP8IlrtGf3d5u7Lg+sSVDgFwtrEIVhih6gw5MV8+fxbZ8xt5GZB93622yYwtDTrb5CO/LonkxLErla9L1x3nIIDRoDMYEDvcg73z7ZXMW7O99Cfy2c++Uuh9kg+3UYCGuK1tyn0pNJazLMG4dDZHMkooYXqF0Ezu8WXuPULtx1jyqJjkZbujv4HVMGcDWgrV7ktgM9dinCEtlzTSohNtHSFuSzoAH9Hv1rTf1iUClF5yetPqazdQ6qeI+YawBGht3/PQMn4TlXI7Ah1DJMhK4spwUJjHLbGYENQIFA4yFrjqUXhNIdeHuEh7ynuONtXIhqUgkXemuG16uGfuGFD3Hd1TH1Bkv07LJM+T3aiapcaITnxyOhCFiHDbFocwUKgXsT0RlkxNpCrBDXGGhYLTq0EAotEgPR0E0sclnecK X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amRsM2ZvNmdiSVhWUHBVOGFka0k1bmtRTXpRYjJ4QmxwL0xMNC9wN09qbDlE?= =?utf-8?B?RnJVS0Zndm91dk1vcG82emx0MnNzQTUzZzA0MlhsQTd1RTlaOFNmU2NLUGxK?= =?utf-8?B?SWdzczJTWlE2RzZOOWxOQUx3RXgwZnl4cjAyendFYThyUENsWkNSdnVHZ0ZG?= =?utf-8?B?ZldJUkt0K1NSYXhKQ0lWRWx0MVFoWUNjN0s5cCtEb0RHVFdEcjNYcXEvTEFW?= =?utf-8?B?TjFyQkdxazlyUXYyL2QzWXpqKzhiWFVFbTgzdkM4REUveERqNkY0WS9hdU95?= =?utf-8?B?T3BkamdwUFVURzNqSjMwTFlQMURCbjQwT3F2MUpHcXpGYjJ0TmV0b2p0b3Jt?= =?utf-8?B?ZkRZSFBMa2R3SFBwYWpyUXh4WUNidGZrM3RRbVZoTVRZbkMyVzZ4YjUvZExI?= =?utf-8?B?SUwzNEx1RGVyS1ZsRzhzbjNSZjlvRFBELzJxNDFRalhxdU8zV20raVFPaW1u?= =?utf-8?B?a2pKbmtsRnlCby9wd2xyK1RiRlk0bzFJS2lTclVQY3BIV0h6Rm9GaHVvQ3dI?= =?utf-8?B?Zis5WU9IeE9FaE1XTU9VUUNQNFBoaUo1ZXI2NnJmRkVlNW1ybnhmSElsZ2Na?= =?utf-8?B?YjNORlRENEtXMGlTNENhOVdsWGtJK3RGYUIxc3NNb0lDUGdPV2FQbWhTckF6?= =?utf-8?B?YXYwdWQ5SjV3WE5wSFlETTJvTEIzbmtUOU5BNEJYNTlyMlAxWWdTSmljREJM?= =?utf-8?B?NnNnMjFKV2puQmxpR2xta1pXQ0FXRVhaYjc1dGMvQjZheGRSMWk1QTl0S0NC?= =?utf-8?B?aFJjazA0MGlwU1BaZC8vQ0NoODA3VmlOSmh4TVFPQkhudndpS0FudTdVdXhy?= =?utf-8?B?ZzFnZ1grZmhpUTZ4bWppcStjVy9US2tzaW1mMnlmbUhVR0VuV0EyWDI5WUZx?= =?utf-8?B?a1BseHVGc1dhQmNqUGE0MVIyUGlNQkRmRXNoNGpEb0U5bEZUdzI2eFJHM3cx?= =?utf-8?B?TTNjQ0Nmb1V4bllxL0tQdy9LZzk4TXBJSlhBVERla0JZRm1QekxqZkdYK3JD?= =?utf-8?B?a2dJM2J0M09NS1YzR1NLTHMyRzl2ZnljRWpZbk1uWXYycjdvdXZaQTl5OEtE?= =?utf-8?B?WmZ3eWpIcUxoeWV2MjllY0R4bFdsUGNNU0RXejVRVVlCT2h2ak12Ykt6bFVn?= =?utf-8?B?R1I3T1BhVUNlQXUwbVBaRzd0VUpKbnVZZmdXR2lCekFmdmVOSlczZDlsZXg1?= =?utf-8?B?TmlGNmFIdzhVQ25tUG9vdzVDeWl3TjFYTXR0Q3pwUDFRSFlNMHZvRTVRTzc3?= =?utf-8?B?V1p0WWlhb2I1M1F6azhQbXRGU2dKMFQwSXlRQWVjb0RQcnVURTdEMDhUV2tF?= =?utf-8?B?M05nK0tVR3IxWTRMclNkblVvMEQ5NHhlamtKVkZEeDhacUFuSlByVExyK0pV?= =?utf-8?B?WldsU1pWWFJNYkVWcmJLOUxHcHhLaktXTzdwN25YTWZQUzdnbHhFRjRjNmJk?= =?utf-8?B?a1M2eEdyOURhNjltKy9zM1YyZWd5WWtlV3BpQzYxNkdzNDNQWDVyci9sZTBm?= =?utf-8?B?b29EdjJCMHVNNDFGT0YweW5xd3pYQUJ3dk83aFJqYisxSldUNmR4ZUp1dXli?= =?utf-8?B?dk1hcVlGNWEzMExxT3VFNnI2MjlqN3ExcG45MVJPenAzVXVzMUZ5dzAyRm4y?= =?utf-8?B?NWQ0bjBWRDBLb3U2Rld6SFp3QkRQLzRCTll2eXQ0Y0FPY1FuNk5HZzRrTlpE?= =?utf-8?B?SFJRUWR4OW9taG91WlhIVmYwdXNwS293RWNYM0hXeE9KN2xYQVltdEtnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93632085-2c20-40c8-c557-08dc49a89bec X-MS-Exchange-CrossTenant-AuthSource: DU0P250MB0747.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 13:12:50.1734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0227 Subject: Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > When the compiler chooses to inline put_amf_string(pb, ""), > the avio_write(pb, "", 0) can be avoided. Happens with > Clang-17 with -O1 and higher and GCC 13 with -O2 and higher > here. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/flvenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index 7e410e627e..d6c9124d5d 100644 > --- a/libavformat/flvenc.c > +++ b/libavformat/flvenc.c > @@ -231,6 +231,8 @@ static void put_amf_string(AVIOContext *pb, const char *str) > { > size_t len = strlen(str); > avio_wb16(pb, len); > + if (av_builtin_constant_p(len == 0) && len == 0) > + return; > avio_write(pb, str, len); > } > Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".