Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0)

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> When the compiler chooses to inline put_amf_string(pb, ""),
> the avio_write(pb, "", 0) can be avoided. Happens with
> Clang-17 with -O1 and higher and GCC 13 with -O2 and higher
> here.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/flvenc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
> index 7e410e627e..d6c9124d5d 100644
> --- a/libavformat/flvenc.c
> +++ b/libavformat/flvenc.c
> @@ -231,6 +231,8 @@ static void put_amf_string(AVIOContext *pb, const char *str)
>  {
>      size_t len = strlen(str);
>      avio_wb16(pb, len);
> +    if (av_builtin_constant_p(len == 0) && len == 0)
> +        return;
>      avio_write(pb, str, len);
>  }
>  

Will apply this patch tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".