From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7AE9048111 for ; Wed, 10 Jan 2024 02:28:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B210F68CD84; Wed, 10 Jan 2024 04:28:44 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2023.outbound.protection.outlook.com [40.92.59.23]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1ED5B68CBAD for ; Wed, 10 Jan 2024 04:28:38 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BS8eWYL6TF+rN4fusrkuFgiLBEBiswULfvZ6PrU6aJV5hMnZBxakYzSj3udAUvXEQEme/0ADUdcyUQlZOCiLf/6JwTIDPfOG6DuFdi1Lxkaym1YzaN34cXK7Br/pn2HoBkO9L3SMAsLDyi8tXyAfoDQQFHSs25DLG2nQJtkXt6RPwhbR5qtXEGg3XPVKpQjA35xaMVp5Gb8FujmADlbF1W8f/JVkt+0vO4gBCBIfVYrxzdcHn+gwrA7xP5tjT18/RlP6qBV/I0WBdSEaXUItwq6M9MdPo2sckxrgb18FKCXt7bZ75CjK4U1aLx5w+/UgM3lElyuENTDZl5E0YJv7fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yO6oPtQy7O5YNqHooORUeVX710eHOKSU5NDaEuvfqWY=; b=K6CUV0oVajovEXnuR8iXis+lpkH6+IM+Ixj/NVpeUpED+vwJI92XzA6diXZfB5jWGkfX3xRB5Ca/A2LGevAvTc+sPO7TSh+6VfkmVDPiBZTjJf4s7p0UzRVAqdby80098aR/EdP3FcPv7PEWtsAmGbG6PkXO0mK1KyNcDOnojkCIN+dXgw7GwGmV8s15ipCodPa1wqkX+WrJtKPYNKtdY9QXcO0GFCGzyZSuxGOYFF3DTYC80nvOHVEivogTaKWJCmsF+x1SpEsurkZ5IouStl0WyG7oIYiAcRKD57LXnDsD76HVYvkBnCK3LbQXu2std9XowzM0F7McEdaYlqe1Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yO6oPtQy7O5YNqHooORUeVX710eHOKSU5NDaEuvfqWY=; b=jKZV9tWSeuKdtNkSZrPAU/L4HBDeXonD1GJ5WlNDt1AiP2WFi7+5ywLe+IDVAUqBLR8xGOtlxLy/QBPvIB5MnpgaX8+702aJa7LeO96UMC7n7mWl14ZgF8k6eRQQm83wl6dfWLWCksBeCTxJan4DBSq7aDOxcbSVXZrKWPT6DPBADUy6u+5vql1TMurFYihlTkKDsE0kJ7NG/y5bjCs5Tde9Ach9P6AQ2V3ajNum6dh3TqFaAU1z3ubIkD/ZVl5YVYr85F2VPkADvFn2jTQ9ctsR+WqFBO4ZM0SZw2M+HYbONpecKzOuuIOWFoat6NQMuEN6wldhDuNSPFpUnurgbQ== Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) by AS8P250MB0039.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:35a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 02:28:36 +0000 Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::db07:87f6:7c75:38cc]) by DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::db07:87f6:7c75:38cc%3]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 02:28:36 +0000 Message-ID: Date: Wed, 10 Jan 2024 03:30:10 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240109221741.60485-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240109221741.60485-1-jamrial@gmail.com> X-TMN: [90yMi/puBJJnTRCChDAsDaA2TONLvCMeesT9ZjfMFDU=] X-ClientProxiedBy: ZR0P278CA0189.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::6) To DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0P250MB0747:EE_|AS8P250MB0039:EE_ X-MS-Office365-Filtering-Correlation-Id: fbff7fa4-7564-4129-433b-08dc1183d912 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kh5lxbHoGTaJW5QMNpIDZHrMvSSlTvRj0v8QS9iQJR8MWBcBjQYr7uMnHOjEVP36miOxc9gC77kIXp6LjpXZrz3tavByDu07RQkPUaONw6WqvkUKAlWMTvQg2A/28Kmu5uWQXu3sbPGof2DtmOl0NbwSk4XqH5jqk6qebCcddeyIMs/fQaoi/8NTzjEjOfd32qOUz9ScYM2VjsA3z9KzfG/pi6xWqzoHx2XsueuTaFp1srmvhkOdvQHcMm6tqnoVJjrKJzKlXlQsD27u+x1d8AuJ/sG0mPQwAUosKKfedC7wN/nbu1KnwNeYuVcvpsa5Q0l8s8OnZEwRcDWf5uBE5Pq2IY3+So4wp1jzsUf6P8mEBv1otCYsUkpoeb6/T8GqfH0GMcoDdtqOxSp9u3RKbh6un5QeYWuKMq7qk+WSTGX56Dh5O2wuFQZv8zV83byEDZ8/SDHQg4WvK3VEHVV0zHryTqd+zpEhJZUOJ3DaHi3AF7y2bKGeBa9acBpG2hOnc7+khVqMq9KdtRBx45khqk2fy/SE+lV6/zOxS5efuxKDGI3/x+5MWazo1c4hcxPj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z09lbmVpa2lvYnpabUxFNDR4UysyVUd4b1E2RnM4WnRQK2FlUTdjQVZOSTJh?= =?utf-8?B?akVvNFBIOGNKREt6b0FXNDdodGI3L0FVU25HVStwL0crRnRiUDZBK0tyVWln?= =?utf-8?B?dytkMEViZG5JNGhxOGtSd1ZkMGRRQThxZzFqR0EyaDRHRGszUHY4ZjVyZEZF?= =?utf-8?B?NnhPRmRHQW1UcEJLckZTbjJVVlp5R2FnOENNeXB0ZlorRldJYUY0YnNXa2dx?= =?utf-8?B?a3F6Njl4b3M5cERxT1FPQjErdFhvc29xTVdUVVVGQ2plZGN6UDFOb0ZwbFpq?= =?utf-8?B?YUtsODVqVC8xVzRDSkhqY25sOEFXN2MxcWkrc0VsbTBOUGhWVXRXb3BDOG9z?= =?utf-8?B?dkxrYkhJOUtWM0tHcE95a25wdXlwWGFGb2wrdm44aE5EYXJQc1pEMEg5czdw?= =?utf-8?B?VEc3c1BpQndRb0R4MEVJd20wTXJRaUlSQ1FzNVJha2JvK3ZyUzNzSjRvR1Bx?= =?utf-8?B?Mk41OWFLeG9VYnN4aG5uazBENE9RQzlUKzd5a0NVNWtzVWphZmg4V3gvTWFr?= =?utf-8?B?VDNzMWJNcDR4QTJObXllL1cyQTZMWFZkdkkvUmdkMXNGTmFodjdwclNKMVFp?= =?utf-8?B?d1FvdzJ5Szg3QXIxYXBaUkhLRmhLQVB1UEdRRncxTnEyZ0xxSjYxZDI1bWpu?= =?utf-8?B?QTFUZjlpbDl4N29vUnpWWXlBTm5pZjNMdXROdGdXcnU1SmNJZytmSFJUanFp?= =?utf-8?B?MFB2K3JyUWlZWHZPVXJWSC9QWU5jUnlsbVFXZTkxSU5WWHFpKzJ2cXMxREVR?= =?utf-8?B?OXFFaWpJTDZrSTl3SEpXRCtpM1JQQ29vbTRCVFJXTmhxa0lxU0JQYmcwMkZl?= =?utf-8?B?R1o0OXdXTkpMRnJlZm1EZm9Pc0h4SFVqUFpLTkk5N2NwTGdXMGJzQU5QMEpW?= =?utf-8?B?dytIdk8vME1FMjRacWFqb0Z2SlprdU90ZGdXaUxyU0lEcmhKTWJXRWsyZHBR?= =?utf-8?B?TWRDazFkSzhvUGFiUEpZcXlycEdsYldqQitHYitYdGdINHRURkVIRGVUclh3?= =?utf-8?B?VWl5QkV6SXlHVHJiZHFOYjg0b3QvYWovWlhTQTkvUDk4VmRadEl2aWhqeVNx?= =?utf-8?B?MVhSU2cyK3EwS1FXVWdNS1lOaGpIdVQ0T01oNHIrcjVob3VHOGhpcUxZa3ZK?= =?utf-8?B?V1UxSTdhdlF2c2t1R0tMeWlBTFRmK1BSQjhnVFBSQVlzd0syNlY2b2Y2RGRz?= =?utf-8?B?czR6UFI4M2FEVGlyelZQV21sU1U1TkZnTjE3YWh3S21RalZPQ01LNy9ZVUow?= =?utf-8?B?TTA4Q1l6QkhCaWZwOTZSeXBheU9LUkI2aGF2V28vMTdVa1c5SkxtT2l2cy8y?= =?utf-8?B?ajl3WnV4MmVONUNoOWE1MFZBUjRiL21mcmNSU3BVZ0Y4emdnUElrQ25TMzhE?= =?utf-8?B?M0FkVUtoSXh4WS9QTnNERVlvMlRoby9oVVkxOUpwOS96eGloV1dyTWI5U1NJ?= =?utf-8?B?SXZMeERQd0QzZ2MrOTNuQUt3czhnRy9XbFRIVjZYMVFTaGNJczRCODVibHpj?= =?utf-8?B?VFVoK25kTW5JZ2kvWCtEOUhTdkNSR2pXV2NWTU96TDlVSjVoeEJaTGVqVmJN?= =?utf-8?B?RytjRzI5MVVwWDZERmtsYUpmd1dtMkUrQUg2N0xjVVJhNXZWZFlpSFZXZWpa?= =?utf-8?B?VFVpZUt4cVhmd0dyVUI1NzdlQ29JUDE2NzdaZ2xKUjdQMWllVFBHTG04SHVk?= =?utf-8?Q?IewsCb5AhTeSq68Hy/d/?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbff7fa4-7564-4129-433b-08dc1183d912 X-MS-Exchange-CrossTenant-AuthSource: DU0P250MB0747.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 02:28:36.3944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0039 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: attempt to set SAR even if no hardware decoding is available X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Should fix fate failures in avif tests when no external decoder is > available. > > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index da05a0f039..43b5aef687 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -1227,7 +1227,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) > av_log(avctx, AV_LOG_ERROR, > "Failed to get pixel format.\n"); > s->raw_seq = NULL; > - goto end; > + continue; > } > } > > @@ -1248,6 +1248,16 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) > case AV1_OBU_FRAME: > case AV1_OBU_FRAME_HEADER: > if (!s->raw_seq) { > + // Attempt to set dimensions in all cases > + if (s->pix_fmt == AV_PIX_FMT_NONE) { > + ret = update_context_with_frame_header(avctx, &obu->obu.frame.header); > + if (ret < 0) { > + av_log(avctx, AV_LOG_ERROR, "Failed to update context with frame header\n"); > + return ret; > + } > + ret = AVERROR(ENOSYS); > + goto end; > + } > av_log(avctx, AV_LOG_ERROR, "Missing Sequence Header.\n"); > ret = AVERROR_INVALIDDATA; > goto end; You should instead implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM for this decoder so that one does not get a wall of error logs when probing without proper hardware. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".