From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C3044728D for ; Sun, 3 Sep 2023 11:41:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8CC4D68C60E; Sun, 3 Sep 2023 14:41:19 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2022.outbound.protection.outlook.com [40.92.73.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F16E868C45C for ; Sun, 3 Sep 2023 14:41:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9+0gtpkFWFzf0WbF4hdt4DIQvV8LvT+6gYR+Y53oKu3nr7EV+lzB4N7cZ6alx6a4r1XSsnH429f8uGr7Xpd6P+gEAKF+QUa14t2ZPtr0THvgGew/9ndy1cxd9agKeKIwhjSt96MeT6+vHqNpTCv13LWSJVAktGAZtsCHLitYWPJAyfGuUq4wo5j1XZOAwuEP/8Lmn8dFW4GTd1iaPM8jhob9/wh6gG5V0dyFJMSvk6/ETzm0i/6NxF2gqO8XrjPYtqtGcQDak+okdOBcC2Mdeb9j5GxVcBFR1douF02k+rlB11xswpFn6/I1KefRQLlGts9B2nSQA9sgKnJEAYcAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yRW2aFfXG8hHTnaevj1tzFg9ExYS8//2rPExwmi7BK4=; b=U2FvCsOKrVS0BOQWcNJVue8expohbOWqchykPr39cjjrRih02W/37GsppOHJ0pPXNAF3lLigGj3aVduz+Ry3STOUmJGplEkdDchb68GLA1zi1VJNsEh4yBKpRbfJoMRs4amUwnxJJSE8IWIqC+n4g+1aENAGJW59v0SsQbThOmawiAoqshraNFAdZsYdRuKmtNFtYWKRjod6/bUO9ux/1PJ69TmnDZxtk5T4SooDHUZsx0Xn97Q6qmkYSsEvAk1sBl4SSjKNd8XMNPX7fIRkPlgMuCM0Sn9iRHlPJEyXVDR8rgGGzJkNL0gwQ/HNKonVJ74hQHoSGg39nNT1hwX7uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRW2aFfXG8hHTnaevj1tzFg9ExYS8//2rPExwmi7BK4=; b=kKVEObRVd5je7ET5xkor5u5cz8KaxrEs4Rh1B/cL3tqiDzDZPqeR/7Rhq/GDaqU5YpFVaIgU85tj6pZcUojOzo5M5UU9do9LiSTE8+YyFCs3wd3D1NfmPGlWr5OfykKjTfE7TqxUQ4ulzwhX9HmqkEP4vPeMf6JL7pG1ysnMO1OhYwYpcrZaP1d11H6dyGZGMaGW6BfvNxh0e7e0xOO6Xni+SNzDjtGDZNbow1rWMAAaLhzKRpO1i//CRglLeKJGd5NsVntLrXYOG94eXUHAgU1fBaltuFrtf8PIK19qJmeIcW0wBJakNkZWkbnV5LRN2JCOOswK6A7aZfX3BgtVrg== Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) by PR3P250MB0340.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Sun, 3 Sep 2023 11:41:12 +0000 Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::e8dd:7fe1:2348:cd62]) by DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::e8dd:7fe1:2348:cd62%7]) with mapi id 15.20.6699.034; Sun, 3 Sep 2023 11:41:12 +0000 Message-ID: Date: Sun, 3 Sep 2023 13:42:29 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [FUbWD0O99FAIZvKgOHR6JaZsENx/15xtNG7OWGtSX6k=] X-ClientProxiedBy: FR3P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::9) To DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0P250MB0747:EE_|PR3P250MB0340:EE_ X-MS-Office365-Filtering-Correlation-Id: 08d630d3-5e1c-4499-46dc-08dbac72ac57 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ooZPpXy59vhptcvbBXbgZMRtQ5Rb7cWZK7i38vmaqy8QbpVTWIwTpICQduTGWgTZ25DiS1r4qDvOYqf8FK3qjfvdAZgSEoWHLLpnHAJbPao9zcaBkrm6F6XTvVmyjR7W7VAuQy12avzHrf//ezbKSTovQmGOBKrfTPu/QdlqXXUdC0H+MQYNvhe52UqdLE4pbzsGfIAOQi60DtYAsCUuVzlfLFLS6dKM+keuaG84QHR0L22RzSj1cAog9HDw/yfyqjPSfxgghLnmWcTqwPKopHciKCv8HRAre9ID9ljE8Lz/XDwdJeAmsR8hjO01UoxPGTt2knB2b8wsUn5a1Ah1ymttDWa9jFyiM/JpFkRrxI6jItFc2MiEYk5dJW7rOPN46ebu9ho9jsgXDZfixVVO81jP246oIqh42dGbvEzJmb6IjmF2o+YHwvT1HpbOPEHtojWJMnm1EdEgJ/512vwvH4bfLqpIT19UdA52fn8+B21zhVh/duwyA3XjNZXVIYP8mlddg5Lbi+lAuGcdUBk9A1RtMaVq2o72N6UlSBnfzh/NfSEAIJ6ikDUl4EyBrNo0 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1RLNzFDVXhqY2V3RTlka1lmRTlYVS9iSlo2dUxybi9CYk9HQnJYOE1LemZy?= =?utf-8?B?dzUycnVQUmh0amEyUjJjcG15VTNiRVFNVmFXcldCSVVDZ1RMMlFTVmRtTkow?= =?utf-8?B?U0Zyc3lXck1YMVNmMWFJTk9tbTBqamhmdzRnYi83aDBtbUxWeVo4aEkyUGlh?= =?utf-8?B?T0t4SUt3OThnSmdpYnZqVGZiVDVKN3haelZLV0liQjU2YlBEMWY5TFNpeUlv?= =?utf-8?B?U3Fra0YxZGhBcWsrUDgxdXNleXl2aXpXOGN1dWZ0cUNtVS82WHJQaUovTjBl?= =?utf-8?B?VlUvdTFSaXJWZ0d3bWlkT2ZIRGFBS1BsczkwQ1o2dWR4UzE2NHU5citqdkw0?= =?utf-8?B?REo4TmQ3Y09INXU3MFJnRlJuOTdqd2JkcXVzdWZBRElrN1dyd3FlMWxUNkFS?= =?utf-8?B?MHJsQUw2UFVudlQrYjNWNGtRSHAwanhmeVpwMkkvZXcrVHdRRytKS0dsV3dy?= =?utf-8?B?QWVibUYyendWZld1dkM0ZWFZVU8xdi8xNStEc1BtYWJWR05KdUc5OGhBaWhZ?= =?utf-8?B?UGNOSk5ZQm52aVhRNy9HSmV1YlNBNXNBd3lCazlnZ3loc2hQUVFuditQZ3o1?= =?utf-8?B?NXNHYm9QWThBbXV1MllHQkVWUSszalEvVDl5WjdxaDExRnZVcjVzc0h5cTcx?= =?utf-8?B?RmVDRkszbEREcGt2YWhGOGt5cjdmK01tVmJnUXc3Snpjams5OTJRMURPSzQ0?= =?utf-8?B?cWtkVlhPTmtEQVdncGwxS0czUlVObndPVXU3UWZsdkNLRVl1SXVheVBTd2s4?= =?utf-8?B?bS9qRlRyUGpCdCtRN3lZZFFsZUoxNmxGSlZuTlVMSHE5dTRqSDA0aDArNUps?= =?utf-8?B?aUFsejdHallxWVd3dndyYUVjQU9QUGNrNlJBdWZnYzdlS3FRUUJjblgyVnVJ?= =?utf-8?B?NmNtS1ZlOFY0cG15RHp5dTM5Z2V1d2FLbk1OL3FRcmJoMVhMUXRvcGJWYmpW?= =?utf-8?B?RU5vU1BWWFpjK3loUnAwejc1WTRHNDlkTm8yZm5VeFphd3g5ZlJjSUM2UFNP?= =?utf-8?B?dHFXM0VXM1FYTkVoK1FuOUN3bDZGbkxqQ3lhOCtkZmRxMjY1M1BKeTRpaU5X?= =?utf-8?B?cndnNm5rWERsNUcyenZuUjkzbitmSFJPSEFBRnhGeHc2OHdxVDFFc0k2MXFo?= =?utf-8?B?NEszTWtzZno2Y3Y2bFlGSkhUWUh1THoyUXJrMXVrbXFtM2NLS0l3OUVLbjZY?= =?utf-8?B?ZUFEQm14cU8yQXYwQzl2YUpqb2V3U2RVV2FibDF4Uk1lMjVwc0x2T0xaTkFx?= =?utf-8?B?WDZ2UFM1MzZyeVBCNkdzOXdXYkpoZ3JXdTJkTXFxcjJjV3B5RE1WYlJFZjg3?= =?utf-8?B?WFE1VTBReTZieVAxYzkzM2tmbXJIWUxLVmxFK3JSRFp5aHozYUNGZm9YcWFM?= =?utf-8?B?MUJVUXYzbFVLYmdobmI0WllrTFp5c0Q1cjlwZGViZ3cveFMrK1VzOTZHVzJO?= =?utf-8?B?cVVDUXN3clNDNFc2cm1vcjVuNWF2RFFab0E4L3NTdGRvVkNHNW5HQ3ArZkxu?= =?utf-8?B?ZXVsZ2h3TmVTd3k1MDhJY2NqK3JrMjV4MGh3a2lQQ0JQVkNqRi9UbmgvcGty?= =?utf-8?B?c0hqM1c2YSs5ekNJL05QMWRsSnhuc1B2cXQvcTdidSs5d0ZNbURKeGgrVTc1?= =?utf-8?B?cEczVWF5cm8vVGFobDFzNzlmekNVZHJDcjN6alBSOVlKWXdSSTZCcmVJK0hi?= =?utf-8?Q?CrD7UbjIswAHTLN1olJN?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d630d3-5e1c-4499-46dc-08dbac72ac57 X-MS-Exchange-CrossTenant-AuthSource: DU0P250MB0747.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2023 11:41:12.3258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0340 Subject: Re: [FFmpeg-devel] [PATCH 01/13] avfilter: Remove unnecessary emms_c for ff_scene_sad_get_fn X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > ff_scene_sad_get_fn() does not return functions that use > MMX at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/f_select.c | 1 - > libavfilter/vf_framerate.c | 1 - > libavfilter/vf_freezedetect.c | 1 - > libavfilter/vf_minterpolate.c | 1 - > libavfilter/vf_scdet.c | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c > index 49fcdc31ff..c9e216f51c 100644 > --- a/libavfilter/f_select.c > +++ b/libavfilter/f_select.c > @@ -294,7 +294,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *frame) > count += select->width[plane] * select->height[plane]; > } > > - emms_c(); > mafd = (double)sad / count / (1ULL << (select->bitdepth - 8)); > diff = fabs(mafd - select->prev_mafd); > ret = av_clipf(FFMIN(mafd, diff) / 100., 0, 1); > diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c > index 6ef5dca27a..6d448be74c 100644 > --- a/libavfilter/vf_framerate.c > +++ b/libavfilter/vf_framerate.c > @@ -76,7 +76,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *crnt, AVFrame *next > > ff_dlog(ctx, "get_scene_score() process\n"); > s->sad(crnt->data[0], crnt->linesize[0], next->data[0], next->linesize[0], crnt->width, crnt->height, &sad); > - emms_c(); > mafd = (double)sad * 100.0 / (crnt->width * crnt->height) / (1 << s->bitdepth); > diff = fabs(mafd - s->prev_mafd); > ret = av_clipf(FFMIN(mafd, diff), 0, 100.0); > diff --git a/libavfilter/vf_freezedetect.c b/libavfilter/vf_freezedetect.c > index fb4e59b127..18d392d9ae 100644 > --- a/libavfilter/vf_freezedetect.c > +++ b/libavfilter/vf_freezedetect.c > @@ -131,7 +131,6 @@ static int is_frozen(FreezeDetectContext *s, AVFrame *reference, AVFrame *frame) > count += s->width[plane] * s->height[plane]; > } > } > - emms_c(); > mafd = (double)sad / count / (1ULL << s->bitdepth); > return (mafd <= s->noise); > } > diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c > index 610ac6b1bb..9920210ece 100644 > --- a/libavfilter/vf_minterpolate.c > +++ b/libavfilter/vf_minterpolate.c > @@ -825,7 +825,6 @@ static int detect_scene_change(AVFilterContext *ctx) > double ret = 0, mafd, diff; > uint64_t sad; > mi_ctx->sad(p1, linesize1, p2, linesize2, input->w, input->h, &sad); > - emms_c(); > mafd = (double) sad * 100.0 / (input->h * input->w) / (1 << mi_ctx->bitdepth); > diff = fabs(mafd - mi_ctx->prev_mafd); > ret = av_clipf(FFMIN(mafd, diff), 0, 100.0); > diff --git a/libavfilter/vf_scdet.c b/libavfilter/vf_scdet.c > index 6de84a43a0..15399cfebf 100644 > --- a/libavfilter/vf_scdet.c > +++ b/libavfilter/vf_scdet.c > @@ -126,7 +126,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *frame) > count += s->width[plane] * s->height[plane]; > } > > - emms_c(); > mafd = (double)sad * 100. / count / (1ULL << s->bitdepth); > diff = fabs(mafd - s->prev_mafd); > ret = av_clipf(FFMIN(mafd, diff), 0, 100.); Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".