From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D3D848A0F for ; Sat, 22 Jun 2024 13:21:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CD9DD68D4BA; Sat, 22 Jun 2024 16:21:02 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2012.outbound.protection.outlook.com [40.92.66.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DF95C68D403 for ; Sat, 22 Jun 2024 16:20:56 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYzWcJav5kDL849FojaZRaWz06EDltAC4D9joTN0uWLtzBDFftC/jea1KMuUwxA6RZw0tF8Xgg17cQyHSoT9KxX4RL0y2Kb1IE3AzWgg3SDLTdGjdSXvGIyhWFnwSXyjkaro1xLAhMLd9qMmQP9+buWLTALl9cl2PFtMscDjwFcK2KxyjUCGsVrhokuT6TzmhpwW4Y5hV+UAE0v7EE2gzyQY5hNMxWY0+7u0OTwC24PN3dK7kwBs5RUJzxGvIcLqp6pSGOSsCcl6yWO05NwZmGn2oE4IHyKsstDWU0hC4Cst4CkY7xocLxACvIhJ00CFh0JD0ad1hme3rYdzzDlnZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=icpaEDCiZn3g2mVXux2JSywijkn2ctSL/8HQF/m1OgM=; b=aTpaEREA+g7BKP5gkQ2EnMfNEms1CMFQ7CSgXbWXmobB+5W+TAz+joIkkgl6sc2aSh5iHiYPjI0tDyapsfHic/CQEzikyATyk4l+uumWQaw/AY1w8ybUe1+k5W3BfpfFZDF/q9GNRd79VWTyB8DY0RjNwjieEbdDS8uunGAbZrIcj4z/GPAZQpyPWy4ozArIty8itMnKPhblHooos3IMNsGjGTJjsRjAW3hTVIfLvIDjgjDDVONFevtYyOvPERM7rktwzuyARTNKPCgo2ShdvRBMBlOqbyEItJd8Mz/hg5Eu+BxSeU8PJ2MET06367IgOBMHRASETgjZQtDvxYyZmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=icpaEDCiZn3g2mVXux2JSywijkn2ctSL/8HQF/m1OgM=; b=FI/6MHjKzSxyZn8kCHIHNkkTRrYCsY5Wpw0CdT9PGx1dEZ47tGI73HHn9v0CAD3eqJOVU+j67wbCHOG4N6vhstWNErwETHn5ZYLhqbi2COl5tLBc0zPBpXsecD+bi14MtnjQnjVcZ8xHHE1Vk5DJg0aCv4QQGGMA6uGVLRYHv7bobf7AMuRTGyKsJUMSmh2NRQJL88u7EPGQXC6T74GkVf9pu9mov4BsNScsiFx38GUb1CXeN4cyAI6m1jjCY9xeeU3/4O2nC2EII1K06gIfyx3ECAdfg0UYteIHIMu0T9gsY5rr5LqqUrYYYNY4Wh7AAFIIHbK6Ko3//5A1EaiRUw== Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) by AS1P250MB0581.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4af::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.28; Sat, 22 Jun 2024 13:20:55 +0000 Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::1f36:56b3:1d04:c7a6]) by DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::1f36:56b3:1d04:c7a6%6]) with mapi id 15.20.7698.024; Sat, 22 Jun 2024 13:20:55 +0000 Message-ID: Date: Sat, 22 Jun 2024 15:20:52 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240622131533.1313814-1-ffmpeg-devel@pileofstuff.org> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240622131533.1313814-1-ffmpeg-devel@pileofstuff.org> X-TMN: [XIqbHHoD+wrH2D1282lYZywOFWoxlHp6qgOJtzE9QWo=] X-ClientProxiedBy: ZR2P278CA0016.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::10) To DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) X-Microsoft-Original-Message-ID: <0a0caa66-8978-4117-a2b0-d228adaa5c21@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0P250MB0747:EE_|AS1P250MB0581:EE_ X-MS-Office365-Filtering-Correlation-Id: eb9c4ccd-fc9c-436c-a54a-08dc92be2565 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199025|3412199022|440099025; X-Microsoft-Antispam-Message-Info: FbnNquitz1EQNbXpzWUM9Ot6GQnRl0PViaF76wQuuAwciffKqi1hs+h5PoMFXOJ8NIE01pFcMJQAfeuxMu5NZ0mYKSmjQ3zeKORHK5E3rZj/nlp+JOlahgmM+wlH0Hz5zAAcaZejhxziNi116ueb2m8llyw+uO8rhP8+5W4a54lJlVJFyMlzBtfPMbxoIpaPQcKBdmiH3wEAdReCMdqUokjlebTHl69QSSMMsndz7evnaIet/gCHkRBZB0vlS9I+AyhjQmbVbG9CSdoqXkDHVx4iXbJ1/hIvIFOM7kRu9ht0jhzcb6vq1mxNKNONXYe4ZHSm1ozbEiqJRSXCQy4v4mj5pZVmXkGRGMXWqVGucYgrzJD0C+MIaPKJI2QaswaDzv37CKeKEOeHBLfvnOZLdr8WhLCOu5ZbzDSssDyCkhiEUEB5PC+nUo9a/zYFuNQm3zeyYJhTUDPrVrO8ZW+Por3qE2VZoRjtjpto6lGarXYyB5E9RXbnKBpACJI2MiEwM7xpyT/brgLoiKX3DdCIWWoBISx0n1ctKoFYq5ftzmfa8LAPuaBENZYsXY9V7iGz X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTQxVUZmWHN0N0drYnVDNVJXOTBNYlZwWmV1Qm1rRW9YQzZPRDlWeFZjODE0?= =?utf-8?B?aFhiUUZWSndaRkxqTWY0NG13Vm9FbitwNWZsNENiQXE4QVl2eHF6WTNxTHJr?= =?utf-8?B?UHJDS3ptSHpxdHo1UDRveDBQTm9acEpSMjNDTlYrcWJISGtwRFlWdzd2WkxT?= =?utf-8?B?SitqdjRReHFHdklLNFM1ZTdpeTFTN3UrNzhiQmRxNmx1a2NnVS94UTRiMy80?= =?utf-8?B?Y3RCNlZ0OHNRbWdjcnlnT0pZaDc2dzBDWkxsMGs3RlpsaUZCdUJhVFNwbXR5?= =?utf-8?B?VFhWQU9SWkFLbTZ2WTk0QjNoR1ZGUkIxVVpDKzB3eTlMYllZcjRPRFR2QWtP?= =?utf-8?B?cEhZMHVFS2k4Y1NZQXFzYy82dzZtQ21VQVpESEVDY0JvamdmdzJmSk5GTXNr?= =?utf-8?B?Rkcya3phOWx3TWVnUHVzUzEwZ2RJNnhKak1OMndvT2JwSngyTEgrRTJSWHNl?= =?utf-8?B?MllaR3lQSGY3TEp1RWJJYUtzdXJ6TlhUWTl2UTlaMk40cmtMS2t5NitlZ2Y1?= =?utf-8?B?eFRxdmpJSlY5K0RzU0g3ci9GNVd3UkZ0bEtjWERaY3U2aWhSZHVWbEx1THF2?= =?utf-8?B?MWMwc293aFVBTkt5VjRCMTBrd2NTb1hKRlFIU08xK0NKNXJCb0x5QmxuZVdG?= =?utf-8?B?czN3Y1A2N3UwZkZqUlRzNXBncmtnNWN3Q2N2bXFWYUJSeFVsUHdZbjI4MzEw?= =?utf-8?B?U0FWY21KbjdLdW9zRnJ3cWNkNU9Zd2tPalBnYXZ6YlAxS1dsZkVLTEFSd1JK?= =?utf-8?B?aUxuS3M0bGJ6UnVLUVVXNTgwWkw2b3RxbkxGaHdHaStIUjVSWHVsVkJ1Tllv?= =?utf-8?B?REExWTMwYTBOZTlVdWxyRVM5dzF2UGhQVUN1MnZOZGthUVlmWkdzN1k1WTA4?= =?utf-8?B?cUZCR3dxZzVvVkNmcHJtaXdFc01TZUlQaEhFYzBGWHdkY1QvdkVWYUFIVWxm?= =?utf-8?B?QTZNRmdieTMreU8yNU5wdXlRaDJXMUtpUWtDRzFuT3pScDVHNHpXN0VNbVlJ?= =?utf-8?B?Y0laZFM0clljN0svWjJWVW9KbThMY3hKR1krWHMyWGFSWFd5TWFQWW1wdmlC?= =?utf-8?B?Y2hyNFgvcktwOG55cnNvL21HbzhVVmZIRkRlZjl1bkxEZjdNMnc1MDNXK2pp?= =?utf-8?B?dFFySUNUTUpnWDdyamZRRkVpQ1hqY252UDJubUVhV1NYbzRvUTZIcEJ0SHVK?= =?utf-8?B?eDJNb0JWMk0vaEU0cVVkckU3OFNna1Fjd1lxQm4wQnd6TXhDWnEwZVhWakg1?= =?utf-8?B?VStXbnIvTVZaelpmTnVGMWdzR0JWRy9lL244WFFFaTZZcFY2bnoyWGh6M1Y3?= =?utf-8?B?cnRhOGlLbGpOdVI3ZEFocnJzaFJMZVBIbFBRdFlCUkt0ejk3RUpRYnowNENl?= =?utf-8?B?QURJWmhxV0dzZWErYThsY3VSdlNkVWJLQnFsUlgxWk1Ic0NVa0E1Yk1aSlhl?= =?utf-8?B?dnVhalpDb1BPeFh0dm5LSk8rWGpWQjdRNXk3NzhhVldpa09QUGgwNTB5VjBv?= =?utf-8?B?Y2YyM2cxajZ5ZHpvWDZkd2xhM3N0blVJbWFEYlBTT25OSENUdDdIcXBGblpu?= =?utf-8?B?SVg5a0hoV25vRTlCVFlXWHZKYS9XbWZKMDBEbnhlVHVJM0lDRGdCTktWRDZ5?= =?utf-8?B?RU03NUdDRXdWRSt1cDFkQ0tmcFI3RzBxYTc3TjVaU0VFNnlWMyswRUZiayt6?= =?utf-8?B?bXR4QmgrUldmc2NjN05DSWlrSEU2RHMyZG4zSjVUZ2dPK0RIb2h1dmxBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb9c4ccd-fc9c-436c-a54a-08dc92be2565 X-MS-Exchange-CrossTenant-AuthSource: DU0P250MB0747.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2024 13:20:55.1143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0581 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andrew Sayers: > The actual value is an int64_t, and is accessed elsewhere as AV_OPT_TYPE_INT64. > > Accessing it as INT will likely cause bugs on some 32-bit architectures. Whether this works or not will depend upon endianness, not on whether the architecture is 32-bit (as long as int is 32bits, which is mostly true for 64-bit architectures). > --- > libavfilter/af_afade.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c > index 3a45873460..c79271ec92 100644 > --- a/libavfilter/af_afade.c > +++ b/libavfilter/af_afade.c > @@ -452,8 +452,8 @@ const AVFilter ff_af_afade = { > #if CONFIG_ACROSSFADE_FILTER > > static const AVOption acrossfade_options[] = { > - { "nb_samples", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > - { "ns", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > + { "nb_samples", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > + { "ns", "set number of samples for cross fade duration", OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10, FLAGS }, > { "duration", "set cross fade duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS }, > { "d", "set cross fade duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS }, > { "overlap", "overlap 1st stream end with 2nd stream start", OFFSET(overlap), AV_OPT_TYPE_BOOL, {.i64 = 1 }, 0, 1, FLAGS }, LGTM. How did you find this? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".