From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF3B74514B for ; Tue, 10 Jan 2023 06:41:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E16C868BC18; Tue, 10 Jan 2023 08:41:29 +0200 (EET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2028.outbound.protection.outlook.com [40.92.66.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5640D68BA40 for ; Tue, 10 Jan 2023 08:41:24 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLjitv88atpMsMy7OZv2BLX5fMdG7HCPQTNiUZPLxSdNreVvSULuZSa0LDlY7SJq0x4wXnkuqCqoRqLsCyiYav7wRDHvbRGJ2AErol5ot35GUYxEz6tIYajYH0fCnKWDXjLGYw0q7gO+xOtWF/6YahvHbNJRmlRiSZgjNuDG0EKcdUrfMZLTS2fL3461j6XBUveuQ/djM4m/8BMS+qiec0h2Ls/ba4NTn7a/O0l6VrFb1sBFCM5MFcpXq6INZK3kVM7xewX4LwzMan90DltX2bICcBofWXWm31RMBbZivH2hDVwAq3IgSL/XJeD86up6V+WezIy1Y1EkLn+/0iYsPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HO/EjX8c7Ijjm6uq0wqfNIjFNUVWP3kwL1DJHY44uDM=; b=NMAxKFOrLEo0uovUfCVDeT7dMqv/8RtkhBmpuGO1qSOrwUGbpjDJZmYvXHLcb1hhp0ycddVRKKeLwArW2B9RFnIv9aDgDDH3QoaR6lD9JrwpYXqrrQe/5N//9OFHi48eqy/erjO82GO/PQHDScux16J7XHa6uLLW2ksuY0GMelGL6u9+K2WEgiPwkJ90K3aEgTxOm39Y/970/FZ+DBO2RLDIIOn9EzasAZLypq35Y5vQv/vg4N5FKt77otz+OxPKxyZHGzOJGFkbFn88wweGhTP1sTmyc7QQB6+ubZKBsjNOuS3Z/Ihqo61LE0GtOrjpJ00Nruo5EF4u4aUFKWQq5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HO/EjX8c7Ijjm6uq0wqfNIjFNUVWP3kwL1DJHY44uDM=; b=Cz1xkupmB16Tw3rQfa4XfXl1tVXTOwhn3xu1soQtsw7jE5SpjpKqQWo6iHAd8JSTN5XcSGRQVU5XnJKzrhF1QXgPr7FySJoEhMeRqNgNTWOZuHAgrPvRI6ehJ9mpD/QYdCLLIksLTsQhQ+TC+TGqQrOIRuStuHgUEdDMGfUT2KTtoJcWr5+N2yLffSUe01FdoLc+xFN1YA1x9XO/qm6ZkpfGH68MW8weszHpm5/iCOlngULhp8ZohOsxx/fPUjqakO21XPCVAFkNOLfGzIAj11esfojAYGK1A/mRcem0l5y+iI3+Eo1RXfSgB8MDBFmZiuQxcedOH1x1BvGp1NQxmA== Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) by AS8P250MB0234.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:379::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 06:41:21 +0000 Received: from DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::b51c:b08a:7ff3:831]) by DU0P250MB0747.EURP250.PROD.OUTLOOK.COM ([fe80::b51c:b08a:7ff3:831%8]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 06:41:21 +0000 Message-ID: Date: Tue, 10 Jan 2023 07:41:49 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [hN5d9P9u8FVO9NQHPvfEMiqrFgOjC4vW] X-ClientProxiedBy: FR2P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::8) To DU0P250MB0747.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cb::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0P250MB0747:EE_|AS8P250MB0234:EE_ X-MS-Office365-Filtering-Correlation-Id: ff19ce4a-7eae-4bdb-76ee-08daf2d5af55 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6pzz9tkXVP4Jv2EIgzS0WmWPCx1k0EJBymGOyDDUcPBK3qlTeBviUQRm995+u54DxzdSreGcGZ368g5MwQ6TKl4fDRx0+ILvb6AgDMU4GAnBCQcutZSMfYZgWMMCLwLEYUgR6MFVwOoLKw74rZ2F5zxXYAtClGkfAg64F5oWO2PBDhionrnCv6yETYrJ9CaDeyWfc1V4IPaxaBaHunekJz7vVlsQSNiDiNsEKx2S/8NiuyTQx89iJ4diOgjP6a7J831vpQYpIkXJyffBRnTsFTbvO5ZYoUE0T9FcUcr+laATMQ1aKkEU9CvkyeqhZltIsz+xAvLQMt564V9f964GJPo5ZwBWiJoWytd+GCdCleSY6U/wspVnwkrjRQyRTcz+Bv6lWT4AOw1gfiq5ObTnsD+ATlgyPe0kPs8PYLslNlIMzuEejd0quJy273Lzt4av+u+X6yJ24OG2NfaTv7oeBnFSZBET88HPh/zFDPBf3pufpVuvLoUmk+Zfp3lWm6ReQLDQ6SOJt1mWwbpciZlVm12IPCVhCpfh6SvlcfVbmJiS1SxCL76HPwIH8Hqzu0J0Ij2CxLUfcS/oRlbfMs04HnVx1DIfK0pF6ekXQWPD9Mweq8C/T353gtPjU2S8TO8rxjYMmbE+FfJMKwlgprMGcM6j8OGK8+adXT98u9/rIOQ= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sjh5RlNCWXJ1TUloWHJiTk5xVXQwZTkrdEc3Mm1OOFk0SnpiWjFFZjQ0WDhZ?= =?utf-8?B?UkFObHZjdFc3elBnRms5VDgzTXpPUFoxM2ZFcGtRMlhUR3BFVkM3aDFETDE4?= =?utf-8?B?ZWtYbG9xcHBsWWJsc2dtSDE4cS9zMGd4aWFNL2VieFNwWnlKRG5uQytKd253?= =?utf-8?B?dmhiQys1dEFVcU80VkN5NDA2SWhMelh2akFkTXRpbjlZN3Q0U3lONVJ2RWpX?= =?utf-8?B?Um14RE5mRndhM0tqeWRubDFxUUNaVldlK0xMNVVtN0tHZlREWFZkVEw0RVFJ?= =?utf-8?B?WnRvUDlhWjRGMXhCRHJZano4eXNiU0RpRmhFUlB3T0poalVnN1lUeEJ6Ri9l?= =?utf-8?B?eWM5K2tlYnFMT0FrOVprMDRHZTQ2NWtSWVR3STFvckR3cVkyNzM2UHRpR3hk?= =?utf-8?B?WUtwTVA5cUxQMnZsdzROb1kxRndhSFp2M2dPMkNWMVJlSzYwbmhDRkZlblhh?= =?utf-8?B?bXovVHNZNlJJZ2QvbjZtdys0RnYxbThRQ1R4a1JsMDVmVzRIM1M0c2NiaC9a?= =?utf-8?B?N2hpcndQTXRTdTRKVGpId0Y0ZEdjamgwTVlQY0hxZ2MxMlV3QlBsaHpRanBS?= =?utf-8?B?cTBteGNhT2tvZDZMT2luWlZtT25KTm93ZDhPcVd3YVZlanJndEEydFQ3UGRL?= =?utf-8?B?QWUvcGVjQkJiU28rZzR3WElkaUFaMU5qS0lyeWM1NTNUamRqbkJaeGhFaXBS?= =?utf-8?B?TTVvY2d0YzR2NjNYWG95Z3NpTHNZRFk5ZTB6Mis0UGRGU3FFYXNSV2taRkFW?= =?utf-8?B?bG1aTU1GV0ZNSng2TENUdXdESjRjcGpseEJ2bWdYNWRma2krSW5IdzBGckNj?= =?utf-8?B?Sko4RXkyMHdlYnlDWWJJaXhFcnoxMzFzeVphcnNuTzJNYUQ0bGhKa1k0ald1?= =?utf-8?B?NTRoS0c4OVI3WmJ3ODRESEloMEVxczQwRkRuQkszTDF2RndTa0NtOUdYQm5W?= =?utf-8?B?MG1VdjUybDY1SUQ2WlJscHdGQXUxRk9UTmN2SVRGK2FTZXpDMUFBd3MwZWtt?= =?utf-8?B?QmFUYnVCYkZaV0dWTnVkTjJJVFh1NWVSaGt1dlBxYW41bmJ3aFM4Z0R3NlYr?= =?utf-8?B?RzIrRFB0TDl5UUZzckNUNU1XemNzUTUvdndVOXBiVDBZc2R2Tm01TWtzc2hE?= =?utf-8?B?c3BHVEpyeGR4SFR5ZDQvQ0hmaGJwWTZjMjZLc0x1dEduTFRvVm9rN2R2VGxk?= =?utf-8?B?U3pCUWtmWHJDYjg4SVJJRGFTek9oY3MyWkwycjZ3NUQ0MGZ2Y3g0SDNSVXFS?= =?utf-8?B?a3VzMzg1d1BqUlgzZnI4Qi9JbnRqeTBZaDdvcnNtV05VbmtuUy9JeERlZDdy?= =?utf-8?B?T0ZQNVNkWGdWUlliRGVlUEhGcytGR3EraGFMUHBNTUlPZkQzTmxJZzMwbG4x?= =?utf-8?B?aWpDdE1yWUhqYXVtWGFpdjNnYmtOTXNEV1Nndm5PYzBQNFlla3JxUmJrdTUv?= =?utf-8?B?bkk4dXBUSFlmK1dSR2FDU2llQm5DVUJsYlRqdDB3YkVsYmdPWTdJeGRpRm81?= =?utf-8?B?S3NaSkovSUtQNlB2aGZLaTZMbzFQM0JCSnBVSS9sWXZuSGpqT1JoZ25xbmRv?= =?utf-8?B?cGZIUXQ0NnlqdUtwaGxjcGlaT3JremwyVWtCOWg3eE1aOGpkd0JwU1owNzRn?= =?utf-8?B?Z2VQb3dLUWN5c2JKSXJnMm55amxnSUNoTk1GMjlJMGdYVGJFS2U5ZkVQYkc2?= =?utf-8?B?dm41OVhKM1NLY3B0Z3RPY2xMT2JZWElYSzJsUWJEMGpGcENGbUFHbGsrelVs?= =?utf-8?Q?0rNu/JBDC2edVd53DA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff19ce4a-7eae-4bdb-76ee-08daf2d5af55 X-MS-Exchange-CrossTenant-AuthSource: DU0P250MB0747.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 06:41:21.2571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0234 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > From: Zhao Zhili > > If there is a single group of SPS/PPS before an IDR frame, but no > SPS/PPS after that, we will miss the chance to reset > idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all > IDR frames except the first one. > > Signed-off-by: Zhao Zhili > --- > libavcodec/h264_mp4toannexb_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_mp4toannexb_bsf.c b/libavcodec/h264_mp4toannexb_bsf.c > index d11be455c2..bbdeca9c44 100644 > --- a/libavcodec/h264_mp4toannexb_bsf.c > +++ b/libavcodec/h264_mp4toannexb_bsf.c > @@ -259,7 +259,7 @@ static int h264_mp4toannexb_filter(AVBSFContext *ctx, AVPacket *opkt) > > count_or_copy(&out, &out_size, buf, nal_size, > unit_type == H264_NAL_SPS || unit_type == H264_NAL_PPS, j); > - if (!new_idr && unit_type == H264_NAL_SLICE) { > + if (unit_type == H264_NAL_SLICE) { > new_idr = 1; > sps_seen = 0; > pps_seen = 0; If I understand you correctly, you want that to include the parameter sets from the extradata to every IDR frame without extradata if said IDR frame follows a non-IDR frame after in-band parameter sets. There is just one problem with this: Said in-band parameter sets might overwrite parameter sets from extradata and inserting the outdated parameter sets from extradata lateron might make the stream undecodable. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".