From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer
Date: Sat, 9 Mar 2024 18:48:51 +0100
Message-ID: <DU0P250MB07476ED6461603FA9AD190D48F262@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <Udn4nQXIGrYLw_55GiJyTdoD62pxsS1fCC3P4_9zRbRHqK_-xSQkhL4TuqDPWJkkChyoMWeQJM32_JflR8bS2SJeyz6YXxzxS2avvIw78PA=@protonmail.com>
asivery via ffmpeg-devel:
> + const char *title_contents = title_entry->value;
> + title_length = strlen(title_contents);
> + if (title_length > 256) {
> + av_log(s, AV_LOG_WARNING, "Title too long, truncated to 256 bytes.\n");
> + title_length = 256;
> + }
I actually meant that you should use size_t for title_length (so that
the output of strlen() is never truncated) instead of adding a warning
that will likely never be triggered in practice.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-09 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 11:19 asivery via ffmpeg-devel
2024-03-08 11:22 ` Andreas Rheinhardt
2024-03-08 11:48 ` asivery via ffmpeg-devel
2024-03-08 12:06 ` Andreas Rheinhardt
2024-03-08 13:50 ` asivery via ffmpeg-devel
2024-03-09 10:17 ` Stefano Sabatini
2024-03-09 12:06 ` Andreas Rheinhardt
2024-03-09 17:20 ` asivery via ffmpeg-devel
2024-03-09 17:48 ` Andreas Rheinhardt [this message]
2024-03-09 17:57 ` asivery via ffmpeg-devel
2024-03-10 14:00 ` Stefano Sabatini
2024-03-10 14:20 ` asivery via ffmpeg-devel
2024-03-10 15:10 ` Stefano Sabatini
2024-03-12 10:27 ` Stefano Sabatini
2024-03-12 11:10 ` asivery via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0P250MB07476ED6461603FA9AD190D48F262@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git