[FFmpeg-devel] [PATCH] avcodec/librav1e: Don't unnecessarily create new references

[FFmpeg-devel] [PATCH] avcodec/librav1e: Don't unnecessarily create new references

[Andreas Rheinhardt]

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
Absolutely untested (not even compiled).

 libavcodec/librav1e.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
index dbd728a408..2a6d8bfbed 100644
--- a/libavcodec/librav1e.c
+++ b/libavcodec/librav1e.c
@@ -472,12 +472,8 @@ static int librav1e_receive_packet(AVCodecContext *avctx, AVPacket *pkt)
 
             if (avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) {
                 fd->frame_opaque = frame->opaque;
-                ret = av_buffer_replace(&fd->frame_opaque_ref, frame->opaque_ref);
-                if (ret < 0) {
-                    frame_data_free(fd);
-                    av_frame_unref(frame);
-                    return ret;
-                }
+                fd->frame_opaque_ref = frame->opaque_ref;
+                frame->opaque_ref    = NULL;
             }
 
             rframe = rav1e_frame_new(ctx->ctx);
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/librav1e: Don't unnecessarily create new references

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> Absolutely untested (not even compiled).
> 
>  libavcodec/librav1e.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c
> index dbd728a408..2a6d8bfbed 100644
> --- a/libavcodec/librav1e.c
> +++ b/libavcodec/librav1e.c
> @@ -472,12 +472,8 @@ static int librav1e_receive_packet(AVCodecContext *avctx, AVPacket *pkt)
>  
>              if (avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) {
>                  fd->frame_opaque = frame->opaque;
> -                ret = av_buffer_replace(&fd->frame_opaque_ref, frame->opaque_ref);
> -                if (ret < 0) {
> -                    frame_data_free(fd);
> -                    av_frame_unref(frame);
> -                    return ret;
> -                }
> +                fd->frame_opaque_ref = frame->opaque_ref;
> +                frame->opaque_ref    = NULL;
>              }
>  
>              rframe = rav1e_frame_new(ctx->ctx);

Will apply tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".