From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 17/20] avcodec/snow: Remove outdated assert
Date: Sat, 8 Mar 2025 20:28:18 +0100
Message-ID: <DU0P250MB07475BC21B47FC4DA46D411F8FD42@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744B45885287D25F7D94D358F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Andreas Rheinhardt:
> It comes from a time before frames were refcounted; it has indeed been
> added in a follow-up commit to c13e490dce1a66d79e1f053d8a38fb9b2eb53267:
> "codec_release_buffer: fix handling of non user buffers". This type
> of check is obsolete now.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/snow.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/snow.c b/libavcodec/snow.c
> index 7e93005492..dcd6d67ad5 100644
> --- a/libavcodec/snow.c
> +++ b/libavcodec/snow.c
> @@ -607,9 +607,6 @@ av_cold void ff_snow_common_end(SnowContext *s)
> av_freep(&s->scratchbuf);
>
> for(i=0; i<MAX_REF_FRAMES; i++){
> - if(s->last_picture[i] && s->last_picture[i]->data[0]) {
> - av_assert0(s->last_picture[i]->data[0] != s->current_picture->data[0]);
> - }
> av_frame_free(&s->last_picture[i]);
> }
>
Will apply this patch tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-08 19:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 18:08 [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 2/8] configure: Add missing prores_(aw|ks)_encoder->fdctdsp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 3/8] configure: Add mpegvideoenc->fdctdsp dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 4/8] configure: Remove unnecessary me_cmp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 5/8] configure: Remove unnecessary binkaudio dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 6/8] configure: Remove unnecessary qdm2_decoder->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 7/8] configure: Remove unnecessary wmavoice->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 8/8] configure: Add (dnxhd|snow)_encoder->videodsp dependency Andreas Rheinhardt
2022-10-10 3:12 ` [FFmpeg-devel] [PATCH 09/20] avcodec/snow: Move initializing MotionEstContext to snowenc.c Andreas Rheinhardt
2022-10-10 16:14 ` Michael Niedermayer
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 10/20] avcodec/snow: Move initializing QpelDSPContext " Andreas Rheinhardt
2023-09-28 14:39 ` Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 11/20] avcodec/snow: Move decoder/encoder-only inline funcs to snow(dec|enc).c Andreas Rheinhardt
2022-10-10 16:16 ` Michael Niedermayer
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 12/20] avcodec/snow: Move initializing HpelDSPContext to snowenc.c Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 13/20] avcodec/snow: Move freeing encoder-only buffers " Andreas Rheinhardt
2022-10-10 16:19 ` Michael Niedermayer
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 14/20] avcodec/snow: Only allocate mconly_picture for the decoder Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 15/20] avcodec/snowdec: Don't zero encoder-only buffer Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 16/20] avcodec/snow: Move allocating encoder-only buffers to snowenc.c Andreas Rheinhardt
2022-10-10 16:23 ` Michael Niedermayer
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 17/20] avcodec/snow: Remove outdated assert Andreas Rheinhardt
2025-03-08 19:28 ` Andreas Rheinhardt [this message]
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 18/20] avcodec/snow: Only allocate x_coeffs for decoder Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 19/20] avcodec/snow: Reindent after previous commit Andreas Rheinhardt
2022-10-10 3:13 ` [FFmpeg-devel] [PATCH 20/20] avcodec/snowdec: Remove debug code Andreas Rheinhardt
2022-10-10 16:26 ` Michael Niedermayer
2022-10-11 14:21 ` [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0P250MB07475BC21B47FC4DA46D411F8FD42@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git