From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5CDF48D28 for ; Thu, 25 Jan 2024 00:43:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA39268CF59; Thu, 25 Jan 2024 02:43:04 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D91A268D068 for ; Thu, 25 Jan 2024 02:42:56 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706143382; x=1737679382; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=GdBocU5ST8RMpNFAcS3rNdRwWsqSpUfpb5qlY++tm3M=; b=R7mevscp7J+LwbS0Qgv2MC1GYOg8K7XDtXC32N3C97mSuqGFf+zPnGOr leNM9w1mwnmCF8qu5aHJad6ws9qs7Tsu8kYqvDnUpyI6LGY4izdy2mAoS 21wV3fUeLY7IPihIwQ4yG1wAFwR+BY8JpgfXtyvgSshoJAojsLvl2q6Qo aXI2Byx+Mj1k/FSYEJIF5SnVnOMJyFWOySvHI0VueoQBE5SNMEW+D3zZX zrU2NqPDqIWjIHy44vNufqrBoGsIrtN1DwBBbEbZaB6sZHxpszZsHD7mo i5G2qP1PFz1p3wBL18Da9UHKN8j/8YYaBEFwzqi7Gq4bJ7wDkS3yGEbK2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="20570047" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="20570047" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 16:42:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="2072769" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2024 16:42:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 16:42:52 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 16:42:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Jan 2024 16:42:52 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Jan 2024 16:42:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJsR4k79qaQR4rWNjqbUDTei3gvSlYPUjLFLyjIR87XfNd3U9QwC93mmEJZiCERjZMxkZRCC1ruMGBH6ck3hrtW6yHzlaqOUeRYEIV5MPJ6oFAG+01iBZMh5sbH3ymsaoI2blqzrxLycwS5+17DWL17yBu+g4pC2fR8KpSpZTnM0PCO/QxJm6wfmS7suXi5jVkmBgeTjdQi7LAvI4rGbAQknBOyVjng7LMi17+A+MGUYNhaSWbed1RTIq1lfgjnmwplp3ihMzqNfNe31V2BzpLfB6ocd4NOuygH4+lPstzrfYGkx2wMraRfzH1mkjL8p6WeQNHDqmPfqmV+3PmzcrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3hib52uU6pXYIPhAv6FxO/1LG1boXxu/Y7n8Avc2yqc=; b=aGcUXNa9fMKuirxzqUlhQ+OojAZm07NGEjj6pfVt+RMLhbuee6+rLUE9q3KsQHTaV3Om6Lv73njpvIPtRemp/VbZsmGgNjPuqKwJU4Bc5Ksyagoh7LNRQ+sMIF6Y/WlJVtIaiP2lLDioDvdnbAIlyTVeHWAh2ewfmDuotj5iKOlBl3m+nRxfHSin9wqjC6T169YH3VepXNCOKAH6/ByMNYN5tZ0b6I8vv3zwuWpNUIlXF2VRMQIMsJ2w/4nsrMzE4ZB6Ou5xT8HT2SFw7AZ+Ep4/qhfD9UmTANm+YD3+Hp/rNAe+YFK+mWklRkjV9owvCmbV3ceyg5/WR/VzWAtHpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB7949.namprd11.prod.outlook.com (2603:10b6:8:eb::11) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Thu, 25 Jan 2024 00:42:44 +0000 Received: from DS7PR11MB7949.namprd11.prod.outlook.com ([fe80::a594:6f8a:5156:39cf]) by DS7PR11MB7949.namprd11.prod.outlook.com ([fe80::a594:6f8a:5156:39cf%2]) with mapi id 15.20.7228.023; Thu, 25 Jan 2024 00:42:44 +0000 From: "Dai, Jianhui J" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check Thread-Index: AdoxhcxeCzuJrmabQlqgxVGMPSzOTQdNHR8AABswvAA= Date: Thu, 25 Jan 2024 00:42:44 +0000 Message-ID: References: <170609648216.8914.11231022843595402569@lain.khirnov.net> In-Reply-To: <170609648216.8914.11231022843595402569@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR11MB7949:EE_|DM8PR11MB5574:EE_ x-ms-office365-filtering-correlation-id: 59b66eca-8adf-4562-79fd-08dc1d3e8b80 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +qN7YByBAZkdmpv6B00z72x+jECFl7wG9R6LeuUV0G+ikvINgjvwWcxv8rD3hGJY7wRUF1S4VKz5Fbj0VHpnUXiSJ4Rv10orlmq9aTAlPkVcBU/rG94MEPvPHE3WEcGVOfxYGZ2SToVW1rGm19MFxe+djeo57B25u1uYvxXp+FAEUSXcicAq24hXgdb4SBxieLU/Sv1ndeQbRJ9Eh3UkBhCsqV4pZX/KkzHFz6JKSLDh0WYXuH+K5zqFaUa+dkyxiBXLsPSunrBBAjzGDllOyQWeKwEmNR9c+/ecrbwPZZudWTqlUw9yVUlH4O5yQsKF9S/zZydAoj1If9KrjH79KcN3XiMYTjxEsD5H+V4yMYmz/yiWICyPv/x+P2OoBuyr6ft0XEbomxBz/HkZ/nHiYATaEUTR+i9dgL9+fSrxg2r/eQYn33H26TnqYicJYxp2h31fHmy15piRsKqfeLta8eLnECNs/gJutY4K39Z27LS33nNTXVB8RfpDKONr7iIxWd0ex/vKrpGounGHWOfqUiKYy3tyDCvOG5mGVLufnMlg+TcsZEcpUBI0iyFsIZ/6DJTXTginXtpf5m3l/lUSJ3d0gpgssqb77n6HtgyCef8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR11MB7949.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(39860400002)(396003)(366004)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(8936002)(8676002)(26005)(478600001)(66476007)(66899024)(66556008)(76116006)(64756008)(6916009)(66946007)(66446008)(9686003)(316002)(83380400001)(52536014)(966005)(6506007)(71200400001)(53546011)(55016003)(7696005)(33656002)(41300700001)(5660300002)(86362001)(38070700009)(2906002)(122000001)(38100700002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ue5QWHHgP1QolMgPutY/eZbiSjXLAiTnD0clxpSbgruEImGc8oORUQTsuab1?= =?us-ascii?Q?AiYOzbj939zUgWtsQ42i+LjyGVYtsOXNg4k95trJGPDb6ENY86rnKGq4H7yc?= =?us-ascii?Q?7/wfG7baYNHDRPbzcvYEODcr1xLsrpODclJy0ZYOxgK4cLRI3xBUubNHt12R?= =?us-ascii?Q?3AFS5fR46oaeQ4BEsoM9yVSqXQawep8PgWnUo9f/JApmsFa/yqQ+z8QoBrff?= =?us-ascii?Q?pJQfBweu79YFPAebr5cqcV2MeN++sSlXISNtvJWkwl7dD+ZYk9iMI3QZzJaL?= =?us-ascii?Q?BZkjIAKeisZU/bBU19KH6MpuemiDBRFySHWMrsUSnioIw3kyScKj7Xk0tYd5?= =?us-ascii?Q?mEFkrp1DHFp61g0kdlSdz6vTP5aEIbFfOFWUSI+NyKiZa+WFf1liRJ0MFu8/?= =?us-ascii?Q?RETEtsHGEdXfvSXV4unCpY3FQ+lq77d7sx565ESR05aVlh0/oIExw4QdpYLR?= =?us-ascii?Q?drJu5FXuiIGgZubNZEbjafAdVp0nXMUMd+A1SxaflkYcUiZiDT8Uywu+tSs3?= =?us-ascii?Q?82RReqLS1uIz228JzliA8ehEBDODVmsm5CXYPc1DQqf8wdsjRO8kBKQTbedw?= =?us-ascii?Q?xt8Kvu2Bi6MYBjT3iH736+wbFWfCY87iXIKOT5U1NP+mq2zuquXG5NcnmacF?= =?us-ascii?Q?23u+QKQI1RSlkRdObQvAwtSUW/sqKpTn6aAfBqWkRxGMNuosXeht+aVfUr0H?= =?us-ascii?Q?AmHUUWTBiZXS0q8u/GJpGlWqkLSmEX+ByRYk8w0RIwSA1NifMdosexmDoa76?= =?us-ascii?Q?qQE4Ne1BqUZD1uWFbeSmSBUOr9yo+pEVhw4uxpvt5IJuMAl4cXuWJ//OLcaO?= =?us-ascii?Q?thyaOY+HVQOdeLbxYCuWxQGm7epTawqOBC6Os5KuysKQTYcFQ8Mn3721tgn3?= =?us-ascii?Q?Ah47ALY5MigP+wOP5XZtSFdiJIyiS2SXNJJ+Tjn9Sdj6HyyU7iMNDqrYooye?= =?us-ascii?Q?I0vfHxRSAbziA0gkh1t6elMsAuq0xolTANtnqK7CodS0w11m1O9Aj53QKgHe?= =?us-ascii?Q?KhzU9shFz8vpXW/KwAR04fNGlM0/Nyp53aaID+Z396X9n7iUv99ENjHfXlTO?= =?us-ascii?Q?zB314lgCz1iV9IzfOz95Il8tizypmXdEYo79N2kY0CgyGBU5t1E5pYsp9kXZ?= =?us-ascii?Q?pBQZsbb++vRsdwh7dRo2RkJG9M/lFi5sR4QjrQ4WNvcAoeRJi3Xs3633ZDUL?= =?us-ascii?Q?XeMPNuB+k7THw33/cOWOwKpGLoYgc2h9fFVeYmGBSBs07QdUE7QXt9as2bPn?= =?us-ascii?Q?1wMy3BZV9Zauf/DQloXYvORF9iaqrMYVBebLMrFdflHPb4IPzekV9IEaJ4oR?= =?us-ascii?Q?HIpxjkpiRomZ5g75TFja8ykTC5/ITibhzKlyZYXvJQ0K8Lc7Rvz+kwoq3YzK?= =?us-ascii?Q?B9e/92dde5fwcWXdPXMfBrt5/E6pJ6skgMjp7mYExO8MldlkAZN71jLU7SYy?= =?us-ascii?Q?Aowg1EaZikB7x9F9RP94eiA2DgP1RsH/t6aR/Rp8iNrwrFJ40Of9D5AfOl1V?= =?us-ascii?Q?CHW6ZaESDttypLtmFepBheP6J6OJnA5Q17puXyIel5IsDz38sNQ7DT1ZpcOv?= =?us-ascii?Q?3p5PULRudg4r3r5UUkV9oriqlCZvINZWdjsDsnOl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB7949.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59b66eca-8adf-4562-79fd-08dc1d3e8b80 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 00:42:44.4845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w2eD+N44bWjfqyNTsb79UrnX3Niwr5V9m8dMSysu5g8d+oQ/1Ww7qT0nHwJni1eEU1jfJkIFuih2+4s76VoL/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, January 24, 2024 7:41 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in > fixed() and improve the pos check > > Quoting Dai, Jianhui J (2024-01-23 03:58:24) > > This commit adds value range checks to cbs_vp8_read_unsigned_le, > > migrates fixed() to use it, and enforces little-endian consistency for > > all read methods. > > > > The VP8 compressed header may not be byte-aligned due to boolean > coding. > > Use bitwise comparison to prevent the potential overread. > > > > TETS: ffmpeg -i fate-suite/vp8-test-vectors-r1/* -vcodec copy -bsf:v > > trace_headers -f null - > > > > Signed-off-by: Jianhui Dai > > --- > > libavcodec/cbs_vp8.c | 53 > > +++++++++++++++++++++++++++++++------------- > > 1 file changed, 37 insertions(+), 16 deletions(-) > > This patch seems to contain many unrelated cosmetic changes. Those should > be moved to a separate patch. Sure. I will split this patch for separate ones for easier review. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".