From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id E1F014DC10
for <ffmpegdev@gitmailbox.com>; Wed, 23 Apr 2025 22:36:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C23F668B2DD;
Thu, 24 Apr 2025 01:36:52 +0300 (EEST)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12olkn2070.outbound.protection.outlook.com [40.92.23.70])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF7EB68B207
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 01:36:45 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=KP25qGfdhR1gV0qgB+9+YadtVcSRVlYkuGdfw2iMY9PTOGlZke77hri2qIFJdoK/TROiW/HglxeqB5bcrALe2kXFGgPjs6AU0THnZxhiylDVeZCIxE7iY47CFcTLfhfKHRZXSvxVBLf/5JEMs8QyyjJk73RMg5JPUOstqylSili1Or+XErDKsSEB2Bg14HVjApslDlihLWcRx9F2NZuRUCqMqArJT6z/EA7RLgJXECyqa2RRESVWwBNNLth57ffjtBJq1EpvocYyheFHotxmvaDYXIXHjQ7gF6+G9F+fi7+1e5i3N3LfAqO0usdKQ3KxCKxgOeOMSxZtM7Jfky6eyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=XcKJ8JuU5SqpmkwjDEpCqmPtKwcmwrCj3qSOK1x/JE4=;
b=LQSjPTJCVke9ODOUMF8OPIWZI68yq4bacOklsmxOFlUOO541gdY13F/gV8dIP2fq05TInUKsnaT77gERDhe5//qJr1SzBjxRbMFu85FkQKEDptvIzZpepXFwBYjdrex07MhU+vZnnGetMeYfSOqRLenBSereI24HpXdFRF8FlQAgGPOrP9RfMDAHRIJtOx+jO+CPqpx8X2VyY9nZCE8fFaj0/wC7Fjh4ivOHE5WfX5Bwy38qfv36n/lVeVTeL1vPy05+NuelRA8IhaFnvsVdSJZQvVvItdGAIRIJBa4H6UD1NPbZRMfjCm9w7nUqjjof2SSLOdCjn/nUI/rE5h5FmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=XcKJ8JuU5SqpmkwjDEpCqmPtKwcmwrCj3qSOK1x/JE4=;
b=jhfauwsejqTNzKe+/Qae9NsIcepvSD6jYheoV1KFC571FVeoEmHPIqMaVGfxCjSUdDH+GR0mWc7MGpP7hDLvcljsbgYns7/LSsSyZvyLu7kJEkSUxvH8E/JhBlIHtWnTyCWV9it10W5xv9UAdNf3P3mdQaPgRk1LRsyIWHxJqLu01K4XSavQelnj/2vyD2Z/ICMjeqOEV06Mn9Og4A5t0rSPPUDKApdJFSC/C9VtfSxvHeDwOCD7e3/cjx9CtfUS87LPw43B9nnAqFVQ/W6eWhAMHCjkP4bh7lgJEcCswxOwTuwPOGHAPu+B2PYTpJplk61EBUycwhwcDnJTi7xWFQ==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
PH3PPFD3B7C3622.NAMP223.PROD.OUTLOOK.COM (2603:10b6:518:1::542) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.38; Wed, 23 Apr
2025 22:36:42 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.033; Wed, 23 Apr 2025
22:36:42 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
Stefano Sabatini <stefasab@gmail.com>
Thread-Topic: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
ac_default_item_name
Thread-Index: AQHbskforhOcV3Q0nE+InvTUBbMy8bOuYcaAgAHNytCAAOZXwA==
Date: Wed, 23 Apr 2025 22:36:41 +0000
Message-ID: <DM8P223MB0365FF6BEE204938825A7547BABA2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.v3.ffstaging.FFmpeg.1744945024.ffmpegagent@gmail.com>
<pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com>
<4f1218b594ac2b4de96870dbd2903abde3f94d95.1745189955.git.ffmpegagent@gmail.com>
<aAaA3V6kJyfHPtAT@mariano>
<DM8P223MB0365A9306A56C7799CDA211EBABB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
In-Reply-To: <DM8P223MB0365A9306A56C7799CDA211EBABB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH3PPFD3B7C3622:EE_
x-ms-office365-filtering-correlation-id: 8a74541b-8b6d-4c7a-15a0-08dd82b751cf
x-ms-exchange-slblob-mailprops: Cq7lScuPrnpFX5gNBgVui9nZ6J+Gucr/KK0WTaMSAqJHch4jHnAc39djaGmtJW35fDQ0YVsCg42GAmPNAoHBrQbS5wR0jdI5rfPj7P7IKvsnhQbk21ZOtIj1yd3PDcRHiVR8VOD/QzdNdDrHpB8XEP88a9Sa4IwY9QBQ2pRH5s/BVccXP4b5RNug4OuCy/ffBFleqDbTxO4ztTMNuzaxUw6D04XFIUXW3IeZyccKnn/OUkJkNo99VIUSmgVopXedNhyZIEva8ppNlRXdZPJ5wuRq/iXlrPvHF86BtHLToLKVlLwh6mzVhJwOgmNQLsTc957a16pZrRd/DJz91jRP7Qo4z46A5p9H5r5kH1ixLf5bK3Kr8yELBatizECXAoOzZHp1y+eQbKmaapWX7BI9uF29C2XASCXi/D5b3HiSjrI6B52qZCd7DgQT5vxZtgSaDhgHM4eaVHCluMrBc3Pw7DjANdn99ul9I55KXFkTIou7JrwZ1ChfFMYMxRw3Eoqdsla2YmZtXP+1kgIkAZpT5IYj6n7RJ1nMndYt7Utaj11MWkpFxpuSmgRG9pa16FcuvhDVKax/v4QgnyJ+h738AOhGKcFsIuHx4cSAXslGtOOVm11SeVSgTSRAfHAwnqPBE3yQE17RaTHPjHpt0bjULOMHuI84KmnE2y1zqu4f0Q5MMPtWjaAB2Q+P9tpdNJ0vVU/4IUcNd9Wn2+pJHuaBVfUzJwLE9HbwJeJyQdXupB0sD+7nbdDOkPA93ouN0Hdo15ASDS+WRoY=
x-microsoft-antispam: BCL:0;
ARA:14566002|8060799006|19110799003|15080799006|8062599003|461199028|7092599003|3412199025|440099028|102099032|41001999003;
x-microsoft-antispam-message-info: =?us-ascii?Q?Gvp3gYxdCRkJITFZz3FsAGA7xpHFRLnzP4F9xPYXy7u7VzVlyZjteNVXCn58?=
=?us-ascii?Q?ypAYNZnS6CXlfj/7STBsXSL2p5GOwyOgGWAUB1Z0xr2RrWbJ79lCCtd3kNFa?=
=?us-ascii?Q?fvl6CvpxUvD7uC18xSwc4MODQ+gQWjARlBBNJKicdxSzwkjxSVd7r4K32mdM?=
=?us-ascii?Q?cHLJIz7XCR5nvs0z0Atrfrxo4shYZt25eff2k82URdo8grs5oM3aCbmfPlF9?=
=?us-ascii?Q?0lYEfRT3tHBqiEYZcr1VebnlbkoKkdO6WLIjOqfDJmnoW5coe09TZB5G4Nbg?=
=?us-ascii?Q?duz/GSI8VS1mSDoVa2oEMKLfoKamJk9/HF/1TJUiu0pmXsAPUEWBxofTyD2u?=
=?us-ascii?Q?sReCqP+5xzcCkszYr0licj3RyYhz3N+WelxSLB0W6TGCifIx30qDoXa5o9pd?=
=?us-ascii?Q?hg2g8xLh0eyBP5X+WILAurx8FgYuub7ehJSfGH/NhjPmA8RRSIB2RKShxvp6?=
=?us-ascii?Q?HuNLAigZqzTXwUJFqT28esWSOiQbNnwHRt342rM2s0J9axHEuZKuttAfVvkv?=
=?us-ascii?Q?pfWJR9tuA7vUgvcpwrugt3CTRDO0KUnPjxI67IBSaviXOvAaps2dtBBFbWea?=
=?us-ascii?Q?EMUeQQnejftib9Ai/WwjiYYSKDPDPRUaW24s5soX412BgWynx1HbmHbjb/qY?=
=?us-ascii?Q?TQNOR8V6Td2NGWI9/dU2TF9PNdBZUbiGINQJ+prwH2bTXjDZc5+3dFdFsKIf?=
=?us-ascii?Q?A63cc66idvUHUWZWC73av0efB688eBfeJlySj85RG0g/ntgrZN3IGQPjxKut?=
=?us-ascii?Q?zmXRqAT2MwXL1zNXVsrjq19I2mHGb4izxQemxvJVICJW+Q3v7ksTFYbRNMiq?=
=?us-ascii?Q?KsmeX2FBkFWMd5Zhl2dSUvCgT3l2kRRqe8qFv/99a1TGDfV4HVl/afWfuNwh?=
=?us-ascii?Q?LdKQjAM+Toa5159zyYhyiecUihKRBQFgiBQg9g6H204jVGjOM8kzW23DkERZ?=
=?us-ascii?Q?iILPzAorCsPHE9F6R/Rh/5rMZHIrcHBgg4sDFQBo64Nm6KIFhPPorlnEMyvK?=
=?us-ascii?Q?zvk8FNehBoYIN3sbmpMqTHeZb7NZsxw2FTDhjD795eY7y9CqmvRuJAGEvGR6?=
=?us-ascii?Q?+8kOU2fUVehCriFSFSb3gVblwdXKGr6nqIA6gXZN/HgLmDSicMAKsg++tLE3?=
=?us-ascii?Q?5R7TvV/8Yrd3L/+BWMdQ2nA9guUhjWRgsQ=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BcN32P0XzAFlJJ3RTNKvgN8LgH8hWlpM1wiWI/J/2xD+GOtIiUf+slsYyzLH?=
=?us-ascii?Q?lZs93EfvYb/rlecpTvQjT52UxGh7iTmwPEoZ6dtnHeBJLp9dSSL2HIybIjq7?=
=?us-ascii?Q?2sMNbJB+qj1pNxoJOJBbeEYmzVelqQOaSnjNLcDM7WyP2qvt3R+6QiFTgone?=
=?us-ascii?Q?+8hs1WAUz7ULF1wxEqvQMlYgl4PAff5eGGKoZhSawiub/odX5LXS2lj35ywa?=
=?us-ascii?Q?zAw20ixH0VPksYppM1Pz2LPo+821N5rSdfUOgh92bn4mgz2T/E6VeB050PCy?=
=?us-ascii?Q?WsWPht8Na3CEyU77ANJH/UVEJ0tLgQrJGqhY/iW9gyoylsdWi0BwT92r9/Wh?=
=?us-ascii?Q?gH55Dr2CTOHIEG0rYpypKN1wQTmptYRY6aQ7AR4S/pqdDUUQ5umumTtXGxlp?=
=?us-ascii?Q?gUmlR7b8P+NLLXIHav1ufTzz/fyFBY+azrhd6s61HFaKKx5Loo9t62qtS3kC?=
=?us-ascii?Q?qmu9mNjJ2400ihzc5o7AOZSYWsZVTA5F7qndwD6TvGcHFAqHq3ttrVRigrdV?=
=?us-ascii?Q?Q3LjDfFzSWqEb4JtSNkyLO4eNNxTXbm9L92rHGaSvgIZ/NhWkwf1yCDi0sx2?=
=?us-ascii?Q?uyW6J5lDEpAK7fm81DwlUNrZfUN5kiI0lESikPXyqdR3npBsR8fHCjKHP2il?=
=?us-ascii?Q?2dbCyqor5N9WUkQBrnP6Rr2BgFBKIcEOxrAEH+iYnN1gHmJmir+IX5X7Sp/Z?=
=?us-ascii?Q?wH4PlultyEd1wr25sVBmUdSpRFK2H6jCH8I6MCUge5NCxAYFYMsZBAnSuDXe?=
=?us-ascii?Q?mdrMgHRNTGgePrY4CzFdP0wfDY1/La24JyGud16G8x/qE6WN8NfG26a+uCm5?=
=?us-ascii?Q?zzlUbRhSB/33NLgCa66hT5/02UYaGPI21KJpnBzdYSzSaT00FBfk3NqvrScp?=
=?us-ascii?Q?DMjxIGPFDqK3TxjyKG2rRnwUkdDsO2Q6LXjHVG9eF+MirVYbsadIcTvQ0vCk?=
=?us-ascii?Q?fc7aqObM/9c++1hvnj4DdSTft0uAkoJ31elQ33zXyvz4o/JUQh5LpjIIhyi+?=
=?us-ascii?Q?ewKztFyE/xhYrbdbMN7MkcGp54aSvOYxMxduRvybbnCZV4kParh47oTPgMYm?=
=?us-ascii?Q?vTcghE5UiVtP8HYn7vQylibE66rjE086XW9jEIEU2/cwZ18XSRWFUtfZ8lTV?=
=?us-ascii?Q?eOpGyleMFfwqQjFimmvfXCWE+0gSidD5LusgkHgdK63mAcRMRl+wrhule353?=
=?us-ascii?Q?AiVBM6x/ZaxIexPi4q6ECAGE1k337LZlwnaDX3SzpCZ89uZQek6JQ6PTV2M?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a74541b-8b6d-4c7a-15a0-08dd82b751cf
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2025 22:36:41.9098 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPFD3B7C3622
Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
ac_default_item_name
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365FF6BEE204938825A7547BABA2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> softworkz .
> Sent: Dienstag, 22. April 2025 23:11
> To: Stefano Sabatini <stefasab@gmail.com>; FFmpeg development
> discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
> ac_default_item_name
>
>
>
> > -----Original Message-----
> > From: Stefano Sabatini <stefasab@gmail.com>
> > Sent: Montag, 21. April 2025 19:31
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel@ffmpeg.org>
> > Cc: softworkz <softworkz@hotmail.com>
> > Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal:
> Use
> > ac_default_item_name
> >
> > On date Sunday 2025-04-20 22:59:07 +0000, softworkz wrote:
> > > From: softworkz <softworkz@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz@hotmail.com>
> > > ---
> > > fftools/textformat/tf_internal.h | 6 +-----
> > > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > Typo in commit headling: ac_default... -> av_default...
> >
> > >
> > > diff --git a/fftools/textformat/tf_internal.h
> > b/fftools/textformat/tf_internal.h
> > > index 7b326328cb..e145bc83bb 100644
> > > --- a/fftools/textformat/tf_internal.h
> > > +++ b/fftools/textformat/tf_internal.h
> > > @@ -29,13 +29,9 @@
> > > #include "avtextformat.h"
> > >
> > > #define DEFINE_FORMATTER_CLASS(name) \
> > > -static const char *name##_get_name(void *ctx) \
> > > -{ \
> > > - return #name ; \
> > > -} \
> > > static const AVClass name##_class = { \
> > > .class_name = #name, \
> > > - .item_name = name##_get_name, \
> > > + .item_name = av_default_item_name, \
> > > .option = name##_options \
> > > }
> >
> > Looks good to me.
>
>
> Hi Stefano,
>
> thanks a lot for the review.
>
> I have applied all the suggested changes (including those where I
> didn't
> explicitly say I would).
>
> For the avtext_context_open() function, I have introduced a new
> structure
> AVTextFormatOptions to achieve a stable function signature that
> doesn't
> need to be changed when adding new options.
> This is done in a separate commit. The other two changes where you
> mentioned
> have been moved into their own commits as well.
Yet I realized that I need to squash 05 and 06 together again, they
aren't fully independent. It compiles but fails FATE.
The signature change (from ... to va_list) was required in order to
replace all the macro definitions (which can work with ...) with
inline functions in the new header file (tf_internal.h), where the
writer_printf() function is defined as
writer_printf(AVTextFormatContext *wctx, const char *fmt, ...)
and hence it cannot call and forward params to another variadic
function (like writer_printf was defined before).
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".