From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 8CC1F4E876
for <ffmpegdev@gitmailbox.com>; Thu, 12 Jun 2025 02:19:15 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BDDD568B912;
Thu, 12 Jun 2025 05:19:11 +0300 (EEST)
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
(mail-bn8nam04olkn2071.outbound.protection.outlook.com [40.92.47.71])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E45AE68B61D
for <ffmpeg-devel@ffmpeg.org>; Thu, 12 Jun 2025 05:19:04 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=oz+A+Nx2kd/iQEMTSQ516Cv0ISsmmrzR3FoAKZ9xqAx6O4SYyXu4VbvCnzttZq217bSMcsBzR7WLA8GSkXy/lxV6wkWE8rLoW7xHljlV0a7Y6uWIri0SaC0Y2o26f1+0xhxgUf2UAEz858zOPgkzt5C+SCQ41NmNWbI3tFcqUthGB4ffWSm2RA4VaFg0ZvoXVVRMYk8HtGY2lwCIu4pTVNL2JfGSjhZC0Wfe/3DWtDol0G6KcgRb8Ci8BvoszKVHHm3JOYGXzVFTqyUVN+/AkiKrhLZ/xRZVvjsyvmQn4QuV/ICXRPuSREI7oAhnYfBAkWAEGlcG8emCWlFuN345IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=cmL/5rrjzlK0P4pqul8cxPx/ufMsMf57Z2MRjny3Scc=;
b=cU0wGevqlVVMfxNH0J1sZXnkp05kdgpoZk7qGM82SUedeHqMQJsDPimBaPeyAaJieiiaznZnngPKgG0wk7INHq542ClsPIc+DS0KRHpSRpy/UAImeij2UW7iYxq4/HpbWuqbrZRKFW176cT9GadBVwv1Yp58ydYfNFr8x0QDMq2SzX8fNFRLRE8hu5txMzKJHNBsmPT516xUNF9s1pkxWea5KraJKHJEiexbHOEiRryVL0aX8dNS4OSVyduIYIOQF0USbcawz4eEQRqgvEE8ge2DApS3iXM+noLz8ttzilGsmZ9R78lG3IdAZK+/aBpVC9945CEwJpouEeEQYHb8hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=cmL/5rrjzlK0P4pqul8cxPx/ufMsMf57Z2MRjny3Scc=;
b=XVn0OWV5A5s6ofaQ5FvRB3IaNNNUjl0fKehXX+TLzQJK2INDSPa/XuRrge053TXpiYGCTewtlZR3Aykbz5XzDpIJM3tSEQVtFRLJ3ZYLVadTdvYjmhNOgguxQXWRMhF3m8hWSG1mrbzUYZ8TieNTzUzBlMw5GOl3k5snyTVodSoAYGmRtYyS7PeKL1Fgc9mBxNJVZogkAwBnSsLP4XpW6l2Zx/ttZLM0LoGlNms8XTSWhgXM1BQyZ0LV0JXXnDxw48TkqBwUzB2G4bOn7wZlDGqkA03UTtyxLYSfQKMM7mhVOL+INYmTNmxFVS+2Haw7+sf5TzuDyxSMJULehoJOGw==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
IA4P223MB1522.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:560::14) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8813.26; Thu, 12 Jun 2025 02:19:01 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025
02:19:01 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in
mermaid_print_value
Thread-Index: AQHb2wspBx7ZczfmwUqwLxw3x1o//7P+yhzw
Date: Thu, 12 Jun 2025 02:19:01 +0000
Message-ID: <DM8P223MB0365FE6884FC5E5307D0AC80BA74A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <20250611195725.95154-1-epirat07@gmail.com>
<20250611195725.95154-3-epirat07@gmail.com>
In-Reply-To: <20250611195725.95154-3-epirat07@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA4P223MB1522:EE_
x-ms-office365-filtering-correlation-id: 219a6a57-4b60-4fa2-968b-08dda9577ef9
x-ms-exchange-slblob-mailprops: Cq7lScuPrnrJkrZRMGqfbGlyUI2Iaaepr/KhlnMDmt8guzPineTxNQvRPgF2bbLCjBVcbnFsh25SNyU7nVEuflkdrISu/wwyza2xW+FB6EJ5R4WJoh+FGq4LPqP+EkpEb+RoA/EvGHYOvma5RMfKhZeVmiYg7sKDUotERjjI6QOIZwmzYr7jQb87nEa9gf1y2AItTtfcp4wp5pg5Z7klksDcsPEcFsTrsNq3lkzcWjin33wRPxpoqwby5A8K4EhegB0H3PqrN4CcPwymAGjODDgwMLcRThKKpf6w4eBgCvn59RmkZN58WgpccFAAIzsiCLFfqWHgbEBJ+vU3GJL8HARU8Vq+WxfM0PzZuq4/tksokwhkjdoFqTAcDooCbmCIxizr3NuR33eWeE1vZqlHKeifDifKzbxYfgnMWiceeVhGvhsjeAsz2QfHfPaF3Sk7JIgGZ7qoR4cmBCosL9b2wBxwMiVfdhWnKZsfKFlrFgh5bxhyVmRN4ucmwfrLNfwUVWNR6dWgQYtjGcWL89QOLS8hwwCBNUK7i0lStyyDSJGXRvIbu9rkGlNrj8uPCTPqAeYJPjjLdl4P7a6LlFsore+Dgx6VsWuz8zfzbDvzKPQ6ktiY3qpl8DR1d6RZ8Ij6xKDBcIaSVUyYNW1V3lbB7ANAu/lILeXfkvWDdxZXRAlT1DPKbXXWtBn95RNqwpk/mcJaUf1Wf2slfhx/z5o1/WvvfZLdj4quTR6/UpdMuhVdFKVy88a8e6I8mRIGV/icfmtMjLXVCt0=
x-microsoft-antispam: BCL:0;
ARA:14566002|461199028|8062599006|7092599006|8060799009|15080799009|19110799006|102099032|440099028|3412199025;
x-microsoft-antispam-message-info: =?us-ascii?Q?v7QElH4Z8P2OVW3chptx/wXGXmhxfyGc28Bfdb9ROipWAS/wOV/kmRuZwSUo?=
=?us-ascii?Q?jxwvwd9qaS4CHlvXdcfg9P4zl+GCdu636gyXNHe3E2MbuseKr9RCaNw3LMTz?=
=?us-ascii?Q?FTin5Bh4AxkgBi4oz2QnhwfOOx7CqYy++8mQpmunm2F2YZmyxp5e3OU+CJVW?=
=?us-ascii?Q?8vmQDjWK3ru3OXjtp1WcXM0qJuhzZnssMBjwkCJAlkpqJaSizs51Ih0W4ZJk?=
=?us-ascii?Q?/DmSz5K2QScj8jGv9A7GQy1u97/ppKdtsLgF+m3vCQZINbBtsG3AQIUKmkwF?=
=?us-ascii?Q?SwM3ewyYEG4dZkpMbUdd6TceMAgQ2D7vPQYeYf2WnlNttHq/0VE5MguFT3QZ?=
=?us-ascii?Q?AeOBZrWRe+H7mCsSgAQfVMbPEeFojyMYMHEYhTc/YC6oeLpOEeB8P+YPnCzX?=
=?us-ascii?Q?9EkAyOJWilVLRIAKDxbMWOLkrwDl8O/SZ3NkKeDDCndf8vhANE8ZWjqCkM4v?=
=?us-ascii?Q?K8xqyTxuMqo72mD0QifMswub6HW4fpgYsAOArBK4/JTagGIph71XW8S6xLXU?=
=?us-ascii?Q?2x8MTKLUKdT8YfUtDgQO/XHuAvu/TgfQ/3922TQKE7Z15DGqKslAV+n71X4f?=
=?us-ascii?Q?I6zlp/eLUvYuktyGhwoceeqodd5eCswkLyGjeCLuLOMNcz4tqvMfRxRza6zt?=
=?us-ascii?Q?aSQGd80tw/7Ft2gkq831EXK4CcIjNyZiaCrM9VnNRwtBo0ko/fNYOjMKYuuE?=
=?us-ascii?Q?OAhHhOZdsn8mxg/0wLspu4oRLYX1dhxTe6cppjguD7optRK+AzNJJIOSZOHb?=
=?us-ascii?Q?4P64v3z5ozo0agwTT4b8O4pUEcbiTNrxZF3Rpz2uUVpFQpGFSyAidWJ6TrRr?=
=?us-ascii?Q?WPcRwiMDjlAcigjYGfptwsQaH36zE0Y8sNDRWSkU1MnO/ipyoQZidAdl3b9b?=
=?us-ascii?Q?5EGmJgXgvAikmb+WJOqJ9i2QHus4x5mPRirsX79/8x4JV0NiHu5kRQjR1jsK?=
=?us-ascii?Q?9V8E3Ec4RsK+pq607YpaPi5CFPSOtzwST75F5DdWFmIwTj+g+Uim9IaWCCk+?=
=?us-ascii?Q?FSyvoNsJ9ZYX1Ef/LWyVQkH+A4FC7sx2tLXGCFISVeDv6z9OIIteDQ/CUzub?=
=?us-ascii?Q?5XDCeenQwTlr4LRyS+KI28JbVbb+a8bxcK7Vskos/iiJj7dHG9c=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RBaqCjc9NwyY85VwAuf3A89IH5X0zkUZl8vXJJjGQ7OP7fSwVY7hcDzTUyfx?=
=?us-ascii?Q?fXP8gxkTFCyXkuEu+TwRbTIP2XkDU4muoSm7le2KNlo1cUE/PmH++RhJjFj1?=
=?us-ascii?Q?nVesUaCq/09LyALq+XzklfLbtD6xsCQXb5HZKbCMJ81bbHjEfKLrwUxG9s7b?=
=?us-ascii?Q?946baqc7jpVi6EfFR1kB31YzPOjX7/dKvtSXCRvJNNfwrwyTD2p0LkRRM8y9?=
=?us-ascii?Q?2FiFqBb4O/X9Gw4C4OmjIjFEc3fIHnfsW8sZCNEtoQpT1xAXJOawuVKBbgcR?=
=?us-ascii?Q?itfspv4L5xdv1yVC5yC+KYbAvRbWFj0zd7d4pIxDWKuuATAbAyvznypGfmoX?=
=?us-ascii?Q?a1FFYjiFEUoJtoKor6cXD8czf3LR+n8Wsa/AHQoMa+bIGL2GDyK2Mt4dDDXb?=
=?us-ascii?Q?qIknYT2avnE+g2ujINtiwk0MRQDsq8swn4LUV6l/UGuz1wT1g9jj/bUA/fbB?=
=?us-ascii?Q?YCaMhuDw2dmJ3QzSOUXHoY4GOZV/S/U4UYBRp08LAFGOg9JU6O3RK2Ozmt5x?=
=?us-ascii?Q?yL1WczZNO+JC2vYGmCB/L4WT2tuqjy/gsTGoaF11VRya592ZxKLm2BwPeYZz?=
=?us-ascii?Q?81xYmmub1M5cmxpIJl1UeH7dpLDqK1wW8U8dtMBsDG/iR8LQNKe5IZm0D28p?=
=?us-ascii?Q?3vi1KXR0ITTEhhi3gc6fp8X+QeAKi9V7mtig8RFLshZo0UaXeuz6YLvGjrJG?=
=?us-ascii?Q?vUJgiu45R5Zhgw4lEAmch77gg4tpCBhwINM9fmXsQRDycl76sDf7PKmIIUC6?=
=?us-ascii?Q?FsfBt/cGNQr5CieQDYKIF6JKFRF8muTO0w48cAQK3Wn2iYSAWRvK3uV+wPkx?=
=?us-ascii?Q?cpx91lxd4HuaMhFM+8OCFyQT8tynsUIVc/GUZowRH3cnxvXCg675aVGltDvv?=
=?us-ascii?Q?o+I6Rkz0M2adJ1IflgV3ts00efV/dFhC6cMocdlOX/LsVS3nVNSkFqtMQgtu?=
=?us-ascii?Q?nqRcdleCbul0rddCf+Vndcb65oow5xHZT4/a8dvvzdcUxRsS2pl8EazLQ7Gn?=
=?us-ascii?Q?OVK7nQSu0DzsRz/uH0aJGmNRs1hThi6r5nB/0I0sqYXVfrtj0r0lyUttEFX4?=
=?us-ascii?Q?oy1kKQwY1AzYa5IpmY0c2Pri6BQvSAtzoqt04OJzXWiTQnqFMyQ4SLDGa7ll?=
=?us-ascii?Q?kViE+WRyV0ltdxUsFnup4vboPEbPcRP79TOaztz9qZkxDr4LQnfweG4CbKD8?=
=?us-ascii?Q?OQO7JhDQCKpEolse2YGyeLiYOc4DV8PZUtMHFQtwT0sqQKKKNsk9HBtr7pU?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 219a6a57-4b60-4fa2-968b-08dda9577ef9
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:19:01.3426 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4P223MB1522
Subject: Re: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in
mermaid_print_value
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365FE6884FC5E5307D0AC80BA74A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
Hi Marvin,
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Mittwoch, 11. Juni 2025 21:57
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type in
> mermaid_print_value
>
> Instead of the caller having to indicate if it is passing an
> integer, just use the fact that str is NULL when an integer is
> to be printed.
> ---
> fftools/textformat/tf_mermaid.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fftools/textformat/tf_mermaid.c
> b/fftools/textformat/tf_mermaid.c
> index dbe489a7a7..da371c8fff 100644
> --- a/fftools/textformat/tf_mermaid.c
> +++ b/fftools/textformat/tf_mermaid.c
> @@ -547,7 +547,7 @@ static void
> mermaid_print_section_footer(AVTextFormatContext *tfc)
> }
>
> static void mermaid_print_value(AVTextFormatContext *tfc, const char
> *key,
> - const char *str, int64_t num, const
> int is_int)
> + const char *str, int64_t num)
> {
> MermaidContext *mmc = tfc->priv;
> const AVTextFormatSection *section = tf_get_section(tfc, tfc-
> >level);
> @@ -587,7 +587,7 @@ static void
> mermaid_print_value(AVTextFormatContext *tfc, const char *key,
> switch (mmc->diagram_config->diagram_type) {
> case AV_DIAGRAMTYPE_GRAPH:
>
> - if (is_int) {
> + if (!str) {
This is not right - it would print 0 when the str is NULL.
See tf_xml, it uses the same pattern (is_int).
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".