Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend the argument for submitting patches

[Soft Works <softworkz@hotmail.com>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 12:08 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
> 
> Quoting Soft Works (2022-11-14 11:46:49)
> > > Sorry, but you problems are entirely self-inflicted. You have
> been
> > > told what changes need to happen right from the beginning,
> > > repeatedly, and by several developers independently.
> >
> > And those are completed and settled, like I had state multiple
> times.
> > It's ready for review for months already.

[...]

> 
> Some random quotes from IRC:
> 2022-09-01 00:25:21     @Lynne  elenril: I never retracted my
> insistence on using the native frame fields for subtitles
> 2022-09-01 00:25:27     @Lynne  not sure how softworks got that idea

I got that "idea" from this discussion:

Jan 14 02:46:02 <Lynne>	can't you really not hide away everything to do with repetition, subtitle pts, and subtitle duration all into the private opqaue field, and give the user what they expect when the frames go out of lavfi?
Jan 14 02:46:55 <softworkz>	worth a thought, but I'm not sure
Jan 14 02:49:32 <softworkz>	I think it's better to make it more transparent. the heartbeat mechanism has been a hidden thing and that's why it wasn't an ideal solution
Jan 14 02:50:10 <softworkz>	when you already need to understand when and why you need to insert a subfeed filter, then there's no point in hiding the effect imo
Jan 14 02:50:53 <Lynne>	I think that's worth a really good look
Jan 14 02:50:56 <softworkz>	the good thing is, that often none of that is needed at all
Jan 14 02:51:15 <softworkz>	(say sometimes..)
Jan 14 02:52:04 <Lynne>	if you could hide all of that into the opaque field, I'd be happy with the patch

This IS a retraction from the "insistence on using the native frame 
fields for subtitles."

(because the actual subtitle timings would be in that opaque field)

Regards,
softworkz

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".