From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5DDC24E877 for ; Thu, 12 Jun 2025 02:08:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 53EA768B722; Thu, 12 Jun 2025 05:08:38 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2104.outbound.protection.outlook.com [40.92.42.104]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B419868B23A for ; Thu, 12 Jun 2025 05:08:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fU9Qn5zamOpxx8pbBSBoCoOH5n/SO1YayQfbskRgKflu2k7Y8DfieiTHBbnFyo1eOCy0RtJPAaOZFlmtTxMTR27iNMECaxw08l7LKhluprgSIO8H5qDnvTkV4Fd2i0TcI3y0dTt7ej/ewSrHAQjhSTDxw6Zi02uOc6oS58OAsPdhgkWnzv2QBhu8kmbYR8yY+lzM6p368X1eq7aQceSPfMhqHarHM2md8N+sZJXVYpWHXFB8y93yT/qRu3p8mZhbg0g09xs7qIdE3Hk0neCZRdq+kR7tc2kTzfwEJXoC8F1W/2VPJe1viciE6yaufUkifBCzo6EQ8PWQ5TxIGXtPcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ga6iRmq9jObVSjsBhJYcO+JHSdo+yq4FCtEnZ06QXpg=; b=md2w+RcUaWjH5fsXmq4i4n+y1Ut/8uOGNp9efRFKNznAk+Mw4duWeaxpFNIJFiaJ4pIcg7o9qNEALLIGE80oR3X7agYNuhWeucJtNHaU+QmURi58pRfh31mEkhsXhnHfh6rXC9c0r44lCpaPPcHiiegLZsmfpQno2Iv+IoTqpqK/e7CsAUIQLAPaO5tc0Ho0jB/QgPCBcFWjwdvge2mU/MDhXb8+/wgVHsqlWxgDTRQbQMLExl/pn4rQQ7IGZKy/W0w6Tk8IhR8QwFj+7f8HFgE5YUbAtn/DmsdJuDBc9ISqDDWcGw0J28h7q1E2MR6Ndi9PSubYXl4OEnCERfTu4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ga6iRmq9jObVSjsBhJYcO+JHSdo+yq4FCtEnZ06QXpg=; b=rMAUsDdzcNa9vUaxHLjTgUl+dQdqGvyHHa+woGFUeqVC4xa43qcQzsx8CRgvZ1rQkYDXuksgyUM5mPWGUWHSuL6SSrAoLgqM2FCsTv3KXhY5kkJ398KvyaBvwfvC31wdKN+lK/yhuLkz9fXv/GM7HxrN+1giWUYx3XLv+v52s5suI19nNyHaZbr+YpjfS91tDOzUvS+JOLW5+V49oSbH0WZr1OndmWq8g2tcjq4PC7OTUBKbhYDa25dJiijejqFTNHrChMI4yWRNm9YAwleob1CA8t9/z5BR/H/9+J2BCKx8tdOUtAWDfXKuHNSmiYnyxM2rqV4Hdjd6MeqYaYRsMA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0134.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:147::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.22; Thu, 12 Jun 2025 02:08:26 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:08:26 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value Thread-Index: AQHb2wsjNOC2EKV9gUiEr7ZSp+Dh/bP+xyyQ Date: Thu, 12 Jun 2025 02:08:26 +0000 Message-ID: References: <20250611195725.95154-1-epirat07@gmail.com> <20250611195725.95154-2-epirat07@gmail.com> In-Reply-To: <20250611195725.95154-2-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|BN0P223MB0134:EE_ x-ms-office365-filtering-correlation-id: 0a07622a-0452-449e-44e5-08dda956045f x-microsoft-antispam: BCL:0; ARA:14566002|41001999006|8060799009|8062599006|15080799009|19110799006|461199028|7092599006|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?UOVlsozpmuDATa1RhC5xskW9EYwN3R4KSEx1GS9T2wcilPmKllOyCAPkqMR+?= =?us-ascii?Q?y5O4YxDQLPk20lasazuNzxUO2QE1x1O6stdmBHjbsR7NtFkdCPAWKyMj0y2T?= =?us-ascii?Q?V5UHCrTRTSOkujTCcyI6w8kcpOGetKvhxI7HLynqnba9QttrrhLDY7Rn7uVZ?= =?us-ascii?Q?JqiwuCYOWl2gJl2rOnIk+wShHiW0JGNCLYsAG+EqNRWEoF/aXgNp8hPU0Swy?= =?us-ascii?Q?q/Yz/A0BL+6HDSI1vAlqMG2NrCYMetNdnUdclThxHQqZZu1AlQmuA6JR1Agt?= =?us-ascii?Q?GGjYggxjLOXZ0EH7FvsEAUhrMZgApMieLU6IpUQ4AhDOPvSjLa1ZhMa42UH3?= =?us-ascii?Q?lL7Btfg3fg4GDfBsLoq8sBx3b+VHOMRRtQIQ/+69aS9UAQTj63PkqbdiCvSv?= =?us-ascii?Q?A9yCget+3vf0ZOSJkfpUqr1OA+fjHNl0aZY6m98i+IFa/tPAnxBZ5o/EvhJU?= =?us-ascii?Q?1q3Yff7/Mr/LIUcaUBdPr6pvbx9PLtTkuH0RPnwrnxH3ZRbTLOuPfmHtF14t?= =?us-ascii?Q?foRGwqfEUYI3nLnhqRyTJJHA5kEStiy9ELj+HNqbLtQVORSi90IsXbIiIFho?= =?us-ascii?Q?xSN8wju4ncrQesk4FgXdH5CfeNjuZbhEV8uVwNsBbL5eNYg35tfJ08XWrfho?= =?us-ascii?Q?CSMdA8tODEUVsqPIKP9eV158JgXpxB4C0qnW/MTDHDMp7IMWOOcp7aIoSt6C?= =?us-ascii?Q?wNQTrdLgjLK7UsRrC+JeCJbj5wTz4Jup7u4UKeg4pEhJRXYX2D2f//cvFClY?= =?us-ascii?Q?3LAHoJVa2Dns/J1L8DCXj0kRqsWTqcYNw5YbbEwGBwHuhKsNSMQNQkw/7+A5?= =?us-ascii?Q?ygRk3IUMSgt+9oH7PTPJl4rC2Xg7d7q3WnBMLkG4l9x3CEYf1mFCOG81Tz/y?= =?us-ascii?Q?Pv9V8IT/Djtsl8Fws6U6mgHEB4TX3RyNSaRWcaxxZsUeelwWFKIlzGFMX2YY?= =?us-ascii?Q?uryBmEdu07fc3cfrnq5Qalx9bebvYNBWzSPNCO1dSgpl0GqdzqtzithAMA9L?= =?us-ascii?Q?lHh4J38ahN866s3tBkpjMgJfFmzHbBgOQy/IBDYogu2QcIoXo6veMXSq8UkE?= =?us-ascii?Q?qLgEGrOnfM2w/H9OwSF93j+rO/vbyvyai9xl/wrnC+ZxcKzRDiiQjwb0yEfd?= =?us-ascii?Q?5aFmhTuVoqQhMPVbrlQSdhGZek8xrRmubA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iT5rA1Znbd2noWT4dAYl66gKyWVMllvnDRRWY8KmHawflMT9jGXxk0C3oEwc?= =?us-ascii?Q?BZJ3Dp1yejfdbBEIMXBJtm3q0p+gaTt726lckFpK7csUT1WlavwVXLBFd3br?= =?us-ascii?Q?QJexJUYj5CSBKzJpzRP0pkF6d0pCfTDLsP4R2AS9lMK2kIVprwj7yY0FCGom?= =?us-ascii?Q?J5sG/cAUyPLgLXj4P7R/I1ZtdRQ4KwF8TPadrXTqt7f+y07eUkgF+0UYnlMD?= =?us-ascii?Q?IELetJpwtEY/pc11MvAjbXk70NH/uK6sQg0Twr8f96D6faaU9svzl8j7ZcKQ?= =?us-ascii?Q?UW+B/iMxEhSJczjRoKhis9mrLhgoXajJ7vcei8l008siw1IKy/iSmwHB0Nar?= =?us-ascii?Q?gVNyNSBVDG2HC8DaOF99mkVzCDib32pyoJLHTXLeDmi2HD+LHdnhurM74Vvb?= =?us-ascii?Q?R751w66TKqPkyuU5k9nDpsC0lKf5FGBENqcWJxN2OTAtmpOr31YEQUQS8eDw?= =?us-ascii?Q?XKkrK85GI1YWnLUxZ1zd31yZalXVzVufpsaR92aSITmNFn05FRX6piRv9czX?= =?us-ascii?Q?HGj86NIETKqHjK7vY1V+nGV04yd5FfXzphFNZ5IzqiH1tgrNChPBuEchShDo?= =?us-ascii?Q?kFBCpc+iEAXWTX1nALMzTLCpHST7L9H1QCnuUGrAuSGgOPI7I+2mwAeij2Kr?= =?us-ascii?Q?AIu5wfzNPDa+kEPMoVt4iIP4uhYV2HqV70XVhTgIZJCR+7a6XeKvNROqyoa0?= =?us-ascii?Q?swOMJWxOWSSbk4o/47xL0uNKfNZPf5ohl2JjD9iZMpgAz9OBaMZqKlu/CNXj?= =?us-ascii?Q?wpQ2ifV4OI1xA+s0gT34j73sug/G8i6PJ896z+52PicRONep/rnAxMKEJn7I?= =?us-ascii?Q?A3Q2R2UzXEC6y/pJgJ7SS4MCOKwmjpLxHYSk1+AjtX9/2/nmxOLoYPmRkYdy?= =?us-ascii?Q?PhiDnKxzipuNion0XugxneqJ/R+oA+xxL3hUXxHuzfxH0+XerEmT1WLBTytc?= =?us-ascii?Q?c3ZQSUSOmMaccDsMrS02BAl5zrn8B+M//wQjo+K+jgLIp6C02jHes6/YXH2T?= =?us-ascii?Q?CSpqASnZjCLTQrzkqT264QuK5/n+kCmJuTKThNvygQX0U9Vxrvl8TnsFsH+D?= =?us-ascii?Q?BAM0ECm9YnCtaXCtamGdi5fqSjZJ6P86nE4bFGXcO1/gX5QZrhdk9A3SvU16?= =?us-ascii?Q?BoeXmZDaiqVP4aHWBAqkGVPBwuI22N0SoOXVioocchQSIOA34CdzVxRqF/PQ?= =?us-ascii?Q?5S/hic2QNhTM+mA2QKwN4WcsDV/Z6hwn6W1PQCPIG6SCzOBJOsm6KkjQfqc?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0a07622a-0452-449e-44e5-08dda956045f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:08:26.1649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0134 Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in > mermaid_print_value > > Doesn't change the logic, instead of exiting in each of the two > branches below, just exit before. > --- > fftools/textformat/tf_mermaid.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/fftools/textformat/tf_mermaid.c > b/fftools/textformat/tf_mermaid.c > index 59b11811f1..dbe489a7a7 100644 > --- a/fftools/textformat/tf_mermaid.c > +++ b/fftools/textformat/tf_mermaid.c > @@ -579,15 +579,11 @@ static void > mermaid_print_value(AVTextFormatContext *tfc, const char *key, > exit = 1; > } > > - //if (exit) > - // return; > + if (exit) > + return; > > if ((section->flags & (AV_TEXTFORMAT_SECTION_FLAG_IS_SHAPE | > AV_TEXTFORMAT_SECTION_PRINT_TAGS)) > || (section->flags & AV_TEXTFORMAT_SECTION_FLAG_IS_SUBGRAPH > && sec_data.subgraph_start_incomplete)) { > - > - if (exit) > - return; > - > switch (mmc->diagram_config->diagram_type) { > case AV_DIAGRAMTYPE_GRAPH: > > @@ -630,10 +626,6 @@ static void > mermaid_print_value(AVTextFormatContext *tfc, const char *key, > } > > } else if (section->flags & > AV_TEXTFORMAT_SECTION_FLAG_HAS_LINKS) { > - > - if (exit) > - return; > - > if (buf->len > 0) > av_bprintf(buf, "%s", "
"); > > -- > 2.39.5 (Apple Git-154) > > _______________________________________________ LGTM, thanks! sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".