From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BA7984D9F6 for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 17:40:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46620687DA2; Mon, 21 Apr 2025 20:40:29 +0300 (EEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2035.outbound.protection.outlook.com [40.92.47.35]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A42C687D19 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 20:40:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HPjhun3EbPk0mvGpuEyGS/KV2Gzs46d/akCnmF3+d1hgjjlGc4+k8WDbYk2xgM+U4OwkcL/w821/aUsLGKwR+kV3+92yuu4Wsfbr0rWMj8EJxfbpDSP2L8LQrfqGYpEGRdCSRmYj2Mu5j2PEev5l7nkPLqCshmqupm0BmjPFBqcfshC3r3PXB2Jb12laGELjtfDq3ojypohWszwiO0520//zz8RVhZpPqgdFGULWcb67M2qz6ig85To/1L1w6ixWodqlfv1iVF0TpP2Up42x3W3qBYjeONtKs2F4cyI9jvbNcl59RJiD8qDivesTB5O40TysnZ/WhmGt7tUSySGsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O3+nkZTNTBVF0+55fDC/VrFjmNkD344Q6plq99N5jfE=; b=FPKKRh1QB9OfpW/GdFK1dbJZBWR9I3hAMXCHMYjjd4/tDRKeaSIteR7Eb1KGzDlt3/JWqjvM1UJyGcpfRU2wMRaAWdKaXcqbF/hqB/92lNB7Y8BVXJ9uAew6j6RA+H0VUYyDUHoa/bRQm64EVYLottY8WHNunz1FW+nkJYkWMbCptWoqhxwI0SHAooAAb4SOnzB7PYozg8HK8nwMKZL3iQn/5RbC0kvz6AXmbXQY7jiXJzzb7ZOhYq+Qv4i0EFvVH5uc/lzweivTVvtdqzW7ekOgBu1e19gzO0qMNJUwY2wCcE8W3Y1LfVzq50Wgd8OaUIIfoChgqDlumf9HJlscnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3+nkZTNTBVF0+55fDC/VrFjmNkD344Q6plq99N5jfE=; b=AmZxL35+RE8a4+MhwuAJSeTmw4OcSuOqJQ8LWgMIi/bSbW8s9wcmrNcqKqBjtAdQ6YjbceNLCjQobYmqYc8Mu6DOLZrhDp0TbrR0a/NqqDiVUExgk/ttvUyRy9hLSRU7Ob5en0nHO3mVTAsUbqnWNHxSTFZddCXjK/v7HQUxP8l6fLsqssQ12E9AeQnGtQojOV2IPhejlaexeJZ/FHZ/0r+TfQQ/cRmd4LJaPSdKqAF6DdfOuqqT9JbPhbYyVbAHpEhpGm7VxlIuudiPEQfknsNpWbDZqFCZIBUsiz1eq7SClA/1QLXdFgR4cCqE9qrEqpGTk+BoBZhMRPZGLDaW4g== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ0P223MB0661.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:47a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.35; Mon, 21 Apr 2025 17:40:19 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.033; Mon, 21 Apr 2025 17:40:18 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements Thread-Index: AQHbskfirCLvbbqOdkyJVJI5B+Lqm7OuXckAgAABJwCAAAU9wA== Date: Mon, 21 Apr 2025 17:40:18 +0000 Message-ID: <DM8P223MB0365FB5520E9B4855A131BF4BAB82@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.66.v3.ffstaging.FFmpeg.1744945024.ffmpegagent@gmail.com> <pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com> <1516e67a5b216022a1ecc2292ee8e2989cfda192.1745189955.git.ffmpegagent@gmail.com> <aAZ9hFakRwILdeRP@mariano> <aAZ-fCizfRETc7vG@phare.normalesup.org> In-Reply-To: <aAZ-fCizfRETc7vG@phare.normalesup.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0661:EE_ x-ms-office365-filtering-correlation-id: 784b8b69-08be-4f71-9a70-08dd80fb957d x-ms-exchange-slblob-mailprops: Cq7lScuPrnpFX5gNBgVui9nZ6J+Gucr/fbbMAVQH/cAOkydapWKBwr8sMV3uU7dO1yImCcDXKJoc8G0Zk48XftEXREnBJ6s796rprTjM7z1++e4SuX0v6LTJyGBghOzLbOXQ3y4nLnPtXUlXYw7jPMydL+3eyuUCoV9MLhj+b5t3CwwlOs3H2TQHa7I+qZ3tKuyUh0VXgi5EqE2brCtBmjFvqpHeK4D8FRyQORtrFvpeXORNtaqlAobWWdkPraJ3mr7i1TWhInSNCU9+KCcjvsMDFXqGr3SoNrBcDrkg8Uli81vCMr+6CA3Sz6HRzS6heRY0WdyDeL5iK2fD0f/ouqhe5gJ46SVM7zlXyG6dH2ia5jJLp4RGhyDPjZZDLL7m3PDMPYYeyC5GUXpHRUOFc5w6dHnoh+RZgVVwUgXVioiAYv8RQBE/19MR7ceQfkNB+0xK+RpXC65rKDOL7j4GCimZyhiyu+trLbD2kl12TtmMuiWwPBtrw2WF55hoWuKXif4CfR/uI6qWn3oA6eRyiGzWDa7PPhEIaIilrP0ov4TgczkQjwSJ3NnPIxFiVbXKGkfLcHAa8joh+Kwt2d3xlt4W7dxKx+OowBFJabumD5vWxrwm8Zvn/O7693PBUhthrF1nf/rxrDs93dmat0h7KMceBCwkMZ3DQrYTyw2xhX3ZU14Z1Da9xq+tU49eKnr+FdVRVNUhmggjE1vhYIWB1UlaWGbsuTSdMlLgPy3PjyUhPex9P7WLf4oUKJeKmie2ay7Uzk23VMw= x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|8060799006|19110799003|15080799006|461199028|7092599003|440099028|3412199025|41001999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?/NAiUv9Uw3L0xSpK/Uc2BAwtVAz4aQfzgDC48+aFtFaR5zR/8Vk98lyIzYLO?= =?us-ascii?Q?uB1bcAJ1AXD+10A4tziVFsMweK8LXeVuUsJjb8QYFIWrAXDHCLYWC60oxMjH?= =?us-ascii?Q?i0tkNjWD995UglcLl/K1QUvC1xugHZdl/hcz8aPkSfC6r1h3Jy8k9vboLejS?= =?us-ascii?Q?r5NVB9usstNn7ytc/6RyWNQVpNINbm0KmH0stwvbjAoNg+EgVTGOygsM/ofM?= =?us-ascii?Q?1IwYj7eGrKeJNhXYpQC8UHm7izKt+jruoYFvfW/3wGCVSKrG1pkxm+H4PhJe?= =?us-ascii?Q?3jy07DgvuGwEJp4Ug2Mdj+u+Kh65rZ0ncVcXk5pt8EIJJy2vbRsGqmKOfnWS?= =?us-ascii?Q?f1SwRa5ptOJK/yzAhEGRiFcfVy9t8lK1PTGXiS6XPFaBWehWsXiPGtx0wt2x?= =?us-ascii?Q?DOtN+A9JxATOn1ngKeDrZBmVLvKKUGsMcYGXIIvW06LamfPgR3gl0d/8Gzmo?= =?us-ascii?Q?AXdty+sD2k1P8FIMOZi7pn3pD0MrtqhHspsN+HapJePLTzNIjQC8+IZblU6v?= =?us-ascii?Q?clfhcaDVRqoVAUvCRlsCZR49TZDskpdb497Ukcc+AFOqVtcC8lfahwqWas5g?= =?us-ascii?Q?zZxp958u9eHrhxwwA6oj01TF6F6p0oNZX6SKvOCrr8bE2x8O5YFMqUdZb8Z4?= =?us-ascii?Q?AT5ZGb0ARoqnR8SDg0rmmewoiiazy0pG7KgevYAuxODEhi6wV8lY79uT2L4T?= =?us-ascii?Q?kgxtQs1NLjRceUtnfEoarjaPXWRuk//s62z0oFA7GpGg2QoyKdFPbF/t10hy?= =?us-ascii?Q?YE+gCkJNRyIG6GffVxxIwtSHw63lRhSgNMsWctnnS1Fqq/mrMPvxHehwur76?= =?us-ascii?Q?DMYNEo62z7IsfB5PGGv9nA1lIyrGaQHjV4MSFjnbaJz8e3bh7syx4eQ2SqzD?= =?us-ascii?Q?qS0zpLbk08473xCHQSBl8FovCoR5cImDrnRxJCBxtZB7k7ZuMhfS6gv+pFzH?= =?us-ascii?Q?Sy7WBVJ0r8++tUDorRkJjDBQ/kAf5qMzL19Pwi9UnjhVQByYAfYZ23Z/pA1I?= =?us-ascii?Q?PfpOxv3jdyXRA+77Eb0mYqlY5bdFCOVGxgoIUj7hnYkjeRRQzA1yZVPEpBB+?= =?us-ascii?Q?p1zS5C9VH9gSKOm6R1gAPHrpKJ6LMERi0QLfoBxVzJXLmYUnEBhmXKZvJSu0?= =?us-ascii?Q?fi2Xb4de6p2d0SlHcvPUk41MMcnz/0VjFQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mqby4VBNQpDNFN4jBD64FRC4QJzz4/pmi7IypY9qPKymyv9sbrVRWeyPcGmU?= =?us-ascii?Q?ysiNNtzkMFPmb+c8BIF5cqNLO/hhsRXUUTyvkRMgoMtVlv3fMH9Lo2XRbpas?= =?us-ascii?Q?CPz/q8+FaRvOaQ3SE7BlkaqxFT8ARrmNmdIbYnuQppBbBJfgEZFO1TTIQ7P2?= =?us-ascii?Q?d5PsG0HNC2BwW0ww8qfkQYIZjHGHFnxddI84adp92jtd/Mvya+baAWflx2fW?= =?us-ascii?Q?ckBQMa2aW2mI4Y95uwzPpQyJEDIPUwk0zhVN/pMqlOW7WPWwXrYoZvIO9cfl?= =?us-ascii?Q?sO3s5sK2YCr+QUI9ARFTMxFZ6UmnhJgjpGgBd72RKA53QnGEzZcntj6w64P2?= =?us-ascii?Q?OMpUDKdFnMaWok/AyLL03rqDIycKPxqG8HRC5fcLZqoVpuZxlf3SlzVb4vpU?= =?us-ascii?Q?hmsXl92ct62aiUDlezw/rFsTpsMGEEpa7IqE/z/skLE+OssXpn/sjrEc4x7B?= =?us-ascii?Q?tX58h42EeFpWaJ3vqUNvsIyl5P1G9ZRfPcpoFhDjWBIKruMlQgMwsSJeioQ9?= =?us-ascii?Q?Anf9cZgk6Mf/0pnfD90EP6lcf5QFG2JLcIUNwtKwa8tRuCaIGuzKjpW0R9Jw?= =?us-ascii?Q?s0APk3w01iMso4JyQT1Jv1j0OEbv5pgsFD9O63aZH6OA08waR0un55NxSmQ9?= =?us-ascii?Q?XCjSXwh0HliGCtxhsUzqD3OndtbwoeAokJH6UFeozur/lAmPrFkO82D2enBx?= =?us-ascii?Q?5MYzH3cSCRTNzZ9xALEZCnTk2x1BWx3RBUzufkagyWXfdsgsZMY22O7+UVjb?= =?us-ascii?Q?XQi/8+vAhEyOOmE76H5gBK0yq/gKc65cJGQq+wC9AF3OLIrggZR6Ir/R91Ry?= =?us-ascii?Q?SfszaqqKVrdsmr3L33iyucg7x7qDU5m4AVY3oAxYqIKWMi6cL1PrliA+N3W1?= =?us-ascii?Q?g/4pzlcmC8FqcXlZuSBg2hnC5c9Zab73b8SeinSWbW3zhLAJaIeVCZTyS9GS?= =?us-ascii?Q?TZw1HPg49od6IkybzyecefFo8Y2s54Rqo/eL4+B7NzEg9StwmqUJk3ZDRRFK?= =?us-ascii?Q?YprHxfVMkQS4Smie12jctn4FJxh4qVd7u8sv5D4xsf/DiRTHGmrTTekwwgE3?= =?us-ascii?Q?rNV3YDLJ+C6mJ3stpwoOdWszX9BsblHmm+7IpjCknD/avj+3JmLNynzcv74w?= =?us-ascii?Q?GKW3uetTRPz8V0eqHqzlbKXOpc6QWsUWkIhIhQuX0SBndHb4JwN3FG4rWE9+?= =?us-ascii?Q?6y95vnGn28ptE64Fn7RjJ1Ou3JsXLIBdnQKp9Kz66a2HPKitrFWbYhHVZPE?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 784b8b69-08be-4f71-9a70-08dd80fb957d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2025 17:40:18.9217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0661 Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365FB5520E9B4855A131BF4BAB82@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Nicolas George > Sent: Montag, 21. April 2025 19:21 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements > > Stefano Sabatini (HE12025-04-21): > > > + if (!pwctx || !avio_ctx) > > > + return AVERROR(EINVAL); > > > + > > maybe warning in this case as well > > Checking that an argument that must not be null is not null is the > responsibility of the caller: crashing here is the right thing to do, > same as fprintf(NULL, "fmt"). > > Therefore, an assertion is the best choice. > > Regards, > > -- > Nicolas George > _______________________________________________ Okay, I'll do that. Thank you. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".