From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 248C242DC5 for ; Wed, 8 Jun 2022 07:43:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACBD168B688; Wed, 8 Jun 2022 10:43:28 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2031.outbound.protection.outlook.com [40.92.21.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4EE6768B59D for ; Wed, 8 Jun 2022 10:43:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nu/FtG20NnWpOMi5KlJYh9ZLPnrKZyIsY3melFjoLMbALkyD5DAF0RkxELtL3JvkSMu7GaVZUURsomIVYdxgXJ3NcgflEN4f0vh/DZ6PB6OM2qsWaf3Imzn1/SLr1gNsx+/0cOW2JYKqnJHu05sOYbeFt4lL206s88zUIGpevTSZ8SzLXc0vNOzKJ8QzOjUxCit69gp5O4keHh6pxmdlb5QIvnbi0LGWVDszaGf4TfnBy+4i/YIaXVZhFAjjTrdlTaIr7uwwxtLf9237wYyvM9B9fz2rrcv1gSlskRygv5tjcrxp4bSxEo7qCymS0m7ejB/N42ERA4zUI4FK87A0Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zm+WTeCTAPRi4O6AdpZyd/MunLRaOVcGqs/eLdMAA+8=; b=B5MMFUVW8a3Kw1ZiQZP1OH8HmL7lBrVYpb0ChCNl5w0f+DggkfL6M6rrdVQeCtsBzZR6+4XcZgq4casyrFDrp/Uw0bG1pgxHtqmE/i/Q4VSiB3cnHvFRqe05dcZyrvjx01/ie/XOMzJFnIbdbjha1BdtdCo/hCjIEbWkKwg1PE/m/o5UKhcmkFMy35cY8uFlbBPcF5GRNl3QbnlkdmNrvkHuALPgjCtF2tEyUd3FuY7X8oUK/xEXo3PI/4nI448b09cCtJCKEbqIE5nKVjyllWdoeBbxLXQ04sMEt9mEVEi/dDXH/NOG2NpGBSwGJGEeMQoYzPpkFBwxZRR7grvi4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zm+WTeCTAPRi4O6AdpZyd/MunLRaOVcGqs/eLdMAA+8=; b=AQcFNz8DDaLMqR52sZARLAj0/9qFkf0JNW9RrnDHhDKBn/BYsYKELef2XOdDyN08BSNHP9Eh3Aq3c+28l6YQ/lxbH2+e3xH1iU79v8kACmNRNcNFhKI2cDx8s72UlEhK2DfAddTFzrojbp+YxAPlpqE6M17S+VxkDcJ0woQDkdm10WyJgyfISdOKodWOMREFgv8VjXfbqDBk0tZNQ6LeQi5xe0AxrEVSSBxvkdV0zuX3aUrvofNFRD8gCNv2k67zrd6x0mP81qEQavKaGMDZTb5EmXY15XsMvESmOYUBU+1MkleF41ufuBz10Sb2B4V/nvyH3OXfIF2ZAmZPxqmP7w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DS7P223MB0477.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:9b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.19; Wed, 8 Jun 2022 07:43:19 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 07:43:19 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT Thread-Index: AQHYemX/APXFdmsBaU2+kzHdFR1g661FChGFgAAOdROAAADHIA== Date: Wed, 8 Jun 2022 07:43:19 +0000 Message-ID: References: <20220607115839.18515-1-anton@khirnov.net> =?utf-8?q?=3CDM8P223M?= =?utf-8?q?B03650454F09DE4D7C396CFB4BAA49=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E_=3CDM8P223MB0365397786EAF497BA5DC577BAA49=40D?= =?utf-8?q?M8P223MB0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= <165466902879.5088.14253593912707356675@lain.khirnov.net> =?utf-8?q?=3CDM8P?= =?utf-8?q?223MB036505AC3D4B249D6F66F803BAA49=40DM8P223MB0365=2ENAMP223=2EPR?= =?utf-8?q?OD=2EOUTLOOK=2ECOM=3E?= <165467214169.13099.10591659789295187077@lain> In-Reply-To: <165467214169.13099.10591659789295187077@lain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [YcgDOxD5AM9cUhgh9uh1YfT2rFOAFfIs] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a636505d-2d78-451b-8aca-08da49228e49 x-ms-traffictypediagnostic: DS7P223MB0477:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KBUuyZch6NVljOcYtFP9kRZUEodFh+uKgXWkNUSn2SBA7lH6G+XzOtGqgexrQNOzIkmsXLNEgIBKKLaILztibEL6X2WM/lF+PX6lZidmpenzwmvw61zdim4IMHHdxGCACUZf9mfa9H+GTkjkpykAoxDDKw7fF1igB7SVzURDrf+ENgcOuaLg7iORUNjOqnwSTDfbPcahtE39US4hpACaHhYAcZI7E3HclefvLW5kNDAox5U6b6kp2nr/NAePOly3PGLxkHiF6O06FUnwkToelN8slPknl/ecxoRJnGEOFpaz5s1cedwmkfHTf+VgFMinaE9ycSsjdRr6WV+CTJa4AOhAFl4kuSe+UNcjCU2QJs3vY2TqA192AODs/8Abqmo8f1yYgUA9xkPNbyuuSuHgZXQ2F8cnZWvJKZ87QJLRzdJQpXp8UI7AdgeySlFQgiiOaz9vg2occNgRohGBkTl8+Y13DYhdLxUbEaiy3JF9qfTzK81KgTo1yYZJhUMVtv9WfdKJesWYg4DL/HM3GE6jX6EwF6HdxhLOGCoc43vz5RInqU1lG8t69qzETSG2AHBx8Xge6CdL1Ypgmgs13wus8MYunQhpgSHc+RQ3O1QcY47i03MHmCE7ilc7vc5Q5LoPU7otxzDfSNENuzEiQtTWfF28JZEyYa8g157TUOB7TJQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MTM1MFZiOFFHVlBIZTRub0NrSDZZVEtZUkJzUXZqR0x6cUFnb2JaM2IwaG5J?= =?utf-8?B?dStaalM0SU9KczNCVVdKWXdFeUZRUlRpZXo4MUk3d044cG1yK251ZWszcXB2?= =?utf-8?B?RDlFYlhvU2F3aDZhNEF4SFE3emNyc2RHTWx1ekphSDgxTkxmdDg0Z3NIa3Nv?= =?utf-8?B?THAxUFE2anNVSlgzWjJIZU9xU3cydlBTZ2prQUE2M3puSjdtVkVoV0RIUHM4?= =?utf-8?B?cUFqajdYTFRFa1FtSDFxdlYvcU1vc0VleGlhTmxVNS9NdWlKN0g3RGlZTnhl?= =?utf-8?B?M1hqcUFOaE5QcDk2cDg2U2xlbzl2emFMQmxyRmtrVmd0MC85WGZQcmlselhh?= =?utf-8?B?UU44OFc2L3RPM2lSZTVYRGVzbVVWcE1YTzZYbW96ejVxYTVhNGQ2SEg0a1Jv?= =?utf-8?B?N0VIZTJnbDdPcWxDc0tMV01BSVAyN1dwNzdqQzVwUG9WalpyTDJtUzJYYUtO?= =?utf-8?B?UmFKdWxneCtDTmhpdzNibDUrclFhMEthQ21zek8vMjM3UGlLbW40N2VhSnB0?= =?utf-8?B?NmFNcjBLMUJ4SmVoaFlhMFpKaEJCR3d4ZXJTWVNleXpSTFpHOXEzTDhtNTM3?= =?utf-8?B?cHJNR1kyN21qVVkzRGNPY2haUC9EM3dobDM0UnZNdVFzUG1tb1dXQnFBbXUz?= =?utf-8?B?bSttZjYxT21NSFpxMStRandhM2dqb2hPT2lvRmc4dGVKdE0wRGZFNFdNK0lW?= =?utf-8?B?NEdSRUlZbnVpTFFXK21jYUhZQzh4V0QvblRIcTlGei9FQzZUdHg1N1BZR0Zq?= =?utf-8?B?OTRjaStObU8xYmxCSGsyNHB0NkplOW9aemhMd0dyS2pOSzNtVTVRUG0vd2Z4?= =?utf-8?B?aDEyRVc1eGFBMnZUNXRGbHc2K1ZHQkFmbTdadmlMMlFrUnFyK1ZIaEk2VmMx?= =?utf-8?B?Y0xWd3NSNWl5OTVkeGdXWHFrc0hudDZkQndndmpGem1tUDRoUE9KajF4dnlK?= =?utf-8?B?SzJNUzFzNnUxYlNnem5LdGJ0Wk5LcERra2I3WjZzKzNVYU5qZGJ2ZEpNeVdB?= =?utf-8?B?aExlelZVVnhHZDFtdHl3Uk9LbVVvZngwNGJCNW5ndCtPZzBDQUZqVzJLbVZh?= =?utf-8?B?QWNrRzNvdEhtUloxcDFwL2R0aWJ5RkxqU0llaTVGRXNhQ043TnNXdlNWWHJW?= =?utf-8?B?Y0pTQkpVTTVDZWpURFFKTnF1d3lzRUFIOUF5NW9HbTBuVHBLZ3hpNU11REd0?= =?utf-8?B?TkVtNG9vY2p4MEloZXNFbXc2U1cyOUF0VTQyVjFSaWVSRzRTRks3Y2dZNkJV?= =?utf-8?B?RzBQa01NeUcvbzhyOGs3a08vekRZZWFzd3BrUTdwUDJnVGNaVS9Nak9TajJi?= =?utf-8?B?QkdEYWx4YnNKZ2ttT0R1L3VmOHMxVWtTTVZOK281SGJac1ZDR3FUK25XSCtT?= =?utf-8?B?YzVTSVAvZUsxczBaa01Ja0xPMi9MVFVoOUtrWVkyYlRPTmkwYUR6V3BLU0t1?= =?utf-8?B?SzZNVzZRNVFzczI4VzVQNHkySzZITHRENVBVSTVMc2dLRTNwMHVSdDRMUU5E?= =?utf-8?B?KzBUTENubk4wTU1VbFVxOXNOY3l4UGNITURCdkUwR1hxWnM4QkhjTjJpOVIv?= =?utf-8?B?QzcveXRPTUo1eXhDcjU0TE1aOG5DVjQ3d1dOZStvdUpHbmp2c3VnNmlmZEFO?= =?utf-8?B?dWl4Ym1RNDh6OWJDN2ZKWlkvdHp3K0xNWHdjcjU4R3hSd3M3eEN4SmxVL3pY?= =?utf-8?B?Y0pwT0dmL1ZVeFRIVmpYRDhTWWlCQU5OS2hEUEFOWXNRT2k1UUM0ZCtkcW5H?= =?utf-8?B?UFZsbG42NUhHVGIzYjhSZGdScys3cFlHMXN0ZGpMQkFJSEF4VEVhUXVjTHUw?= =?utf-8?B?eWFJM1VjRllaVk9JU29Pc2VGaHhMdXg2ZXRKbDBHZUN2ZUZ2NnA3WTYrR25n?= =?utf-8?B?RkRkQ2FjNWRZWXFSeW5ET3VjVmhqUjYyODZodmhRenduU3JwSEJGUU1ZQWoz?= =?utf-8?Q?/7qep2JSmBA=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a636505d-2d78-451b-8aca-08da49228e49 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 07:43:19.0922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7P223MB0477 Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Wednesday, June 8, 2022 9:09 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain > attachments to AV_CODEC_ID_TEXT > > Quoting Soft Works (2022-06-08 08:39:21) > > > Overall I'd say this just strengthens the case for my original lavc > > > commit, since it is clearly helpful in exposing bugs in other code. > > > > As said already, I never doubted the validity of your patch, it was > > about the effect and unacknowledged responsibilities. > > > > What do you want to do with the text attachment "none" caption? > > Maybe a separate "cummy" codec id? > > Do we need to do anything about it? I am not a fan of inventing fake > codec ids for every conceivable kind of data. lavf already exports the > MIME type, that should be enough. Maybe the way it is printed can be > improved, but that is not urgent as far as I'm concerned. ffprobe provides multiple output formats which are intended to be machine- readable (e.g. xml, json). If it was just about interactive reading by a user, then it might in fact not matter that much. But for a machine, it was "text" and the patch changes it to "none". > I am not a fan of inventing fake > codec ids for every conceivable kind of data. This surely makes sense from a larger perspective, but when such fake ids are already being used, then it doesn't matter how many. 5 or 6 - 33 or 34 - that doesn't have relevant impact. At one point in the future, we might get rid of them for something better, but - again - the count won't be of much relevance. Whereas implementing some special sauce, different from the other attachment type handling just to avoid one more fake id - well, I'm not sure whether there would be any benefit in doing so. But when you want to do some kind of workaround instead, I don't mind either, I mean it's just about printing "text" instead of none. Ah, when you remove the mapping at the decoding side, you should probably remove it at the other side as well: https://github.com/FFmpeg/FFmpeg/blob/93505a9095bbacba9b2102a05191e0bc8ba36d4b/libavformat/matroskaenc.c#L2163-L2164 > > > I suppose it can make sense to log an error and continue when opening > > > the codec fails. This could be useful also for probing genuinely broken > > > streams where e.g. extradata parsing fails. > > > > > > There could also be an option like ffmpeg's -xerror that would make > > > ffprobe exit on failure. > > > > Sounds good to me, but I'm not sure whether everybody would be ok > > doing it exactly like this, as somebody might argue they would rely > > on ffprobe failing in such cases. > > I can submit a patch for that - unless no objections or better ideas > > would appear.. > > https://xkcd.com/1172/ I don't think it's absurd, neither hypothetical to ask whether somebody, would object a certain change --- BEFORE working spending time on it. Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".