From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 75BA54C437 for ; Fri, 7 Feb 2025 04:37:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2D7F68BB36; Fri, 7 Feb 2025 06:37:22 +0200 (EET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2108.outbound.protection.outlook.com [40.92.18.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD60B68B65B for ; Fri, 7 Feb 2025 06:37:11 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dpUkMDN4662GO9fQUODzui8o8o0hWiPDVqoLtxenr1ibGUQRLDdv3IpTo3ayhUKOl2SM8u7MbefJHYGfcWIF/zVb0nc0SxGe2I2sOGZiQmims0wzBYq2d9POSF5W4WHbLMBQhsBfGK4+0Emiao4KNhW2uecOqRLxvlQYKI+mmWVdhoG4nABy/r8NQW5/OJcpz2BZ/TOYYiyDMW9gwpLmi95lMF6hJnT5qYgfIldqGSjMPQBqCiy+H0fsHxmr9BWdmZ3aimPCv3o3pmfHit5rdabf6DVXvXr/WXnpm/4/s3+bCcsFqv404NFp8yMROCZYu67ITULlzVVNZbCPnkANPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=acv1CLCf+VKNWRirOlP0dJVq9vkon03LtYW3HUT4aTI=; b=trBiv20BfnYeWkv9ne33PasAG3t3ZrNNxgRKMD0/il5sryecWJyPrT9GPWBx4IK26/fjk5uSnpLeO3OYVqSl3BscVklt+n4Q1wCahoi6A/DDcweVyyKggyOYOgKxIeWcNDAM6F3ZfFWgLCXhkDUcPRcpk7c2QI11q4n3Yww1Rk8IZSl6Mr5Jutq4loD54nbTHu8HuA0SO1aUdDkZO5xqmuX50bTcBo1GL3RdFRcTkViwbSfPe3xzhdqradQVooKQHD6h5iTzdiKg6gDVreUnbXWSCCyXYhDJYjKGv8w8fNkgQRmAtogm2UcWmml7jRZngx4aV5Z13G0KgOzcBMZvnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=acv1CLCf+VKNWRirOlP0dJVq9vkon03LtYW3HUT4aTI=; b=iCwrZTp/8m32sE5kA8EuySEsLY/ABcapxsCto6a8cv3iChmwi6skxxNiXh+sa71AoP11D6gA6Omhfqgm+9+ISGvYRrjtMfq3G316Mp1zdLcS6+tW1OsEwdiTJrowWkM0GnWy24ND8/Qw0j52grLDTwLmlkkNjosO8YF2iuFXQzc0yJc95YaCS5hAh9tAeIP8DKdd8twAHQ2G/0goCK0aA7TvKqpwRisxIZcHjMC8dIfXhg2tZhHcfvmkChRNb7OSIYJ7+CUvnlx583ea2qrP8TE2HsmNYOjh0JEIe0Kq8oi4tpmajLLVKkRGWhTl3BdBAH2bX/Kl3dGnrLvqABkk+w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SN7P223MB0696.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:263::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Fri, 7 Feb 2025 04:37:07 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8422.011; Fri, 7 Feb 2025 04:37:07 +0000 From: Soft Works To: Marth64 , FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing Thread-Index: AQHbeP9WYHVJZz9V2EqPNfwV8U2qQ7M7NwcAgAACx9A= Date: Fri, 7 Feb 2025 04:37:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SN7P223MB0696:EE_ x-ms-office365-filtering-correlation-id: fdc3df2d-3d5d-436d-4c1b-08dd4731143c x-ms-exchange-slblob-mailprops: YfhX3sd/0TWYnBBcTvvGLlHdY79wcCjUFCwBzQyaf/SJXSUkKAIrIAgxEj2jyAxflAW1fP9LpqRV+sAbxTAnl5WuA6BUnZvBUxkpMJTQEshtGc+fpp3ITXPWid0Xfl46e0ZE9s6+p0KDVqzqRUupVWE6Tbx44TQSlDm6Voro4UaBRIZmpvweX54wWMj1irc5TiY6mQvN3Y3N15hii21r7VGo7npDXprL6eCpiN5GzgJApmFYuAesEwWTiWiqNaydnuXokD4BVqPYPAriW1ParHQNps+Xoa1GhFLiufMi46fAzZluL9EFQ0D7vRGkcdxo0Tqq6UPprfukridFY9yZ6WvTYx4+M9paFT4ovGqiapKt7ziZMc7gnaIFHhWhnbL1OTsjZXpJ4yhoSgpqPGmSC0oziGE5RHv18eAb/AsOEWiIxO7NajQbn8i2JgUtSA2S7tXZGE93YmX7hbXIkKPLPWEdspzRxpsBwqhRBRty1ZZyFHrT9P42E5VHfYVmPrve8Lh+o55LCwRRa0h9kKiV+44U9e2QkX7SbAO7x/tmG0AZU4sHdI1ZfNM+l9yFpjXrGkbHW+zDqK6uEWc5aH7sku6kKXgHi330IjF9CnZFbC9K9AGSrmaKSsonU6y/2mnlkuRdOEsidX1YozsgCtZofjIknXZJkkJtijff2IeYQWV4oGGTRJtIlw7LhzBZyWyNJSz+hf5Im9gMkOaPJ5E9QQ+tX1lAjn0cSVOHsazQNz920CIxSRK+gicAKKQI8uNQxPXhCODtcWWRKS36svgWCyWHZIqXDXMDfgwwJRagFYk= x-microsoft-antispam: BCL:0; ARA:14566002|461199028|7092599003|15080799006|19110799003|8060799006|8062599003|102099032|1602099012|4302099013|3412199025|10035399004|440099028; x-microsoft-antispam-message-info: =?utf-8?B?b29LbzhXWHNlL1UyTW03K3dkcEVjaTBiSmx2MTBMMndNK29KcXZIQ3dIZ3Yr?= =?utf-8?B?VlNmajZ2SE9BeW1MdlhNUXRKU3IrcWlJbHhUeVRDV1JHcDFQSXhJOFVTTFNJ?= =?utf-8?B?MWovWkJ1VlhLTHNaUEQzY2ExK1hPRFFUbFc5UWs2aWJKa2ZUMXcrM1ovZFdD?= =?utf-8?B?UkViV01MZGQyMEx5WnJNQ0VLMkszZDdYT1NvOGM5M1ZnTStEY0FvNE1BbVc0?= =?utf-8?B?UmZ1cFhVN3AxeHNwTG81QkVOVDdxMzlJWlJUaXRrR0xIcWkvLzQ5S2NLN3di?= =?utf-8?B?QVNlMDhXS3dpeXNGeDRGamtxZS8zWksyVFhmcUVqYktoVzZvS0tWN2tBdTND?= =?utf-8?B?ZEEreEZ3VmNUZlNZT3pEQmRnTWFSQU5USHBLeFRON0JHcVRIU3lBRDdvRVAz?= =?utf-8?B?ZzErcmdZSzVDaDNMcUZoNm1hejg3dGkvdXF6UmluQU41VXU5ZFErYTZsTW1O?= =?utf-8?B?ZkFCMTVxMVlON0MwZXJuNHN2WTlzcWNtOXZra3YyeTdkRVpKa0hJa2RGV0dF?= =?utf-8?B?NG50ZmoyZGVLbk5DdU1CQjZFYWMzb1YrZjlQUnQzdjZpUllMRVVkWWJudHV0?= =?utf-8?B?NkRGek5OZnRmZFZPb1NzeW9XNmJQREZPek5YODFHVVJkYzFwRWNVYTIvZFhY?= =?utf-8?B?ejJzTlZtV2NjU2YxdG5oYjdxYVhaZjB0cDgyQXpBeVlpcjk5eHNwbTZ1V1RX?= =?utf-8?B?YWFjU0RCbGxMK2xENDRKQnVSNmFlVXFHdnFTUXhIamZjR1ZNaW43NG5BMFFk?= =?utf-8?B?dklRZmhFbU81Q3NxNUIzTHpPcytTYU1FaFd4aGY5ZmxnUHZkWjJLTU9hNEYy?= =?utf-8?B?OUJwYktoZWp5MllNa284Y2lhbWpRR2RvTEVyU0sxNVV0cWRVNFVvUjUvQnBz?= =?utf-8?B?dk5SNGhPZkpzN05lTzk5NFVMWGVSUTcxQkdzeDQxSU9pdVc1RnlzZHhEa2dm?= =?utf-8?B?UlZaLzlhMG1QRDFHRVhpczlqQjRqQUdNTncwQzk3dDkxYW41UHZsZ2dEalhG?= =?utf-8?B?T2I2Ynk3MXFkTHZpdVI4WlN0RUZCRXJUUHpkdG5EcldId2ZYRlFTQWYxa3gr?= =?utf-8?B?SlRLMll2Y0gwNld3ampOcERlRVdGdE9LeGp3VTFXN29LdTdPOG5WOUpyMUIv?= =?utf-8?B?T1FPSDFpUVkrNVlMSTFhb3dYK1FjRE83NlQ4bkwwajJSeG9reHJraExXK1Fj?= =?utf-8?B?REhINGxwZjRwdjlRb0JTV044YnRld05EL3FNNm5aZUVZOU9qSGpIeEF4cFp1?= =?utf-8?B?bG1HMTlpeFpzRitnU2djenI4QUFybmVJZHplS2pQak9JVkk3ZXRRVnBCWDBn?= =?utf-8?B?NWdYVzRFYjR3WHh2Q3RzczI3TW5tTGFNWmFEYjEvOUVTRVdxSTEyZEs3eGgr?= =?utf-8?B?eTNSRitoYkJIdGdzMnFWMXpUV3ZubDNMc3QzSlBHbTY5RUhPTVNreVBkVFZO?= =?utf-8?B?bm1HVjlnY0ZOOVNjY1JHS210V0plaXI2a0FVZTZBRUFXNEZLVjkzckRjcEM3?= =?utf-8?B?WjVOdlQyaFlRajczVGdFZ1FyTGZkajhBNGJtTHFMQ1dsT01FUWJUb24vVDls?= =?utf-8?Q?+YqARSaRyqYMupbtSRvijrBmK1eEgb19mWpX9M4jglwiq3?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a3hEQTJnQm9EdWo3aVFyWVoxekpBN1lQS2krUmpWaHpiN3g1ZzdaNjdENWo4?= =?utf-8?B?OEFrU0tyWWhhaFpiZkZTTEx3aE1BdDVqVjNkaFNzdGxXL0ZaMmdrazdBcnN6?= =?utf-8?B?YnlHSVVOTmc0WUlpV3hzR3ZFeE9CeDlJSGFhZnlhaFNTT1p2YkROdW9zeWdq?= =?utf-8?B?TlBtNmFOQ2labUFCOWd1WForWFp3dUlwdExXTE1XZktEeUZLV1NCek5NSE1i?= =?utf-8?B?azlzY2tiYm5yTXNwdU5SSGhYZ3FhSWtsWXhBRmFyZDVHMFczd3oyWTVjUVI4?= =?utf-8?B?TGtnV2hkeTJkck9NVkc1T3hwM0NxT2V6OURmTC9Db0NDb0xhMzRwbHdxeld3?= =?utf-8?B?MGEvSy9ld0NpOHFncy9rWlRrQUN6ZEp3dG5wd0JRQ0Rva2IveVBxQVhmT2s0?= =?utf-8?B?RGorcjNjLzJJM2Z5UjlFYkd1V1lpaFg5ZXo4Tk52TEhnVFhYaC9WU0tMZnAx?= =?utf-8?B?czhQMHRIRG5zTDU1cGprQU1hRTRWcVNYeVQvQ003a0dPNW5yWDJ1c2dqczB4?= =?utf-8?B?KzNsV3NTU2xackRrTThBZjdaUjB3QXZRWlVDakVkTW13c0R4SysvMzVmMncw?= =?utf-8?B?VHFtQW1XeE1USXV5aDlmQURSaW03YU5BRk5uSmxVOGpjYXVRN1Qrdys3OXYx?= =?utf-8?B?N282cWUxOUM0SmFsMUFmUklDbFBGNmpyd1ZaU0xvd0wrOTM2SGg3NGtwR08x?= =?utf-8?B?TXl1WTJmMEFNTkk1Rm85Z2J6QUNpaU1CSDhGOXljR055bFRQNFg1Tnl6UTIz?= =?utf-8?B?Z3lrVjJjYzgyQ0hGYWV4clRqQW9DS0R1eUN5ZnRmY0p5TnhTM1VtaGlOQmtt?= =?utf-8?B?dkpNVTVXSDhacTVzeDNHSmdsb3BJRzljbVNzakVMMVhGYlVLaS9yOXFmQXAr?= =?utf-8?B?SU5uV3BLbVpWYXFnakJ1Ump1TG93SUNLcjU1VC9jc3VEeWpkVWN0RVlHN2p0?= =?utf-8?B?UHVuRGFZc1hray9UTkRTaXUvYnZ0TW0yU09OZk9PRTFRbVV1ajJqZ1pSNGhN?= =?utf-8?B?QnlPVFFRTXA1aTYzR00xaHg0NE9KV2ZLL3g3ZDB4ZVUzUExsNTE2NWNaVzF0?= =?utf-8?B?d3BvMVZKZUY2aUY3WXBGRHI4Um8xYjdFVlN0RldXV2VxSFpzbTZNSjNpbzBt?= =?utf-8?B?Z3V6dm53SmtOOWxpZEQ4elVUeTJ1S3hrdVl6Qm03T1RJR1B3YUhBaUZobmJu?= =?utf-8?B?RWVJZkF2azlnanlnMnFjeitoZG1uWlFVLzVNN1VMcWVZM29rUWlzRVFRUWhp?= =?utf-8?B?Qld0c1ZZbndEZjhKVmxPSnJ2TmkxV09lL1JWZ0N3MjUvS0w2YTlhRHlkZklH?= =?utf-8?B?UVhlMUY3UGo4eHMrSk5jVUxLUlhBM2ZwamxPS2JyLy9VL1NGRExWRmxXMmxl?= =?utf-8?B?RzhIMDVxNzVVZHdZbTVzOXJKVkYvaXUyblY0UlF1MHlwV0JrUmFoUXE4SzVQ?= =?utf-8?B?MjNnUWhWMWpIODNqZ1hYUkIzbno3eWtCbUZZcFh6eXlLNnRVQk12NGpkUHFR?= =?utf-8?B?Y2puVklvMHJyRFRUVXpNZWE4NFdURXp6K0pGMUI3ZFlKVFg2RWNmOVFrUlFx?= =?utf-8?B?ZHBDVTg1bUVVNUtORXJjSVNjRUFyakdJQ294RndoRkx6endiN3Vna1BvVmJy?= =?utf-8?Q?QH8/o6ZpDHZHJqdeyD9H5g/YrO17Lhg63XFKp0DGyxc8=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fdc3df2d-3d5d-436d-4c1b-08dd4731143c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2025 04:37:07.4800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7P223MB0696 Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer , Soft Works Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Marth64 > Sent: Friday, February 7, 2025 4:58 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Cc: Michael Niedermayer ; softworkz > ; Soft Works hotmail.com@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing > > It works good. Millions of log lines were written with it already :-) > First pass thoughts: > 1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case > convention and conveys clearly that the parameter is an `AVBPrint` Oops, missed that. > 2- Option switch: +datetime and +time feels lighter/easier (vs. -ing) Sure, I don't remember how I even came to the 'ing'. > 3- Term color: the space after the time keeps the background of the > time, which looks odd IMO with terminal emulator color schemes that > show the background. > Not sure if this is intentional. Let me know if you need a > screenshot. Here are two screenshots: https://gist.github.com/softworkz/f78a6a4973f804b9381fe37d5f75f9ea I suppose the lower one is what you are referring to, but in the upper one you can see that there are many lines with black background where it would probably also be odd when there's a single white space in-between. That being said, I don't really care about coloring so I'll gladly change it to whichever way is desired. > 4- (Optional): how would you feel about RFC3339 representation? If > machine parsing is a goal for this. What I feel is that the T and Z letters make it just much harder to read. Why wouldn't it be machine-parsable without those letters? Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".