From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 27187432CD for ; Fri, 26 Aug 2022 22:48:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B0EA68BA36; Sat, 27 Aug 2022 01:48:11 +0300 (EEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2010.outbound.protection.outlook.com [40.92.20.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF32068B9C9 for ; Sat, 27 Aug 2022 01:48:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GvxutNUU3T7fFXN0dwhQHwTE67QH3KiYH4jlesIB7P98LUZpP/z+G6ys9/DZG/4aU+tWgdnnzDPtgTlfSe3OnY9JzxfpGsE73Jrxp50M9sHJtehQRrNDkj8e/47cwKT49fuvwVD+4z+JKVP1WtVInTWfxX3RKJteVvZFrNdlh0uUug16x9u0Xi8M0KFi64sS2G1oVXvNHq1XGWcB/MftoEieliw2m6xR7SU91aTUpA05lQijihHMIRpPHMDMtf6HT17tM3asQalajhCIcl2NwfA/S7w9Fil66wb/fCVV0/0wbqjAFUG9WlwqOjowI7uXNXM99NQLoAULDeDNJwWU5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zVVzcEuVnSNFqaC4p+QfsnKg/tMhRFQqmOi38v+ihsQ=; b=QmccUdNiwFloUWCjMVzrhX8ASfzYQ3gI6ZafclezBsKgDqBv+wv7qWDlO+/nTZxMHwFG4YA0BPHKnQgLAm9T7uPzzjzUJP6JkTzD+U0sjY+HpLHEdrCJdfg5pulPghmB3Vw5zbUC7xlTlgqXcZlW0B3Uha97q8UejbtAIy6P+b6J2rN8JuLwypmVPfzKPqNxRtL5UmPxfn7WGh+uUjO+dhYabDQSt0l77HglqBjpdDTW7WJfWDg4MFydSOOZhl1O61aYtCg4rJeWbUz8N+PaZqtBtzWtNg1dLsyb7A5R490yiZG16M7WezuzACAIoNdjyN/57+PFKbhl4/EV5p3CUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zVVzcEuVnSNFqaC4p+QfsnKg/tMhRFQqmOi38v+ihsQ=; b=vKPpceM7pha2iXzfFDOylyDI3kgAMDZ1Dw9n43LkcpoqryzBIMAIee4XIRJcRsHRZJ1cJmb4ezS0skbAzLHSJLI+bBW6ufBE+BLBK4ymSxptbG6eA4z93wV2NJY3RRWtz/x5Svk7bjKHMQNGY6cBgO+Rfe0d8i+Z018sdvQdkuJLrcl9QTkRk2QzUL6LplnL7r28zCKy2eiBv+eo5M/cv1thU6VjzCXAbZyAKn/KOPAqJ7KPIy3EPeB0vfrmeOOAwiUsMMRx5jIERo8luK+o4vZRJwyo3v0hzjOH721yCjXwx9dPXsM9gIdQOnT8OrohVNKd4kkcUMnRDKcrh+VkCw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DS7P223MB0405.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:87::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Fri, 26 Aug 2022 22:48:01 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::59af:f946:e59d:784b]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::59af:f946:e59d:784b%5]) with mapi id 15.20.5566.016; Fri, 26 Aug 2022 22:48:01 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 Thread-Index: AQHYiHoQ/s8zpruhyEis6n+SHo1FCK2qkhHggA7hQ4CAABDRAIABrZcAgAAnFYCABrBT6IAAFFKw Date: Fri, 26 Aug 2022 22:48:01 +0000 Message-ID: References: =?utf-8?q??= =?utf-8?q?=3C=3CDM8P223MB0365D91C08ED6BA00BCDE342BA649=40DM8P223MB0365=2ENA?= =?utf-8?q?MP223=2EPROD=2EOUTLOOK=2ECOM=3E=3CCAPYw7P7T=3DQd6mujTqsQbK=5FkBHk?= =?utf-8?q?3mDW8MfoVv=3DAf=5FpXmxcitvqg=40mail=2Egmail=2Ecom=3E=3Cac8af460-b?= =?utf-8?q?f9d-4c7f-aaa4-9c9a664c6037=40beta=2Efastmail=2Ecom=3E=3E?= <166117073498.25402.3952806733544526391@lain.khirnov.net> <08928116-7643-4c02-afa5-b1b38d388a88@www.fastmail.com> =?utf-8?q?=3CDM8P22?= =?utf-8?q?3MB0365254229D2A9B9871D0913BA739=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E?= <166154682732.3205.14632132553698015937@lain.khirnov.net> In-Reply-To: <166154682732.3205.14632132553698015937@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [1ChZzeFHKhdMyF1SXHbC59Mzh9mOkzYu] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 786c1619-2c12-423d-fa8c-08da87b507df x-ms-traffictypediagnostic: DS7P223MB0405:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JuER3D9zkpeeQcqihGfIoubmLJvIgeEp8tNezm0wVwkoXI9GGDJ7jb/nArI053RYsXLzkk2yn9InQXn/sOb4kgKJJ4YdDxVYdra+UrbElVYS7evu+FOkEcNmgN5hGgiUuoVmF16uaYzwqDCCpTisPj7skIEKmh7LmzVVm+arohTcDA1IYaJsd7ZmO6fkPpYhs6t4UWMGw5XBAT6KxTqwV59bkvzKiORlOmZ591MetIqwQr+2Nl9cBKEuq4XIRn5CdLNtCatMhxQDcx2+lRKbmCoyrHgQbeSA6U0vFHAIu6aM14FURDWooQ7gs6x//tC5MIMCO6YDcYiJiZ8KTzAT2I5SyU+g/zNCzJWQGDiWlrkLipE9v655CgFKl8XBU3rM0XfKQGiJGPiTbOHnWmAu/knVCehO0GvA1BwmjXCEAdS35q77vbL0vDw3EXNDB3Hd2Fa47ixYHTkv/9U0TTGLliMQISmhJDAzn7fJhH1yzccn5B5CcYl7uW8WRNlv6BZGTV7RqDQLGd6TyO5i3lhuaC9UpuwhEM9KAY/6k0XjrE441SJF+awgXI2MmXtnsCYxrKHelvm0PFb3T9NUDYBeh7TAZzMxHDU3PiKHUOWafdFIIpzaZZg97tJokLKxrzz1T7TU7q3OXY7IbmlV0nCOSSFhGR65gqm8PiJjcm3q//VXPjyKVSj1FwaeTRofPKXz x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a0ZnVndyblZkMVk2dGhyeVR5YmJWaStaSll5Zlc0ZkZWZmlDUk4vQ0RJUlp5?= =?utf-8?B?eGdVMjJuZFoxbmFSd1BSZHpMcmpzNm1ZRE1hREYweUdnMmRDSVJDeDFoWWll?= =?utf-8?B?Vmh2K25IL1dkK2NSZHFRUTJoSWJlaUdxb292b0NNSTdiUG10cEQ3UVpIbWx0?= =?utf-8?B?ZU1kN1pnL2pOOHNvNXVGRDJiNkZCeStrS1QvT0tIRzJLMy9UczlUalBJTlNr?= =?utf-8?B?WHlnakhwK2FJTi9XZnJDN3IxNXVGdGg3TkpuZWJjL3Z2U05VanlxSXdXQjhQ?= =?utf-8?B?SWJlU051Q2JKdkVodCs2NVdtOFVWcGRHVVF3T2xkaG5uMHFlSkVDM1p3WU5P?= =?utf-8?B?NXJTd05RQ1crSlVRQjBJY2l1a2RxTzJDa1BVU1hnWWMvQjhKZ0gvQlJuMk9X?= =?utf-8?B?c1NaSWI0ek9SY1l1NU9BVjNDQ3lHSGdlQjZnRjZSTWpJd3RWdVE3cVBSMFBV?= =?utf-8?B?SElDZmNwQU5CYWdGdVU2QlRnVTl2aXhhZEFCek84ZGdHU09YNTdJYkMxcnpW?= =?utf-8?B?QnZMQllVSVRSTkFRMmpaOTc2Ukd0Y3c3a1J0TjY3RUJNSWRwYUs5Q0RtVHhL?= =?utf-8?B?cDVTMnNjV0dKb0Z1Nm84QUxTUmdwcUdRKzVlTnNldzZoYTN6Zys4WHovYVhU?= =?utf-8?B?TGFFZ3lYdm1sTjlMdVVnWW9Ra0xWY1F0ZngzbEY5aE1nQ1IvdzFHQUUyV3Zk?= =?utf-8?B?blBUWjkwelRpUFUvY1pocGF6TlRCaUtXR3VlbWpydXlhZXlPbnYyNHhYdG5w?= =?utf-8?B?RldoeUxwelBSNXJ0VjNVbEd3cGc5TndpNEw2ZC92S1pjSDZnSFNOUWlwb1Ri?= =?utf-8?B?QmdNWi9nVUZxcEYxVWlQZTVRMllacE1RekZvR1JXQkhBTnQ5U1ExaHJhSFJG?= =?utf-8?B?VmlrYllUcnJGckpoT2N3V0F4UThXMzk5WkZqSDF3OHRYd2FXaUhuc0psVENy?= =?utf-8?B?WUI1WnZjVEkzWlhBcjF5K1hyQzBPWXVLRGdBZ3FrQzdPclRaL3I2WUxNRllV?= =?utf-8?B?MFVlaGU2SmxYV3Q3K3hmMENRbHZyckRvN0pTTkNsZkFsZ0kxRGxWd1JVNHls?= =?utf-8?B?QzFrTlFUemdBa3MrL1Z2UE9sR2xjL21DYW4wclJycGQrQkJ4TW9YR2pXanc0?= =?utf-8?B?L0N0RzZmSlB1eThNdGQ3Q2lsUDZIRjdGY21mSzdyc3k2MitVWHgyRWF6MzBB?= =?utf-8?B?Nnh6ZEJnL2R3NldyVSs5b0JkNWxuTHh2U0p5bjA5MXJkc21MakhiVFJsRmFn?= =?utf-8?B?Mk92VFJpTEViRHd3YXBVY3ZES0I0S3c1MFJNVWUvcGxhcVArcWhQbE9OdDZv?= =?utf-8?B?ZXpuQUpjb1RmSVRJTnVWQzBXbUdLMHQ4emJHa21jV3JBSWxEd2t1aWUyTWZk?= =?utf-8?B?Q1FiRHh0bmJzWjA5bGJnQ1lEUlZ1eUEraDZPWGVqVUFzcTJiVFdTVHczaDB1?= =?utf-8?B?MVRic3pmN0JuTXVsRUxZa3BvZGtqMnl2TVBUa3Q0SmdhbHhNVVVwSGdCTGNx?= =?utf-8?B?bmQ3UVZRd2xNME9qQ0FuSWhJUHU1MFRIc3NUZTFSNTR6T3RyaXFSZ2JQeWRi?= =?utf-8?B?ZHd2NHd4QkUxWkpCb0oxdjk1TGQ2b1h3Rm5jTHo4VTRuOVA4a29hZjJySlhn?= =?utf-8?B?NXJPRStsaUVBMnBMWVJrd2p2ZFNXMEw1aDVMMTJPRVhFSHN4enFTQzVPZVl4?= =?utf-8?B?TEVtYmpMS1NPVVkzTXRYSWdxNmlNeHJFUThPVFJUMFQ2UHdnU0phci93PT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 786c1619-2c12-423d-fa8c-08da87b507df X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 22:48:01.7139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7P223MB0405 Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, August 26, 2022 10:47 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 > > Quoting Soft Works (2022-08-25 00:19:33) > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Jean-Baptiste Kempf > > > Sent: Monday, August 22, 2022 4:39 PM > > > To: ffmpeg-devel@ffmpeg.org > > > Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering > 2022 > > > > > > On Mon, 22 Aug 2022, at 14:18, Anton Khirnov wrote: > > > > Almost exactly identical objections to the basic aspects of the > API > > > were > > > > raised independently by me, Lynne, and Hendrik. > > > > IIUC Soft Works still refuses to address them (though it's not > so > > > easy > > > > to tell in a 200-email thread). > > > > > > OK. I lost the lists of objections, then. > > > > > > -- > > > Jean-Baptiste Kempf - President > > > > > > Could everybody who still has any objection PLEASE name it with > reasoning > > and explain in which way it should be resolved? > > Most of the main objections are mentioned in [1]. As far as I can > tell, none of them were adequately addressed. Hi Anton, thanks a lot for your reply. In fact, all of these were addressed long ago. http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-December/288894.html That message you referenced is about 4 issues: 1. "Milliseconds?" I have changed fields to int64_t values in AV_TIME_BASE, please see below. 2. "There's no reason why this cannot be handled using the buffer and data fields" I had explained the reasons and in conversation on IRC, Lynne was no longer insisting on this AFAIR. 3. "I'm not going to accept a field which is instantly deprecated." I have reworked this and there is no longer a field that is instantly deprecated. 3. "As we've discussed multiple times, please merge this into the regular frame PTS field. We already have _2_ necessary stard/end fields." I have addressed this as well already. There are no longer 3 but only 2 fields remaining (int64_t in AV_TIME_BASE): AVFrame.subtitle_timing.start_pts AVFrame.subtitle_timing.duration > Frankly, you write too many words. A good argument about something > like > this should fit in a paragraph. Maybe followed by some extended > explanations and clarifications, but the core of it should be quite > short and right at the top, not buried under heaps of introductory > remarks and examples. And if you cannot boil down your argument to a > few words then maybe it's not a very strong one. It's a complicated matter and after I had seen that the situation wasn't understood, I started to get more into detail. I will try to write less text in the future. > Or maybe people just got tired of repeating the same objections to > the > same patches being submitted again and again. Or maybe people didn't realize that the objections were addressed already? > You are the author of this set, it is _your_ job to keep track of > what has and has not been addressed I do that, and the count of unaddressed objections that I'm aware of is zero. That's why I'm asking whether anybody would still have an objection or might not see her/his objection being addressed adequately. Thanks again, softworkz PS: the one thing that was under discussion on IRC was about why the subtitle start_pts cannot be the same as the AVFrame pts and that was the point I was explaining in so much detail. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".