From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4D68E4E86C for ; Thu, 12 Jun 2025 02:04:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8DCDF68B508; Thu, 12 Jun 2025 05:04:39 +0300 (EEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2095.outbound.protection.outlook.com [40.92.20.95]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 31AA3687DE4 for ; Thu, 12 Jun 2025 05:04:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XOZHqF54uHCDhd8XLLieo7F51BOHczJSqLCBVDXgVNkte018wWfGiThRf1Sf/AMAz+9ecXlPda4GSgZujLCQZOnWHZj6T34hqOspICECHWc5gyYQKOjPGoVPtvyBupTo4h/aWo6Q8UBjjCguNzK3fj5Fb7oPnbqM1tknw3yBkzfivZEcmcwzvonZG6mIbabXBtx5HC1J79hjUlAohEE+9HAncQc7ZUItPDgbLrlMJSkaJWpvEkuBLjXgXJA0g28jPF3n3cipU4T+oUShSRMMV36Q3KLCEy3yWP6R5Uj8UyEZ7Pcie0/ZQ5VTFsfJU8IWeNmCT0CtmbsW5zLoZxcB9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ej+HDukVppB2c5AtnrHVOAfI2/toAtGuV0HohsmmKNE=; b=Fz5wbaoAtLnJgsK14s5/CPZxdLojgQO0vpyzoJNpzpyI/6mi89QBp4Is77X3/F4/Oa1jzgFUB2gS86K/UTNJX5CHqrl9mS3xtS2MOZfESJVMXgBBDxht2AXSXD0/+rAT6dLbUqF9mqVuYmCQErxetXwkQ5RStg0eOnOILCWK0DsQWR1A2u2hPjCq5WoIrVYesFLnMs1dQHtgFNoRExsCsLTbDzV6EM47ezv66+1CA4XOmc9HJFLIYeScWAgv1tCdNHk3bBRmVVsjJ9KeuqXid7ABs9RbRVg2DLl0jYFY0/5kenfQWrlgAyRMvzEpdVbylI7wkGTVeoiRIJDTYcJtWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ej+HDukVppB2c5AtnrHVOAfI2/toAtGuV0HohsmmKNE=; b=DKuJSDX4EUxzRG+hGC3aGk/4hZHwXyDGIuwtayXPo1o76eCGB8hpWSo9XtIbeDgL8AgTRbnvnAcK+DxMjje67LIG67owz9TXbPWWcf6AWkwx6Igx6Ir1PVqfUgxdbZq4E2RKm7jZusubWERYazh+lzwJI+2OZSyn2FHhJJBbtnWyfu+nvVCV4qaiLowGJnoRrRexle7p3JHnR1Xz4qRrEVsDIepoKc509+aam7R3hNkxIPPAmt5AJcHvZ8y4LVruP7JaRzZSUw45SQffCrvSS5JesY0WJZr9mexeMByCkM9KmUCppufoyvW3PU7EB3obbVMHVS6Hb82ThsoVZP9oXg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0134.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:147::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.22; Thu, 12 Jun 2025 02:04:29 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:04:29 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid Thread-Index: AQHb2wsb+ZookLGmaUG6w4WVLRgWQrP+xJWg Date: Thu, 12 Jun 2025 02:04:29 +0000 Message-ID: References: <20250611195725.95154-1-epirat07@gmail.com> In-Reply-To: <20250611195725.95154-1-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|BN0P223MB0134:EE_ x-ms-office365-filtering-correlation-id: 8fc468c5-291f-41f7-e041-08dda955776f x-microsoft-antispam: BCL:0; ARA:14566002|8060799009|8062599006|15080799009|19110799006|461199028|7092599006|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?3ozrctdp92/CWT6leTrMdFvCu/WyU+iSymR0/F16n02bPZhPs6ywesFHKn6k?= =?us-ascii?Q?gJuMhIJeKITLL6SQTy+HzYy+VSnn2kIkAPUMwrTtl7tulf1fV4nZfWXGSi7C?= =?us-ascii?Q?xRTL2mAABWnSoGkoTZ831HM6L8rs+tDhHAQ9oh0tUVV/k48cCmNXNezwr4ka?= =?us-ascii?Q?9zPPUa7FqndAjvtjQM5wW0728ey+zblJAhnhQO1HtrmPVAXgYVLUqNRZThjf?= =?us-ascii?Q?2Vi4d49/h5hb9d1J+GNgJ+IBUTOLSRjQR3OdHg6juqjWfC7NCJC+zIH9ZUVC?= =?us-ascii?Q?hjJPuGvPCfR/B8gEOJumcbkk9jLdQSvsRnUy3ENy73HRazBWSVaQtZxYkq7x?= =?us-ascii?Q?XHLXu+UxbgCkMixBI7ZWost0+d1OL4+H9ayPWI4Fifl1vXDt9zydiITAnSdY?= =?us-ascii?Q?xEKCMxHZrf7lBWr5MfCXkwTisc2ZuKqhtu9Tul+k7OGs3R98btLsxODhjpuN?= =?us-ascii?Q?WvOjTIcKzFrS5frIPEVfN9dff3qN7ESDAa6Vk5dtAnRNt5KCbz9TBE/YWxSn?= =?us-ascii?Q?jskwhSeNQxMaeIBjzI+OxoHBq87nwSgsTcZz9mtY5/qtYVk6+5dvYhDQKU49?= =?us-ascii?Q?ZjeZ0iBfZP0Wa4XgMMm0Hz2vvIO4W1MuAOyYESskIPzOic+0gMuXJYeW0U55?= =?us-ascii?Q?sUWZ2KPehDa2EM+EbkW+mWQWYSGl672tJ1Mc+jBRmD8Im+K3Ssd9lCvWFIwC?= =?us-ascii?Q?Q7s8xoGFlNGK+6bjwFfgt1GcZTbszhovipWeJSI+0SmpgvdnN7ERfTC3pGb5?= =?us-ascii?Q?F36GXHoCMvVK97Lmgw1/YEH+SMQ2aFq7gdnQJyQNfwtK6o9e9idPaUl5mfXQ?= =?us-ascii?Q?7jPz7SDt02I1gioLLjXIN5juCwyS7FHi8zX/pqVVM1tlSWOwIk9KMBJjRnzA?= =?us-ascii?Q?ou2QAncVvHqDf/xZ2zU6uaBc+trO/Tlrh29SlNKMl5iu8F8d+VkvwaUxOCtS?= =?us-ascii?Q?sAC9rUeSqoQ8CrJuhl0ye0BfGM/iO3QmYrfSOadSqOpVchgT6orq0TYWVciO?= =?us-ascii?Q?bOV+N/hxnp1Q7GEz5yUUUgcfNCHUWlIzFEQ4dUxRWPJFQSpXkcA3WuDmiNII?= =?us-ascii?Q?WIlOl6VRImsSKOdv8tsLJxGpvC0zLrtccadKYDgoRn/hQvZG/Ss=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M7fa1Jd5CHegzWNMOIj7oDEm/LfPncFXl9HHMlQ57YJ2UhL5UNbs89hwnLYZ?= =?us-ascii?Q?E+Hr3WkcqoBlBrHO6K5Lsnq6QpR8ehky9yLCRflJAD1496R3sFgdMWnxOAEo?= =?us-ascii?Q?SLPlTfSODeWXGu+hh2OWUZhwUaeX/RAXugF3jE1IN7TYpa1svy/+4W6LdzJD?= =?us-ascii?Q?pBp1p6k8/QTcxV/wMQ9SAuhcCoKU7v6gIfkmbZ7+ry3YmpdMRZ2/gujaa5VS?= =?us-ascii?Q?XVAU2JUssO00oM/wsUrYxh3Ufr1+owkTYvyv+ehfOOv17CnSe2AZEwYxPYBg?= =?us-ascii?Q?ztM+fzAHB8XQi+kJyMv4b3n8C0pxh68oMOgThtUHgBFrqHH0deLmZcSNK7eq?= =?us-ascii?Q?QuBgS29pYuHaHfG+IOWfCfFu2PzJavT8j9A1YBu+J2VifcOleTKLcWCwS5Uk?= =?us-ascii?Q?avvP9d4SMdEylTw3YU0zsmHRTJQ6KBGotOFVCvASTKYeV8Y5/vum+/MOWPU7?= =?us-ascii?Q?k3H7xLZrtK4d/8Mjv+5WtU40GlZruN2nc1lK7wiz+zKp1/1g1/F9Qt0LrKsw?= =?us-ascii?Q?JEfPaLS4e0+TFW42//DPciItbFMGU2cyabKmthJwb47SFjJf1rBzbfcHUl9f?= =?us-ascii?Q?A7GkFGxZzKUsbl7F+PEIf6bEyjn9u3mhZItnHn6l2kZ0gkd3gnEbhF9nl27d?= =?us-ascii?Q?GMRzGldkQlsuJZ987VbvRJPOkZ6+j+cGIhFjd8m8Hdfo6aEZb3TrLc52vWty?= =?us-ascii?Q?72uw/S8MeBivJp2aKujfd24IE+5yExKK7QmF4nj6NgLcnaSUFZmu+cOyU1d8?= =?us-ascii?Q?CwQOjqlUDIrjKi8Lkfso9HUHIiOFPNV9fnuFoq5KgJ8lDKX7dxu21cIu3ibL?= =?us-ascii?Q?p4S3R7fLMrQ3oQjn75ATxyHjLT94xClCN7I1Q9vzRqof67p8Q/Z7L3kxuTDd?= =?us-ascii?Q?CRrg3oIbVUeXDY92zSMRJ71GQZJMvUurRIcXZw+j3sYJk0eRRZv+EomrBy5B?= =?us-ascii?Q?8Cc+4yx6rU2UbcEpOWtW3/4+aFH682yjBpnrSzqGWYQkd/Xc9+XBgGamBUsw?= =?us-ascii?Q?ncLgWGzjDvudh1Bh2m0E00BSGyxzJIFXqz1pDKKzLkgbhh2OHTFEJ7A4bNGF?= =?us-ascii?Q?3Ql85MokR/GCDAfOBa1BT/39EzPTeIOJy+Y17Bht0QoDPf1rSMG35G+zzlio?= =?us-ascii?Q?64lCSVpRP1K85/qstiYW5E4T3b6kJwpooP+LNMIYUn8oNf8M6jgIsTQYbzyZ?= =?us-ascii?Q?aBWceGL3SKRNbswC3Jzb3UPxp2bQkohhAS6cv6YHzsAToVC/e1IPhGQ/SaA?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc468c5-291f-41f7-e041-08dda955776f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:04:29.7336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0134 Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Marvin, > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 21:57 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing > integers for mermaid > > With the previous logic, the integer writing codepath was > unreachable. > > Fix CID 1646948 > --- > fftools/textformat/tf_mermaid.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/fftools/textformat/tf_mermaid.c > b/fftools/textformat/tf_mermaid.c > index d3b9131ada..59b11811f1 100644 > --- a/fftools/textformat/tf_mermaid.c > +++ b/fftools/textformat/tf_mermaid.c > @@ -604,22 +604,20 @@ static void > mermaid_print_value(AVTextFormatContext *tfc, const char *key, > > break; > case AV_DIAGRAMTYPE_ENTITYRELATIONSHIP: > - > - if (!is_int && str) > { This is actually intended. The reason is that Mermaid ER diagrams do not allow number values for column and data type names while for AV_DIAGRAMTYPE_GRAPH, it's not a problem. Also, column names must not be NULL. Still, you are right that there's unreachable code, which is the first branch of this if-block. if (is_int) writer_printf(tfc, " %s %"PRId64" %s\n", key, num, col_type); else writer_printf(tfc, " %s %s %s\n", key, str, col_type); That first part can be removed, only the 2nd is needed. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".