From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1781E4F078 for ; Fri, 16 May 2025 08:55:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BF92368C98C; Fri, 16 May 2025 11:55:18 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2026.outbound.protection.outlook.com [40.92.19.26]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E7C7968B59E for ; Fri, 16 May 2025 11:55:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RUcFKYBWBUEZqhckvrY8Rdg6viDO/ZD3L4IjF/7E+LjqL1GfU02JyQXW0dIDycVBiPGc2IQbf5npOKkLvHmKeUxYj6Uit19QD+4fRyBE1cdJzUFrOrVlgmwtXx9T8XXRW0kKXlxSWFNcuHz9OgK6Dk4VdKPYtD4s1z3Fm4rF98z0jX2cux0PY2+G9aMhNKnKj8A/B9pAjE0eT7V97/uQJfZ7jV7JNM27J4ai0ERcADyRqCvGfoM2DeIS/u+tAyWBWTQYBBzT/U47Vn+u+YYb2qjcc4larMUnMZ6tnP3rkCEUPbohnwXjBFcfrkeAiaIYuNbe9v+uCuEDxVP0cz+8Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tK7Oj9zNGLqNIWoA2SxjjxNFUgUAMX5aH79zAN8TIYs=; b=yYrcCHwpKSCzqf6rqXqOml+Y5Ibi1tlm0HS9Vg3Ln2vYxmFuH1tRH3aJXKkWjEc1guNBEn/v2puT65xA/3PdRXtFsAMlXklffqE5VZWBO26aeJ4DhTohPEPA57ClZjbMXad2K6QC2/0PaHcf5kUsS+we1RmOPHt3JcL5/RtoDgXutsw1uz536iFkoPcIKfmIikNvqofJN8EzQkjeKbapXt+kwBCjPSkimlge0CU+/BJZ88n1V7H+R1tbKq07kpr2tiOWE9Ate5rn43o3Jp07b8d/X2L8RL1V72bEF8bk4lT7rFYCRPkiGAXr9LS+fkOFE77CicMqJPK12MgLH8O7sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tK7Oj9zNGLqNIWoA2SxjjxNFUgUAMX5aH79zAN8TIYs=; b=PFdsXJ7P/Aj/oGREy1HrnLQIhkOEVEmBRmCHO/iKQ2dHWBSsKoJli3bA+Gpr5RjrW22Ika33EjbOwz+WoQG8fTF7eRtnp9Ch60Aiv2o3t04ywGiKtsQ2y75jlBTpu7h9UYcbf92fywI+IT01/qG+OCwxSafkASbW6/s6tp8QMtwID/KSTTqIrPu9IRRC6jS2seMgj5dkC/YGwnFKQR9r2sK+nKmpj6pN/yYWsnPm7PzzXxWufsXeKv1tJzbiK44ZDVzBBHlC/pCjprPpBH4WNN+ynNheqWn1PqVUSQLG+Q2EkbGpoFDNEsKtqz1iZIb/27p05N3jWWAJRwTftKGwjA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH3PPF174357263.NAMP223.PROD.OUTLOOK.COM (2603:10b6:518:1::511) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.32; Fri, 16 May 2025 08:55:08 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8722.031; Fri, 16 May 2025 08:55:08 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! Thread-Index: AQHbxirm507au67TyEiB1J2yca4eyLPU4cSQgAAIYICAAABpkIAACF2AgAAAlcA= Date: Fri, 16 May 2025 08:55:08 +0000 Message-ID: References: <20250515211148.6C91C4128B8@natalya.videolan.org> <3df3113a-203a-11de-6bdb-6a3ed7771c94@martin.st> <941b73b-44cb-b49a-7c3e-62f2cffb2e10@martin.st> In-Reply-To: <941b73b-44cb-b49a-7c3e-62f2cffb2e10@martin.st> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH3PPF174357263:EE_ x-ms-office365-filtering-correlation-id: 080feec3-e979-4084-1ade-08dd94575c11 x-ms-exchange-slblob-mailprops: cn60g5V53KPw5WU8gd1IqJnxdTHKCVAzlG9Wvmyp7de4aehVXMo8FLMx/ztSb6BAfwMfvl0kiS1lT+r2VxHEAaAMLgYayOmsGdoxYxG4mHuNQ+r+zBhapWlZKyXisHS2rdS5teyu7xg1Od6BFMxJEiSZHH+jDYP6oAf3PfOKVVA3kQ6bIv2SRqEtURF8YobyQwH9utbhZK6kdV+1Qw5uLPv9W0LdSR0/XGHTKVBFuX9uLb9W+8hPdI0XWpssYVCs3xup3mxvgDxFdCBZKjue8zHv4Mg4sQeKg45V0PZOj9XEGQ5AjJzARBCYXZOUxNI5BAwPzMPwGyCTHUiwcuMAWg7tB705FuLa6Rnbr+tPH9+0vJuZmIRqMPwhvX0OyFjz4wcAWHndAVmT/zP3WwjVNNLK9FXzsToq/3dpPaa9yN17Phis6QsVJ5XqqXqt2zUfvEdfnbgHbKVdlUVnBFbZb5T6KSUj2X0SKFrCUhrHrZCx5XuwUqK8INPpV3uEce8g5UFN6P4M/7C4+tBBitTkb19+ahcgW96oextBVOhbzuOqLYiqtOvznzl6gG4kk3OWhv0559DMwmPxk2GIIMkNB10T9Q6sf3mKnMAlFTYXNQqeglCpW0/NzNN+A3xQTK/f0l1HvEJLFTDtg4kOLUSrvlmzaz0azkljiHU6RjikdEyTzhOzZaAiY4Nnz5vcbzdqMP+sEB/jZuOdRD8l4qKyB3h1OynNVni1zONGwA7QNkKrIkACjDU4FmsSv+OYuoANGM2VodlzLI7p+SDdeT3SEwqqIyWo15mIqMNvwLtwbR0SsQy/FI2QNOcOYNEoEEwbZcj+RidKuJXCC/aOwxoXNpbaCCdxuhE3Pi+8t8yXt9jXMg1GuzEHsA== x-microsoft-antispam: BCL:0; ARA:14566002|19110799006|8062599006|8060799009|7092599006|15080799009|461199028|440099028|3412199025|10035399007|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?zL9wb9FjaJGguWrkKDMvTwkMkagrOlcAv+0IbeKeyNZ6PtVD7DJ97JTRGN?= =?iso-8859-1?Q?3Iplr/mJ2O3CJxTR2fxswxF3rv50qC5v+ENaDgYJQIZlQg41lbYVqbMFBD?= =?iso-8859-1?Q?9uxPdqv+biqMpugHcVpggiKh/p3/OvALOykuri1/Z4pYMMgbar8igxNUuH?= =?iso-8859-1?Q?IYHuyHUn2mcdbkfRqhBSWji5mzBkYGQFhRPYJ2xq/wWf7kne1/eREog3z9?= =?iso-8859-1?Q?SaQtTa4tHD/p/I0UMG0jAhDTQsAnN5H8HhSzHvNEEqgQIUi+y0cEZEKqVL?= =?iso-8859-1?Q?ygyUK79O2MtVb+pGiRkbC9SmsbO79w4BTZTzCXUZJnwqYy8i04lYYxAFeo?= =?iso-8859-1?Q?8xsMPUdK8duhOEYKMh904yzdwJa8xOTjgVSMFkL6mDk8xKjPFtEiMO2hW7?= =?iso-8859-1?Q?VJEe0qJpOJDZp9+FWfT96A75FSJlVzJ3vKwzv9McJjcSWE4ituCp2aR0o9?= =?iso-8859-1?Q?zm0ut9sNuCEirEjkip9isMPjhSn+zAgB3FWFljO/gDdplaXMdBYk/G3Ste?= =?iso-8859-1?Q?tvoBtCCHkFvIlRPSvcJkO2L3ve7xOBpIeD+Z9eRTnS3eMyo2HLuey6muNg?= =?iso-8859-1?Q?rqdmXbO/sBJwWkHxxhRxTqMBUvxzN8ZIOaN5JYqhL3M7vaEB17motGwW2s?= =?iso-8859-1?Q?41IuSi+Am/zFsGz+LcqBVz/zJ8DGRlz6kINV7f25F++RlHGNaRblL0ntaG?= =?iso-8859-1?Q?b+bhuoHRg/prEAb3wIC8JbRZBKsXiwtbhODGzxd78rlIZF38++J7cK70KC?= =?iso-8859-1?Q?qitqBSGRijCpVvQI8NIJU7Kkm1xKyxsv7hVQaB+buTiep8EOUX6kU2DI21?= =?iso-8859-1?Q?C6rwhYI9F+2JA+A8pKoQ1Nssv7eZlqe6zJSwZGEagVVTWSbEnt5nr+jOyi?= =?iso-8859-1?Q?a3+1ejmcltpK0URsfdevvvrRNNIWpQBTaYPCxco+4J246ZE0Ps/84ZF8L0?= =?iso-8859-1?Q?JfW9zYCRv0ZGXtzcH7B+sx2ysmSouDNXlywHlRfJJwoYFZLm7UhSgy1v1F?= =?iso-8859-1?Q?TByV8H6yVBKDr+hKbvQv4ieB/+C3br5jtDtgCTBtoS/hdAb0bypJUN5ckq?= =?iso-8859-1?Q?ONYQdqc5I8n8qou8L8QeRA++Iu4epOnkWdtIgKfM8HMZFhO7gYVIXfcUh4?= =?iso-8859-1?Q?hjhz8jVtemcx1R6jKIdGoF/YXC2g0uXWNHvwiMiKT/UFnJMjYGaE7vtXGc?= =?iso-8859-1?Q?SI7Cl2mujA5gX92T5wWW2Vzito9MLu/a6ZA=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rXtBbXAKLwxR3JydRJf3S0zTLPIwL8xH2n2HRVCQWVjUk1CONpYGWXSsSc?= =?iso-8859-1?Q?yXARJW2iJ15NnFbszzXMsKT9+SWdUUzp4pefMSIkOIml9rKVQm+3mc7taW?= =?iso-8859-1?Q?+aWm6sUa9EDkvwel9xfeWxJkCxg3vObumzfUVoflrsZzZpxxCdhld5kXEG?= =?iso-8859-1?Q?auZEBIGMcl4N7buHYgiemMvGcOMdXb3u7S3RmxHUQwY0n1cIpBbQUr+7lI?= =?iso-8859-1?Q?TlSuzGfNl3eeiodj9abIyRHRhSyY9iT1qnyZYE1QwcuZzY29FLDG8k9iev?= =?iso-8859-1?Q?jtO5ZfjWzU8K+Fg+zi7KSyq4u3U/+fnncb8rjdkkpPNcCgGqIqYWkQRu69?= =?iso-8859-1?Q?RXA/HZqmTA59mEroy4hS6CazjaFVcU7eSrqVotbwabmUAUIiw4asUrDRhz?= =?iso-8859-1?Q?llfLf/IFPH5+HZeE34N2Cahk7zrjvfKMyr0+ubgK0YOPvgDDCNphZ0RcS2?= =?iso-8859-1?Q?Cj60xQI/ifWJ3siZ05tfnvfGakg6HG6xi7EiaNIsY4w1LG7CTOobTPGH1j?= =?iso-8859-1?Q?0RlNnnauht6e3yvXNLZD9b3sFO41xQsimkjEZtjLZhhIIsLi5Tx0K/W7mQ?= =?iso-8859-1?Q?L26FeyJjVQLEkbXmQe2b/0od8ocGLVUIstQjnqtSbdb6WROdQlYmhVeZ1n?= =?iso-8859-1?Q?bw75KsCq42mbkPaNgoHMW2zNsMgHpAZim7+UhkIZzv6o/4i3TD/mUQFK05?= =?iso-8859-1?Q?m/lH8zuHbL0rljnm/R7HZUm4yOxDKLZD+rNinD7LWUhbtCX1i7dI0xsl9r?= =?iso-8859-1?Q?WOwBq1z/t+Nls6S77mSIwmlpG1YyUCSHFM3zWaXMvX57icNRaurjS3zghA?= =?iso-8859-1?Q?zMvj8yWgbsFTGiKoR1iEsuIjnH7h2XzAzB/h1spWn4DW3JBF0yR0D+sDIc?= =?iso-8859-1?Q?O4VbtAFJ1OhYGe4eQEUydRq7xHPcTmaBMO9D1DxuB4bAWDLgvyw/WV8/n4?= =?iso-8859-1?Q?krEqnJraWHhHMvfT4goGDm8ud7jpXSve6Sn2c9LtqvxhKbg8sLIkjJwH7W?= =?iso-8859-1?Q?WwQVmln9zN47Jd97MVXhwWCr2bHPHK0h6Ea6sFoYtoqQVi9hhe1g6IiXyk?= =?iso-8859-1?Q?SVbx0vT9jTLbJUWC+cFDuSUtOeuRGcmt5gq88Q20gvJkidjGnzuFqi01/G?= =?iso-8859-1?Q?94F3//VV5/BmkMoYSpr4vKI+09u208G/a8HM5F7QwDTJkbSrFyiYB3HzHg?= =?iso-8859-1?Q?bV8IsQErZP3oKqnHXWgKAfndusWvjmMfs710c7r5YIJOYBOe+AsIlgKLnx?= =?iso-8859-1?Q?8HLLv3gS7btNbMLZ5wa3VLkr7MxVAEq7W32fTut48=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 080feec3-e979-4084-1ade-08dd94575c11 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2025 08:55:08.3747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF174357263 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Martin > Storsj=F6 > Sent: Freitag, 16. Mai 2025 10:51 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make= it a > Killer-Feature! > = > On Fri, 16 May 2025, softworkz . wrote: > = > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Mart= in > >> Storsj=F6 > >> Sent: Freitag, 16. Mai 2025 10:19 > >> To: FFmpeg development discussions and patches > >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, m= ake > it a > >> Killer-Feature! > >> > >> On Fri, 16 May 2025, softworkz . wrote: > >> > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf Of Ma= rtin > >>>> Storsj=F6 > >>>> Sent: Freitag, 16. Mai 2025 08:22 > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now,= make > >> it a > >>>> Killer-Feature! > >>>> > >>>> On Thu, 15 May 2025, softworkz wrote: > >>>> > >>>>> ffmpeg | branch: master | softworkz | Thu M= ay 15 > >>>> 23:10:02 2025 +0200| [1f2b8d7238eff4ab8a4d8d6177e250b8180d51f4] | > >> committer: > >>>> softworkz > >>>>> > >>>>> fftools/graphprint: Now, make it a Killer-Feature! > >>>>> > >>>>> remember this: -sg <=3D means Show Graph > >>>>> > >>>>> Signed-off-by: softworkz > >>>>> > >>>>>> > >>>> > >> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D1f2b8d7238e= ff4ab8a4d > >>>> 8d6177e250b8180d51f4 > >>>>> --- > >>>> > >>>> This broke compilation in a number of configurations: > >>>> > >>>> Windows UWP/Phone: > >>>> https://fate.ffmpeg.org/report.cgi?slot=3Darm-msvc2022- > >>>> winphone&time=3D20250516053009 > >>>> > >>>> filelauncher.o : error LNK2019: unresolved external symbol ShellExec= uteA > >>>> referenced in function ff_open_html_in_browser > >>>> ffmpeg_g.exe : fatal error LNK1120: 1 unresolved externals > >>>> > >>>> iOS: > >>>> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- > >>>> ios18&time=3D20250516011754 > >>>> > >>>> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailab= le: > >>>> not available on iOS > >>>> 61 | if (system(cmd) !=3D 0) > >>>> | ^ > >>>> > >> > /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/iPhoneOS.plat= form/ > >>>> Developer/SDKs/iPhoneOS.sdk/usr/include/_stdlib.h:184:6: > >>>> note: 'system' has been explicitly marked unavailable here > >>>> 184 | int system(const char *) __DARWIN_ALIAS_C(system); > >>>> | ^ > >>>> 1 error generated. > >>>> > >>>> tvOS: > >>>> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- > >>>> tvos18&time=3D20250516014542 > >>>> > >>>> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailab= le: > >>>> not available on tvOS > >>>> 61 | if (system(cmd) !=3D 0) > >>>> | ^ > >>>> > >> > /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/AppleTVOS.pla= tform > >>>> /Developer/SDKs/AppleTVOS.sdk/usr/include/_stdlib.h:184:6: > >>>> note: 'system' has been explicitly marked unavailable here > >>>> 184 | int system(const char *) __DARWIN_ALIAS_C(system); > >>>> | ^ > >>>> 1 error generated. > >>>> > >>>> // Martin > >>>> > >>> > >>> Hi Martin, > >>> > >>> do you think this is a reasonable condition for Apple in configure? > >>> > >>> enable browser_launch > >>> if test -n "$sysroot"; then > >>> case "$sysroot" in > >>> */iPhone*.sdk|\ > >>> */AppleTV*.sdk|\ > >>> */WatchOS*.sdk|\ > >>> */BridgeOS*.sdk) > >>> disable browser_launch > >>> ;; > >>> esac > >>> fi > >> > >> This is not how we normally do it. String matching trying to detect th= ings > >> is generally brittle. If the problem is that we can't compile a call to > >> system(), the configure check should try to compile a call to system(), > >> and if that doesn't succeed, avoid compiling the code that does that. = That > >> also works for e.g. ShellExecuteA. > > > > I'm preparing a patch that aims to limit this to Windows, Linux and Mac > > (regardless of API availability) and I'm not sure how to determine whet= her > > mac or the others above in configure. > > > > Is there a better way? > = > Test compiling code and checking if the expected things are defined. You > can include TargetConditionals.h and check if TARGET_OS_OSX evaluates to > nonzero; that's what we do in code elsewhere anyway - grep for > TARGET_OS_OSX. Okay got it. Thanks a lot for your help. Even though it's not needed = anymore now. The next FATE builds for those platforms should be green = again. Thank you sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".