From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CCB004CE94 for ; Thu, 15 May 2025 01:05:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3641B68BF11; Thu, 15 May 2025 04:05:25 +0300 (EEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2109.outbound.protection.outlook.com [40.92.45.109]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6A8F968BD99 for ; Thu, 15 May 2025 04:05:18 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nqf6OG9lh8vJBzf5B1e1UGpDbsLG3KtlMsaUmnKFmy7PEd7PZNS3S9b/NqHXAFnDb1kxJcjR3vwXEbLItwx/o94G/QpcqkUcNcrlXfYufDMLimvYGmPnwpp5gV/Sd6NLmUdEAImPBXXXh+Scg+OWedxzUlzSS+BI3tyFET67/K/C9j07DxDaK5T7ApfXTVL0TJJFrevktMj1uAFysoiprDPCEO+ss/62OQ9XRKbvDt7mihHZB5N1nQ2dmFY9slp+ZcyWVUWS4sF9nyGeAwMVggW5n2J4SvhBYsnc5TxfTys1pO6Mn3KfoNFGumofEEKR8xd2sDmwzi4wfvdnczY7EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=USlkb4oRzyJeq94SDWHVuL94+gMOBpBq+caxWs8GHbo=; b=ng1nhooiKq2KwzrrN6wuEHBQvSVBmre9ASZ5KOZqr04maYCpkzs+gTen3robymq+JOidEBTHGi7KDU9YC4UQ6gyJXcRrHOzvktNQSLbk161kBTgZOBpGqEtHwE2IGMOlOA/j/FeW0YIAFYCFoJyoPGzg1UFXozCAo7gVxo816PtJ/fz7lVTibVAKuiEQM3Lf31j6Obm6ubSgwwqBwFwhFELBXf1NT6gaM4DQadRqCFjSU2ldU2mkA3tVVPlb8oOLbUaQGwRzuDM3/fz7Wrp34ocOUohWp2NNJ0Y1vE7CHCA0c+pA0Jl8RYiic/YQkcuEPPLcSbcFZMS4aQvJfAItMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=USlkb4oRzyJeq94SDWHVuL94+gMOBpBq+caxWs8GHbo=; b=UIEGN66hs562svPqqYdwwO/ghmGwPXwbJI6E5BVG5GkaDR29MMoHg5hh3NrtR7SkuttyoeDkOh2PEQaK4bzU+Pl3YQp/XWUskW0Aifuj3ZJFYJPR1fe9IHBIo56Zn7UJ3AqDSPqsoMDqFrLjYRasF6x1h2+bjzzQjAC4FjfbhJKMakMmtGpgP2QjKVEB7IoIG+lH8Pp419jrpQF7nv1R0q3rgSKIvlWd9YELmL6zzsaZo0rxc26Vfdc5+Zr5pGaeVrJuGQGxFA452jP/ka3ek2bTdNVjWNwyIrVsOsSrOvFpj9vl7W24V6DfxWyTE15+dE5DmlxHPFok1uQtF5RC8w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by IA3P223MB1527.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:571::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.25; Thu, 15 May 2025 01:05:15 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8722.027; Thu, 15 May 2025 01:05:14 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmarking inside the width loop is meaningless Thread-Index: AQHbvAvNWXq8EyMsBkypa02KuY/sLLPSuUYQ Date: Thu, 15 May 2025 01:05:14 +0000 Message-ID: References: <20250503091319.76948-1-nuomi2021@gmail.com> <20250503091319.76948-6-nuomi2021@gmail.com> In-Reply-To: <20250503091319.76948-6-nuomi2021@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA3P223MB1527:EE_ x-ms-office365-filtering-correlation-id: d54215a3-0605-451b-37ee-08dd934c8ce1 x-ms-exchange-slblob-mailprops: obhAqMD0nT+76ZruCrigLPUIQMEMZUn+1N8P01yjPlOcZw11NFfpkHZ3xK5foqZSN2vY9OKK0tXagCUEJZyO2i68ScwbLwC9aF/4cMMOmHmbiySSd/K50MxsmHSUcg4ncj8wXd5NKxu1DtX1inq4g7narA5jOE4BXXJIosyRO+OrhVq8BTz/OQGXclW1tR+KVuA7pSA6z0IzztuS/1dl9iEiTXlOSsy8pV14HQCaGRPHprX5d5bgjXeGAk2zfajJ1BTr6XHySldKqNfScWfRCJAIJKDE+H6kARAupHDTFRhEvc+VxTJjf0iHOTfZldlmvsWoMeZ3WsCmSOSrH2ascTc5jQpcHPXfQnQKI0aXbiKhAdbei6Ft5EqBJlutt0ZP8l1rHdXwkImvExLgV4owsyoa34ppaCepPaFFacFFrWfPigX49sh8+wQnxjk8dHJrapxvrE/iMNtJgJPA6x8CjnTozFqufHKajrONl4i5qXpQSEwem3emw3kSE1l2UbEPiELjyghC6/iU090q/oXSRzSgm7YokfJtOP7ljG2YyuWRriPNKgclb+fjKX4/X34n20ksE7upCbQ+R+u1GdI7IHG3hXInrLKbtnGzOBuJAf8IUneX1AXNFIXABO05Lka+zeU5xz3t+qutPZnxOR8/mqPplf9CI4NDZhstTE+D/RzRvTIOvntsYgn/KJ+jBtmdsQIk5brsbdGzG1p/k6dWKKcro2FwNYMC2WVfJYQcU1T01dl0/AvGurAVvB7QJCTkDiWvOHoVwiG2cu+329y/v521TBceXAp+4jQ9I+AE+Pl5IGpzCE9I/Y72mI/AUid6 x-microsoft-antispam: BCL:0; ARA:14566002|8062599006|8060799009|15080799009|7092599006|19110799006|461199028|102099032|1602099012|4302099013|440099028|3412199025|10035399007; x-microsoft-antispam-message-info: =?iso-8859-1?Q?ysrWZ7IdyOt7zSZ8QZ+qU+WsOmSfobstqXKgXq7wuz4Sa0+U+7Hx6zt/nn?= =?iso-8859-1?Q?IW72lVJfKFVJNVjhCF22lBGvJ7Z8GfJwGtPTvoHMb41u8qbfhZiZ43XYfc?= =?iso-8859-1?Q?LthCP2y8nk1zGocNoD+W0Mu4pRqOAYh6knjdQoBVq0/Ps0saNCPhI9d19s?= =?iso-8859-1?Q?+PZOwMb94w73AXuMknR+2ovPHT1K4GaIVoo3m6p4d4ktOxO+GMT2JbwGv4?= =?iso-8859-1?Q?qeMop0lHs7Zi7wtGJPJ8Ylkgrmglp8m/c4LAajMbZ4jA4jbHGYUBxVQVUB?= =?iso-8859-1?Q?ebS8G9UnQzkk+VCf8jGI0ePBmUGB43+iLLtFI0ucMDsYIfEUMxNih2ioV5?= =?iso-8859-1?Q?evtuKN3Fhm/ZW5m2uRQYP+epY7oB0U6vPmNyobcv+K/mCvgu7OlmO+9Ige?= =?iso-8859-1?Q?ZW0hiPLsankK1PibYBBUxMar+OCj/h7+xmwL9ciJvaIgJLOSOikyiwPGuw?= =?iso-8859-1?Q?1RreALzux6Rl56TQ/VN99p++5CPbBz0cesNTyYJbKFuSocwZGzBKsrf99H?= =?iso-8859-1?Q?xmz67/WFHiZHeluIV1AiTgTfiZSGgmUBIEzwdzGq0iQIn1NDmi7z1wju2X?= =?iso-8859-1?Q?3hTFq50hFUC1dTiQ9EL97dX2wzsTd7ucv72xsoqspgzM34tiWeX8Mrwc2O?= =?iso-8859-1?Q?TLdPu1IMx5LEJQcXFWYtdyWqWrXm7NfS+Xvt08kZAZDATY8HeNSuq2EUPh?= =?iso-8859-1?Q?2aHDe7j6iy/2nKktObyuAPKumAjhafBVgLd9XD8glmVWo0Y0fwNiMWBv30?= =?iso-8859-1?Q?1Ux7tHa4n9y0dClpjGWBcoXucOo+D5sn674u/sM6Y/er8MZjJm2sBvqqNp?= =?iso-8859-1?Q?DKlIqQdISF/0aej2svbztwDWWvS4rPjMUC5rWJLKN9J/6/DpynJREuSjSH?= =?iso-8859-1?Q?31IiYRnGi86qO7BfSsVXdCtu05dGtaa6QpuzHRXwrjS4Z9tVl/aU4bhcNS?= =?iso-8859-1?Q?pDYHIolDBCKPzB1OwUTKwQrdg8nsjqe5ua4K3wCr+mFvTHUQHNbW2UI5it?= =?iso-8859-1?Q?1lUMHjp9IeWrNAH9i1BSL5fHW4ryxYvzH+3/E5w607Q9VPwBSs60FPL11Y?= =?iso-8859-1?Q?6ssc2Xzc0BSrKCfSYsnzWYgdTqdeK56HYJXzQo6LXl0BGwE3YPFlcKpPS6?= =?iso-8859-1?Q?OflHzZA1DprkELO5Rn1h5Grt6weyKM9mXbHDwedV6ouIbZPbKTdKcyt4le?= =?iso-8859-1?Q?UFGXAr7s/12zjkBzU+d5/NIVq7QbKaEOH6cFfaj9SsekIxjjjxOZ+R59yw?= =?iso-8859-1?Q?PBBS5Iv1r944wrsqnsAqy3S4zKSMTt7tBtjxxtQdc=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?slCZYr2lepQt/XSgbprFyGavTb+jfyAfeFFbTYNiyOZZxM2+U1yE5abvHw?= =?iso-8859-1?Q?yBiUPlGfgnjWALHrAjS3CSD7zl0PHHXe73NsGULXXGVCyeEL3p0NQpwEEB?= =?iso-8859-1?Q?ULHVf/U2v+M8QjWmjFny5TQSL9rEQZ1Y9v43jvORPp6qRFRbnkwhGa6bjv?= =?iso-8859-1?Q?eLHdPZUvWEZEO+N/U80UJn61byIvhDBezxL5MqUBWBH3E0xPmYmmUTUYZR?= =?iso-8859-1?Q?MDU2Q1IxOWAQxubI1MocZD/Lm+//+Dm4+bEqAyzTt0JOWESMDwgFzGjtN+?= =?iso-8859-1?Q?Y5AbUVDl0xpcuh4BnIV+XPCyM3C4LEScMriHE7c4XXIhekY6zl3f3/h2Ok?= =?iso-8859-1?Q?D/6RaWq40AuHk59QVC40Joj9eLU1s2nQMOL21UyNhQ8MqQNKHWWmhtDbbj?= =?iso-8859-1?Q?QSe0pzTg4iz0NokLWW9yM80oMxl/kUAFjKVmJUc5qfp/oiApPPsYAH7Gup?= =?iso-8859-1?Q?0WtN9jBw6AUWiTJB4q5EZMkA4VGWNUAxD9mDHg12jDkWd8P1aJtubnp9hP?= =?iso-8859-1?Q?5XVHmdlmNzl2Pm3v484deefAvfA8LdOv2KVxhPqGvnFq8ePaqbrlfs8w+u?= =?iso-8859-1?Q?qqLshQRx4Ppfiw2ESCuvXSi1UUBzwu1o6UER2XfIGMLblGt6pVxQhvc2oX?= =?iso-8859-1?Q?K0M72Wjlxi2vs0QnFpsoWXh89hJoDi7ZCZiDQ2BK08wBZ/GwRjSFA7RAlO?= =?iso-8859-1?Q?2z0gt3bdlmm5FsloYKaOBi2htvvKx8RAkTKIzWsmzDjZlS9J/4208NmHxw?= =?iso-8859-1?Q?J5kL5WMYRsPIdPJzXqeKxc+xaAieNEFJFoz/WldzoBx1miV4SYGJ/Bisz0?= =?iso-8859-1?Q?rUIauie70mVWIljjKK8Wc/FOnVHbWCluLElCdPRlLkzCKQ0y3PvAVH+D4r?= =?iso-8859-1?Q?gp5HDijhDiWPMTcQHf1aw7aLnE7+GGw2Kp+5eVTNx2HAcDXdpiCit9xrti?= =?iso-8859-1?Q?KowHJbmqjUtgfFM5onscxTt+FQ08uJThXUODrhffDaSXI/4oCo/Tv8Ps/n?= =?iso-8859-1?Q?mpiAPOL2oV2jqvLM5SDMoFt4XfND4X3rmTxhI3SGdF3K3kWhTIhDd06TZ9?= =?iso-8859-1?Q?JGBptIueJ4IGDhaWlIuSLO9i30znN2IBySS1NSNwFSnM7bnbpCFFhn57hZ?= =?iso-8859-1?Q?v0YFiqZzgA0vwAo4pLdjNYLeQLeeXWRU30tDCCYvQqD+bhyraDvHvCXYsO?= =?iso-8859-1?Q?8+bLQWzFx7XRNN2S9Ol+9rknksMpjySVjDvmygfeLteLl6TVxZGptcSX0N?= =?iso-8859-1?Q?rKxMbzMLgLMrAg/p4XQNtLcGl9K6KZJB1jd4hPtF4=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d54215a3-0605-451b-37ee-08dd934c8ce1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2025 01:05:14.6823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3P223MB1527 Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmarking inside the width loop is meaningless X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nuo Mi Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Nuo Mi > Sent: Samstag, 3. Mai 2025 11:13 > To: ffmpeg-devel@ffmpeg.org > Cc: Nuo Mi > Subject: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmark= ing > inside the width loop is meaningless > = > --- > tests/checkasm/hevc_sao.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > = > diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c > index ad47423f10..f597eb5254 100644 > --- a/tests/checkasm/hevc_sao.c > +++ b/tests/checkasm/hevc_sao.c > @@ -119,21 +119,21 @@ static void check_sao_edge(HEVCDSPContext *h, int > bit_depth) > declare_func(void, uint8_t *dst, const uint8_t *src, ptrdiff_t > stride_dst, > const int16_t *sao_offset_val, int eo, int width, i= nt > height); > = > - for (int w =3D prev_size + 4; w <=3D block_size; w +=3D 4) { > - randomize_buffers(src0, src1, BUF_SIZE); > - randomize_buffers2(offset_val, OFFSET_LENGTH); > - memset(dst0, 0, BUF_SIZE); > - memset(dst1, 0, BUF_SIZE); > + if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d", > block_size, bit_depth)) { > + for (int w =3D prev_size + 4; w <=3D block_size; w +=3D 4) { > + randomize_buffers(src0, src1, BUF_SIZE); > + randomize_buffers2(offset_val, OFFSET_LENGTH); > + memset(dst0, 0, BUF_SIZE); > + memset(dst1, 0, BUF_SIZE); > = > - if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d", > block_size, bit_depth)) { > call_ref(dst0, src0 + offset, stride, offset_val, eo, w, > block_size); > call_new(dst1, src1 + offset, stride, offset_val, eo, w, > block_size); > for (int j =3D 0; j < block_size; j++) { > if (memcmp(dst0 + j*stride, dst1 + j*stride, > w*SIZEOF_PIXEL)) > fail(); > } > - bench_new(dst1, src1 + offset, stride, offset_val, eo, > block_size, block_size); > } > + bench_new(dst1, src1 + offset, stride, offset_val, eo, > block_size, block_size); > } > } > } > -- Hi Nuo, since you have applied this patch (or 7/7)=B4today, both FATE builds on Win= dows (MSVC + GCC) are failing - for all submitted patches. = https://patchwork.ffmpeg.org/project/ffmpeg = Could you please take a look? With MSVC: D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache': unreference= d local variable vvc_alf.c CC tests/checkasm/vp9dsp.o vp9dsp.c D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache': unreference= d local variable STRIP tests/checkasm/x86/checkasm.o skipping strip -x tests/checkasm/x86/checkasm.o CC tests/checkasm/vvc_sao.o vvc_sao.c D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache': unreference= d local variable D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache': unreference= d local variable C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 227): error C2143: syntax error: missing ':' before 'constant' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 227): error C2143: syntax error: missing ';' before ':' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 227): error C2059: syntax error: ':' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 228): error C2143: syntax error: missing '{' before ':' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 228): error C2059: syntax error: ':' make: *** [ffbuild/common.mak:81: tests/checkasm/vvc_sao.o] Error 2 C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 229): error C2059: syntax error: '}' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 230): error C2059: syntax error: '}' C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um\winnt.h(21= 231): error C2059: syntax error: '}' https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=3D87858&view= =3Dlogs With GCC: CC tests/checkasm/vf_threshold.o CC tests/checkasm/videodsp.o CC tests/checkasm/vorbisdsp.o CC tests/checkasm/vp8dsp.o CC tests/checkasm/vp9dsp.o CC tests/checkasm/vvc_alf.o CC tests/checkasm/vvc_mc.o CC tests/checkasm/vvc_sao.o X86ASM tests/checkasm/x86/checkasm.o CC tests/api/api-threadmessage-test.o In file included from ./libavcodec/vvc/ctu.h:31, from tests/checkasm/vvc_sao.c:27: ./libavcodec/vvc/dec.h:36:33: error: expected identifier or '(' before nume= ric constant 36 | #define CR 2 | ^ make: *** [ffbuild/common.mak:81: tests/checkasm/vvc_sao.o] Error 1 CC tests/api/api-flac-test.o CC tests/api/api-seek-test.o HOSTCC tests/audiogen.o STRIP tests/checkasm/x86/checkasm.o HOSTCC tests/videogen.o CC libavcodec/tests/apv.o CC libavcodec/tests/avpacket.o CC libavcodec/tests/bitstream_be.o https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=3D87859&view= =3Dlogs Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".