From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove leftover comments in mermaid_print_value
Date: Thu, 12 Jun 2025 02:20:19 +0000
Message-ID: <DM8P223MB0365F13FCE779B1F1939A4CCBA74A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250611195725.95154-4-epirat07@gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Mittwoch, 11. Juni 2025 21:57
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove
> leftover comments in mermaid_print_value
>
> Remove some leftover commented code and an extraneous semicolon.
> ---
> fftools/textformat/tf_mermaid.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fftools/textformat/tf_mermaid.c
> b/fftools/textformat/tf_mermaid.c
> index da371c8fff..9d98b6a36f 100644
> --- a/fftools/textformat/tf_mermaid.c
> +++ b/fftools/textformat/tf_mermaid.c
> @@ -575,7 +575,7 @@ static void
> mermaid_print_value(AVTextFormatContext *tfc, const char *key,
> }
>
> if (section->linktype_key && !strcmp(section->linktype_key,
> key)) {
> - mmc->section_data[tfc->level].link_type =
> (AVTextFormatLinkType)num;;
> + mmc->section_data[tfc->level].link_type =
> (AVTextFormatLinkType)num;
> exit = 1;
> }
>
> @@ -590,10 +590,7 @@ static void
> mermaid_print_value(AVTextFormatContext *tfc, const char *key,
> if (!str) {
> writer_printf(tfc, "<span class=\"%s\">%s:
> %"PRId64"</span>", key, key, num);
> } else {
> - ////AVBPrint b;
> - ////av_bprint_init(&b, 0, AV_BPRINT_SIZE_UNLIMITED);
> const char *tmp = av_strireplace(str, "\"", "'");
> - ////av_bprint_escape(&b, str, NULL,
> AV_ESCAPE_MODE_AUTO, AV_ESCAPE_FLAG_STRICT);
> writer_printf(tfc, "<span class=\"%s\">%s</span>",
> key, tmp);
> av_freep(&tmp);
> }
> --
> 2.39.5 (Apple Git-154)
>
> _______________________________________________
LGTM, thanks!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-12 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 19:57 [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid Marvin Scholz
2025-06-11 19:57 ` [FFmpeg-devel] [PATCH 2/4] fftools/textformat: exit early in mermaid_print_value Marvin Scholz
2025-06-12 2:08 ` softworkz .
2025-06-11 19:57 ` [FFmpeg-devel] [PATCH 3/4] fftools/textformat: infer type " Marvin Scholz
2025-06-11 21:20 ` softworkz .
2025-06-12 2:19 ` softworkz .
2025-06-12 11:34 ` Marvin Scholz
2025-06-12 16:40 ` softworkz .
2025-06-11 19:57 ` [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove leftover comments " Marvin Scholz
2025-06-12 2:20 ` softworkz . [this message]
2025-06-12 2:04 ` [FFmpeg-devel] [PATCH 1/4] fftools/textformat: fix writing integers for mermaid softworkz .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB0365F13FCE779B1F1939A4CCBA74A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git