From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 30AEB4E9D4 for ; Thu, 12 Jun 2025 17:12:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7CF1668C154; Thu, 12 Jun 2025 20:12:10 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2109.outbound.protection.outlook.com [40.92.42.109]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3E54868A5E4 for ; Thu, 12 Jun 2025 20:12:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dyHUEpDZLkS0ym1FSHA+hV/++Ecr/fHKLLc3iDfOahCtah/SGWyOoHnS+7PtNZvS4vlRP8AVvag8TjYOarD6SrV2VjJ88jzYFkGbpEAcPZ3Wz+HLur3a4r1of36yDyVsSXE8jiy4s1gIWW7Q1U/VWgO9tl7swpOrGcuOytLJg5rjrfpXtov+NPeyB724ozF4oPQPI85JfS7XtIrNt5A5llL8Q6a8ArIciKaHtmaIdXOXF+UtPNURZF+xByh/BMfztYm52bQWSRSYm+UqanXEfbxEJtdAV1p2BO3RE2MF9uGBobl4Ds3+8RFrckzIVcly3LvedZ17X+JEYo3uPrwQ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JCn0OYXQzQPNNnNz5S6mNI6vMywU+wWAUW8E+iZ87pA=; b=XgVUmrVp75C9/XhQCgpjvTwzVlYIsFOLdB+QHmJLjxwluI9TmCgjGwcCydZ2K9ohQtNSRKqffdPhUPm58t7o7lkU4QjNEdg1GTiS1Nj/qPa6wDbLXZge1/cBqHmuj9+GxCiIRyAWwBfOjMwsXOP9pY6iOUezddNxJBEsJ/EEPC2od5wW3HITDbjAxHvG51JwMJOSh2SwoBlGUZntd84Xe1JFYue3I2snk3Atrb667WHY5ockR4RGbc0MoY1pkG1cq0KAaHrh56o8eg1fnUNweYHme5b3PIQiNQV1Jm7u5++uRvfc1WQCFlnkV4qyTx3mF8fg4ORR5QEzuYntTNa0Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JCn0OYXQzQPNNnNz5S6mNI6vMywU+wWAUW8E+iZ87pA=; b=JXHN4cQrFk5CabzSLPZKZPpICyV8vZKJZhZ0KLr1covnX91yUszSiEtjXO342ybO3vQBhTo435jsNhnnaYxZedo/DKQw4KsVymtYEckirJiNRn1FBljX9+wZp9BdxtCfWTYruF0zkdmjqWJi1L9mM5mSWgma30i+jYXLcHfci75iOIOmSO/mdOPsWWyPvZFip+K3OFWFdiZfcgLADQFDf3CR+Uf7wfNoDTSTl7TFfSF0ypgXM02as8SMX1F6wDkf53y2F0z5NJaaFvuySzng7R/jqQUc5n+611/EFZmnN05+D3TWj5UnjY6IAKBrS//L5CMEqoRuQpinZ7JP3LQYig== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by IA2P223MB1247.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:4ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.31; Thu, 12 Jun 2025 17:11:59 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.023; Thu, 12 Jun 2025 17:11:59 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes Thread-Index: AQHb2xFtsobu0ETyC0KHJhY1nBY0ULP+zBuAgACXBgCAAE9RYIAAEEqAgAAAfGA= Date: Thu, 12 Jun 2025 17:11:59 +0000 Message-ID: References: <20250611204213.97295-1-epirat07@gmail.com> <395F8F80-4C17-48A4-AD34-442029EF7D11@gmail.com> <3E1D038D-815F-4914-89FA-18C3F99E6073@gmail.com> In-Reply-To: <3E1D038D-815F-4914-89FA-18C3F99E6073@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA2P223MB1247:EE_ x-ms-office365-filtering-correlation-id: 512e526a-2dc1-4ed9-c02a-08dda9d43dd3 x-ms-exchange-slblob-mailprops: obhAqMD0nT9Mhdt0L/MjGVnTaKcEGyHKTb9sfBkFAV2KR0stAa34gMsp0guVZKPBisn6j+8/CmRhlro5ahwKn03lGnDqqbJWId8IzpoS8VhmYZAP2FYrmiA0KpBBAbEeFZlX3HO4GA6A71iV/Kf3XDAx5edcnQXXa/Ghjx4EQNMd7ahbM1vYlTqD9VSXZZyQgDxVshw1uHQDq55iHpRhEAKUIEAleYTp/ivZ3KlSOjwAAx/SsOzhnXcgXsxOzx6K40DCOtg9exLEO3oESVYP+ROYz1oo1ady6IYtmlEgqikMYCZQqJUFyRHohTGDAZOTJlrI3PdIR1HB3J13YO/OuR3AaZdCzqTdAQVk8iRktgbh7YmpU1qY1u+GN9ObXar72iNAxoT0te6Cy/itLSivHIwCntW+LoffDinIznN6Tv3IEdsNSFhTT7NFv5PjDtol7wVI+f8Sl9qVNItcXexYTwTJMJhVg/vfLuPQjvisVt/oOvEBjc/zlNNZVUkwP56eys+NUGw1cfBT/Lm0iZlTcR/WN2i7QWIoB9tKNVTcUAaamE9NITJznhC/kSIbHOaQ/Y3zC+LjszYdWwtpvKmD/6+XiqeiMug4wHnW85EFFIKDIHYVUeQED3Q3UKyMk5GHIdD2W8BAd/SRR31PaIdsRhVZWVN1ZXgay1osIjCV6JTKC2y9o2Br3UYzgYqYLfzs599Uel2kFuDGMum29HkBumpwTqSfixDsnFLpO0VS3lX5TbMiewB65sBQ/xojb6kX6nzDgoKGtBTy8+CshsZxMaEVbnNcU4iES22sA00cj0r3hUOPFMi8zHBe4hhMEedo x-microsoft-antispam: BCL:0; ARA:14566002|461199028|7092599006|8060799009|8062599006|41001999006|19110799006|15080799009|4302099013|3412199025|440099028|12091999003|10035399007|102099032|1602099012|40105399003; x-microsoft-antispam-message-info: =?us-ascii?Q?eSCLJk6OzYZRCIcjyi3n1tTEdobZmamtJ6+LNnGnMfrgzi/2hGD0uA5Dy0kz?= =?us-ascii?Q?jqBlNmHwzrnFLJ+U3YnxuIoEA66j37l6Z+3CNALWPxEYTHP3I5PnCW+pMIsJ?= =?us-ascii?Q?uNSLSjxtSU90Ohpnl2Uc/AKDFPVxTSZ02CtrlKn+g2efgwuxCrahGn7zxfSz?= =?us-ascii?Q?ScjTLhS/1PnMzfBuD5qV4atFl3vcXdlSsJUOb8/WyYXemyVCQuX7x4PpDppZ?= =?us-ascii?Q?2MRESxBssSSJQzLjhfLIQxuNmF8Qpc8FMNr6MbvYso0stCXwyFUml58a3PvR?= =?us-ascii?Q?vvmZ9aPk54yxBzMsvPEbl7G/M2jatdoJpWjVZFIwgzw6tCFu4GfhotwdxGM6?= =?us-ascii?Q?3F0FAxQRP5v9qEpfPNvhjLQ8puQio0YZsE3XDr8iH/NDwHY3skas8DF9qaAw?= =?us-ascii?Q?LH+9yEAgVGmtjakWNFKNkp/kD6Oacf1tYoG0oHTJlZzEcHVg1pNdVOLyTuWh?= =?us-ascii?Q?HYtjNjBeVLTO38flFTHbkoYkuKshUVMX4Pn47eIcTas/PZEbnKB5/B4YC5yJ?= =?us-ascii?Q?Z2imW5fH4PbshRt5fCGVJz9GOoHellp2qNb0WHmMz1XaZYga2NLJUQAty9k9?= =?us-ascii?Q?aLcpkoUezTWuDZCEM45sTrHn4KHBUSNch9hB5Tl1Ei0abjEniFcc3pzt7+Vj?= =?us-ascii?Q?10PRphCcNqgODRMnYXyKF86pfEw3g9/yywX7YPgJN+gIdgaomV513FttqwWJ?= =?us-ascii?Q?mBQqJ+ZPxIfbiAhypP50CngdM83Y8s69TZRAOp+M88W/q8QOiKn8fXAu+Wxv?= =?us-ascii?Q?0lgrQPvnLZjbN/CEgUp7RhFAaHPJIxDWZ1AL6Egma5YbqTpI9UrBqiBB1mnS?= =?us-ascii?Q?il9giKD80Iz7jzl0ZiwwTJhq/8l5wi+uh1YymzDklxEYG0nOdrGMLGzfBlFN?= =?us-ascii?Q?mnkJTv0QvjsO16yYCG8NLFXzSbHLStx6cdFxWHjoY+iSEqbEyL2ykYaO6QL2?= =?us-ascii?Q?+/WfGycHKZdwp5q7siJRfnbL8ycg9n4lFu3Y6RhqjO+0faJJgxMM9JrvHKWH?= =?us-ascii?Q?SfjB5PgkXXBVAAe5RJzW4P7AgYV2JXTWKUmKCy20r3LCJgzpVovyoDRqvY6X?= =?us-ascii?Q?L94+xyQFmXBiGhtZc1AtKje7UBPhQZPLhgod/kLSnZlMOMm8ajAassRWY2V1?= =?us-ascii?Q?8Tf4wK1jXdkJY/KjfUR2753p84/ScVg4Y84WgB0g8ZZ89p5uvZFbxr/oRQOo?= =?us-ascii?Q?GIK/msc/wuf5cbzHTrWOAPAbtw562E7hGMRDOdwpn5bbZh7wF7D6b651nsXx?= =?us-ascii?Q?BW2IF1lR18PIJ6JiVssRBTEY6aNwuoQ3wEQY9SftSwZxByyMQz2tnQAyZWWw?= =?us-ascii?Q?wfGfwiwBVQU+NGLJ9uAa5c+p?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uA1JZi6CoiSoBGM+rqP05E1tqn8OCP63trkvShvR+RXqLqxiMFtmU/WCd8CN?= =?us-ascii?Q?ptCb1CoySiDBcnxS8J1g1nEvmIPOf2PYdRSWS/bo7S9vx9W/5Ls2+mVuk7QS?= =?us-ascii?Q?80PXbiDzMXRCcPnoj5SqdvBaCAw0TJZuj77DPc0rUestQtAb7m90ele1Lfna?= =?us-ascii?Q?7J2hzlD0rcAah6C0ytRRKUvlLz2pHh48ekU7VkORlR/2usawGT+t7xETIEEC?= =?us-ascii?Q?ul+5BuoJRjNJOCCz6to4V0yNxSns4ELmt+Wly8OLBPt3EzjL/rynWm+pAPWJ?= =?us-ascii?Q?QTtO9RtpVRLhxZypxhkSHnvk84cvcPbANkYvXu86AwGT5EJ8EzqygPME9KRc?= =?us-ascii?Q?VTwdf/qVkkJ7PTJXksE1sDtgLNse1EWcIf37nnGhcEhzvG4Riv3jbzqO/yjq?= =?us-ascii?Q?1qZBdj4sT9PLROX9nQDR0MS/s3E0g9TE/I1I3WE0rxxsK8dtoK/b6HkVHP9h?= =?us-ascii?Q?zxiEumpnNRk3ChtBq/HSOSL9QcxxJKEJEeDFUDl+U4SE2XnWKJvaqsIJj3tt?= =?us-ascii?Q?rpzx8VxWg+f8GYU9pMpQ42Ze6vb7qOrZ3IhplvdfHg0/GC6UWKq6ETaAY3Tf?= =?us-ascii?Q?e3zBMeZl/D+TyUya82JrHlxEoFfreAATGbfc2Ki7w1T4Vg8WHUfdcXuq6aw6?= =?us-ascii?Q?8YHz8K/TwYDwaoHbj58va5A0DEzP7jLN3Nh9AP4ao2KeZ80NYqLJnh7HmP/X?= =?us-ascii?Q?VVr45AOgs55Civa2EX++bTGauQB3YA8+VmOnIm+yR7J7gEKJCDdaVK/EYTHK?= =?us-ascii?Q?TFrO4AlX/AkLdeZ6BHwMnfepSObW5P2QKoaG2FiuFzhFfouvjxcAQFu3aq9n?= =?us-ascii?Q?ZXB/BRYcD+LhgTRytReergW+/HqBNq7FZk/s2pH4u2LxBMYoN7L46osM42rB?= =?us-ascii?Q?ryh773viEd7TQ51vph2VPGyeJ5HbJmHKuBG1JROvkj+Yeg9tXroZk1jP2BBr?= =?us-ascii?Q?PqEQaGixkwt5B+Him9izb1g6TnNSEnqOAEjGoAtO19kcRKVbuec9nTFkeG0P?= =?us-ascii?Q?y1EnKBhg8CQHh/X/Zu8k/3+3gRvuXQfMpI9tSvrHR4gilfeGs23O4sqBZSCz?= =?us-ascii?Q?HApd6bTXSnWJDXVEQM9AoizY56jOrzMHPYXz0B/4YmBU4pvUrF/Lm6Z77yA+?= =?us-ascii?Q?5EJRstweSP1AGJpCAWn4t5iuwl14A070sGjW/1pflxnb/x97zFfGYESY/z0W?= =?us-ascii?Q?4lN+kUPfJJjsOkPhAx1Nr7I8PZaWOYFPYfAnZzYGdLGsDPSFZHYBmexelPI?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 512e526a-2dc1-4ed9-c02a-08dda9d43dd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 17:11:59.1672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2P223MB1247 Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow variable scopes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Donnerstag, 12. Juni 2025 19:07 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > variable scopes > > > > On 12 Jun 2025, at 18:10, softworkz . wrote: > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf > Of > >> Marvin Scholz > >> Sent: Donnerstag, 12. Juni 2025 13:25 > >> To: FFmpeg development discussions and patches >> devel@ffmpeg.org> > >> Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: > narrow > >> variable scopes > >> > >> > >> > >> On 12 Jun 2025, at 4:26, softworkz . wrote: > >> > >>> Hi Marvin, > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf > >> Of > >>>> Marvin Scholz > >>>> Sent: Mittwoch, 11. Juni 2025 22:42 > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: [FFmpeg-devel] [PATCH 1/4] fftools/textformat: narrow > >>>> variable scopes > >>>> > >>>> --- > >>>> fftools/textformat/avtextformat.c | 15 ++++++--------- > >>>> 1 file changed, 6 insertions(+), 9 deletions(-) > >>>> > >>>> diff --git a/fftools/textformat/avtextformat.c > >>>> b/fftools/textformat/avtextformat.c > >>>> index 14779e6f0c..f1811abb1c 100644 > >>>> --- a/fftools/textformat/avtextformat.c > >>>> +++ b/fftools/textformat/avtextformat.c > >>>> @@ -101,7 +101,6 @@ static void bprint_bytes(AVBPrint *bp, > const > >>>> uint8_t *ubuf, size_t ubuf_size) > >>>> int avtext_context_close(AVTextFormatContext **ptctx) > >>>> { > >>>> AVTextFormatContext *tctx = *ptctx; > >>>> - int i; > >>>> int ret = 0; > >>>> > >>>> if (!tctx) > >>>> @@ -117,7 +116,7 @@ int > avtext_context_close(AVTextFormatContext > >>>> **ptctx) > >>>> if (tctx->formatter->priv_class) > >>>> av_opt_free(tctx->priv); > >>>> } > >>>> - for (i = 0; i < SECTION_MAX_NB_LEVELS; i++) > >>>> + for (int i = 0; i < SECTION_MAX_NB_LEVELS; i++) > >>>> av_bprint_finalize(&tctx->section_pbuf[i], NULL); > >>>> av_freep(&tctx->priv); > >>>> av_opt_free(tctx); > >>>> @@ -130,7 +129,7 @@ int > avtext_context_open(AVTextFormatContext > >>>> **ptctx, const AVTextFormatter *form > >>>> const AVTextFormatSection *sections, > >> int > >>>> nb_sections, AVTextFormatOptions options, char > *show_data_hash) > >>>> { > >>>> AVTextFormatContext *tctx; > >>>> - int i, ret = 0; > >>>> + int ret = 0; > >>>> > >>>> av_assert0(ptctx && formatter); > >>>> > >>>> @@ -202,7 +201,7 @@ int > avtext_context_open(AVTextFormatContext > >>>> **ptctx, const AVTextFormatter *form > >>>> if (ret == AVERROR(EINVAL)) { > >>>> const char *n; > >>>> av_log(NULL, AV_LOG_ERROR, "Unknown hash > >> algorithm > >>>> '%s'\nKnown algorithms:", show_data_hash); > >>>> - for (i = 0; (n = av_hash_names(i)); i++) > >>>> + for (unsigned i = 0; (n = av_hash_names(i)); > >> i++) > >>>> av_log(NULL, AV_LOG_ERROR, " %s", n); > >>>> av_log(NULL, AV_LOG_ERROR, "\n"); > >>>> } > >>>> @@ -525,13 +524,13 @@ void > avtext_print_data(AVTextFormatContext > >>>> *tctx, const char *key, > >>>> { > >>>> AVBPrint bp; > >>>> unsigned offset = 0; > >>>> - int l, i; > >>>> + int i; > >>>> > >>>> av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED); > >>>> av_bprintf(&bp, "\n"); > >>>> while (size) { > >>>> av_bprintf(&bp, "%08x: ", offset); > >>>> - l = FFMIN(size, 16); > >>>> + int l = FFMIN(size, 16); > >>>> for (i = 0; i < l; i++) { > >>>> av_bprintf(&bp, "%02x", data[i]); > >>>> if (i & 1) > >>>> @@ -571,7 +570,6 @@ void > >> avtext_print_integers(AVTextFormatContext > >>>> *tctx, const char *key, > >>>> { > >>>> AVBPrint bp; > >>>> unsigned offset = 0; > >>>> - int l, i; > >>>> > >>>> if (!key || !data || !format || columns <= 0 || bytes <= > 0) > >>>> return; > >>>> @@ -580,8 +578,7 @@ void > >> avtext_print_integers(AVTextFormatContext > >>>> *tctx, const char *key, > >>>> av_bprintf(&bp, "\n"); > >>>> while (size) { > >>>> av_bprintf(&bp, "%08x: ", offset); > >>>> - l = FFMIN(size, columns); > >>>> - for (i = 0; i < l; i++) { > >>>> + for (int i = 0, l = FFMIN(size, columns); i < l; i++) > { > >>> > >>> You are changing behavior here because size is changed inside > the > >> loop. > >>> The pre-evaluation into l is intentional. > >>> > >> > >> I fail to see how I change anything here though? It is still > just > >> assigned before > >> the loop runs, just that l is scoped narrower? > > > > This is the original code: > > > > l = FFMIN(size, columns); > > for (i = 0; i < l; i++) { > > if (bytes == 1) av_bprintf(&bp, format, *data); > > else if (bytes == 2) av_bprintf(&bp, format, > AV_RN16(data)); > > else if (bytes == 4) av_bprintf(&bp, format, > AV_RN32(data)); > > data += bytes; > > size--; > > } > > > > See the size-- ? > > > > I see that but again I fail to see how this changes anything. > I am not changing that l is assigned before the loop runs, just > narrow the scope to the loop. > > See: https://godbolt.org/z/c3hGKfne4 Ooops - my fault. I didn't look carefully enough. LGTM! Thanks and sorry, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".