From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 218664430E for ; Mon, 5 Sep 2022 19:41:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E115268B44B; Mon, 5 Sep 2022 22:41:34 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2097.outbound.protection.outlook.com [40.92.42.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9278268B44B for ; Mon, 5 Sep 2022 22:41:28 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HDfa50MaHXjAoksDKwOxrisY9Dm8Dwx1jEge1KAeXkGfvkkDpWJoTAHWWgzTEHlv/4dPwSmU6elr4EkzkHUL/JfoExzcKGMUglKfWFusNCfNVbDu+JUL4Bb7u02DFfneB+Bw3BVh3zcU9w1MMHrp4ePU7j3+t01sSi9g6bhszR3z7sN3otQrZCWlsfkbYtgmOgHGOqVXmy4s6aQ/ED2Dst4S5bY3kdJV8XWI6RihOuyEokXaMyli38zPVc1rJbi8on7OqOKUAXkOK1m/eYi5ZPWce7gsHd164CqSDvA6FheOGq7yUSD3jSHt8TS7dGk1/x2WJ2r/uxKFt03uT1R0zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5DTSqp7e9le2Ti9vJn6oHqKrAtBMw03sAKQMPMiDXU=; b=UBmT8O1SXCXPfuXsv1+Ca1ZtiY2dG6qNB7klEmvtA3gBsPzk7ysOuu78fTYKw0I7k7AUJY3gkKN+pO2JQDGW1Rs5TUAa1zQvxWICB6lyOftgs3zLbb8GmgHKqwfno1S2IxaYucru9SL/SPbY6Zeqs5wqL9mMj+6WvRR2dTil88jtDPSMBfZPSwJl9LUFzAWlm3Qg1bu6aal13JExRvxTMmO9EC4CTtGHqPQ2ShSt2ucR0H//kBaoP8kArPUuyY1v+nD2NbCfmBjoUep+rwMxlgEl8R/Y0oDBWOE4+5cFK3G3RpEb8EwxNKX+SK1y1dx83W83+CVRoRmOAFlMKJwZnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5DTSqp7e9le2Ti9vJn6oHqKrAtBMw03sAKQMPMiDXU=; b=Xq2QnxfJeopYL8w25fgynzLbHUKfiZ7zUckuYDU6WnnK+LM+/ntcH87Yi9TCl9FghkoQox/ShVhcROJDjAZvisg3MTJNiPbdylz6D6889fFamurQhkSoTpBNTtGs1mmJpJjTc7aMRO9veGAM+U/b52q8GbqN8vxp+da7UpCoplHpbSRdKaOq+eUVP5BFpZ5+hJrGbvN5BERIZb6NTHc85cP4pcIt7rlTb5nyleQdJ4HP5k/wGx1e4swgyEgK4Yb88xAhZnVEmm/zUBMka+Yp6AektHpqIBBQmlwVVLnvSFE5XVXRo29x+FzECC/t/CTbr8ghxr47eOhAloILu1xuWQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0014.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:154::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Mon, 5 Sep 2022 19:41:24 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::59af:f946:e59d:784b]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::59af:f946:e59d:784b%5]) with mapi id 15.20.5588.017; Mon, 5 Sep 2022 19:41:24 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [RFC] d3dva security hw+threads Thread-Index: AQHYvlsm8NDH6SmX30mfzPKm/JQGmK3LPYqAgAOdMoCAAYHfiYAA4yTA Date: Mon, 5 Sep 2022 19:41:24 +0000 Message-ID: References: <20220901233236.GP2088045@pb2> <166227470363.5707.5961328202531700226@lain.khirnov.net> =?utf-8?q?=3CDM8P2?= =?utf-8?q?23MB03651F44AF0CB13A516C4C52BA7C9=40DM8P223MB0365=2ENAMP223=2EPRO?= =?utf-8?q?D=2EOUTLOOK=2ECOM=3E?= <166235755622.3205.11723035588545989440@lain.khirnov.net> In-Reply-To: <166235755622.3205.11723035588545989440@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Xgm0EoXk8Ov03aLAOnESL9iZIxuLQFhW] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b22084aa-e78b-4a47-5048-08da8f769e01 x-ms-traffictypediagnostic: BN0P223MB0014:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: phlBV66vmGaiWq0y+t4kUXFF6n98MGLQPT0CKq3tmaC+xyB/LWuRnpCOZ+PSCAvBYjxZ/B9Zv0SZpTmZUPpYtsoY/RnoMAC9RDv2qMDagVfmge03QyjNzcfmVJfQiR4JqisgiBmAE4+NoGVOmYZV0JGcil0fDF7wmhfbDyXgzD6NZcxeWw1K9XvNAxBW/P2q47p9kVBrhBuhtcqFh6SsCryCIhpP8hUmkbhe4QlU6D6ilBubO0Vh2UvnHgVTviDfWfSqCNEO96s49d/RXYNqCktv/WfcbEuHS2i6Eey4sdejv7d5GttReIaEHJU556R1vcoN/1004RDowavJR5W2vUZUdcUfHHzmzB4aouSG6jQ5kMYBjslOJJWvHYsJK8xLbzmh5O/wLNOWRPv/ZA68dHfsUb5zauITCZJmnBvP7qpfRN6Y0ZoA0t40Dz2Ru8H2ukYRttsZqviV2OTqLq6mqC/WBi8ZlCJGnSK8Q7oFNdnOeP9GRMmogGHsZk8oO9WvYTadEs/W41HTQmb51fzRXQTtpudIuyU01gqC7jmiga2Ct6Cgoxk99gr8WqCTVYXCjf/Td1BhgQ9H8K4AAjZFe2ajd3q87xQ+O9k7BpVK/Lx9wIbsxr7TwNa6ZyuV+RFTGJ76IDn6hb2WzBk1X3WC29I+LJ5EtOBMo3BurvmEM7dW/v+MzBYFRA2iN2MrrGg3 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cnJUank3TC8xaU92cXgwMWY4Umo3dGtKQ0lscUZMSFRXL09rRVExLzdJZi95?= =?utf-8?B?SVk1OHFaNzZ5WjFZMDFaV3RSYVBQcVhlanNON281a01OL0pOMzdPbTdqZmZk?= =?utf-8?B?NGVhQVo3ZEhVaHdpUE8rY25NQjNHRzBCZWtPQjNsd0ZYd1hudFk1ZjNabkMv?= =?utf-8?B?VUdzNWFIdjU2U1JIU21OUGdHamJSQUpacXNIdXNwQ0NSUVIrT0F0VWQ0VktU?= =?utf-8?B?bjJSNExEbE9sandXYXlLWEo4YU9ISFk1NytJTm5FdGtZUExKWkhYOUJqdnQy?= =?utf-8?B?Ujd4VUZrWkhmbk0wb2U4Q2xjNTRhZmlXMU1ja2greFBNMVNNOTRKRVdlTTE1?= =?utf-8?B?aG5HTVp0bjhWakNsR1gzZEFOR1RaQWdtOGtsdWxtblc2bkM2cE42a3VzVm9Z?= =?utf-8?B?RStoME9sMUQxY3BEd0pybjJFOUhFT2l3RGpSMEhkWjB2ckw5MUpRL1piSy9m?= =?utf-8?B?dDE5WmJkRERQNkV2V0FNYVpWUk5zRlNCRmU2czF4eG1KOFpXcGp4QzJQa2Yw?= =?utf-8?B?elN4Z1Frd25BYklidkVvcERoSVB2UnlhYktoNnZDa1YrQ2NKUklkeXJzSVY0?= =?utf-8?B?VC90TktDNVVNNkNxRGRHcHloQkdYZ2JFdlBwVXErLzFDQm80aWFBeXQvMklG?= =?utf-8?B?akpEd0xyaS9TQ21Ob1NDdFoveHJmY1VLVE1lOFJoTm40UHZHSXVubEJwSGVj?= =?utf-8?B?Z2JITWUweWxYdzMrZjhWSHo4dmNjRXlCTGM1V0FJL0NuMXlWRjM3bTVUZ0lt?= =?utf-8?B?NWJReFJCcytyRnUzNEo3aFFzaS8yeDZMcWtZMEY1d3crY05QU3hMZlE0TVR0?= =?utf-8?B?bE5aM1ZEWG45RDlCaWFEZUxPeGFuM2kyNVlubzNSdTBJc1pOa01BNGNad0Vl?= =?utf-8?B?SUtJY2RYUlBTd0J5bWtsSVBMa2RuekFDNlcyemxpYUl0TzNleXhjeFk2VGhr?= =?utf-8?B?Z2ZJRUhoZHNHRGxROCtpZ3NJNU1xdjBpZWZXakFiQXRMVzBtQnhTb3lZTFJp?= =?utf-8?B?YmN1MWZPNjRsTk1RMzJMMW5Tb0NoNkRXTThSMkh1SEpkMnBaSzdXS3RPMytJ?= =?utf-8?B?cm85azZaRkJoa1dnZFJ3OUMwYjh4RmpnRW4wZ1FEK3NsNW13Z3RJS2pZbzFN?= =?utf-8?B?RjFwY0NjeTUxUkpnQ2lnTSt2MWo4cE9Celc4OHF3em1VbzFIYmlYd2xDMFdr?= =?utf-8?B?cVkzZHVOQVVZMmtLVWg1eWNHRlljOElRRkY5R0hOTE10RlU3TTkzaXNBL2tX?= =?utf-8?B?T2tyM011L1JhUTlMK01sN3RnOUZsNVlwT3BJM1FUZk5nSGlUSTRGVy91WHdD?= =?utf-8?B?Nm1vUjY2NFh5VFAvc2x6Nms5eTdEaEVOL2VTLzZQUVRJMDBEME15Rm15cDdm?= =?utf-8?B?S1E4a3djS0lvVmhJOVRNYk1EVitDMzhjRmtYa0xLZG52NjdrVE5kWmp2Z3lt?= =?utf-8?B?MWNJTVVSVVZhbHEzdUNJS2hRUHhlOHRVRG4vMjV6YkFVK2dNdUoreHpJTVU1?= =?utf-8?B?UnVKaERmTUdBRVdYV2JxTC96N0RHbjk0NnRjS1pXanNoWlRFaVUvUWpJdVg0?= =?utf-8?B?L0MzUXdRZno4WDVVMDBodlNiQU9qOGVBZjFtRWh3Mm16bEVUNWM4ZkhjRDhi?= =?utf-8?B?TytONStVVVdnSFpDK2dPU3ZqdER6MlB4eERQUGlRUVpFemQveEg0eVVJKzkv?= =?utf-8?B?ZVdaMnV1eUl1VnBMWnVKbDlybkI4V2ZNdVdubjIzZ1RtK2ZmUFp3eXZBPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b22084aa-e78b-4a47-5048-08da8f769e01 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 19:41:24.5833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0014 Subject: Re: [FFmpeg-devel] [RFC] d3dva security hw+threads X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, September 5, 2022 7:59 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] d3dva security hw+threads > > Quoting Soft Works (2022-09-04 09:43:36) > > > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Anton Khirnov > > > Sent: Sunday, September 4, 2022 8:58 AM > > > To: FFmpeg development discussions and patches > > devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [RFC] d3dva security hw+threads > > > > > > Quoting Timo Rothenpieler (2022-09-02 01:46:59) > > > > On 02.09.2022 01:32, Michael Niedermayer wrote: > > > > > Hi all > > > > > > > > > > Theres a use after free issue in H.264 Decoding on d3d11va > with > > > multiple threads > > > > > I dont have the hardware/platform nor do i know the hw > decoding > > > code so i made > > > > > no attempt to fix this beyond asking others to ... > > > > > > > > hwaccel with multiple threads being broken is not exactly a > > > surprise. > > > > So we could just disable that, and always have it be one single > > > thread? > > > > > > We are already disabling it in a way - the frame threading code > > > ensures > > > that threads run one at a time when hwaccel is being used. > > > > > > Is there a described way to repro? I would try whether it still > > happens after removing the lock code in hwcontext_d3d11va.c. > > Those locks are not really needed and might prevent release > > of dx11 resources in proper order. It's a guess only but > > easy to try. > > The problem is not in d3d11 locking code, but in the generic code > that > does not have clear enough ownership rules. Steve already tested that > my > patch from Friday fixes this. Oh I see. I was missing the context. The patch makes sense to me. Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".