From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1E42F4D033 for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 22:59:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7C608687DBE; Wed, 16 Apr 2025 01:59:18 +0300 (EEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04olkn2031.outbound.protection.outlook.com [40.92.46.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 411B1687D65 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 01:59:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=df/tZnYOnEsPbxzEhnTEx2hhJR/U/Bu7XKkVqmlgaeXDN3FIFi06mgk0B5UPf5+sc6wJZLZQChxsBprLRNXC4HmLfSGGu/94h2WEstTu3K6ezXd+sl1DL1U0hEzQltbC4SvbetG6UeDzgwI+aNYlez5BoWy5eUrBRxICrPvObFTF2Z6mYQe3HJHZv8lXMmKQ51fRTDnYFZqoUZGuRGfmjBh1chvTHMFUhWw344LtLyk7S96hdNHESLUc4gxrBAc94nzBVRk7Pi6AcZ7XxSyG2LKTEfMylupFcv1wrfs0GM89aitBeC2MPBfNPHTO2NvB7WpX8DUY7bts2Z95sRc+Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjKw8re0+g6krznbQ37xKuxTTHO9e/TRtr2oErmbUNg=; b=fUbwLGTL1g+kmr5C+v3ds/79HXKBOjwO0jhsqbYzZkUNPVc0qT62wm7m3xO/eHmAIvOzrIqzP1OZpS+MZ9kFOAXb3rnui3vyW2QsuNAn5QiluawBHr+C5csN3XfM2fGCYTAtamoJGxx3Rgxn3H0czf4nIvNULPqliCrj2KvLO+2Y/jZOOt16NaCy24rwHyW0mURTcWc8CLWajMo/KU4QiBaHBcMz8JSdeo/W01keJh/FYwRtlLOqMev1KjMB9TRpecNiTeT8dKpa4yi2WEkyZ47mKLK2agy2Or4rRaN1/CIs71199BmbZqZBXl41w4RswmZ35BKNUNiiFC7mygXlrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wjKw8re0+g6krznbQ37xKuxTTHO9e/TRtr2oErmbUNg=; b=aOqAJIivauyrHa0iIdMo0e+y7Q2vQRptr/YG2rBtK/Qexga3aMflMKibqkY1tAoi0m4rT3k5QWGhT/Zz75GGLlRKGzQzkiURjrtkiOYfpfuaFZWp3IqgY+jAFyN2ApcMtNpy9ES/mrm4VCWreq39XQYsV8LLupinn0yzQHrJjfr91gHvW0VbZuZ+VSypP8hpM8iScFG+uDdXf1ewu/2mHl6WL0T6O1VdgJckxDzF2KA57ycvl3fZ3N3oIOjpqim1kG/kQXtg1nc1LsfGp0wbBJS+JNFpbN729ig51DYj6cknUeD0Q3AZAWoaETPYPDnT/bFVa+vCc4QzBVDcLiEFvg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by IA4P223MB1835.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:562::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 15 Apr 2025 22:59:07 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Tue, 15 Apr 2025 22:59:07 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAAAZwAIABQhQAgAAFo+CAADvZgIAAAb7Q Date: Tue, 15 Apr 2025 22:59:07 +0000 Message-ID: <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB0365928500AB53069869DC99BAB32@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415185538.GR4991@pb2> <DM8P223MB0365E10D38EF9174A32557DFBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415225001.GW4991@pb2> In-Reply-To: <20250415225001.GW4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA4P223MB1835:EE_ x-ms-office365-filtering-correlation-id: 8db5b5b1-3a33-431b-c7bc-08dd7c712086 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|8062599003|8060799006|19110799003|15080799006|7092599003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?NX4QNhYff9eD+R6/nkWoOAHIP+HsvxiSjtpfyYiZXhhV2oi3hQ2HwPAqaAX2?= =?us-ascii?Q?tOKgATmcbleSArjbCqUOrpnIZ3R1ZIeKwcAvY15rp8Pp36UG7pWae4faPGRJ?= =?us-ascii?Q?WUEuXbWX9WWBp5qbgoogM2OaERer1a2/O/3Kaz3Ed51G52J1YU39bh6eO0LE?= =?us-ascii?Q?c46KyJN8vZfvEbTLVFyL3Um7kzalkD3PnBLVSr4cXBIlp/zyM1ApxnpzwbxU?= =?us-ascii?Q?Zt+/bdUJN1pFL2zORQK1mhB3KsCEQmhU172c7vdWvGKd3KIRBM6ZU8iVH3EZ?= =?us-ascii?Q?fyKWgaAOfCgyr4yxBGWv4bOUfp6gauiSEjFA6ae6fSSKQeRLRIqOHaucTKz2?= =?us-ascii?Q?g6wnntr57PYfT0i4jKgUPq736Rt8gK5j0FILIcMPKYq7pYdRHaAKmGFhxUGF?= =?us-ascii?Q?GzOnirGTAn+G8QoIZPsjifiw20tJT3WLSL9Uons5rP69LlLmhTfM2hHLmxNi?= =?us-ascii?Q?04URNRY2vrZNdayY4/xhCTVUDVO6epGxf+RhA/iU0oZbpQ1A8BSEZcKUDDr2?= =?us-ascii?Q?zv+0P48GoPwUeWmixr7gvlUPbUnmltfQhkXi9HEqk6fLdq6N6+Lemq6W9kiL?= =?us-ascii?Q?uXZdbXa7wBCOCLfB43z2GO+U0IsYRqd6FKUDSEldIHUK6GKTipVvlb3csZfg?= =?us-ascii?Q?75LqyR733miDeZs2kULzt7C9i/Mw0gKUAr6fxo3hkpbQzi790tV/z1VSRNes?= =?us-ascii?Q?y5htV0hW4TtMA8Biaq/2uzPtpWdBNtqltwdGKWGsw5iOZ9I4xqInAkaE5wYu?= =?us-ascii?Q?UY2ToSyYRWqit//alKdQmPRVu4wTkQs4689zevpD2JvMydHI35MDzrhFZk9v?= =?us-ascii?Q?Hopv9kmbyAa+9bWG2WO5LFq9dUAY49aJZ3J5lTbevQeTihJ1VsOSB1aEn+sH?= =?us-ascii?Q?VRh8eXRA1FZNgn2+TgFbEUPXZKdu4h7OvI9XkvqemO+rkW+eP1N3owy7Y0G6?= =?us-ascii?Q?liFl6Viyh8s19cmKvJWRlAasa03zh19luGTR6QlDjGdxfI5tg7Z5t+18EdT0?= =?us-ascii?Q?0vu/5ZK2Xpa+S647kjyDt7d8eYDIB50W6CRJO3Jr1jEdWbsaQYPC4EGxGBjj?= =?us-ascii?Q?ZQL13/VvpNYj2kjME5DA57b8YVfEkUwkUyiNLOLUNVAAmS4lv9g=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bzWbZ0i84cyXOA1BhK7ktVdjlF6nMRtRq/blZ1uS3FQvVnGqzLLP7WC1uUGR?= =?us-ascii?Q?63p/fBRolEEuEcPdqxbQJ4EKuo3yGz3TAtAfZZClZ1CQOszpVtJrhk7+z1Yb?= =?us-ascii?Q?v5wnWxpqMzWRzkqUz9MjbVlIgbxKUBaEp7vY0q4TtGvsaja+BdjSPLIYqfUC?= =?us-ascii?Q?3vHbu7MpAx5vgK4x5WDlhEBL1DJsJgoIAOFQDOROse852juLdFERkV3ICXQY?= =?us-ascii?Q?1eV4039oG0IIUz8R4Z2sBac1sSpPaESBANuyrmM+VYeKNVMo+Sy07N3sUTFf?= =?us-ascii?Q?Ri9sMEfuYKtDF/dfx4na3NnZ5Atx2vRFmaB/O/zQsbvVfanx1Bd5m1Nex7KH?= =?us-ascii?Q?vgWOqfQRQxQJ/nvsNhJJjtjSdLir8vGfMYJh6MhX1PCekC+J82W26pqJScwn?= =?us-ascii?Q?JUWnsKsntGw8Y7bWNBDsJAyu21zs6KZM4bnLy8dcbGr9BMJ6nvY1OoaQ4pAw?= =?us-ascii?Q?MSF6U6bKP/TLLOTNgwDpiTqABzUK8EmhFI+yzNEIuapZbxYYI3GfRH9mudj8?= =?us-ascii?Q?0FEbzcSedH57eIC3r0MX3IHRqcapLedbiygbNGaots+GOcVgZzvTmkVLRFHw?= =?us-ascii?Q?RL+SoicBKgVvl3f13g8W7FIIhRrCx3v3FGelPskQICWL9jTWZrgZK29FknFF?= =?us-ascii?Q?I91AtFISdOK+CFkFIsFldeoAyRMV9Ek3qfpEgPiNZTGzak/DQrZIHp45BwGn?= =?us-ascii?Q?6jctplIUBXFHw5aVImMnwkXliqULJmLCQjQRhs5wcecA6liVhoVRh/lZbAjz?= =?us-ascii?Q?HEVHEmCJa1pd2MH7X708HNmlQoH+v1YETrHsPPaj5DVwnzvp0Ny9VmlZirL3?= =?us-ascii?Q?VNL+t6jOjZMerbbDZ98KFViNzcB1g/yiYHmQ8OnTfFD57/WLyTw7YSHqy4tt?= =?us-ascii?Q?1c59mWealI2yc2QQvh8rE9u+C1hu3UcXjwfpltfPKh/PtwFhzkmCQU4fxhxN?= =?us-ascii?Q?v93meafv+yqXXyd4GM3D0LGKJ2Y5WJM49rpTmQX/FeGc1xTLZ6ysEQcjHBdG?= =?us-ascii?Q?Yi0JeECJYtMcJ7IHiADhA1Sgw6mYoQFRbzecFH2RF4uDsRJ0NGr7IGjlt7CN?= =?us-ascii?Q?kTt2fyvm7kXymdx7oHrKOIR61xGU+BO/guMy/7vW1Zarut7ljZnGcN7kqqwt?= =?us-ascii?Q?pnFlj/W37Bxra8ij6Q5aK81vNtNJOesir2NC1zGodsCOPMsWXcK9gn258loE?= =?us-ascii?Q?n9a+xUnsgN6/H8nhOdtRsSdZVy22jC7ibKqQi+wY8RZgOrvqDn9o9ycnOvw?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8db5b5b1-3a33-431b-c7bc-08dd7c712086 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2025 22:59:07.4978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4P223MB1835 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 00:50 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On Tue, Apr 15, 2025 at 07:59:00PM +0000, softworkz . wrote: > [...] > > > - The representation of multi-values - both, internally and when > > outputting as probe data - is a de-facto standard > > The external handling in formats is specified in the corresponing > specifications. ";" is certainly not correct for formats which > natively support multiple values per key. > > Internally, if you have a data structure that represents multiple > authors, you certainly do not set it to one author and a string > with a bunch of semicolons seperating multiple authors > > Title: "Smile ;)" > Author "Smily Face ;)" > > is not 2 Titles and not 2 Authors and software that cannot handle that > should not be used as reference IMHO > > That said, anything that works is fine with me, > > But internally it will be better to use a representation that is > universal, generic and simple, ";" may seem to be that but only > as long as you do nothing with it and dont care about corner cases > > Ill leave this ";" question to everyone else, i have a backlog > of quite a few things i need to work on This is not a great outcome, because "leaving everyone else" means nothing will happen. At least revert the rcombs patch until there's a conclusion, because it really makes things worse than better with regards to FFprobe output. This will cause deserialization errors for many people in the world who are processing FFprobe data. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".