Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/webvttdec: Add webvtt extension and MIME type

[Soft Works <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Dienstag, 25. Februar 2025 02:04
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/webvttdec: Add
> webvtt extension and MIME type
> 
> On Fri, Feb 21, 2025 at 03:13:22PM +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > The webvtt extension is sometimes used in HLS playlists.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >  libavformat/webvttdec.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/webvttdec.c b/libavformat/webvttdec.c
> > index 6e60348764..6feda1585e 100644
> > --- a/libavformat/webvttdec.c
> > +++ b/libavformat/webvttdec.c
> > @@ -216,7 +216,8 @@ static const AVClass webvtt_demuxer_class = {
> >  const FFInputFormat ff_webvtt_demuxer = {
> >      .p.name         = "webvtt",
> >      .p.long_name    = NULL_IF_CONFIG_SMALL("WebVTT subtitle"),
> > -    .p.extensions   = "vtt",
> > +    .p.mime_type    = "text/vtt",
> > +    .p.extensions   = "vtt,webvtt",
> >      .p.priv_class   = &webvtt_demuxer_class,
> >      .priv_data_size = sizeof(WebVTTContext),
> >      .flags_internal = FF_INFMT_FLAG_INIT_CLEANUP,
> 
> should be ok
> maybe needs backporting
> 
> thx
> 
> [...]
> --
> Michael


Are there any more comments or objections from anybody?


After merge I'll follow up with a patch to support mpegts time mapping via X-TIMESTAMP-MAP in the  WebVTT headers.


Thanks
sw
 


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".