From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9490644E4C for ; Sat, 26 Nov 2022 02:32:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56F0D68B315; Sat, 26 Nov 2022 04:31:57 +0200 (EET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2044.outbound.protection.outlook.com [40.92.42.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D10E368B187 for ; Sat, 26 Nov 2022 04:31:50 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6on8vqK1MZgDEB4EkqHEC6tV5+Tpg3rq32MkQU+pL6l+mHegau3aanOuW+SXqP64U3h2HGSFlg3aitcQr/AoxONsbCTxe/gGFDsTpO4ibwIbjvXweqEWkeS50z54kEJdkZgRKncU6PftJ++eMkj+AMDUXXKN5Mm1qvAAhjiLkWCnQrCQV6mQXTO5WUhLe/H1v9UYr5qGbpcj7Gs7vga/o+aSgm/VQNBPM0Uh5pqowIKve2IJeX7YOK5UoVVAo8TpAeRtmNMd+MFDHQpusDqHAFMUCtv2kzRpDeZOqAbWDZr4IgzgMaF69KJ+gHxw1Najl/H/nFlqYM1xf9ocwqw/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8C5UWup0jVvVI83qakwalRBPXRALPkRg3i9yE78EAkQ=; b=ZWRqsKTEEFpYtHM6ehdrP7zwzoPGE6EHPp/ZAO+Egj8KCclQbP3hEzF/iM9sHbbUGev/QmoJxmykVS9SHvdZvs94YJSrDtj2oPSDTxrLAdBBr16GaTB1VYL4tWY3Xer1q586vDpkW15dM6rdbzarRIpaa+Z/6A4SNkA1Sh2RTyiZYG24rSWo2XYMEcWlu/WLJiX2wNK67KRSweh8RwfUl449CcQGyCp+fos0S/bbD7Bu2Ma91HvSLOGBDk5G0y8cRQUwfBojmFdIu2cu0D9ABmCdfNIk2wIc1dBOkBrb2o4qxLMxyAtugeWWq1TyvxK0uFdkK+ui7dnnVAH6+W/Wrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8C5UWup0jVvVI83qakwalRBPXRALPkRg3i9yE78EAkQ=; b=G8ttgYCwmqltMde4+wkJjL+1YprxCvQDXJRvh7yW2H/CPDiRTb/LDhhGkj946K+1eHuBHUZuqGNDWUePbbVCm23ghzRqXRBz2cbM+zsX3sHOJdFZcl5zEVKuQkNln+lkc6TWE4UzQpWDtNdFnzQiNB8SMPiZ0MMI4YGTI9N1kyJM5oujdg3oudxft6snWY8Htp/xFTCDuvZ2JOWQh6en/bsH8h+LvvFCyuzN82b6r7RqJRIIbGrivGkhT55FsaZd52LRAPgnAtOLw9Az/8EvMQYqq43cu2gQIYLj/bKa12pYgmz+A+NgbfbiKwnZxvXvzVymfhPXryj7oPgvv8wPEw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0644.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Sat, 26 Nov 2022 02:31:47 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::45ea:be80:31df:38c0%9]) with mapi id 15.20.5857.020; Sat, 26 Nov 2022 02:31:46 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format Thread-Index: AQHY/8THCFVwiEkFUEugDzP43oUjCq5PqNyAgABCHnCAACMZgIAAGzVQgAAhdoCAAABtgIAAAjyAgAAD5KCAAAKbAIAADnxAgAADFwCAABh5oA== Date: Sat, 26 Nov 2022 02:31:46 +0000 Message-ID: References: <20221124052209.520239-1-haihao.xiang@intel.com> <166938393779.4503.7930861168279237996@lain.khirnov.net> <12d8e532-f236-83b8-61cf-6c9ee72b10ee@gmail.com> <4bcec8d4-8593-9a23-3130-8aa52b1f3c11@gmail.com> <494bbc9b-ab82-0c62-f471-3ac9be03e80a@gmail.com> In-Reply-To: <494bbc9b-ab82-0c62-f471-3ac9be03e80a@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [zshGzIRI4kWRr6UI5ETSqHHSeJcFXOhp] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0644:EE_ x-ms-office365-filtering-correlation-id: aa348c4f-47eb-48e4-4345-08dacf565d3e x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dcj9CascB7bNLt0II4PQCwDs8vtYIT2ckdKPMohElSDCLLv3ae1x4JOHlsbcIUzFdCk/4caRXwsrN0/l+ehoK7CaEj1y8S4i1V0nHamPgZ9+yBQm/sgAioOTvuQEPrZyd+dOpbxLzLzynmA+Yc5/MuzKugocnKBj1/96/B+H8GX1P/rA4K2F1YyamQHfjUgj8eHZu8v0hbTLXXdwqzt54bxtAM9O9cZ5oDWJ+2+HKDD/DccsNdB3nw07yCr6HcjJ3wycGcbRg8l07ZlE4Kp8nDJe9eHIDXcu/1CsrDZ9t/A9P6AoWcMr1lSQIKuJKkFZ1djsI075l7DWBzeGBKKHytD2t8YOehWgo7p2Q6UYncbXIf/7a2/CP3Q9yZlh0X582g0L/4dsB4cLUF6iciGpf8DcN2hDQEOFYc+AqBKZlFTrBsJskarbbn3Jwx9FCppnCBsXS8BbYlCh3hyNXP7s9Rq4iI5G7o7osk3iP7IiX45nk+RSd5txHoYuJvPj7OVFvDXnuQV3Rs6e2LXctRtumbtQ09d9WlqfHHfQCKQQP+gBEZU6MwOqDNd+GWJokf/5wANxBhFKKyH5iMS7wOgjQDkznHr+rwmWbJ+Qi0OdMpIuPgHCYJTtmuPgGBYTVQOKwMh0ifpGKDU26L8IDD7TAg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RDluRGhuU2tSd2pWTnVDTFhXcFdEamtFQVBVVDhIS3owdHVsVzBoSm5zaFk2?= =?utf-8?B?SHZEWll2WFk5RkNDVmMvT2tOQ3pYUVAzcnFpY1hMd1dVcUQvck51N09ueFVo?= =?utf-8?B?U0Q3Z0I2TmJvNmVmRDNwUlZEODVzeGxzRjR6am1iYnVUeERCanFtV083VzB5?= =?utf-8?B?SEN4ZjBTUTBhcWZyU0pjWm5qVkJQa21USWkzU1lwMkVqckk2SFp3V2tkUTY5?= =?utf-8?B?QThVSXVudzFXbTlaRkcrR1EvWnVjNDlhRFl0SFZvTmxaZHJVMnU3cFlxN2xI?= =?utf-8?B?aDlzUWRnUTFVdGg1by82SzJQTTRHWklwaHE5SUxyQzZHSUVIL3ZVbnA2RWNy?= =?utf-8?B?d202REhxTGFkaHlNVVFBQzRZT0dBL0h6Q1lDUmtBeWM5VkJ0TVVIcDBCcmx0?= =?utf-8?B?MnlramtUbmRtWUNuSGJ1bFR6MHMrZUxxM3ZZdFR3SFlPTC9UYVArQllZNXdL?= =?utf-8?B?TnVtZGRaVFQ4TTlwNGdLcTI2OGMvcmovcFUvV2VvaVJMMVI1Q29DbmptT2FL?= =?utf-8?B?VVlreEhMQm9jMEhsTTZYTlZjUGsvWXZCMGdJTnJxa2RVWUlKb3dPTFZqYTRl?= =?utf-8?B?MmNxQzY4R2w1dFB6WDR6LzZZRURFRU50STJHZlFBdlExQkZsbCtGblR3dGVj?= =?utf-8?B?R051TlNaMUZWWTBHL2I2R0QxSGx0MnRGcnVOa2htTjkxcUkxSElHTVByZ0FF?= =?utf-8?B?cXVPcE1GVE45YjQ0MTh3enkyaHQ4eW91MVZTS21EK1dZc0ppSWZEbzA1eWpw?= =?utf-8?B?U1ZXU29oRVIxS2RIMVlYR014eTZzNmgwT0dHRm9RZlh2K3FmN2tjK1JOY1F1?= =?utf-8?B?MURPNnNRdjJROHYvOVc0a2pwbWREeTFUU0FMUEhhM3lNemFqZGxuUUxMWnpm?= =?utf-8?B?aWVkWGh3RDNreXpLODMwUlpUNVR5THZxVHBkdTNORnFBQ0NrUE5NOEdVSlZP?= =?utf-8?B?S3JSREt4WVk4TU4zdGxOV25yRXRaUHMwa1ZQMmdOejVmRDZ3RDlrNU5kdHpm?= =?utf-8?B?WUJyTFlZUTU4YU8zcERHNy8zd0hLb0xibG45Ylk1Z2JTTVlySEZmMkgrNDVE?= =?utf-8?B?Z2g4cWFnOUZnVTFZZXNCODBQd0F0VTBRdVlQRHJ2VzRDU1ZNSHZzRW1CVk0v?= =?utf-8?B?M05MeE1WZFllQ1UrdnFoTXJaUXY3cGNVRmhkNzhNUlY1UlJhclZ6dSt4djZK?= =?utf-8?B?aitRV01HNzlMT2Y0aDlKZzFmYnh5VGZyeHhreGhIMU50UWJGMG9DN204US81?= =?utf-8?B?ei9XNVVPVFJGWlc4dml0V0FmNHRBWHVJV0VpbXUvMFhpUFhQVWU4b3RNWkpm?= =?utf-8?B?NUpmRm80TUVvc29yQm50TFRseWVmQkF1MDRZLzdzWDhOYVZ5dVNtS2JzT0t1?= =?utf-8?B?NEtlN3B0b3MwbGFUUlRSd1Vya1NBYjdvbXI1SUpoRUhjRXVHdVk3enlDR01y?= =?utf-8?B?WHlYSmEwT1Izdk5BNXZMZmRuUTZtNC9IL1l0NUZkMVN0NXdyTGdrN2k3RnUr?= =?utf-8?B?NWdqbjM3TFNGUEQrRTlERHl4WkM1dFRyMHB1dXFPZytvcVdpdDBmUmJzaTdw?= =?utf-8?B?MXpjc3RRbFFsM0dOZmtZd2l2M1ZaL2NXVWRWM2R5RktDUEtrR1RDeTNCOTFn?= =?utf-8?B?b3BOYVVsVTQ5ZzBMN2xndE9Wa0hVeHZDNlV3MmJaNTY1cnQ3UWtCb0xQTDM3?= =?utf-8?B?Wnh5WkdsUWgrZGlhaUlRNjhlS3Uzb0V4UG1zdUpxQzFMY0Zhd2tURUlBPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: aa348c4f-47eb-48e4-4345-08dacf565d3e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2022 02:31:46.4688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0644 Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 2:01 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 9:58 PM, Soft Works wrote: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Saturday, November 26, 2022 12:58 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 8:51 PM, Soft Works wrote: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf > Of > >>>> James Almer > >>>> Sent: Saturday, November 26, 2022 12:35 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >> support > >>>> P010 format > >>>> > >>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > >>>>> [AMD Official Use Only - General] > >>>>> > >>>>> Will it make sense to accept P010 input, however encode to h264 > >>>> 8bit? > >>>> > >>>> If it works (the encoder accepts the 10 bit input even if it > >> encodes > >>>> it > >>>> as 8bit), then i don't see why not. I assume it would also be > >> faster > >>>> than using swscale to convert said 10bit input to nv12 before > >> passing > >>>> that to the encoder. > >>>> > >>>> Removing support for a pixel format as input in an encoder needs > a > >>>> reason other than "It's rarely used", more so when it's a single > >>>> line. > >>>> It either needs to not work, or somehow get in the way of > further > >>>> improvements. > >>> > >>> Oh sorry, I noticed that there was a misunderstanding. > >>> > >>> When I said "It's rarely used", I didn't mean that as a > >> justification > >>> for the removal, it was meant as an explanation why none of the > >>> hwaccels has implemented it. > >>> > >>> softworkz > >> > >> Alright, then i'll repeat my question: Does it work? > > > > No. > > What does this encoder currently do when you feed it p010 input? What > does it output? An error: 1. 10bit from HW context: [graph 0 video input from stream 0:0 @ 000001dc301aeec0] w:3840 h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 [auto_scale_0 @ 000001dc2362a700] w:iw h:ih flags:'' interl:0 [hwupload@f1 @ 000001dc2944ef00] auto-inserting filter 'auto_scale_0' between the filter 'graph 0 video input from stream 0:0' and the filter 'hwupload@f1' [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Init [AVHWDeviceContext @ 000001dc444fab80] D3D11 Init [vpp_qsv@f2 @ 000001dc22a3d880] VPP: input is video memory surface [vpp_qsv@f2 @ 000001dc22a3d880] VPP: output is video memory surface [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 Last message repeated 2 times [h264_qsv @ 000001dc161b6040] Using input frames context (format qsv) with h264_qsv encoder. [h264_qsv @ 000001dc161b6040] Encoder: input is video memory surface [h264_qsv @ 000001dc161b6040] Using the average variable bitrate (AVBR) ratecontrol method [h264_qsv @ 000001dc161b6040] Current pixel format is unsupported [h264_qsv @ 000001dc161b6040] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Uninit [AVIOContext @ 000001dc16197c80] Statistics: 0 bytes written, 0 seeks, 0 writeouts [AVHWDeviceContext @ 000001dc444fab80] D3D11 Uninit [AVIOContext @ 000001dc161839c0] Statistics: 131146 bytes read, 2 seeks Conversion failed! 2. 10bit from SW context: [graph 0 video input from stream 0:0 @ 0000019e915dee00] w:3840 h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 [auto_scale_0 @ 0000019ee99936c0] w:iw h:ih flags:'' interl:0 [format @ 0000019ee9993240] auto-inserting filter 'auto_scale_0' between the filter 'Parsed_null_0' and the filter 'format' [auto_scale_0 @ 0000019ee99936c0] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 Last message repeated 3 times [h264_qsv @ 0000019ee9995dc0] Using device qd1 (type qsv) with h264_qsv encoder. [h264_qsv @ 0000019ee9995dc0] Encoder: input is system memory surface [h264_qsv @ 0000019ee9995dc0] Using the average variable bitrate (AVBR) ratecontrol method [h264_qsv @ 0000019ee9995dc0] Current pixel format is unsupported [h264_qsv @ 0000019ee9995dc0] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height [AVIOContext @ 0000019ef62b4000] Statistics: 0 bytes written, 0 seeks, 0 writeouts [AVIOContext @ 0000019ee995abc0] Statistics: 131146 bytes read, 2 seeks Conversion failed! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".