From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 707E14C343
for <ffmpegdev@gitmailbox.com>; Sat, 8 Mar 2025 17:55:01 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64AE468DD25;
Sat, 8 Mar 2025 19:54:58 +0200 (EET)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam10olkn2041.outbound.protection.outlook.com [40.92.41.41])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EAE1368DC37
for <ffmpeg-devel@ffmpeg.org>; Sat, 8 Mar 2025 19:54:46 +0200 (EET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=cg3VIBVvRvkq4P3a+1Pwcuf7FTe1G+M9PqADnuLUn7PYGtnGTrhHS9Zdq1rm20iAFMuXOZ59hi3DLe1p1Y2i1l5WSRJirnS8kh51YWHdIMWlaGCn7ShRrziU/3mQELy9R8Sxlx+Q4ZrOPk7uv00l7AOL41AAjlZ2xF2v3Yb3ZY0jBIMhuS0iplXZX3WBKsFucUfKO9NlIe3so2KcEqlXque7WtqTOxax4QZcRv3IEoDD0mJCyqbcv/7EbSncmorgbv9ON7ZdA9JGqXRWnc4XAdTUal1U/m8PyoyuEXAALaKx/Gj1+foeNiuoxzNlVwy+K870HC+acXcjIbqAI6XxEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=7M13lXzg3TywS6+5/KGAh1osH4f8GRsV9R6DwTZNGqU=;
b=rqZ8D62FB5qe6JJZO7QCaT1kVgcS31KX4VjG3fBsMtwd1vM/wITxwAUXtOA8x3NOTbGL9bZRGD895zyROwQnwQEdS2DbwLNVfdIy3gjL5G5LBwvrPNkQceW+m6eYJfahAiEa+sYMy1BZOEHceFu5efxtEnA7mdiH0e3tsX43pL6U1Dsvi3hosxlxA35fd3iRCb7L50oZyAVT7c8ErbvBsPKGeMODZJlgGgq6JcCguE6YvrtkabZQnduzeFLroKpfawxywi6w0ImmfxWDTQhbgrKxDDHQDS1MQ3VZE//JOIrpg/FFX1vaadP+FthWpgwZPDFotx+E3ymxDwPoPZUn1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=7M13lXzg3TywS6+5/KGAh1osH4f8GRsV9R6DwTZNGqU=;
b=Q2sKv0KrfXXrVzdUItxe2fI6zAqem4tTAxoT6zhFgOrp/Odnxr+/0Ad0lif+L/LVfxilUEHZ/qLClNtobpX41R0kyjZaJet9JlxXYQC6RCv3vCzR7bZmWGOIb/P4J5EyhiNLcUTGOo+1HxBB1by0tUXhmowmDHQwsXmMeJbf9PcMcBVIc2taagwtu8WcS1JXipFjrUHd8/hdrE/yuHC8d14NmXoQe8OQLusHsdDfH97oKKIWIYatXu0HK4imLoIhzvOC4bqtCYZZfQbxd1aySy8RuwiVqqRldQPfvwlWp9/zS+FaelApSsX8fH4VNeztjHI5d2DU4QUHgiI3rWrYRQ==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
SJ0P223MB0590.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:47e::10) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8511.18; Sat, 8 Mar 2025 17:54:43 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8511.025; Sat, 8 Mar 2025
17:54:43 +0000
From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
To: Stefano Sabatini <stefasab@gmail.com>, FFmpeg development discussions and
patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v3 3/7] fftools/ffprobe: Rename
writer_print_section_* and WriterContext
Thread-Index: AQHbipELgc83i77Oy02SJaLsrva967NpXHyAgAAy+SA=
Date: Sat, 8 Mar 2025 17:54:43 +0000
Message-ID: <DM8P223MB0365E4A0DBA8676EA8095184BAD42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.52.v2.ffstaging.FFmpeg.1740137232.ffmpegagent@gmail.com>
<pull.52.v3.ffstaging.FFmpeg.1740823324.ffmpegagent@gmail.com>
<8dcc17112d07ef798a2843c8d1c9197785571370.1740823324.git.ffmpegagent@gmail.com>
<Z8xYKbetaIEAFe39@mariano>
In-Reply-To: <Z8xYKbetaIEAFe39@mariano>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0590:EE_
x-ms-office365-filtering-correlation-id: be48b662-9ab1-42c6-bc5b-08dd5e6a4eb9
x-microsoft-antispam: BCL:0;
ARA:14566002|461199028|8062599003|7092599003|8060799006|8022599003|19110799003|15080799006|3412199025|440099028|19111999003|102099032;
x-microsoft-antispam-message-info: =?iso-8859-1?Q?bhcuVhlovKW8NowoolxzNcTNq/+E/BUv+odE6kRe1r0bGtDKJQQmaVChxY?=
=?iso-8859-1?Q?KFaD0ZOs/XM//PqZqozTsFQUBybQB2ugAhTZVrn7rZZnna6TNfgKWG/RhQ?=
=?iso-8859-1?Q?Phra87cdEjrsabPTEOdTA/LwftSdfjtU8A4Fypuij5gPCcGMtliPZ7dn/p?=
=?iso-8859-1?Q?Tvg7fC0debRyKS5PKfioStzQEQipHF1S+1YS+u0euULIeSnYw06uxbSgLt?=
=?iso-8859-1?Q?+Loxzv1qXYhjofTUkaJEIcQ6X5H1fwox/g6B0c/4Y2yI1gBOQzKy+EoiR/?=
=?iso-8859-1?Q?jfrdKq6vmxu3nNOJTG7GOtFdUa31FpuxoyX2cUabUGI9rnzHuALAkeIhok?=
=?iso-8859-1?Q?QlE6vkcgh+FQ0iO5N3kj2Jex0dm8svYxWA2vU4hiYByCh0TAZAbOr1CeKv?=
=?iso-8859-1?Q?5HiaHDTJPe+9GL2U6XOLrnFAnYEsZgpapIoWHM3f4ok+DFc80ofScD2CoE?=
=?iso-8859-1?Q?RDmTANrAdVTuPSKfw6PovKixQeFwe1UnDVQA3tTGLSF7k9zD/3l/hLpJ0o?=
=?iso-8859-1?Q?LhrULWdy4eYisKk2Tt8KZz27PlbQu7YIzajOyjAYd8Cn8TlbHZfA7I2uAY?=
=?iso-8859-1?Q?wG0R9LUyqoYtuKVkwqUnz8I4H9+mpTnid9f5BhH6ZGfgj3yBqUtt2BeMhF?=
=?iso-8859-1?Q?eudZmfXzxoVkdNfqSgRF1lJAV+W1Aa+sYETMJ10bkAoCG++XDs2imSiqws?=
=?iso-8859-1?Q?5qEgvdvOL3LXwqXmI9sa8M4sPW3RFs+RAIgbNl3/lIz4iOHaS8QoCLNX6d?=
=?iso-8859-1?Q?b9gL4hb8dZ+ylZJ+WkWQJlU4RiKICgn1TODgCZl9emazcoFMnjA/HRWpHI?=
=?iso-8859-1?Q?Pzsh5uUXQhsBwAL7oefmQ02k2VLWqu5Hkox1TXpO3lC9NwmJnKt1rS1Kw4?=
=?iso-8859-1?Q?qJnKWJBf8pXweV8SIBYyrKHp00+o4wU6tHhIKtFziXRorw27JFILn30Vwh?=
=?iso-8859-1?Q?+fzRbTBahoMVrIyh3tF7bTQYXoNUx2LXQMcrhLv7B2Wt/G3WntRTmESCUC?=
=?iso-8859-1?Q?pJ/YKvQl8To6V15uGx0nhYmgj5SFKwGseYaYCZUhgehuYNPzxbreOc2Y3m?=
=?iso-8859-1?Q?7aFIW7CpM4xMKu4N6A/3GEOJQ0SRTHlS+TwKBesgT0ejeq19CcZhIwk7gB?=
=?iso-8859-1?Q?wBRw2HwDKl3SXcQh76LFkUK0vlqb1lLuF9w89uKZaNI7ppi18i?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?alZt8MNV6LyHaw6oWLklj3laZdk9X2P+lVv/sMGCVqP2QOxP1RoDOrVGbt?=
=?iso-8859-1?Q?rL5CPWxkELmwkr2k6/0UqPJweHUJbE3Lw3HvgYbfmGlUCRnmVkhp2TN/8D?=
=?iso-8859-1?Q?eU6YC+Lg73UvMZr9zwigrLNqQPM8wSc2UhZIC88VzojM4R+1YvpmlazbLs?=
=?iso-8859-1?Q?wMr3YHjhKJ8LF+clbr9PW+rg5zsFhhea/lYm9BYPY++goLiiBtKzQKvwqZ?=
=?iso-8859-1?Q?onYAOGjbEbtE4yB+zeIZtNXrURQrvcbTym0Jf4QD4O2LAvzS3MC3Ad4TLp?=
=?iso-8859-1?Q?lHz0UNMhg//DK/weohLO4/aeIYpOgWhZXkbmCM07qnDsL6AGK7o/rEoUlx?=
=?iso-8859-1?Q?xBOyemrWMW/J+f16btYXmfpOLnC5o6IqFQfHe2sxPrSkDnACybOse1PvkR?=
=?iso-8859-1?Q?k91M/x6qWdFGysO+vp/ZUOV0nxsfCM0qWncBZKQjoQj8eFrccME2WnT3tN?=
=?iso-8859-1?Q?h8C4l7MgL0sYGGNNv3wkjI6TvcmmJ+WMPi9oJwG7Coq6LDgagNbGrG13EI?=
=?iso-8859-1?Q?a4TD7JPsqu1ji7o/9+P83JysAoMmTkspL/JpkLSB6PfabXcDLAnD2wp8yf?=
=?iso-8859-1?Q?9fr/bnb3fxRNXOjwu9AB8/5bpG20rbSSQCKZYfdZcfUymEI99+msGbWjaP?=
=?iso-8859-1?Q?ISNKMyeKKij/tURpPPMGF4+n3a0IWQQKWO3Wes5lpVV+Z2Bxl/PyVHgl+J?=
=?iso-8859-1?Q?Pw8FFu6uUX92CKG2b9aF2GNbJdA9nbg5d0VlnSRxc51EAwmynCfgQY9j+K?=
=?iso-8859-1?Q?2gbMN3EH6dJtziTjFLDwXnsUoU5JZ78rfBh/GjTBije+XIhReXBjyXR+zv?=
=?iso-8859-1?Q?isRMqvaBBCjHyxdXnWUxZ5/1EL5NtxXLOVnuBDvLSxTWKTYWRAFKpEEdQl?=
=?iso-8859-1?Q?EAcKGR8bWLiqkIvrPgjDNoyn2q1+jbU8oOadmNc8eNmr4uQ+lQKB0lsvbf?=
=?iso-8859-1?Q?EBTvGm5+/k6KYBer/5bJwzQsq3SaVm/Y0C6mgbJj4Cdf0ABXYO2du3Y4am?=
=?iso-8859-1?Q?9ZDb6TTDXs28Ey/VuScyO/VJzrll1wOG4RK5PZVRzyfPzAx5szh0IhS3LJ?=
=?iso-8859-1?Q?4JaSkR3NlCJ007H9yj4WYumzXVGPwCX41LWAcIDIx9wFL5cC7b9DUkB/Bf?=
=?iso-8859-1?Q?wCFdE90t+aZJH+mmrEmaXw60RFoV4B0A+KM+SG+02CAHZ6q8f2vTtQ6n4P?=
=?iso-8859-1?Q?SURuw4ZD3P+5S7wR2B9aYMPWWrSvaU+7Ebh+3o7uzXDfBXbZ/Vto6kMdVT?=
=?iso-8859-1?Q?p/RxUGFGDiSNQ5DvuRVO6uwEJB31bVJ5+rhwcPTvw=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: be48b662-9ab1-42c6-bc5b-08dd5e6a4eb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2025 17:54:43.6673 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0590
Subject: Re: [FFmpeg-devel] [PATCH v3 3/7] fftools/ffprobe: Rename
writer_print_section_* and WriterContext
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365E4A0DBA8676EA8095184BAD42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: Stefano Sabatini <stefasab@gmail.com>
> Sent: Samstag, 8. M=E4rz 2025 15:46
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>; softworkz
> <softworkz@hotmail.com>; Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com>
> Subject: Re: [FFmpeg-devel] [PATCH v3 3/7] fftools/ffprobe: Rename
> writer_print_section_* and WriterContext
> =
> On date Saturday 2025-03-01 10:02:00 +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > separated for better clarity of the preceding commit
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ren
> > ---
> > fftools/ffprobe.c | 361 +++++++++++++++++++++++----------------------
> -
> > 1 file changed, 178 insertions(+), 183 deletions(-)
> >
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index f398057df7..4a90bc4824 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -71,11 +71,6 @@
> >
> > #include "libavutil/thread.h"
> >
> > -// TEMPORARY DEFINES
> > -#define writer_print_section_header(w, d, s)
> avtext_print_section_header(w, d, s)
> > -#define writer_print_section_footer(w) avtext_print_section_footer(w)
> > -#define WriterContext AVTextFormatContext
> > -
> > // attached as opaque_ref to packets/frames
> > typedef struct FrameData {
> > int64_t pkt_pos;
> > @@ -446,25 +441,25 @@ static void log_callback(void *ptr, int level,
> const char *fmt, va_list vl)
> > memset( (ptr) + (cur_n), 0, ((new_n) - (cur_n)) * sizeof(*(ptr))
> ); \
> > }
> >
> =
> > -static inline int show_tags(WriterContext *w, AVDictionary *tags, int
> section_id)
> > +static inline int show_tags(AVTextFormatContext *w, AVDictionary
> *tags, int section_id)
> =
> maybe while at it also change w to f or t?
> =
So I tried that (t) and it compiles, but FATE test are failing. I wasn't ab=
le to identify cause without going deeper, I don't know how exactly FATE te=
sts are making use of ffprobe (or its code?).
Most likely there's a naming collision. I've renamed it to 'tfc'. It has tw=
o more letters but it has the advantage that it's a unique token in the fil=
e. It's isolated in the last commit, to you can also skip that last one if =
you prefer.
Thanks again for your effort
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".