From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DF2334280B for ; Fri, 7 Jan 2022 16:14:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A614868AB9D; Fri, 7 Jan 2022 18:14:26 +0200 (EET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02olkn2065.outbound.protection.outlook.com [40.92.44.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6741268AA6A for ; Fri, 7 Jan 2022 18:14:20 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c/XYUuxuv58qVtCqp3KbqOCJKyTMr1SlYl/OQu5VTB25g8V7BI7eTns56hMsmDTy2szKSOkDdOlLOFAZArK6yKjMjYJmFW6OoC0C61kh8pubfvnRXXDjerQsAsrLy52zRwhnZgz+xFzAgticFUyFLs/0d6S9CdQNT9SkpNFc8othpJJWkR4IWSWrR8JijxCwLXxFietvlU7ybQ9t3dKiG2sD5EIXdClklaXO7glsiE+CYe9F0rcvW05g7nXNETsstGxBPziepYxs+L346Um1oo9ZHMoSg4ZrYom2l5Yyvp/8otFe1AXqzQdlTZyonfULIjcRbcBaAKivCI+PB/mhuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LmJJ/X4q5er7MIWHkNY6dm5oJ52yXRA8HoxqoYe3iyE=; b=ODME8U+aqJPJ8Xg59obx1Sv/n7wqoUXaDBJwoxx/vpVXzFML1f7E1ZUxhuRoq+S5qG0vY0n/AD8eldMG/wdJ21soO0gLOnuuVW5p2xrtWGXHsPlmeumr8xCC51d4KTOMCHYxk4dByochgyosaMtWHUnmHGCxCuxPm8I1agbu3wSPfEjfnz1Pfe0la9SVY3C/2zgpAhjPo8lja1Z7RzkvIaQa3VnkyT3lmmme/VJDl/Rgytjrxj5xDsdW1H6hwyut3Cw9eqyJgiFjqp/MyBnBw1jAZa3yFH7bUfgoCk19aYliGI/NczzVeorqH8iIXCWKtlKFeUVV/6A494pw6MRX6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LmJJ/X4q5er7MIWHkNY6dm5oJ52yXRA8HoxqoYe3iyE=; b=rlxhMW4SJqpBP3yqOkCRwMca9IYHn6zI7wFWnKxKsksYI3mO8VDgeEJ/LfOryk7DrwaKhS3LXhFpl0f/Lmdzls4Sl5EhCgJYgEr8/qfd9eZF5+rzxDxGZcj8g27FPR4DZcGaVVErKIoI2keT2ofnSZk/MZKRnnknqc5yENLkiUU1ZSvsZXW4y4Afq+i6RRsrqNmcKiR5kr/gKYJbxllKgEEP5/YfuhAiBGDzGBLlGifnGlQhbYVdx2oLh/U3T1BKzjkKGXhpp6eHGdaQDxqysdgDvz730pwkQIYFTBwSHJN39weguhmAWnyIJQUTqwfPLNHd9sjZ8cQyDvC6e/axZw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0127.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Fri, 7 Jan 2022 16:14:17 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%8]) with mapi id 15.20.4867.011; Fri, 7 Jan 2022 16:14:17 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define Thread-Index: AQHYA7A8l94DiL6ARkGLmmcz+4mIX6xXXCIAgABe1wA= Date: Fri, 7 Jan 2022 16:14:17 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [3zAiMOzlO2m/Qm7+yMlPvHoowXUsaR3/] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2fadb657-5d2a-4e8d-1b82-08d9d1f8c164 x-ms-traffictypediagnostic: DM8P223MB0127:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: riYV05hGPiUxK+TsWnZmR0kgqpkBG7FX7GzWT90L08gtPIH3kPuZJLayV4iFr0z8zn56nuvSTTCBc+Z8b1Vhu33/pVPaLLWfyIHv5S8tosEyQzvcElgq1bdUkXWeREijG5hf4GoDrMS3swQ6rc5naY9Yp/S9hv2QDCLkhe0UgkZPkRwS6Ya3EbSl7fwxjvZcHG8aWAK2Im8XgOJRWND1gF5RBH1JabXZo49i1lY9o8SC0xKQoGE83gaHI6HsC9S2whI7AhDr082wShI3rh22LhQuvJt5qwBy+bwLTttcBWFF7c3XJEbODYWHKtKLfehPqXRGbVQhQB1bhqJWaKddE+AFDQGhnWZDqjnKPoA17JV7OxxZv32NuAwkxiCkTlCXwv0upJUYqAOkbEnhJsWLjBpRtzaypsb062Ng1r/nSEa6IYz0YKZbjlzgR6ttgbKtnFA5MnU/Nm+7YKrokGxY1iiu7xwsh/b0JxzklSIhqLDtH3ez3zSINeubSq37CbFIFFnqxD/YkQPbjWDWqDIEb81MGZ8Fj4oxXBUhxde3GnDiuVya7BGOF74R3O7VyCsrzL1IS4SflH+mU35ZNakXDV+djB43e+5TqiYZttMiZMeF/ezrZ/RTm2wnJuJcU/81 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TkVuQWVTdWtaWUZHanhBUEFRVjhmK1l1dFZoMXpjbG1lT3habnQyK0I1QTh4?= =?utf-8?B?Qk1VVDZuYkRYb3NjbXowUnVNenEzMUxIYm9YZlhNNjFMTGJkbUpWeWViakgx?= =?utf-8?B?UVR3WVpzMG5WdWVRSDgzZFFsb2txeXg5ajdMRzc3cGg2MldYOHo5WVRFY0pI?= =?utf-8?B?OXNsa2doQm52V1lYTXB5MEp4L0cwTEFpemtSbkp3VWlFQ3RnUUdYTDU0ZHdw?= =?utf-8?B?MHJoZ2JyVGpGbS9sYUFmNXl5VlVZajEwQ0lxbForUkdnb2NsWGxMYUQvNTVa?= =?utf-8?B?KytMSytub21zRjNSZVgrcVlKUXlIWFVyKzBPVm0wa25LUHZvb3RxSjllL2x1?= =?utf-8?B?Z0dYam1IdXIyOEtGVEhvODJneExpK3NJQno4eFM5RGJjNEF3M1ZEMW9RNk54?= =?utf-8?B?dlJHSzNVN1hPZUx2ejcwNk8zcDZ1L2U4djNNWkEvdStJTE4xb2hhUVBCTk91?= =?utf-8?B?dmxYVXhZNnZmQk9QTGZmRGhSODVYbjc5ZmsveEZaUFkrbGZwQUc3Z3NTbVUw?= =?utf-8?B?cEI5R1VkdllNdzErQUhjTXRYVUs1MHlPQyt1S29PSm1ZV2ljSVBORENLbVRK?= =?utf-8?B?MnNoOEZYRGJvK0xxWHlaN1VpYTlJencyR1FRcjU2cWlDWTFzUkZxTjh2Uy9E?= =?utf-8?B?dUpXd3YxSzBZQW1FYXI1YmZVSm1SY2ZhUFdKbUFxUmhMMGd4ejdPVzFROWhx?= =?utf-8?B?dkI5K2V5bGY4UXZrWmY0K0txNENyWTJLMVRuTkFtMGNSR1ZhMzcwR1JhalBY?= =?utf-8?B?d1Nxb2ZxaFhHdkNlSi9mTE95a1BjREx6bjIvZnpTYWI1ZEc0K25EaElDbUVn?= =?utf-8?B?SFZBTWtjQVQ5T1ZNaDJOazl1ZjI3MzVMZFJodldQUndXZVMrUnJEQTlMSE4v?= =?utf-8?B?Y01RVWhFTi9VS1k0L1pyU21QTCtJZHFjWDQvb1F3M0U0b3BsZnd3a3ExVVFl?= =?utf-8?B?R2lLZU1PaU9zYzhQVHBpK1JKaUxzSEl6UjhYeWVCWVRuSkhHTEg2MWZadXo3?= =?utf-8?B?S1A3bDIxem1aMDVHcGY1L2xFaVFpZHBBaVRSS1B4S2dBR01uR1dQKzczTWxx?= =?utf-8?B?YTM4YXZUVWowTFFQMHZxOW1KTzl3T0ZTbDUvVjlZVDBlRzF3ZGwrT2VSNzJF?= =?utf-8?B?U3ord1BVeTNIQWFocFNzaENzVW4wRmJ1S0pINDFaelBCNm5vVmhmSDZlVERM?= =?utf-8?B?QWl6K20xdDVjNEFqQTVsdTJzR1R5M2xwMkc3eGw1MzlIdC9aQ2YwOGdkOEE4?= =?utf-8?B?dm9Od2xySktBSDk3MnBsSklpN2VjNnJkRFR6aktsNFpoYkRpZz09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2fadb657-5d2a-4e8d-1b82-08d9d1f8c164 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2022 16:14:17.5981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0127 Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Hendrik > Leppkes > Sent: Friday, January 7, 2022 11:32 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't > dump images to disk based on DEBUG define > > On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes wrote: > > > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent wrote: > > > > > > It's annoying and unexpected, but still useful at times (as I've realized > > > just recently). > > > > > > This is a follow-up to the earlier submission here: > > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html > > > > > > There has been a comment from Anton, questioning whether the dump-feature > is > > > useful. Meanwhile I came to the conclusion that it can be useful in-fact. > It > > > just shouldn't happen automatically when DEBUG is defined. That's what > these > > > patches do. > > > > > > I also added fixes for the fopen() call. > > > > > > softworkz (4): > > > avcodec/dvbsubdec: don't dump images to disk based on DEBUG define > > > avcodec/dvbsubdec: fix writing ppm > > > avcodec/dvdsubdec: don't dump images to disk based on DEBUG define > > > avcodec/dvdsubdec: fix writing ppm > > > > > > libavcodec/dvbsubdec.c | 20 +++++++++++++------- > > > libavcodec/dvdsubdec.c | 11 ++++++++--- > > > 2 files changed, 21 insertions(+), 10 deletions(-) > > > > > > > > > > These patches need some squasing. It should've been obvious from them > > being duplicated. > > > > Actually I fell into the dvb dvd trap, but regardless the patches are > basically identical, so I would still squash them, personally. No problem, but in which way? 1. All 4 commits into a single one 2. 4 >> 2 horizontally (a single one for the debug commits and a single one for the fopen commits) 3. 4 >> 2 vertically (a single commit for dvb and a single one for dvd) Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".