From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C7E340B2E for ; Sat, 7 May 2022 02:42:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0632C68B387; Sat, 7 May 2022 05:42:18 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2017.outbound.protection.outlook.com [40.92.42.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5343868B36A for ; Sat, 7 May 2022 05:42:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4MOeeKkM8MgQdlx/TXowPBUAmh5R9/TicJKRNsNW07TRJUanGHPyBfZ8q7DfP6VnJcIOKIl93XA7S6o7MqP1nvkgsUR6iIWIVIv2zFrs6aXfaH3L+4b3OVG43OBQTCVu8hoZJjWQpGIR6nTfwn7Ic8kI2ZjtOKmNUDbf9p70gBSZzU8sswoWmVml5wg/miwmE7lQXzkIiam3wftQM7oPrUD33VLGU8nNjlujEMTXCsU9Ps6b/GmLGfUMk29gBH8D5i0DFiBq3H11xpAcP9WhLk0JHdob/cP6iSKTiKAtgCeMWDSe0isUXFLDmvqtqzoSex7jKFf7K81hUH7kWjP0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUr/hROB0WPOojh8v5OFWP/8lhahSOCSOVhthlVTVrg=; b=mDRtom6CGq+lPz3P+EPv/xnu+imeqYINuLBp3qn2oQENLOHq+pMo4rEEg2VSByGIZSxPoN01DCoCVos2hiTD0OgsbZgPjxuhE8y8Lm4N3ra8Q0zzGNu25dusxIcocuwX4rfSAnnKlGyGUNKwxzeE5/7qo+nE3xX4dmp1HU753wZ+UMfmicN+lzz/+1VdHOl4hRIVVf5SW4Lgmy/9Xjlinf2pNADmYpbKUOvtWkUr4WWFNbH1hQXOiRJEHZqgt2KpdApkmJ1e8mkxJl+kF/JbrJ8UnU+XHnoA5szjjnTajRNFfSoOjWzI0hJtE9V3UsvvpDNtW6mwuVzzx4CGN8BT+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dUr/hROB0WPOojh8v5OFWP/8lhahSOCSOVhthlVTVrg=; b=LDS5NgWx7F9M/nsQOmmJlAFAq+l1aTAS9bQ45UAeNn4La9+zXezpnd3VwhHEqNZ26ukX7Ay5JlZWgBgq4RGY9WqKtfRffpy3jLWwyHv2qt4u2udYir+85djUwjX+EH7rtwn6/t8ti4x9jtHEIH+eYtKGRKsKHluESIMkMedGpHU4zKw5dz8VdXj/XCJDh7M6g0psLl8yw0BBs3VqGkoF5WCu/Mf7fuhQWlTO0CdfcSYmTy2p+HZphbD1ouQoiBFhnHgXTpx++cHUMGRsVyjUrndmyAc0X5Emj2lL0VhWPROmOG0H1fYeWrfx8s6Jde04pg5laoSAgN10sZq0XraZiA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0260.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 02:42:07 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5227.020; Sat, 7 May 2022 02:42:07 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames Thread-Index: AQHYYQ4t3JNR1kKq7kKDEIjo4KztjK0StGAAgAABW2A= Date: Sat, 7 May 2022 02:42:07 +0000 Message-ID: References: <20220506055711.1671-1-tong1.wu@intel.com> <50b7bc55e01eff10e06a9b5d18a5e96227b2c579.camel@intel.com> In-Reply-To: <50b7bc55e01eff10e06a9b5d18a5e96227b2c579.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Wq6gq4f5m/uD+cZFFQbLV8P7ycpBUYqC] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32061e57-a3cb-4e60-cd3e-08da2fd32d9c x-ms-traffictypediagnostic: BL3P223MB0260:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aZLRO/notX3ZQw4l4pXkwjTIqCB/c+8+ptjyAnRm8iMmT59Re7STixizrEIjmaCHUioEM/YNVLjWMF8H8NTtLUH/Zk815A2e0JLThrij2iZlnpvigAwNbh+S39DEfHFmJh1b1eC4bZDCAN5OhUigmYbZj8HrQ8yMOhyEXEP8EtMlEucIz93KWTV3fn5bFkAvszlYxtsatjnjw+AEAmJX5o5A01qIAzHq3dwrFcmZCcfH6HkJrgMqBsrjTlIb7eIafUvTcGhJZvAaliuQGNnekD34cDm/PtJ7psrjUgDYrPK+B879jfqKCs8sn+WJaU+WlKTdOfh2pOaadTMxEH87T/PYSfaMt7FDf8Z/LQPvFVBTiv0jf0lcxlBciXZOnPh3DjJuJhW+lfd2/7dfgLK5BWrUhY5VV5dw3lQ9YJ39rw+50nfSK/qhGZRMapAln8N36Uh/5VMO1uz+EXToZ6o9JPSUyd+HqEs2VaMdQIzonFNfsCZG5n4RqKDZuO2UwsoZHamQN2vSlIjIig67ke4lNW++G7vw4KMCGsXvNYvYiwx2aCtb5cbGS4xbBdMxvkSm2hJ/1kx46ZHiRHPBf5EZmkcptHf7/pFDKc783KMH9DBh89uVbD8pVcFOT6fRWxr1GlzZ1kEBIhNhdFwYW+ID7Q== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aE0wT0NOKzVjcUE2eVc0RW8vbk5GUXFCY2hXbTM4MVJUaHhHd1NDWk9sT0Na?= =?utf-8?B?SDN1Y0Z3bk9MaFBmWDBtSks4MWNHRER3RG1uc1A2VTBBU2VLbVpoSzVQWHFa?= =?utf-8?B?eXBzUGlyclYzOWpyNVc2RlV6Y2w5aFpSaXVZM1RrSkJCTWJGM01HKyt2cWk0?= =?utf-8?B?UVJBdjVNQU5iZkdUTXpOM1BSMHhVdTFkTE9zV2ZTRTdtK2dUeTdUSzhSME9O?= =?utf-8?B?VHQ1YlM1WDMzakEyNkI5RDFmUnU4Um00QkxIdWFVQ01yV2JwbHAyTWFjRTBH?= =?utf-8?B?V1gvTllGUEtxNm13UEZMV2hMbEw2am8vMDBtVk1BZFBrODZoUFA1SHl2TlNa?= =?utf-8?B?Z1Q0d014dGxjUDBnaWFKRExLWEZtSVMrWTAybUs3OWgxZmdkTXBVY25ZTEFO?= =?utf-8?B?aEd2QnZ0TklYRWxmZUFIckg3alpYVHJMMGc5bXcxUWltcy9jaEVXYmdKbmxp?= =?utf-8?B?bTc4bmZqOE5oNjRLOTZTaHU3ZXNaa2pKRG1QbFJYK2I2S3BjamZ5NHJrNFJ5?= =?utf-8?B?bGZjYTFhdjF5aGtjQkp2NGxxcitlSDA5L1M1UXBFWXA2NE1aZXFYbWZpZjBO?= =?utf-8?B?cUU5dkgrdE5kMlV4MlQwcy9IdC96Vnd1RFpUOWpPc1k3QXFIR0VoNWVDU1d3?= =?utf-8?B?SDF3WXQyd0IwcHRndS9iZmlBbFdRZ09BOWgvbWN4VHRnRHJ6eDBxUlpyYXdH?= =?utf-8?B?WklXa3pCQ1BUWmxsTHRqMnJhaTFzeWRtVjNEckV5UjN0a3NtWjlpYWxOeFZ3?= =?utf-8?B?MnBHL3NwR1I1LzZ4b1hicVoreDhPRW16ZlJHRjBpRzFqVm0rd0xXUzR6V1Q5?= =?utf-8?B?ZThKd3p3dEhyaTRYbHZZYmhnRHhiVWRXUmlKYmdxVG1jNnJ6OXVtbGJ1THNr?= =?utf-8?B?d1pWM1g2Zzg0eDMxcjFjZENMYkREaXJ0QXNlREJGR3ZnYUhZTGpybk4zY2lx?= =?utf-8?B?eEl4MmhkeGNyMTdlRHJxcGpxYVQra3c0bGZyVURjeG5kNis2MDBvRWlMT2xy?= =?utf-8?B?N1k0blpYRTMrYXlRSFBWdXBlQmxRUWlteFNrRURYb2sxa1VadEVxUDBsQm4v?= =?utf-8?B?U1pKZ3d3NDYwTUozaTViaXF4NlE3a01icGNoNEZxUHEzVVpoeGZVSElMckFk?= =?utf-8?B?TzZWejJnYlNvVllEajdTbWNiNENvZHJ3STZOUmVHN1hiYUdGSExVRkFMNTVR?= =?utf-8?B?dzJ0anhDWWkwZUkyV0ozYVB6eVI1R0hXSHRqUTNaN2lmeEtwb3l1azRUeWwv?= =?utf-8?B?bVNtVUdlV3ovVjIraFc0dU9wa1MxNXd6LzhNeTRjdEwyNDZ2MXZvY2lnUEFt?= =?utf-8?B?cDkwUXlqRGtoNnJ3ZjNncVRzMW4raEhHOW9HMlJyU1drZjFkaFZReEhZS20r?= =?utf-8?B?cU9RcmtjSzFhVjBOdWc1SWNqZlY1TzgyRzJVTEhUWWUrSyszN01XUkk1UzNi?= =?utf-8?B?MXI1OWUxelc0ZWlORU1YSGFwWkZwdWVGV0dKVTZuaWxLU0N4Ly8xRUhBdkJi?= =?utf-8?B?bmk3anA3S2xLWkxoanBHa3hKTGExekpvKzZUd1pMRFRta3l2ZUlhOFpzcHR4?= =?utf-8?B?VjZ1aXN5Um9uTFpyT2FGZVpabGR4SWlFc3lzK2U5RlRpa1IwSWpNMnI3TU55?= =?utf-8?B?eG91UCs0dUUweHloTXp0QTg5YnUwKy9LeHN1MG9Ed1FBRDFpZHBFTytvNjlP?= =?utf-8?B?eHk5UUJ5TkEvWHhHR0hHaGlraUk1MzBsZGVNMVI2a2pzejI5d09HRHg3RE1y?= =?utf-8?B?Y0hFelRHNlU1T2RoN1ZkRG0zNjhWRWxuTUhGdmJUME5sQmw2KzlMa0hLeHo0?= =?utf-8?B?Z1hjRDV0WmEvOW9IZkVIOW03U0ZuQXFneFNQUlVMRFdDRWJ5NWFuZThoZmNs?= =?utf-8?B?V25wdC93T3YyeVYwaUZkZzY5enlnd0RMOUJLS1IydGF6TVJ6bXpVN1pSd20w?= =?utf-8?Q?dU5qVDeawio=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 32061e57-a3cb-4e60-cd3e-08da2fd32d9c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 02:42:07.5734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0260 Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wu, Tong1" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Saturday, May 7, 2022 4:36 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Tong1 > Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: > derive QSV frames to D3D11VA frames > > On Fri, 2022-05-06 at 05:57 +0000, Tong Wu wrote: > > Fixes: > > $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ > > -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv -i input.h264 \ > > -vf "hwmap=derive_device=d3d11va,format=d3d11" -f null - > > > > Signed-off-by: Tong Wu > > --- > > libavutil/hwcontext_qsv.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > index b28dcffe2a..bf150c8553 100644 > > --- a/libavutil/hwcontext_qsv.c > > +++ b/libavutil/hwcontext_qsv.c > > @@ -1281,12 +1281,22 @@ static int > qsv_frames_derive_from(AVHWFramesContext > > *dst_ctx, > > #if CONFIG_D3D11VA > > case AV_HWDEVICE_TYPE_D3D11VA: > > { > > + D3D11_TEXTURE2D_DESC texDesc; > > + dst_ctx->initial_pool_size = src_ctx- > >initial_pool_size; > > AVD3D11VAFramesContext *dst_hwctx = dst_ctx->hwctx; > > - mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > >surfaces[i].Data.MemId; > > - dst_hwctx->texture = (ID3D11Texture2D*)pair->first; > > + dst_hwctx->texture_infos = av_calloc(src_hwctx- > >nb_surfaces, > > + sizeof(*dst_hwctx- > > >texture_infos)); > > Please check whether the pointer is NULL > > > if (src_hwctx->frame_type & > MFX_MEMTYPE_SHARED_RESOURCE) > > dst_hwctx->MiscFlags = D3D11_RESOURCE_MISC_SHARED; > > - dst_hwctx->BindFlags = > qsv_get_d3d11va_bind_flags(src_hwctx- > > >frame_type); > > + for (i = 0; i < src_hwctx->nb_surfaces; i++) { > > + mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > >surfaces[i].Data.MemId; > > + dst_hwctx->texture_infos[i].texture = > (ID3D11Texture2D*)pair- > > >first; > > + dst_hwctx->texture_infos[i].index = pair->second == > > (mfxMemId)MFX_INFINITE ? (intptr_t)0 : (intptr_t)pair->second; > > + if (i == 0) { > > + ID3D11Texture2D_GetDesc(dst_hwctx- > > >texture_infos[i].texture, &texDesc); > > + } > > Move this out of the for-loop ? You may call ID3D11Texture2D_GetDesc() > below: > > ID3D11Texture2D_GetDesc(dst_hwctx->texture_infos[0].texture, > &texDesc); This could crash when src_hwctx->nb_surfaces is 0 sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".