From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1F9384E898 for ; Thu, 12 Jun 2025 02:28:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 42A6068BEA6; Thu, 12 Jun 2025 05:28:50 +0300 (EEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2029.outbound.protection.outlook.com [40.92.41.29]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BD82C68BDBA for ; Thu, 12 Jun 2025 05:28:43 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IWgbvUbpK+eljr8s7kXG5yH2GwRUIF+yjA4RmzZSpcL7dzh7zAh18unjDLHsdUiS4UosOQGd68d2PJqGgamOI9vHjCqdLS9rmG6yCodWPg8aO4Ui1MvNnErk81koJ35g1QUIhO1/EXm9Pj8QVFSzuKLqkmaGG+i7A75R6KSg39MdSIbPH1Rba9p8GiE9ORv3ZLIlzGsfdjBPZ1wMYVkL3gNJ30VzYw6g0vQ54uqHliRqWgeWCLXOjhlN2AiKdrQBA4VyKXS4g3L3Kxgl/ZgDnOGEKOKwYNlSYPSNCvtswXNzUaM95+YBE+UlwaEPQ1tJgoZWPHAu0l5vRDia9TG+yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RtG8L/iIG35QBUlYww6gGnSSkz2CDHXCDKnQU5kMAFU=; b=ayHTOzkqyydnFFSfqI4C/nVqQKZkPFCwRlvXMjCPj27N7E4wpTg27aLUMRglbvGR4Y4mzJWxj1Uy8+a0lBq0JqvW8wn2GYq5KfdBHQCLGfawZxAFo+9BlQtHXVQQqgWwv7cLeVy2gl6faUq6MnZpcofPq20zMpBbVlZzdfYg/eQN0oYnyKs6nOd+8WBoMTXQ4PcVAlK5JKCkgu8RBzkAdkoPP+z7nmDzKp7+MKe1fSy0Vg+6GWXRY/Rh5N70VJrTli9fK/nj0rJKCfchL9sQTryf1KSIk0WoSvBiXs78pa1iMHkB4dGm/CLHCbngwsX6/s87xEnXkR2vjNvNYQChHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtG8L/iIG35QBUlYww6gGnSSkz2CDHXCDKnQU5kMAFU=; b=WLDf+mxqjAj2o+xvtEWKefX5OnFQOP9GUiJBhg3bSqcjvgYk9V/mDbnWuMtYcUqype/S3lbK9MipsoMsq54Dl6vwgD7MSrdfQzCz5XE7zmuhABiNK2FiKhckdrdbpjul5l5izci0y6iGxu9byuuqBDJguSjNaSlQjgzA1UN/Cw0V4EoggGWSlOStNhlI8wjppmtNni87O8wZWrJRgrWb7NPqrnFVToMD6ciiQsY3+4L3/xrA5GRgM+YuabfE5WpHU3jl1dQlx1bHeY4lu1PQj2liuv6upR1z/Bof8Lb7iteCh90z2jpju4u2VmiGKL+4sRrS0g+5zduDHOhofi2HPg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB0667.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:1b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Thu, 12 Jun 2025 02:28:40 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:28:40 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop free Thread-Index: AQHb2xFnABc+Co8jMEa4+tDgGgx1abP+zNjQ Date: Thu, 12 Jun 2025 02:28:40 +0000 Message-ID: References: <20250611204213.97295-1-epirat07@gmail.com> <20250611204213.97295-2-epirat07@gmail.com> In-Reply-To: <20250611204213.97295-2-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB0667:EE_ x-ms-office365-filtering-correlation-id: 98bc369f-f9a0-49a3-95a3-08dda958d84f x-microsoft-antispam: BCL:0; ARA:14566002|15080799009|8062599006|8060799009|7092599006|461199028|19110799006|440099028|3412199025|11031999003|12091999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?WXxjH3G2z5AHf7+0KHwLolPjvb9cWIrDFRBUTO+tX7gs33zY8ilK3NO4WQNE?= =?us-ascii?Q?GpyJ39HlyYMjFJLIrKLOVBjAHEt0mkryzkB20TRQi8WsR8sxXyGHWkDaIFP5?= =?us-ascii?Q?oCkMPPAW7+M6fHcq/GJ8IrKOT015SazWNMxyEFzIBmdfu8RPl1HbW7suvTUk?= =?us-ascii?Q?+EGZkusKN/4Ne2m4MaJ0mDbCA1jwZw4KGAJLXzY5F/evFeSVrtaWFLsVJu/h?= =?us-ascii?Q?wfbqAuhAYcqNuev/+oZsv0rJtf5pVHk7oWmYJvSAxKctW3pz2p5Qrl34dp1J?= =?us-ascii?Q?URyCkdfkeuLKdl2/0YW67mZR0+vIUH3oBV6pXrS1C+0CYnIIBi+swGSNmksh?= =?us-ascii?Q?/D7tkfNRSz4cujHwkdaWyY73Px4NnJNSwR1LHXt7pSApsuj5RzTouB+dh/ki?= =?us-ascii?Q?AiwxKWgXrDoO5ItE96aghZjXVYxmwgPToXRw8hwFMDHf9j/0Y15wtlSGcoql?= =?us-ascii?Q?F3LXFOdMFhvI9QvKThdbbppAUgHOCnRTXh/1wCYeDFNyLTaRxuvnf6DIDYm5?= =?us-ascii?Q?O3VwHBnKvJDVPgIOLbo/JY2KnDkSeEQ6tQuSBB9K9Yxay0pp445uc+PiEAkg?= =?us-ascii?Q?1rb8QXElBoQDjRddZ0ekvgJiblLP4jbTHUI9kQlu7fZv8ClZ9Z/tMzzlA5yo?= =?us-ascii?Q?sgM2bCRdSE55te0rwdY4DPRbU2DG2pAod9LX6cYlyjH0YZvyEKB2T3Faf9/j?= =?us-ascii?Q?hIfvoEJBFL+0oJD5WMUVBkW9P1pLvEbDbvdFxgPQ02n+8u83MAIz67aX7fIK?= =?us-ascii?Q?eFCBv5/rAt7s+zyJo/k2ZMAtQGQv8hfNTYu0/Ed7D1dFosCBrAcCbXB9q9TP?= =?us-ascii?Q?kVxJI76vpu58k+4qCDuUKHRNIs5yIgjoY1LvTepUBP2PzNdoJc0HpQJQ+xHk?= =?us-ascii?Q?gDk4dRxPChGj9WRUAPaSQQErt8UKHEH6gH5gep+wnw08QxyCsILW+L8Q1NtJ?= =?us-ascii?Q?NFYzTJG7t7RFAI7FrOKz0IcNje0uxf9JqqBrmtcCrF0U3Yr6ceDhZ5gRqPl+?= =?us-ascii?Q?WA/5OZw3NxYYSjUJ0dGRk376VU60WbT/DQeNPDwm1QIAGtTwuH73Raj+5ep1?= =?us-ascii?Q?kVQ0vSFoze/eXi0y4HYolI8VZgHUbQHZ6/5f+KnuAjBjEy2o1GEBh02TdQfz?= =?us-ascii?Q?RYkkhIIiD5S46Px59tF72AwxinHpyLToZsVvsBuZ4oSbRDcxpOwkKGU=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5jz5p3SJs00C4q4THiikb9WZB5t5WXs2zvIAtxkvvpWWlZXhHCe1+otmGFJO?= =?us-ascii?Q?98mzxWrQG+Sdn0XajCbXUnZZjaxxQF8IkX2dDcAmC0xi1WEW3Bdt2OGRmWXv?= =?us-ascii?Q?KS0jNy0RKmNbeAYI2iy8a/LRORWMwGslPa+hbzSR0wAtwEQ2lLyFLmOcw5Cg?= =?us-ascii?Q?Iyxv9nOdOtL6jcGEFW9XA8GmX5a9xet+cMQN3TszhtEwzhkVWJSPbmfiaXz3?= =?us-ascii?Q?B+36TJADqXfyBBVuEyW0446t1uP8kzEFSQAuzmsQsFK8HTtdjjc/gyKGWCxB?= =?us-ascii?Q?hIJEx/G69ts4wEfl72QrZoLLxB7pSD/q7asz/NlGpHFZ+MWzUc9EMtjNnfpt?= =?us-ascii?Q?wKydVvHgHP/FNcXCoNHy2G/frfat5xSDycnTWxSOd6bp5sVDF7xAm6ynu+/4?= =?us-ascii?Q?TUVnPzmJYb9KS41rNwouoparEW7Usq/ltR3RKizU0Noi9TlVXECLaZ7Kqm0L?= =?us-ascii?Q?tqs/QB8iZFqzPW3ueYYSJwnJtKMCv9/UblG6fIJt3GuY0jQtuYSKDQ6B6lVa?= =?us-ascii?Q?3OP1vUhANZqx78haTkDlNFIz+d5+PlPC+XLFCPCAPPlHaRLDB6LHuX3qJxd3?= =?us-ascii?Q?Do8/FFX+JiDW2J55KLaekc9oXvQNbJgR30oiqGHJ9Al/5rpljP50H+UcBDLZ?= =?us-ascii?Q?b29bbdLcz7QvpK3Av/11ijWeEf3FKFWH7j4oHZGjkzONUF9UfsQggXmT60ch?= =?us-ascii?Q?7rrvekBA9fLiU9CaN1pcB1jBsUloj86JIZKYmsGg0CaE4f7wGKcPevS+m7eg?= =?us-ascii?Q?6vDX+VB70FwW49nMJ53XKy3kOMV8N9cOnsITYzgmbQo4l5eqTQLqVzt+qUgu?= =?us-ascii?Q?7Ov/YGQHBbfbBYkC4ZUePUWL0l0EPkLC+3jRhcWkRki75WtCEFAS0FYb51sT?= =?us-ascii?Q?XM1QGjL4UjANZB2J824DWhqI5pdyZ2jKcaOYz6TG7nb+UxcinQy3J7V9E060?= =?us-ascii?Q?g0pl4bSFQsMIw6uXIl4CLEaQEYjyosYkT1+NsUyRdzbs1lCz88ZRzi/do/zl?= =?us-ascii?Q?XmllJD6IHFd7fcwU5TTwQhqzaBpvl19Dk0tK1gRMXVuxK1YeaXv5en5TJJN2?= =?us-ascii?Q?KE5+g1ty0LP6rBRTT5FdJwmvGzDKYPWLdzFnxamEjTcNcVDJ39HsMakHI67s?= =?us-ascii?Q?oZhi2oEt38BpxlqDEHQ4MJB0tJseqUwVAYZ57PThuPMZjdZZq6v+HHQ43OLL?= =?us-ascii?Q?7U5SJLVCxXLNXl6ghFgcIx+iGmcIj6lXBcrFUU7NYbaKGp9cnZ1qoW86fls?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 98bc369f-f9a0-49a3-95a3-08dda958d84f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2025 02:28:40.7704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB0667 Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop free X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marvin Scholz > Sent: Mittwoch, 11. Juni 2025 22:42 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop > free > > The tctx->hash was freed already right before. > --- > fftools/textformat/avtextformat.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/textformat/avtextformat.c > b/fftools/textformat/avtextformat.c > index f1811abb1c..fa5abce261 100644 > --- a/fftools/textformat/avtextformat.c > +++ b/fftools/textformat/avtextformat.c > @@ -108,8 +108,6 @@ int avtext_context_close(AVTextFormatContext > **ptctx) > > av_hash_freep(&tctx->hash); > > - av_hash_freep(&tctx->hash); > - > if (tctx->formatter) { > if (tctx->formatter->uninit) > ret = tctx->formatter->uninit(tctx); > -- > 2.39.5 (Apple Git-154) > > _______________________________________________ LGTM - I feel like I have fixed it 3 times already, but it always seemed to have slipped through. Thanks a lot, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".