Re: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop free

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Mittwoch, 11. Juni 2025 22:42
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 2/4] fftools/textformat: remove noop
> free
> 
> The tctx->hash was freed already right before.
> ---
>  fftools/textformat/avtextformat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fftools/textformat/avtextformat.c
> b/fftools/textformat/avtextformat.c
> index f1811abb1c..fa5abce261 100644
> --- a/fftools/textformat/avtextformat.c
> +++ b/fftools/textformat/avtextformat.c
> @@ -108,8 +108,6 @@ int avtext_context_close(AVTextFormatContext
> **ptctx)
> 
>      av_hash_freep(&tctx->hash);
> 
> -    av_hash_freep(&tctx->hash);
> -
>      if (tctx->formatter) {
>          if (tctx->formatter->uninit)
>              ret = tctx->formatter->uninit(tctx);
> --
> 2.39.5 (Apple Git-154)
> 
> _______________________________________________

LGTM - I feel like I have fixed it 3 times already, but it always seemed to 
have slipped through.

Thanks a lot,
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".