From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 767D344758 for ; Tue, 25 Oct 2022 09:59:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C03E668BCED; Tue, 25 Oct 2022 12:59:01 +0300 (EEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07olkn2088.outbound.protection.outlook.com [40.92.15.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59C0B68B99B for ; Tue, 25 Oct 2022 12:58:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLLKFHadDLIvCtmbq7aQJVqoOVbjtEBOkaV5e9Fs/P+6CeVQvnvpfpDXFpBlB/hJD8IXW2W7//+OvAn4d/K49xP2zBBCUAIH6R9ooerNYXtQcH6K9TYeDaF8poMdmivlVI20SKWRrDfvFvFKPR3+QUXDtJpg9T9znJxc6jKZScJK9kC+ekNEO6GlClJsQQpjYzKlg0sjwFeQEcR6dMZDqlQQAiDdt2r7D9iGUhpxXdPugfbnEryiOikwRgDOwOICiLcf0mHyKiujDuDlDmc54JLJ5VQPG6fqGUpAxtS234tIGZQksJ+PbJdWCn0apSRaup03bIx9Reu3uqCAB//l2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVSwcIbZiwLMgwqN6SzLIzalFW0nVCAQCNjPXW8kczc=; b=bA0MeZ9no3z8rZCwaPg10MTicHkUOMcHzAR+dp+haoD+PZcOr+G/TrVlNMtghSaKluZkV3DeE6HbQodNcKpFPomXIxA8pXJhUsfWe4q7EiksjzKYMRhr+HAfJge+zkj2t70IL+lY4T+ICVhPbMi7klKmt1cBOKVJ4JiX0x+hamejLxYcFA6QJ6KVZH7BvUAZlKR2zVzJUAGgKFrvaaW9VCn8gEZayG8CspXEQX+f/vF8A3cHjkooUeWcmeDQHZkH86Xh/Fv79ek1FyBkis60N/IEoZDDQrMUiERumK8HaBJZfhDxl67zNwehA3qSnDug3ofqF7f955vL008oV7lzgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVSwcIbZiwLMgwqN6SzLIzalFW0nVCAQCNjPXW8kczc=; b=oPpko7Qmt755+NTZMACjGU5Hod/h4w2TGMCa///XDTUvi/wLvrPr5nEID3ZDycycfvkhrtUu+CJoZbBMB6pLQaU0mM47rGEMhhOzbxAAUh4BJCcgk7TmGOJdZmwR1cl2SeykLq0dTtPUlmHGUBbX+YgSYE/4/ZYDICbLTZxeMn2Wp/f4nFC+yhNv6CQ60k/kXb+OdQTztz47TIP3/mdXJxHQQquX6fXtMJOnsXaG1rwkutQihEzq0rq2NUZNuykIPN7urYSRjmzFJhzfR5iLC0b2VeQ4IlUM3OV6lHm+sNu+6llkkMbQxZOMg7vJ8tT6lfJCWIkynftOoHiDyBZYRA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by MN0P223MB0461.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:3cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 25 Oct 2022 09:58:52 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::47dc:5b94:abdb:4663]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::47dc:5b94:abdb:4663%7]) with mapi id 15.20.5746.025; Tue, 25 Oct 2022 09:58:52 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare AVFrame for subtitle handling Thread-Index: AQHY6FIZ6iaATX3dY0mmlAmUcbv3h64e2jwAgAADECA= Date: Tue, 25 Oct 2022 09:58:52 +0000 Message-ID: References: <95e9b5f39f921151f1da2aeba099088ddb1ed0ce.1666689226.git.ffmpegagent@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [uTDqj8EUVpcy1FwOesgiF7ZClE5Qyzmf] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|MN0P223MB0461:EE_ x-ms-office365-filtering-correlation-id: c77db563-52c6-4295-6411-08dab66f859b x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vb3VyJUs9dGPSQ3XwZ4Wg+Rs9BdR6NFJM1su8KaiXSX/1hJ/2uaarIBiWDeKNqAaCK/uje0H8NrqH5SOjhDg42SVV6mNMYzZ00PUCoyD8Zyr5LMooHALRHZpy3aqLmJ4XRiK1Rfs4YJVdS2QsJIqLsdoM8UHW4vvqdTYGeHPwG3CAWZwCqWh/NLWDu8jXl8FDzP1snmf4dl5LKg4K5YZyCEpVpkBx7T9yh+Hxf7z/PkmJVlU5ZrwR4EccgAlA4huOor4juEOqtDx4YEMItsrpDcd5tCsCAA4ROljMXXJDCdRbas+AaskDuEO91Xt738J3Z8NHvkWDOvcslIBmOLI8pHOZ6SUsDuQabKJBXdwEBOmf9K5neaeg5yhw+f8KuIxG7Cl+XGzXZdZUEuaCAotPrOFqPZMNnzedVNB8IC1ycUiBrQ3pRTaZiL0sz8uUHzr2ym7IO2EDgXVrwW5u3cqwumqim8WPf1dbs9nPaCFCHec3y5IUEO28WvECMXfere6quC0brFe7tccdVZr9xegdTwJp8D/DJf3msjHSH/pCW9jsKTkvQhBSoCvJccNAm52dFVijVQJm5GjRTI/SXE+b5LBsiw8uCDkzREbcOygUZJ3RHBKdY82AKAiH/g3rhwoKrB0u15qiRIOk9/zKmTXGNEKgIwVslTh1hWeFmNbAesjnLWSeZWSYkaF1/ZTF9mJ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q3JtRFhhcTdzRHhBdm9xWXN3bjE3MmNGT1BzSmp1MW16cDZlNnAzcGNxckZL?= =?utf-8?B?RXZsNmttdmdqbmJHN1h1SXhyQ0JyMHRScWFQckhYbGVqQmR3Y0pIaDFnSytv?= =?utf-8?B?RXhGQ2hnWXZsR2F3Y2JDc2kzTXltQkhiVDhMTVFOeW1vaEhHRkRRZmVMVTVQ?= =?utf-8?B?UFZOTlBnWWZHamtnZ1Z4eXg5RnRmWWV5Z3JkcmtpaFVpLzBvMXFDbFNlRVJL?= =?utf-8?B?YjI0QSt3Q2N2aWFhYlVqYVlTMmZ3Q1o3clBPUGp3b0ZnNkNLbVM5b2tEMzlH?= =?utf-8?B?czNTZElCVDZtL084ZG5kek9keWxteEFXY2F2K3NTa2lJWEVXNUJxeHp5emZ2?= =?utf-8?B?TENMWFhSSFNNc3ZqTXdzeVNSUWV5UFFIZm5NUFROL3pwRTQ3WW9POTBGaTE3?= =?utf-8?B?djVydzV4eGR3M1VOUTVia1BHZnR6dnVoZnE2ZDZzclZRT3hxcmpaeEVkakJk?= =?utf-8?B?bWtNM1gxbWxaR2szRm1hSE9XRmRMTThINkRqSGFTWGZ4SmUxYVplTUlxaUdu?= =?utf-8?B?RDZKVGgzb0QyYi9iWnE3cjhrQXA0OFZkbjZwQzU5aDUyRTQxZDZYczRGblgz?= =?utf-8?B?SjBmckEwdzVuNHZCZFNIOFF4TThFMjQ4U3FWaFJTMkszWkN2enFlSlh2bXNm?= =?utf-8?B?REJyUm05alVZcGd6Z2tKSk1LSGRSRnJIL0t6cUtXQXAzY1AwcGxjcEovMEJw?= =?utf-8?B?N3FEd2hXeXU2Z3UvKzJXTjRwaFV1YUozLzVtaXhSdm1vaWk3MHJmY3NhTklR?= =?utf-8?B?bkRLaHR2UWNxTGNMaEMyczAvdkdFNDRIWEtMTG9wRFVPVTRnVFNNaDcxODZ0?= =?utf-8?B?MDhjZlBBZzA5c25NSGVXWWhJUzU0RVA0NVhMUUF0OGdlSW15MWdkbDVTT1Q5?= =?utf-8?B?OGRyQXRyK241OHlTTWRWZk91N3h5NCsyblRTUmptSWhaTkp6TWxYL05ndGgx?= =?utf-8?B?Rzl4dGFuQTJxOGx2MHlTUTF4a05rL0xJZkY1Sk41K3dBdWt5VkVzamo4cC9i?= =?utf-8?B?eU8wekkrM0pIaDJuaG8vTHoxWDZMbk96VW1zSzVjekVkQ1JiWnc4QlNyWU5S?= =?utf-8?B?bklDOGRxelZueFNVdG1VeHVST0JCd0FWL2JzV29aVmVyb3FrZ1ZiazlUU0xh?= =?utf-8?B?YkVxVWl5RmxqOEk0Vk5lMFI1SjhMNm1vMDdvREQ3Tk02ajRxNGdtN1ZlUWg2?= =?utf-8?B?K3dVazFZTnYzRVhqL1piV0Y3VnR0VHBFS1F3NE5aTmZoSFBjUERXdXdOczd6?= =?utf-8?B?dWJrKytFTEdCL1VCc2p1VENSeVNJbmhIOXpNQ3IyYmhxMFJmQTZHNlNlZ0ZV?= =?utf-8?B?SFNkdTM0MGE2WDJXQndNTzkzcmQ0NG9sTURLSHNjTXlReXAzbjlaWHVGR3Bu?= =?utf-8?B?aVAwell1YU5LNW9qZjFLc3ROdFlrSHI1VlNEZGpjSm9XbHlkUFF3UCsxczRH?= =?utf-8?B?ajV1dDFZTmJIRldtenhuSEN4VTZyNHRraWtWSlhLMEJIV0w3TUNybG9NdGdI?= =?utf-8?B?MUJZQlZpK1gzWWMvQjBqV0ZCUEFhZlY5L29oejl4WUxOcW9UNWhGVDJIRU1k?= =?utf-8?B?OVI5WlRQdG00dEJ4UW5vUTVITGVKcTFEZHNZOVZWSkVIV0MrcE9sSGRONnU2?= =?utf-8?B?b1J6TU50eEkydVVIdXRwNjlqNy9WQnVleGJwOEdkZkd5K0xzQ2J2eVNYR0dH?= =?utf-8?B?R1BoRUdJVERhUGlkRlJWNUFlMmFMRzYxMkNPL2NMcDNiSVloNU5KakNBPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c77db563-52c6-4295-6411-08dab66f859b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 09:58:52.5212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0P223MB0461 Subject: Re: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare AVFrame for subtitle handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Tuesday, October 25, 2022 11:38 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v9 02/25] avutil/frame: Prepare > AVFrame for subtitle handling > > On Tue, Oct 25, 2022 at 11:14 AM softworkz > wrote: > > > > @@ -712,6 +712,53 @@ typedef struct AVFrame { > > * Duration of the frame, in the same units as pts. 0 if > unknown. > > */ > > int64_t duration; > > + > > + /** > > + * Media type of the frame (audio, video, subtitles..) > > + * > > + * See AVMEDIA_TYPE_xxx > > + */ > > + enum AVMediaType type; > > + > > + /** > > + * Number of items in the @ref subtitle_areas array. > > + */ > > + unsigned num_subtitle_areas; > > + > > + /** > > + * Array of subtitle areas, may be empty. > > + */ > > + AVSubtitleArea **subtitle_areas; > > + > > + /** > > + * Header containing style information for text subtitles. > > + */ > > + AVBufferRef *subtitle_header; > > + > > + /** > > + * Indicates that a subtitle frame is a repeated frame for > arbitrating flow > > + * in a filter graph. > > + * The field subtitle_timing.start_pts always indicates the > original presentation > > + * time, while the frame's pts field may be different. > > + */ > > + int repeat_sub; > > + > > + struct SubtitleTiming > > + { > > + /** > > + * The display start time, in AV_TIME_BASE. > > + * > > + * For subtitle frames, AVFrame.pts is populated from the > packet pts value, > > + * which is not always the same as this value. > > + */ > > + int64_t start_pts; > > There is still no explanation here why they are not the same, why > they > could not just be the same, and which field a user should look at. > The cover letter talks about clarity why this is needed is important, > but then provides none of that. > > "Its required" is not an argument. So please enlighten us once again > why we absolutely need two timestamps for subtitles, instead of just > one. As far as I can see, subtitle frames only have one relevant time > - when its supposed to be shown on the screen. What would the other > time ever be good for to a user? > Similarly for the duration, of course. I can even see the > AVFrame.duration field in this patch snippet just above the additions > that would seem to fully replace this one. > > - Hendrik Hi Hendrik, thanks a lot for your reply. Probably I should have better advertised the article I had written specifically to explain the background of this: https://github.com/softworkz/SubtitleFilteringDemos/issues/1 I hope it's understandable - please let me know when you have questions. Thanks again, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".